April 2025 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips
by Dmitry Zhadinets (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Anastasia Klimchuk, Dmitry Zhadinets. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/87251?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: libflashrom: Add API for capabilitible chips ...................................................................... libflashrom: Add API for capabilitible chips There were no options available to obtain the list of compatible chips for the programmer. The implementation is based on flashrom_supported_flash_chips and flashrom_flash_probe. Arrays of constant strings are returned, and the array must be freed using flashrom_data_free. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Tests are moved because there is a bug in spi test. It does not clean everything. WIP Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/libflashrom.c M tests/tests.c M tests/tests.h 6 files changed, 69 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/87251/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/87251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Gerrit-Change-Number: 87251 Gerrit-PatchSet: 4 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips
by Dmitry Zhadinets (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/87251?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: libflashrom: Add API for capabilitible chips ...................................................................... libflashrom: Add API for capabilitible chips There were no options available to obtain the list of compatible chips for the programmer. The implementation is based on flashrom_supported_flash_chips and flashrom_flash_probe. Arrays of constant strings are returned, and the array must be freed using flashrom_data_free. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Tests are moved because there is a bug in spi test. It does not clean everything. WIP Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/libflashrom.c M tests/tests.c M tests/tests.h 6 files changed, 63 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/87251/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/87251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Gerrit-Change-Number: 87251 Gerrit-PatchSet: 3 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips
by Dmitry Zhadinets (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Anastasia Klimchuk. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87251?usp=email ) Change subject: libflashrom: Add API for capabilitible chips ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I need help with the test. What dummy chip can be definitely compatible with some specific dummy parameters -- To view, visit https://review.coreboot.org/c/flashrom/+/87251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Gerrit-Change-Number: 87251 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 10 Apr 2025 04:45:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips
by Dmitry Zhadinets (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Anastasia Klimchuk, Dmitry Zhadinets. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/87251?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: libflashrom: Add API for capabilitible chips ...................................................................... libflashrom: Add API for capabilitible chips There were no options available to obtain the list of compatible chips for the programmer. The implementation is based on flashrom_supported_flash_chips and flashrom_flash_probe. Arrays of constant strings are returned, and the array must be freed using flashrom_data_free. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Tests are moved because there is a bug in spi test. It does not clean everything. WIP Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/libflashrom.c M tests/tests.c M tests/tests.h 6 files changed, 63 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/87251/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/87251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Gerrit-Change-Number: 87251 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Add API for capabilitible chips
by Dmitry Zhadinets (Code Review) 10 Apr '25

10 Apr '25

Dmitry Zhadinets has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/87251?usp=email ) Change subject: libflashrom: Add API for capabilitible chips ...................................................................... libflashrom: Add API for capabilitible chips There were no options available to obtain the list of compatible chips for the programmer. The implementation is based on flashrom_supported_flash_chips and flashrom_flash_probe. Arrays of constant strings are returned, and the array must be freed using flashrom_data_free. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Tests are moved because there is a bug in spi test. It does not clean everything. WIP Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/libflashrom.c M tests/tests.c M tests/tests.h 6 files changed, 66 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/87251/1 diff --git a/include/libflashrom.h b/include/libflashrom.h index f30ad6b..fc56251 100644 --- a/include/libflashrom.h +++ b/include/libflashrom.h @@ -261,6 +261,16 @@ */ /** + * @brief Returns list of supported chip names for selected programmer + * + * @param[in] flashprog The flash programmer used to access the chip. + * + * @return List of supported flash chips, or NULL if an error occurred. + * The pointer must be freed after using flashrom_data_free + */ +const char **flashrom_programmer_capabilities(const struct flashrom_programmer *const flashprog); + +/** * @brief Probe for a flash chip. * * Probes for a flash chip and returns a flash context, that can be used diff --git a/libflashrom.c b/libflashrom.c index d6bd098..4b0e34b 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -329,7 +329,31 @@ return programmer_shutdown(); } -/* TODO: flashrom_programmer_capabilities()? */ +const char **flashrom_programmer_capabilities(const struct flashrom_programmer *const flashprog) +{ + (void) flashprog; /* unused */ + unsigned int chipcount = 0; + const char **result = malloc((flashchips_size + 1) * sizeof(char*)); + + struct flashrom_flashctx flashctx = { 0 }; + for (int j = 0; j < registered_master_count; j++) { + int startchip = 0; + + while (chipcount < flashchips_size) { + startchip = probe_flash(&registered_masters[j], startchip, &flashctx, 0, NULL); + if (startchip == -1) + break; + result[chipcount] = flashctx.chip->name; + chipcount++; + startchip++; + flashrom_layout_release(flashctx.default_layout); + free(flashctx.chip); + } + } + result = realloc(result, (chipcount + 1) * sizeof(char*)); + result[chipcount] = 0; + return result; +} int flashrom_flash_probe(struct flashrom_flashctx **const flashctx, const struct flashrom_programmer *const flashprog, diff --git a/libflashrom.map b/libflashrom.map index fc6724a..c0b6933 100644 --- a/libflashrom.map +++ b/libflashrom.map @@ -21,6 +21,7 @@ flashrom_layout_read_from_ifd; flashrom_layout_release; flashrom_layout_set; + flashrom_programmer_capabilities; flashrom_programmer_init; flashrom_programmer_shutdown; flashrom_set_log_callback; diff --git a/tests/libflashrom.c b/tests/libflashrom.c index 59ffeaf..9f44217 100644 --- a/tests/libflashrom.c +++ b/tests/libflashrom.c @@ -114,3 +114,23 @@ assert_int_not_equal(ptr - array, 0); } + +void flashrom_programmer_capabilities_test_success(void **state) +{ + struct flashrom_programmer *flashprog = NULL; + const char **array; + const char **ptr; + + flashrom_programmer_init(&flashprog, "dummy", + "emulate=SST25VF040.REMS"); + array = flashrom_programmer_capabilities(flashprog); + ptr = array; + assert_non_null(array); + + while (*(ptr++)) {} + flashrom_data_free(array); + + assert_int_equal(ptr - array, 2); + + flashrom_programmer_shutdown(flashprog); +} diff --git a/tests/tests.c b/tests/tests.c index 2a79d32..562fdae 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -478,14 +478,6 @@ }; ret |= cmocka_run_group_tests_name("flashrom.c tests", flashrom_tests, NULL, NULL); - const struct CMUnitTest libflashrom_tests[] = { - cmocka_unit_test(flashrom_set_log_callback_test_success), - cmocka_unit_test(flashrom_set_log_callback_v2_test_success), - cmocka_unit_test(flashrom_set_log_level_test_success), - cmocka_unit_test(flashrom_supported_programmers_test_success), - }; - ret |= cmocka_run_group_tests_name("libflashrom.c tests", libflashrom_tests, NULL, NULL); - const struct CMUnitTest spi25_tests[] = { cmocka_unit_test(spi_write_enable_test_success), cmocka_unit_test(spi_write_disable_test_success), @@ -501,6 +493,15 @@ }; ret |= cmocka_run_group_tests_name("spi25.c tests", spi25_tests, NULL, NULL); + const struct CMUnitTest libflashrom_tests[] = { + cmocka_unit_test(flashrom_set_log_callback_test_success), + cmocka_unit_test(flashrom_set_log_callback_v2_test_success), + cmocka_unit_test(flashrom_set_log_level_test_success), + cmocka_unit_test(flashrom_supported_programmers_test_success), + cmocka_unit_test(flashrom_programmer_capabilities_test_success), + }; + ret |= cmocka_run_group_tests_name("libflashrom.c tests", libflashrom_tests, NULL, NULL); + const struct CMUnitTest lifecycle_tests[] = { cmocka_unit_test(dummy_basic_lifecycle_test_success), cmocka_unit_test(dummy_probe_lifecycle_test_success), diff --git a/tests/tests.h b/tests/tests.h index e87c00c..3d715e8 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -36,6 +36,7 @@ void flashrom_set_log_callback_v2_test_success(void **state); void flashrom_set_log_level_test_success(void **state); void flashrom_supported_programmers_test_success(void **state); +void flashrom_programmer_capabilities_test_success(void **state); /* spi25.c */ void spi_write_enable_test_success(void **state); -- To view, visit https://review.coreboot.org/c/flashrom/+/87251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id33fac2935b4098586526bda87b25231c9a6ab39 Gerrit-Change-Number: 87251 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com>

1 0

[S] Change in flashrom[main]: libflashrom: Add API to get the list of supported programmers
by Anastasia Klimchuk (Code Review) 09 Apr '25

09 Apr '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email ) Change subject: libflashrom: Add API to get the list of supported programmers ...................................................................... libflashrom: Add API to get the list of supported programmers There were no options available to obtain the list of programmers. The implementation is based on flashrom_supported_flash_chips. Arrays of constant strings are returned, and the array must be freed using flashrom_data_free. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86921 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/libflashrom.c M tests/tests.c M tests/tests.h 6 files changed, 42 insertions(+), 2 deletions(-) Approvals: Dmitry Zhadinets: Looks good to me, but someone else must approve Peter Marheine: Looks good to me, approved build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/include/libflashrom.h b/include/libflashrom.h index b9b0d17..f30ad6b 100644 --- a/include/libflashrom.h +++ b/include/libflashrom.h @@ -194,6 +194,14 @@ */ const char *flashrom_version_info(void); /** + * @brief Returns list of supported programmers + * The last entry in the returned list is followed by a NULL. + * + * @return List of supported programmers, or NULL if an error occurred. + * The pointer must be freed after using flashrom_data_free + */ +const char **flashrom_supported_programmers(void); +/** * @brief Returns list of supported flash chips * @return List of supported flash chips, or NULL if an error occurred */ diff --git a/libflashrom.c b/libflashrom.c index 888ca05..d6bd098 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -194,6 +194,18 @@ return flashrom_version; } +const char **flashrom_supported_programmers(void) +{ + const char **result = malloc(sizeof(char*) * (programmer_table_size + 1)); + if (!result) + return NULL; + for (unsigned int i = 0; i < programmer_table_size; ++i) { + result[i] = programmer_table[i]->name; + } + result[programmer_table_size] = 0; + return result; +} + struct flashrom_flashchip_info *flashrom_supported_flash_chips(void) { struct flashrom_flashchip_info *supported_flashchips = diff --git a/libflashrom.map b/libflashrom.map index a12a95c..fc6724a 100644 --- a/libflashrom.map +++ b/libflashrom.map @@ -32,6 +32,7 @@ flashrom_supported_boards; flashrom_supported_chipsets; flashrom_supported_flash_chips; + flashrom_supported_programmers; flashrom_version_info; flashrom_wp_cfg_new; flashrom_wp_cfg_release; diff --git a/tests/libflashrom.c b/tests/libflashrom.c index 3320597..59ffeaf 100644 --- a/tests/libflashrom.c +++ b/tests/libflashrom.c @@ -1,7 +1,7 @@ /* * This file is part of the flashrom project. * - * Copyright 2025 Dmitry Zhadinets (dzhadinets(a)gmail.com) + * Copyright 2025 Dmitry Zhadinets <dzhadinets(a)gmail.com> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -96,4 +96,21 @@ /* check that callback is called after the change*/ assert_int_equal(print(FLASHROM_MSG_INFO, "1%s", "\n"), 0x666 + (int)FLASHROM_MSG_INFO); flashrom_set_log_callback(NULL); -} \ No newline at end of file +} + +void flashrom_supported_programmers_test_success(void **state) +{ + (void) state; /* unused */ + const char **array = flashrom_supported_programmers(); + const char **ptr = array; + + assert_non_null(array); + + do { + assert_non_null(*ptr); + }while (*(++ptr)); + + flashrom_data_free(array); + + assert_int_not_equal(ptr - array, 0); +} diff --git a/tests/tests.c b/tests/tests.c index ef71967..2a79d32 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -482,6 +482,7 @@ cmocka_unit_test(flashrom_set_log_callback_test_success), cmocka_unit_test(flashrom_set_log_callback_v2_test_success), cmocka_unit_test(flashrom_set_log_level_test_success), + cmocka_unit_test(flashrom_supported_programmers_test_success), }; ret |= cmocka_run_group_tests_name("libflashrom.c tests", libflashrom_tests, NULL, NULL); diff --git a/tests/tests.h b/tests/tests.h index e358e86..e87c00c 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -35,6 +35,7 @@ void flashrom_set_log_callback_test_success(void **state); void flashrom_set_log_callback_v2_test_success(void **state); void flashrom_set_log_level_test_success(void **state); +void flashrom_supported_programmers_test_success(void **state); /* spi25.c */ void spi_write_enable_test_success(void **state); -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 13 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: libflashrom: Add API to get the list of supported programmers
by Anastasia Klimchuk (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Dmitry Zhadinets. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email ) Change subject: libflashrom: Add API to get the list of supported programmers ...................................................................... Patch Set 12: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/86921/comment/06005584_3d862a9a?us… : PS10, Line 7: libflashrom: Added API to enumerate supported programmers > Done As a note, you don't have to vote on your own patch: we assume the author of the patch approves their own work. Also in any case, every patch needs to be approved by someone who is not the author. You don't have to change anything here, this is a note for future. -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 12 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Apr 2025 00:51:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: libflashrom: Fix dynamic linkage
by Anastasia Klimchuk (Code Review) 09 Apr '25

09 Apr '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/87194?usp=email ) Change subject: libflashrom: Fix dynamic linkage ...................................................................... libflashrom: Fix dynamic linkage flashrom_set_log_level was not added to the map file Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Change-Id: Iaa9f50d79364cd3ba8242e4faea7612c88e7053c Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/87194 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M libflashrom.map 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/libflashrom.map b/libflashrom.map index 4ab9ac9..a12a95c 100644 --- a/libflashrom.map +++ b/libflashrom.map @@ -25,6 +25,7 @@ flashrom_programmer_shutdown; flashrom_set_log_callback; flashrom_set_log_callback_v2; + flashrom_set_log_level; flashrom_set_progress_callback; flashrom_set_progress_callback_v2; flashrom_shutdown; -- To view, visit https://review.coreboot.org/c/flashrom/+/87194?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iaa9f50d79364cd3ba8242e4faea7612c88e7053c Gerrit-Change-Number: 87194 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: cli: Use flashrom_supported_programmers API in cli
by Dmitry Zhadinets (Code Review) 07 Apr '25

07 Apr '25

Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87195?usp=email ) Change subject: cli: Use flashrom_supported_programmers API in cli ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I think that this change is not needed because the code has become more complex Up to the reviewers’ consideration -- To view, visit https://review.coreboot.org/c/flashrom/+/87195?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I86ac83ee0ef4e850e69aa4e7b607e28ebab9d3d5 Gerrit-Change-Number: 87195 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Apr 2025 23:16:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: libflashrom: Add API to get the list of supported programmers
by Dmitry Zhadinets (Code Review) 07 Apr '25

07 Apr '25

Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email ) Change subject: libflashrom: Add API to get the list of supported programmers ...................................................................... Patch Set 12: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/86921/comment/bb8a270c_67dec252?us… : PS10, Line 7: libflashrom: Added API to enumerate supported programmers > But you haven't changed the commit title :) It still says enumerate. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 12 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Apr 2025 23:13:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2025