flashrom-gerrit March 2025

flashrom-gerrit@flashrom.org

1 participants
157 discussions

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Simon Arlott (Code Review) 01 Mar '25

01 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86411?usp=email to look at the new patch set (#4). Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... spidriver: Add support for the Excamera Labs SPIDriver programmer This is a SPI hardware interface with a display (https://spidriver.com/), connected as an FT230X USB serial device at a fixed baud rate of 460800. Firmware: https://github.com/jamesbowman/spidriver Protocol: https://github.com/jamesbowman/spidriver/blob/master/protocol.md Most of the implementation is copied from the Bus Pirate programmer. Tested with a SPIDriver v2 by reading FM25Q128A flash memory on Linux. Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Signed-off-by: Simon Arlott <flashrom(a)octiron.net> --- M doc/classic_cli_manpage.rst M doc/release_notes/devel.rst M include/programmer.h M meson.build M meson_options.txt M programmer_table.c A spidriver.c M test_build.sh 8 files changed, 381 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/86411/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Simon Arlott (Code Review) 01 Mar '25

01 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86411?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... spidriver: Add support for the Excamera Labs SPIDriver programmer This is a SPI hardware interface with a display (https://spidriver.com/), connected as an FT230X USB serial device at a fixed baud rate of 460800. Firmware: https://github.com/jamesbowman/spidriver Protocol: https://github.com/jamesbowman/spidriver/blob/master/protocol.md Most of the implementation is copied from the Bus Pirate programmer. Tested with a SPIDriver v2 by reading FM25Q128A flash memory on Linux. Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Signed-off-by: Simon Arlott <flashrom(a)octiron.net> --- M doc/classic_cli_manpage.rst M doc/release_notes/devel.rst M include/programmer.h M meson.build M meson_options.txt M programmer_table.c A spidriver.c M test_build.sh 8 files changed, 380 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/86411/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Simon Arlott (Code Review) 01 Mar '25

01 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Simon Arlott has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Patch Set 2: (10 comments) Patchset: PS2: > Simon, nice to meet you, thank you for the patch! This is really cool :) […] I've added an entry to the release notes. I don't think I can maintain support for this programmer, it's quite slow to use and I'm looking at other USB SPI options but I only do occasional flash chip reads. Commit Message: https://review.coreboot.org/c/flashrom/+/86411/comment/96dd7a81_4cd3ec70?us… : PS2, Line 9: This is a SPI hardware interface with a display (https://spidriver.com/), : connected as an FT230X USB serial device at a fixed baud rate of 460800. : : Firmware: https://github.com/jamesbowman/spidriver : Protocol: https://github.com/jamesbowman/spidriver/blob/master/protocol.md > These lines would be very good to add in the beginning of manpage entry that you added. […] Done File include/programmer.h: https://review.coreboot.org/c/flashrom/+/86411/comment/0fc60cf6_0d74222f?us… : PS2, Line 101: extern const struct programmer_entry programmer_spidriver; > You need to swap lines 100 and 101 to be in nice alphabetical order. […] Done File spidriver.c: https://review.coreboot.org/c/flashrom/+/86411/comment/d2a61cf3_05d95c35?us… : PS2, Line 19: */ > Maybe add link to firmware here as well? (from commit message) Done https://review.coreboot.org/c/flashrom/+/86411/comment/98830cf0_7f6dfbe2?us… : PS2, Line 81: { > Why do you need this bracket (and closing on line 101)? Is there a reason for this block? It reduces the scope of "buf" so that it's not being shadowed later and can't accidentally be used. https://review.coreboot.org/c/flashrom/+/86411/comment/6aa405e7_d98656fd?us… : PS2, Line 136: /* Read and write */ > I assume that's just because of how SPI works, since the periperhal always shifts bits in from the h […] There's no read API, because something must always be written on the SPI bus in order to read from it. Typically this would be 0x00 for SPI and the preceding command would prepare for a read operation. https://github.com/jamesbowman/spidriver/blob/master/protocol.md https://review.coreboot.org/c/flashrom/+/86411/comment/76b2bb98_1ebd23b4?us… : PS2, Line 179: .max_data_read = MAX_DATA_READ_UNLIMITED, : .max_data_write = MAX_DATA_WRITE_UNLIMITED, > The indentation here needs to be aligned with the rest of `=` Done https://review.coreboot.org/c/flashrom/+/86411/comment/afb40d7a_c3d152c4?us… : PS2, Line 211: Invalid SPI mode %ld > Lets add the second part to the error message: "Valid values are <... […] Done https://review.coreboot.org/c/flashrom/+/86411/comment/94e0943c_69c2b049?us… : PS2, Line 212: return 1; > So invalid `mode` param returns an error, but invalid values for `a` and `b` below continue running […] Done https://review.coreboot.org/c/flashrom/+/86411/comment/0edfc7b2_9e1797f0?us… : PS2, Line 309: version 1 > Is it useful to print `fw_version` here instead, as an in addition to ? Done -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 01 Mar 2025 21:58:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: tests/chip: fix print format errors
by Antonio Vázquez Blanco (Code Review) 01 Mar '25

01 Mar '25

Attention is currently required from: Anastasia Klimchuk, Antonio Vázquez Blanco. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86679?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: tests/chip: fix print format errors ...................................................................... tests/chip: fix print format errors Change-Id: I8c461accefddce3d5ee33b0fb6b91c434d721945 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M tests/chip.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/86679/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86679?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8c461accefddce3d5ee33b0fb6b91c434d721945 Gerrit-Change-Number: 86679 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: tests/chip: fix print format errors
by Antonio Vázquez Blanco (Code Review) 01 Mar '25

01 Mar '25

Antonio Vázquez Blanco has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86679?usp=email ) Change subject: tests/chip: fix print format errors ...................................................................... tests/chip: fix print format errors Change-Id: I8c461accefddce3d5ee33b0fb6b91c434d721945 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M tests/chip.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/86679/1 diff --git a/tests/chip.c b/tests/chip.c index 25bb8db..d26fbc8 100644 --- a/tests/chip.c +++ b/tests/chip.c @@ -91,7 +91,7 @@ } if (flash->progress_state->current >= flash->progress_state->total - 1) - printf("Progress almost complete for stage %d, current %ld, total %ld\n", + printf("Progress almost complete for stage %d, current %lld, total %lld\n", flash->progress_state->stage, flash->progress_state->current, flash->progress_state->total); progress_user_data->last_seen[flash->progress_state->stage] = flash->progress_state->current; -- To view, visit https://review.coreboot.org/c/flashrom/+/86679?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8c461accefddce3d5ee33b0fb6b91c434d721945 Gerrit-Change-Number: 86679 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com>

1 0

[XS] Change in flashrom[main]: Enable authors list generation on Jenkins
by Anastasia Klimchuk (Code Review) 01 Mar '25

01 Mar '25

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86678?usp=email ) Change subject: Enable authors list generation on Jenkins ...................................................................... Enable authors list generation on Jenkins Change-Id: Ia018ce4addb65273fe022ed1f1e9d38420c0e469 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M test_build.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/86678/1 diff --git a/test_build.sh b/test_build.sh index 968f259..1470e08 100755 --- a/test_build.sh +++ b/test_build.sh @@ -26,7 +26,7 @@ build_meson () { build_dir=out - meson_opts="-Dtests=enabled -Drpmc=enabled -Dman-pages=enabled -Ddocumentation=enabled" + meson_opts="-Dtests=enabled -Drpmc=enabled -Dman-pages=enabled -Ddocumentation=enabled -Dgenerate_authors_list=enabled" ninja_opts="-j $(nproc)" rm -rf ${build_dir} -- To view, visit https://review.coreboot.org/c/flashrom/+/86678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia018ce4addb65273fe022ed1f1e9d38420c0e469 Gerrit-Change-Number: 86678 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: doc: Final cleanup of remaining references to the old wiki website
by Anastasia Klimchuk (Code Review) 01 Mar '25

01 Mar '25

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86676?usp=email ) Change subject: doc: Final cleanup of remaining references to the old wiki website ...................................................................... doc: Final cleanup of remaining references to the old wiki website Change-Id: Ie002c1242075c8becb59d26bd9c562c7616233c1 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/classic_cli_manpage.rst M doc/how_to_support_flashrom.rst M doc/index.rst M doc/supported_hw/supported_prog/index.rst M flashrom.c M ichspi.c M util/git-hooks/commit-msg 7 files changed, 41 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/86676/1 diff --git a/doc/classic_cli_manpage.rst b/doc/classic_cli_manpage.rst index 243cf4f..cf80556 100644 --- a/doc/classic_cli_manpage.rst +++ b/doc/classic_cli_manpage.rst @@ -789,13 +789,43 @@ atavia programmer ^^^^^^^^^^^^^^^^^ +The VT6421A is a PATA/SATA PCI controller that can be found on various cheap PCI cards. +Currently there is a `datasheet <http://spacehopper.org/mirrors/ftp.vtbridge.org/Docs/Storage/DS_VT6421A_100…>`_. + +There exists a patch for flashrom that makes it possible to access the attached flash chip, +but it has problems with some cards. They seem to need an offset added to the chip address for unknown reasons. + Due to the mysterious address handling of the VIA VT6421A controller the user can specify an offset with the:: flashrom -p atavia:offset=addr syntax where ``addr`` will be interpreted as usual (leading 0x (0) for hexadecimal (octal) values, or else decimal). -For more information please see `its wiki page <https://flashrom.org/VT6421A "its wiki page>`_. +Cards found in the wild: + ++----------------+----------------------+--------+---------+------------+-------------+----------+----------------------+-------+ +| Vendor | Model | rev. | country | lot code | Chip | Size [B] | Offset | lspci | ++================+======================+========+=========+============+=============+==========+======================+=======+ +| | | | | | W39V040BPZ | 512k | | | ++----------------+----------------------+--------+---------+------------+-------------+----------+----------------------+-------+ +| Eminent | EM2001 | 0910CD | Taiwan | 2IA0022481 | SST49LF020A | 256k | 0xfff00000 | [2] | ++----------------+----------------------+--------+---------+------------+-------------+----------+----------------------+-------+ +| "SATA CONNECT" | "High speed 2/4-port | 0901CD | Taiwan | 2IA0022471 | Pm49FL004 | 512k | 0xfff80000 = | [3] | +| | Serial ATA card" | | | | | | 0xffffffff - size | | +| | | | | | | | + 1 (aka phys_addr) | | ++----------------+----------------------+--------+---------+------------+-------------+----------+----------------------+-------+ +| Gembird | SATA-3 | | | | W39V040C | 512k | | | ++----------------+----------------------+--------+---------+------------+-------------+----------+----------------------+-------+ +| | HZ-006 | | | | Pm39LV512 | 64k | | [4] | ++----------------+----------------------+--------+---------+------------+-------------+----------+----------------------+-------+ + +* `[2] <http://paste.flashrom.org/view.php?id=1369>`_ +* `[3] <http://www.flashrom.org/pipermail/flashrom/2012-September/009992.html>`_ +* `[4] <http://www.flashrom.org/pipermail/flashrom/2012-December/010318.html>`_ + +The revision consists of two characters that are printed below the "VT6421A" string on the chip +prefixed by 4 numbers that encode the production year and week. +The country is noted right of the revision. atapromise programmer ^^^^^^^^^^^^^^^^^^^^^ diff --git a/doc/how_to_support_flashrom.rst b/doc/how_to_support_flashrom.rst index bb5cdaa..483d3e6 100644 --- a/doc/how_to_support_flashrom.rst +++ b/doc/how_to_support_flashrom.rst @@ -94,11 +94,8 @@ #. If there is an announcement on the mailing list about new doc under review, have a look and you can join the review -#. Help migrate information from `old website <https://wiki.flashrom.org/>`_ to `new website <https://www.flashrom.org/>`_. - The rule is, all useful docs need to be migrated but they should be reviewed. Concrete example, - there are docs for programmers, written a while ago. If you are using the programmer regularly - you can review the existing doc and help update it (if needed) and then the updated doc will - go to the new website. +#. If you have been following the document and discovered something incorrect there, or outdated, + send a patch to update the document. #. New documentation welcome. diff --git a/doc/index.rst b/doc/index.rst index f32f182..b175787 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -20,7 +20,6 @@ how_to_support_flashrom how_to_add_docs documentation_license - Old wiki website <https://wiki.flashrom.org/> .. include:: intro.rst diff --git a/doc/supported_hw/supported_prog/index.rst b/doc/supported_hw/supported_prog/index.rst index b87b995..d1a42c9 100644 --- a/doc/supported_hw/supported_prog/index.rst +++ b/doc/supported_hw/supported_prog/index.rst @@ -10,7 +10,7 @@ (see :doc:`/classic_cli_manpage` for more details on command line options). The output of this command is long, so you might want to save it to file or grep. -Patches to add/update documentation, or migrate docs from `old wiki website <https://wiki.flashrom.org/Supported_programmers>`_ are very much appreciated. +Patches to add/update documentation are very much appreciated. .. toctree:: :maxdepth: 1 diff --git a/flashrom.c b/flashrom.c index 8daad74..49d2b36 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1528,27 +1528,27 @@ if (is_internal_programmer()) msg_gerr("This means we have to add special support for your board, programmer or flash\n" "chip. Please report this to the mailing list at flashrom(a)flashrom.org or on\n" - "IRC (see https://www.flashrom.org/Contact for details), thanks!\n" + "chat channels (see https://flashrom.org/contact.html for details), thanks!\n" "-------------------------------------------------------------------------------\n" "You may now reboot or simply leave the machine running.\n"); else msg_gerr("Please check the connections (especially those to write protection pins) between\n" "the programmer and the flash chip. If you think the error is caused by flashrom\n" - "please report this to the mailing list at flashrom(a)flashrom.org or on IRC (see\n" - "https://www.flashrom.org/Contact for details), thanks!\n"); + "please report this to the mailing list at flashrom(a)flashrom.org or on chat (see\n" + "https://flashrom.org/contact.html for details), thanks!\n"); } void emergency_help_message(void) { msg_gerr("Your flash chip is in an unknown state.\n"); if (is_internal_programmer()) - msg_gerr("Get help on IRC (see https://www.flashrom.org/Contact) or mail\n" + msg_gerr("Get help on chat (see https://flashrom.org/contact.html) or mail\n" "flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!" "-------------------------------------------------------------------------------\n" "DO NOT REBOOT OR POWEROFF!\n"); else msg_gerr("Please report this to the mailing list at flashrom(a)flashrom.org or\n" - "on IRC (see https://www.flashrom.org/Contact for details), thanks!\n"); + "on chat (see https://flashrom.org/contact.html for details), thanks!\n"); } void list_programmers_linebreak(int startcol, int cols, int paren) diff --git a/ichspi.c b/ichspi.c index ac70eed..7471d1a 100644 --- a/ichspi.c +++ b/ichspi.c @@ -2236,7 +2236,7 @@ if (ich_spi_rw_restricted) msg_pinfo("Not all flash regions are freely accessible by flashrom. This is " "most likely\ndue to an active ME. Please see " - "https://flashrom.org/ME for details.\n"); + "https://flashrom.org/user_docs/management_engine.html for details.\n"); } /* Handle PR registers */ diff --git a/util/git-hooks/commit-msg b/util/git-hooks/commit-msg index e2f5de5..505c0cd 100755 --- a/util/git-hooks/commit-msg +++ b/util/git-hooks/commit-msg @@ -28,7 +28,7 @@ CHANGE_ID_AFTER="Bug|Depends-On|Issue|Test|Feature|Fixes|Fixed|Staging-ID" MSG="$1" -DEV_GUIDELINES_URL="https://www.flashrom.org/Development_Guidelines" +DEV_GUIDELINES_URL="https://flashrom.org/dev_guide/development_guide.html" # Check for, and add if missing, a unique Change-Id # -- To view, visit https://review.coreboot.org/c/flashrom/+/86676?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie002c1242075c8becb59d26bd9c562c7616233c1 Gerrit-Change-Number: 86676 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2025