March 2025 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Sergii Dmytruk (Code Review) 04 Mar '25

04 Mar '25

Attention is currently required from: Anastasia Klimchuk, Richard Hughes. Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: libflashrom: Update the API for progress callback ...................................................................... Patch Set 12: (1 comment) File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86031/comment/fcc8ddc4_5ee85bc8?us… : PS12, Line 110: * Note: callback set with this function takes priority over the deprecated one which : * could be set by deprecated function flashrom_set_progress_callback. I think this note is no longer true because at most one callback can be set now. -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 12 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 04 Mar 2025 15:15:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Peter Marheine (Code Review) 03 Mar '25

03 Mar '25

Attention is currently required from: Anastasia Klimchuk, Richard Hughes, Sergii Dmytruk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email ) Change subject: libflashrom: Update the API for progress callback ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 12 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 03 Mar 2025 22:51:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Anastasia Klimchuk (Code Review) 03 Mar '25

03 Mar '25

Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email ) Change subject: libflashrom: Update the API for progress callback ...................................................................... Patch Set 12: (2 comments) File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86031/comment/eba252a0_85bc1058?us… : PS11, Line 76: since %s is deprecated > May want to modify this message to use the same language as the one below, since the reason for both […] Okay I copied that part, so now both messages have the same second half. https://review.coreboot.org/c/flashrom/+/86031/comment/a05d3902_a5e22303?us… : PS11, Line 93: "We recommend using flashrom_set_progress_callback_v2 instead of deprecated API " : "because flashrom_set_progress_callback fn is deprecated and will be removed " : "in future versions.\n" > I don't think these sentences are necessary, because when we hit this condition the user will have a […] Agree, I removed -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 12 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 03 Mar 2025 09:02:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Anastasia Klimchuk (Code Review) 03 Mar '25

03 Mar '25

Attention is currently required from: Anastasia Klimchuk, Richard Hughes, Sergii Dmytruk. Hello Peter Marheine, Richard Hughes, Sergii Dmytruk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86031?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: libflashrom: Update the API for progress callback ...................................................................... libflashrom: Update the API for progress callback The initial version of API for progress callback would require the callback function to make a second call to get the needed data about progress state (current, total etc). This patch changes the callback API, so that callback function gets all needed data straight away as parameters, and with this, callback has all the data to do its job. Since the initial version was submitted and it was in the tree for a while, the change needs to add a _v2 suffix for new thing and deprecated attribute for old thing. Testing: both unit tests and cli are libflashrom clients. All unit tests run successfully, for the cli all scenarios from commit 75dc0655b95dde91f1426a7e5aecfc04d7b8d631 run successfully. Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M cli_classic.c M cli_output.c M doc/release_notes/devel.rst M flashrom.c M include/cli_output.h M include/flash.h M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/chip.c M tests/spi25.c 11 files changed, 125 insertions(+), 72 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/86031/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 12 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[S] Change in flashrom[main]: util/docker: Update the script that updates the website
by Elyes Haouas (Code Review) 03 Mar '25

03 Mar '25

Attention is currently required from: Anastasia Klimchuk, Patrick Georgi. Elyes Haouas has posted comments on this change by Patrick Georgi. ( https://review.coreboot.org/c/flashrom/+/86681?usp=email ) Change subject: util/docker: Update the script that updates the website ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/86681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I844e4ea84b94444c96f29325fee205b0deb972da Gerrit-Change-Number: 86681 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Mar 2025 01:22:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: util/docker: Update the script that updates the website
by Stefan Reinauer (Code Review) 03 Mar '25

03 Mar '25

Attention is currently required from: Anastasia Klimchuk, Patrick Georgi. Stefan Reinauer has posted comments on this change by Patrick Georgi. ( https://review.coreboot.org/c/flashrom/+/86681?usp=email ) Change subject: util/docker: Update the script that updates the website ...................................................................... Patch Set 1: (1 comment) File util/docker/flashrom.org/Dockerfile: https://review.coreboot.org/c/flashrom/+/86681/comment/48f1e7a0_7a4f1012?us… : PS1, Line 19: ADD ditaa.sh /usr/bin/ditaa Did we get rid of the need for ditaa or has it been integrated? -- To view, visit https://review.coreboot.org/c/flashrom/+/86681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I844e4ea84b94444c96f29325fee205b0deb972da Gerrit-Change-Number: 86681 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Mar 2025 00:20:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: util/docker: Update the script that updates the website
by Stefan Reinauer (Code Review) 03 Mar '25

03 Mar '25

Attention is currently required from: Anastasia Klimchuk, Patrick Georgi. Stefan Reinauer has posted comments on this change by Patrick Georgi. ( https://review.coreboot.org/c/flashrom/+/86681?usp=email ) Change subject: util/docker: Update the script that updates the website ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I844e4ea84b94444c96f29325fee205b0deb972da Gerrit-Change-Number: 86681 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Mar 2025 00:19:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Peter Marheine (Code Review) 02 Mar '25

02 Mar '25

Attention is currently required from: Anastasia Klimchuk, Richard Hughes, Sergii Dmytruk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email ) Change subject: libflashrom: Update the API for progress callback ...................................................................... Patch Set 11: (3 comments) File include/flash.h: https://review.coreboot.org/c/flashrom/+/86031/comment/3e14d559_1aef23a7?us… : PS8, Line 624: flashrom_progress_callback_v2 *progress_callback; : struct flashrom_progress progress_state; : struct stage_progress stage_progress[FLASHROM_PROGRESS_NR]; : /* deprecated, do not use */ : flashrom_progress_callback *deprecated_progress_callback; : struct flashrom_progress *deprecated_progress_state; > I rebased to fix merge conflict in devel.rst (my favourite type of merge conflict :D) […] That seems nice and consistent now, yes. It does occur to me that the most general solution would be to allow callers to register an arbitrary number of callbacks of either version (maintain a list of callbacks internally), but that doesn't seem necessary and would be more complex for users. File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86031/comment/00dab8ec_06e63eff?us… : PS11, Line 76: since %s is deprecated May want to modify this message to use the same language as the one below, since the reason for both is that only one callback can be registered. https://review.coreboot.org/c/flashrom/+/86031/comment/d96249ae_6494c19b?us… : PS11, Line 93: "We recommend using flashrom_set_progress_callback_v2 instead of deprecated API " : "because flashrom_set_progress_callback fn is deprecated and will be removed " : "in future versions.\n" I don't think these sentences are necessary, because when we hit this condition the user will have already called `flashrom_set_progress_callback` and gotten the deprecation warning from it. -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 11 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sun, 02 Mar 2025 22:59:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: Enable authors list generation on Jenkins
by Peter Marheine (Code Review) 02 Mar '25

02 Mar '25

Attention is currently required from: Anastasia Klimchuk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86678?usp=email ) Change subject: Enable authors list generation on Jenkins ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia018ce4addb65273fe022ed1f1e9d38420c0e469 Gerrit-Change-Number: 86678 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 02 Mar 2025 22:34:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: util/docker: Update the script that updates the website
by Patrick Georgi (Code Review) 02 Mar '25

02 Mar '25

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86681?usp=email ) Change subject: util/docker: Update the script that updates the website ...................................................................... util/docker: Update the script that updates the website - Update the base system (alpine 3.8 -> 3.21) - Update sphinx and its modules (and from pip-install to alpine-install) - Remove unused features that increase maintenance overhead (autobuild/livehtml and ditaa) - Use the build system to generate docs (instead of calling sphinx in its own, custom ways) Change-Id: I844e4ea84b94444c96f29325fee205b0deb972da Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- M util/docker/flashrom.org/Dockerfile M util/docker/flashrom.org/makeSphinx.sh 2 files changed, 12 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/86681/1 diff --git a/util/docker/flashrom.org/Dockerfile b/util/docker/flashrom.org/Dockerfile index 23f5f50..2fc9e9f 100644 --- a/util/docker/flashrom.org/Dockerfile +++ b/util/docker/flashrom.org/Dockerfile @@ -1,29 +1,12 @@ -FROM alpine:3.8 +FROM alpine:3.21 -COPY makeSphinx.sh /makeSphinx.sh - -ADD https://sourceforge.net/projects/ditaa/files/ditaa/0.9/ditaa0_9.zip/download /tmp/ditaa.zip - -RUN apk add --no-cache python3 make bash git openjdk8-jre ttf-dejavu fontconfig \ - && pip3 install --upgrade --no-cache-dir pip \ - && pip3 install --no-cache-dir \ - sphinx===1.8.3 \ - sphinx_rtd_theme===0.4.2 \ - recommonmark===0.5.0 \ - sphinx_autobuild===0.7.1 \ - sphinxcontrib-ditaa===0.6 \ - && chmod 755 /makeSphinx.sh -RUN cd /tmp \ - && unzip ditaa.zip \ - && mv ditaa0_9.jar /usr/lib -ADD ditaa.sh /usr/bin/ditaa +RUN apk add --no-cache sphinx py3-sphinx_rtd_theme bash git meson ninja gcc musl-dev pkgconf VOLUME /data-in /data-out -# For Sphinx-autobuild -# Port 8000 - HTTP server -# Port 35729 - websockets connection to allow automatic browser reloads after each build -EXPOSE 8000 35729 +COPY makeSphinx.sh /makeSphinx.sh + +ENV MESON_PACKAGE_CACHE_DIR /tmp/meson-pkgcache/ ENTRYPOINT ["/bin/bash", "/makeSphinx.sh"] CMD [] diff --git a/util/docker/flashrom.org/makeSphinx.sh b/util/docker/flashrom.org/makeSphinx.sh index 5b6ea03..51ff771 100755 --- a/util/docker/flashrom.org/makeSphinx.sh +++ b/util/docker/flashrom.org/makeSphinx.sh @@ -1,12 +1,8 @@ #!/usr/bin/env bash - -if [ "$1" == "livehtml" ]; then - echo "Starting live documentation build" - cd /data-in/ && sphinx-autobuild -b html doc /tmp/build/html -else - echo "Starting production documentation build" - cd /data-in/ \ - && sphinx-build -b html doc /tmp/build/html \ - && rm -rf /data-out/* \ - && mv /tmp/build/html/* /data-out/ -fi +set -e +cd /data-in/ +meson setup /tmp/build -Ddocumentation=enabled -Dgenerate_authors_list=enabled +ninja -C /tmp/build doc/html +rm -rf /data-out/* +mv /tmp/build/doc/html/* /data-out/ +rm -rf /tmp/build -- To view, visit https://review.coreboot.org/c/flashrom/+/86681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I844e4ea84b94444c96f29325fee205b0deb972da Gerrit-Change-Number: 86681 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2025