March 2025 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: util/docker: Update the script that updates the website
by Patrick Georgi (Code Review) 06 Mar '25

06 Mar '25

Attention is currently required from: Anastasia Klimchuk, Elyes Haouas, Stefan Reinauer. Patrick Georgi has posted comments on this change by Patrick Georgi. ( https://review.coreboot.org/c/flashrom/+/86681?usp=email ) Change subject: util/docker: Update the script that updates the website ...................................................................... Patch Set 1: (1 comment) File util/docker/flashrom.org/Dockerfile: https://review.coreboot.org/c/flashrom/+/86681/comment/… [View More]

1 0

[S] Change in flashrom[main]: util/docker: Update the script that updates the website
by Patrick Georgi (Code Review) 06 Mar '25

06 Mar '25

Attention is currently required from: Elyes Haouas, Patrick Georgi, Stefan Reinauer. Hello Anastasia Klimchuk, Elyes Haouas, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86681?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Elyes Haouas, Code-Review+2 by Stefan Reinauer, Verified+1 by build bot (Jenkins) The change is no longer … [View More]

1 0

[S] Change in flashrom[main]: Use SPDX in cli_getop files
by Anastasia Klimchuk (Code Review) 06 Mar '25

06 Mar '25

Attention is currently required from: Antonio Vázquez Blanco. Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85073?usp=email ) Change subject: Use SPDX in cli_getop files ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Knowing that in general you want to keep a single header style among all prohect files, should I dro […] Oh no, please don't … [View More]

1 0

[XS] Change in flashrom[main]: tests/chip: fix print format errors
by Anastasia Klimchuk (Code Review) 06 Mar '25

06 Mar '25

Attention is currently required from: Antonio Vázquez Blanco. Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/86679?usp=email ) Change subject: tests/chip: fix print format errors ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: Thank you, this is nice catch! There is a large patch which will likely to have merge conflict here, CB:86031 I plan to … [View More]

1 0

[S] Change in flashrom[main]: util/docker: Update the script that updates the website
by Anastasia Klimchuk (Code Review) 06 Mar '25

06 Mar '25

Attention is currently required from: Patrick Georgi. Anastasia Klimchuk has posted comments on this change by Patrick Georgi. ( https://review.coreboot.org/c/flashrom/+/86681?usp=email ) Change subject: util/docker: Update the script that updates the website ...................................................................... Patch Set 1: (1 comment) File util/docker/flashrom.org/Dockerfile: https://review.coreboot.org/c/flashrom/+/86681/comment/44cccca1_a860073b?us… : PS1, Line 19: … [View More]

1 0

[XS] Change in flashrom[main]: Enable authors list generation on Jenkins
by Anastasia Klimchuk (Code Review) 06 Mar '25

06 Mar '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86678?usp=email ) Change subject: Enable authors list generation on Jenkins ...................................................................... Enable authors list generation on Jenkins Change-Id: Ia018ce4addb65273fe022ed1f1e9d38420c0e469 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86678 Reviewed-by: Peter Marheine <pmarheine(… [View More]

1 0

[M] Change in flashrom[main]: doc: Final cleanup of remaining references to the old wiki website
by Stefan Reinauer (Code Review) 05 Mar '25

05 Mar '25

Attention is currently required from: Anastasia Klimchuk. Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86676?usp=email ) Change subject: doc: Final cleanup of remaining references to the old wiki website ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86676?usp=email To unsubscribe, or for help writing mail … [View More]

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Sergii Dmytruk (Code Review) 05 Mar '25

05 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Richard Hughes. Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email ) Change subject: libflashrom: Update the API for progress callback ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help … [View More]

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Anastasia Klimchuk (Code Review) 05 Mar '25

05 Mar '25

Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email ) Change subject: libflashrom: Update the API for progress callback ...................................................................... Patch Set 13: (1 comment) File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86031/comment/d60620f7_7b1afe94?us… :… [View More]

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Anastasia Klimchuk (Code Review) 05 Mar '25

05 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Richard Hughes. Hello Peter Marheine, Richard Hughes, Sergii Dmytruk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86031?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Code-Review+2 by Peter Marheine, Verified+1 by build bot (Jenkins) Change subject: libflashrom: Update the API for progress … [View More]callback ...................................................................... libflashrom: Update the API for progress callback The initial version of API for progress callback would require the callback function to make a second call to get the needed data about progress state (current, total etc). This patch changes the callback API, so that callback function gets all needed data straight away as parameters, and with this, callback has all the data to do its job. Since the initial version was submitted and it was in the tree for a while, the change needs to add a _v2 suffix for new thing and deprecated attribute for old thing. Testing: both unit tests and cli are libflashrom clients. All unit tests run successfully, for the cli all scenarios from commit 75dc0655b95dde91f1426a7e5aecfc04d7b8d631 run successfully. Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M cli_classic.c M cli_output.c M doc/release_notes/devel.rst M flashrom.c M include/cli_output.h M include/flash.h M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/chip.c M tests/spi25.c 11 files changed, 122 insertions(+), 72 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/86031/13 -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 13 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> [View Less]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2025