September 2024 - flashrom-gerrit

[M] Change in flashrom[main]: Fix FEATURE_NO_ERASE chips and add test for them
by Anastasia Klimchuk (Code Review) 05 Sep '24

05 Sep '24

Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84203?usp=email ) Change subject: Fix FEATURE_NO_ERASE chips and add test for them ...................................................................... Patch Set 3: (1 comment) File tests/chip.c: https://review.coreboot.org/c/flashrom/+/84203/comment/507a9a1a_20709f79?us… : PS1, Line 418: 0xCC > If this value changed to 0xAC (something different from initial content), the test times out. […] Changed the test to run with dummyflasher, so that dummy takes care of all memory buffers. -- To view, visit https://review.coreboot.org/c/flashrom/+/84203?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I582fe00da0715e9b5e92fcc9d15d5a90a2615117 Gerrit-Change-Number: 84203 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 05 Sep 2024 12:36:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: Fix FEATURE_NO_ERASE chips and add test for them
by Anastasia Klimchuk (Code Review) 05 Sep '24

05 Sep '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/84203?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Fix FEATURE_NO_ERASE chips and add test for them ...................................................................... Fix FEATURE_NO_ERASE chips and add test for them New check was added to `check_block_eraser` in commit 0f389aea9e630c3b21547a5dd8dbe572a8502853 but it was not handling FEATURE_NO_ERASE chips. This patch fixes processing such chips and adds test to run write and verify with dummyflasher for FEATURE_NO_ERASE chips. Ticket: https://ticket.coreboot.org/issues/553 Change-Id: I582fe00da0715e9b5e92fcc9d15d5a90a2615117 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M flashrom.c M tests/chip.c M tests/tests.c M tests/tests.h 4 files changed, 65 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/84203/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/84203?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I582fe00da0715e9b5e92fcc9d15d5a90a2615117 Gerrit-Change-Number: 84203 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: flashrom.c: fix programmer_table
by Anastasia Klimchuk (Code Review) 05 Sep '24

05 Sep '24

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49594?usp=email ) Change subject: flashrom.c: fix programmer_table ...................................................................... Abandoned This code has changed a lot and enum programmer does not exist anymore -- To view, visit https://review.coreboot.org/c/flashrom/+/49594?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id0755d550d1e5736f0fb3983028c2733822ebbcb Gerrit-Change-Number: 49594 Gerrit-PatchSet: 1 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Anastasia Klimchuk (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... Patch Set 8: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/83854/comment/f3ea7566_efdb9f9c?us… : PS5, Line 10: : The IDs of IoT chipset SKUs (ending with E) can only be found in "12th Gen Intel® Core™ Processors Family (Formerly Known as Alder Lake -S) for IoT Platforms External Design Specification (EDS) Addendum" DOC 634528 rev 2.7 (NDA). : : TEST=Probe flash on Z790 chipset. Run the ich_descriptors_tool and check output is correct as expected. > Sorry, my laziness came out and I edited it in gerrit UI 😊 Corrected Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 8 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 11:54:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Michał Żygowski (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Anastasia Klimchuk, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Sergii Dmytruk. Michał Żygowski has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/83854/comment/3c6d1f6b_d175bd75?us… : PS5, Line 10: : The IDs of IoT chipset SKUs (ending with E) can only be found in "12th Gen Intel® Core™ Processors Family (Formerly Known as Alder Lake -S) for IoT Platforms External Design Specification (EDS) Addendum" DOC 634528 rev 2.7 (NDA). : : TEST=Probe flash on Z790 chipset. Run the ich_descriptors_tool and check output is correct as expected. > Just one last thing: if you could wrap commit message by max width 72 chars, as we have by the style […] Sorry, my laziness came out and I edited it in gerrit UI 😊 Corrected -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 8 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:56:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Michał Żygowski (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Sergii Dmytruk. Michał Żygowski has uploaded a new patch set (#8) to the change originally created by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... ichspi: Add RaptorPoint PCH support Based on public Intel 700 Series PCH datasheet, DOC 743835 rev 004. The IDs of IoT chipset SKUs (ending with E) can only be found in "12th Gen Intel® Core™ Processors Family (Formerly Known as Alder Lake -S) for IoT Platforms External Design Specification (EDS) Addendum" DOC 634528 rev 2.7 (NDA). TEST=Probe flash on Z790 chipset. Run the ich_descriptors_tool and check the output is correct as expected. Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M chipset_enable.c M doc/release_notes/devel.rst M ich_descriptors.c M ichspi.c M include/programmer.h M util/ich_descriptors_tool/ich_descriptors_tool.c 6 files changed, 45 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/83854/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 8 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Michał Żygowski (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Sergii Dmytruk. Michał Żygowski has uploaded a new patch set (#7) to the change originally created by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... ichspi: Add RaptorPoint PCH support Based on public Intel 700 Series PCH datasheet, DOC 743835 rev 004. The IDs of IoT chipset SKUs (ending with E) can only be found in "12th Gen Intel® Core™ Processors Family (Formerly Known as Alder Lake -S) for IoT Platforms External Design Specification (EDS) Addendum" DOC 634528 rev 2.7 (NDA). TEST=Probe flash on Z790 chipset. Run the ich_descriptors_tool and check output is correct as expected. Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M chipset_enable.c M doc/release_notes/devel.rst M ich_descriptors.c M ichspi.c M include/programmer.h M util/ich_descriptors_tool/ich_descriptors_tool.c 6 files changed, 45 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/83854/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 7 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Michał Żygowski (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Sergii Dmytruk. Michał Żygowski has uploaded a new patch set (#6) to the change originally created by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... ichspi: Add RaptorPoint PCH support Based on public Intel 700 Series PCH datasheet, DOC 743835 rev 004. The IDs of IoT chipset SKUs (ending with E) can only be found in "12th Gen Intel® Core™ Processors Family (Formerly Known as Alder Lake -S) for IoT Platforms External Design Specification (EDS) Addendum" DOC 634528 rev 2.7 (NDA). TEST=Probe flash on Z790 chipset. Run the ich_descriptors_tool and check output is correct as expected. Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M chipset_enable.c M doc/release_notes/devel.rst M ich_descriptors.c M ichspi.c M include/programmer.h M util/ich_descriptors_tool/ich_descriptors_tool.c 6 files changed, 45 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/83854/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 6 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Anastasia Klimchuk (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/83854/comment/e29b63af_83318243?us… : PS5, Line 10: : The IDs of IoT chipset SKUs (ending with E) can only be found in "12th Gen Intel® Core™ Processors Family (Formerly Known as Alder Lake -S) for IoT Platforms External Design Specification (EDS) Addendum" DOC 634528 rev 2.7 (NDA). : : TEST=Probe flash on Z790 chipset. Run the ich_descriptors_tool and check output is correct as expected. Just one last thing: if you could wrap commit message by max width 72 chars, as we have by the style guide, thanks! https://flashrom.org/dev_guide/development_guide.html#commit-message-1 File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/83854/comment/3438bba2_cb2f71bd?us… : PS4, Line 2209: {0x8086, 0x7a90, B_S, NT, "Intel", "R680E", enable_flash_pch600}, : {0x8086, 0x7a91, B_S, NT, "Intel", "Q670E", enable_flash_pch600}, : {0x8086, 0x7a92, B_S, NT, "Intel", "H610E", enable_flash_pch600} > Added info to the commit message Perfect, thank you File util/ich_descriptors_tool/ich_descriptors_tool.c: https://review.coreboot.org/c/flashrom/+/83854/comment/ccb3fa58_9419e014?us… : PS3, Line 142: "\t- \"600\" or \"alder\" for Intel's 600 series chipsets.\n" > Got it, added info to the commit message that ich_descriptors_tool has also been tested Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 5 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 09:45:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Michał Żygowski (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Anastasia Klimchuk, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Sergii Dmytruk. Michał Żygowski has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... Patch Set 5: (2 comments) File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/83854/comment/83335f3a_2ad8227f?us… : PS4, Line 2209: {0x8086, 0x7a90, B_S, NT, "Intel", "R680E", enable_flash_pch600}, : {0x8086, 0x7a91, B_S, NT, "Intel", "Q670E", enable_flash_pch600}, : {0x8086, 0x7a92, B_S, NT, "Intel", "H610E", enable_flash_pch600} > The chipsets ending with 'E' are IoT SKUs. […] Added info to the commit message File util/ich_descriptors_tool/ich_descriptors_tool.c: https://review.coreboot.org/c/flashrom/+/83854/comment/a7ac837b_922aca27?us… : PS3, Line 142: "\t- \"600\" or \"alder\" for Intel's 600 series chipsets.\n" > Oh sorry, I said it in a confusing way! No, you don't need to add the output of the tool to commit m […] Got it, added info to the commit message that ich_descriptors_tool has also been tested -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 5 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 09:05:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2024