August 2024 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[main]: doc: Remove leftover reference to building_with_make
by Anastasia Klimchuk (Code Review) 22 Aug '24

22 Aug '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83942?usp=email ) Change subject: doc: Remove leftover reference to building_with_make ...................................................................... doc: Remove leftover reference to building_with_make Change-Id: If6d3580972ea7d42503004b922b90829025bd62d Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83942 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M doc/user_docs/example_partial_wp.rst 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/doc/user_docs/example_partial_wp.rst b/doc/user_docs/example_partial_wp.rst index 67a382a..811c772 100644 --- a/doc/user_docs/example_partial_wp.rst +++ b/doc/user_docs/example_partial_wp.rst @@ -14,8 +14,8 @@ Write-protect manipulation functionality is included in flashrom since release v1.3.0. If for any reasons you need the latest code from head, you might need to build :code:`flashrom` -from scratch. The following docs describe how to do this :doc:`/dev_guide/building_from_source` and -:doc:`/dev_guide/building_with_make`. See also :doc:`/dev_guide/development_guide`. +from scratch. The following doc describe how to do this: :doc:`/dev_guide/building_from_source`. +See also :doc:`/dev_guide/development_guide`. Alternatively, your operating system might provide development version of :code:`flashrom` as a package. -- To view, visit https://review.coreboot.org/c/flashrom/+/83942?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If6d3580972ea7d42503004b922b90829025bd62d Gerrit-Change-Number: 83942 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in flashrom[main]: tree: Remove print_wiki.c
by Anastasia Klimchuk (Code Review) 22 Aug '24

22 Aug '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83941?usp=email ) Change subject: tree: Remove print_wiki.c ...................................................................... tree: Remove print_wiki.c Old wiki website is retired and so is print_wiki.c Change-Id: I9990add27f7fdddc23ddd1f33306566ce7548417 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83941 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M cli_classic.c M doc/classic_cli_manpage.rst M include/flash.h M include/programmer.h M known_boards.c M meson.build M meson_options.txt D print_wiki.c 8 files changed, 2 insertions(+), 508 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/cli_classic.c b/cli_classic.c index ffded5f..3343438 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -51,9 +51,6 @@ bool read_it, extract_it, write_it, erase_it, verify_it; bool dont_verify_it, dont_verify_all; bool list_supported; -#if CONFIG_PRINT_WIKI == 1 - bool list_supported_wiki; -#endif char *filename; const struct programmer_entry *prog; @@ -81,9 +78,6 @@ static void cli_classic_usage(const char *name) { printf("Usage: %s [-h|-R|-L|" -#if CONFIG_PRINT_WIKI == 1 - "-z|" -#endif "\n\t-p <programmername>[:<parameters>] [-c <chipname>]\n" "\t\t(--flash-name|--flash-size|\n" "\t\t [-E|-x|(-r|-w|-v) <file>]\n" @@ -124,16 +118,10 @@ " -o | --output <logfile> log output to <logfile>\n" " --flash-contents <ref-file> assume flash contents to be <ref-file>\n" " -L | --list-supported print supported devices\n" -#if CONFIG_PRINT_WIKI == 1 - " -z | --list-supported-wiki print supported devices in wiki syntax\n" -#endif " --progress show progress percentage on the standard output\n" " -p | --programmer <name>[:<param>] specify the programmer device. One of\n"); list_programmers_linebreak(4, 80, 0); printf(".\n\nYou can specify one of -h, -R, -L, " -#if CONFIG_PRINT_WIKI == 1 - "-z, " -#endif "-E, -r, -w, -v or no operation.\n" "If no operation is specified, flashrom will only probe for flash chips.\n"); } @@ -754,15 +742,6 @@ cli_classic_validate_singleop(&operation_specified); options->list_supported = true; break; - case 'z': -#if CONFIG_PRINT_WIKI == 1 - cli_classic_validate_singleop(&operation_specified); - options->list_supported_wiki = true; -#else - cli_classic_abort_usage("Error: Wiki output was not " - "compiled in. Aborting.\n"); -#endif - break; case 'p': if (options->prog != NULL) { cli_classic_abort_usage("Error: --programmer specified " @@ -895,7 +874,6 @@ {"wp-enable", 0, NULL, OPTION_WP_ENABLE}, {"wp-disable", 0, NULL, OPTION_WP_DISABLE}, {"list-supported", 0, NULL, 'L'}, - {"list-supported-wiki", 0, NULL, 'z'}, {"programmer", 1, NULL, 'p'}, {"help", 0, NULL, 'h'}, {"version", 0, NULL, 'R'}, @@ -934,13 +912,6 @@ if (options.logfile && open_logfile(options.logfile)) cli_classic_abort_usage(NULL); -#if CONFIG_PRINT_WIKI == 1 - if (options.list_supported_wiki) { - print_supported_wiki(); - goto out; - } -#endif - if (options.list_supported) { if (print_supported()) ret = 1; diff --git a/doc/classic_cli_manpage.rst b/doc/classic_cli_manpage.rst index d8380c7..932f4c9 100644 --- a/doc/classic_cli_manpage.rst +++ b/doc/classic_cli_manpage.rst @@ -11,7 +11,7 @@ SYNOPSIS -------- -| **flashrom** [-h|-R|-L|-z| +| **flashrom** [-h|-R|-L| | -p <programmername>[:<parameters>] [-c <chipname>] | (--flash-name|--flash-size| | [-E|-x|-r <file>|-w <file>|-v <file>] @@ -39,7 +39,7 @@ OPTIONS ------- -You can specify one of ``-h``, ``-R``, ``-L``, ``-z``, ``-E``, ``-r``, ``-w``, ``-v`` or no operation. +You can specify one of ``-h``, ``-R``, ``-L``, ``-E``, ``-r``, ``-w``, ``-v`` or no operation. If no operation is specified, **flashrom** will only probe for flash chips. It is recommended that if you try **flashrom** the first time on a system, you run it in probe-only mode and check the output. Also you are advised to make a backup of your current ROM contents with ``-r`` before you try to write a new image. @@ -256,12 +256,6 @@ For verification you have to test an ERASE and/or WRITE operation, so make sure you only do that if you have proper means to recover from failure! -**-z, --list-supported-wiki** - Same as ``--list-supported``, but outputs the supported hardware in MediaWiki syntax, - so that it can be easily pasted into the `supported hardware wiki page <https://flashrom.org/Supported_hardware>`_. - Please note that MediaWiki output is not compiled in by default. - - **-p, --programmer <name>[:parameter[,parameter[,parameter]]]** Specify the programmer device. This is mandatory for all operations involving any chip access (probe/read/write/...). Currently supported are: diff --git a/include/flash.h b/include/flash.h index aa89409..d9a20ad 100644 --- a/include/flash.h +++ b/include/flash.h @@ -606,7 +606,6 @@ /* print.c */ int print_supported(void); -void print_supported_wiki(void); /* helpers.c */ uint32_t address_to_bits(uint32_t addr); diff --git a/include/programmer.h b/include/programmer.h index a90624b..77e79ae 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -208,10 +208,8 @@ const char *vendor; const char *name; const enum test_state working; -#ifdef CONFIG_PRINT_WIKI const char *url; const char *note; -#endif }; extern const struct board_info boards_known[]; diff --git a/known_boards.c b/known_boards.c index afc6992..c412b8f 100644 --- a/known_boards.c +++ b/known_boards.c @@ -18,12 +18,7 @@ #include "programmer.h" - -#ifdef CONFIG_PRINT_WIKI #define B(vendor, name, status, url, note) { vendor, name, status, url, note } -#else -#define B(vendor, name, status, url, note) { vendor, name, status } -#endif /* Please keep this list alphabetically ordered by vendor/board. */ const struct board_info boards_known[] = { diff --git a/meson.build b/meson.build index ae56b26..85d69b8 100644 --- a/meson.build +++ b/meson.build @@ -61,7 +61,6 @@ add_project_arguments('-DFLASHROM_VERSION="' + flashrom_version + '"', language : 'c') # get defaults from configure -config_print_wiki= get_option('classic_cli_print_wiki') config_default_programmer_name = get_option('default_programmer_name') config_default_programmer_args = get_option('default_programmer_args') @@ -623,15 +622,6 @@ endif endforeach -if config_print_wiki.enabled() - if get_option('classic_cli').disabled() - error('`classic_cli_print_wiki` can not be enabled without `classic_cli`') - else - srcs += files('print_wiki.c') - cargs += '-DCONFIG_PRINT_WIKI=1' - endif -endif - if config_default_programmer_name != '' cargs += '-DCONFIG_DEFAULT_PROGRAMMER_NAME=&programmer_' + config_default_programmer_name else diff --git a/meson_options.txt b/meson_options.txt index 8a04114..0f56e26 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -1,5 +1,4 @@ option('classic_cli', type : 'feature', value : 'enabled', description : 'classic flashrom cli binary') -option('classic_cli_print_wiki', type : 'feature', value : 'disabled', description : 'Print Wiki') option('default_programmer_name', type : 'string', description : 'default programmer') option('default_programmer_args', type : 'string', description : 'default programmer arguments') option('ich_descriptors_tool', type : 'feature', value : 'auto', description : 'Build ich_descriptors_tool') diff --git a/print_wiki.c b/print_wiki.c deleted file mode 100644 index a0cade9..0000000 --- a/print_wiki.c +++ /dev/null @@ -1,452 +0,0 @@ -/* - * This file is part of the flashrom project. - * - * Copyright (C) 2009 Uwe Hermann <uwe(a)hermann-uwe.de> - * Copyright (C) 2009 Carl-Daniel Hailfinger - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <stdio.h> -#include <string.h> -#include <stdlib.h> -#include <time.h> -#include "flash.h" -#include "flashchips.h" -#include "programmer.h" - -static const char wiki_header[] = "= Supported devices =\n\n\ -<div style=\"margin-top:0.5em; padding:0.5em 0.5em 0.5em 0.5em; \ -background-color:#eeeeee; text-align:left; border:1px solid #aabbcc;\">\ -<small>\n\ -'''Last update:''' %s (generated by flashrom %s)<br />\n\ -The tables below are generated from flashrom's source by copying the output of '''flashrom -z'''.<br /><br />\n\ -A short explanation of the cells representing the support state follows:<br />\n\ -{| border=\"0\" valign=\"top\"\n\ -! style=\"text-align:left;\" |\n\ -! style=\"text-align:left;\" |\n\ -|-\n\ -|{{OK}}\n\ -| The feature was '''tested and should work''' in general unless there is a bug in flashrom or another component in \ -the system prohibits some functionality.\n\ -|-\n\ -|{{Dep}}\n\ -| '''Configuration-dependent'''. The feature was tested and should work in general but there are common \ -configurations that drastically limit flashrom's capabilities or make it completely stop working.\n\ -|-\n\ -|{{?3}}\n\ -| The feature is '''untested''' but believed to be working.\n\ -|-\n\ -|{{NA}}\n\ -| The feature is '''not applicable''' in this configuration (e.g. write operations on ROM chips).\n\ -|-\n\ -|{{No}}\n\ -| The feature is '''known to not work'''. Don't bother testing (nor reporting. Patches welcome! ;).\n\ -|}\n\ -</small></div>\n"; - -static const char th_start[] = "| valign=\"top\"|\n\n\ -{| border=\"0\" style=\"font-size: smaller\" valign=\"top\"\n\ -|- bgcolor=\"#6699dd\"\n"; - -#if CONFIG_INTERNAL == 1 -static const char chipset_th[] = "\ -! align=\"left\" | Vendor\n\ -! align=\"left\" | Southbridge\n\ -! align=\"center\" | PCI IDs\n\ -! align=\"center\" | Status\n\n"; - -static const char board_th[] = "\ -! align=\"left\" | Vendor\n\ -! align=\"left\" | Mainboard\n\ -! align=\"left\" | Required option\n\ -! align=\"center\" | Status\n\n"; - -static const char board_intro[] = "\ -\n== Supported mainboards ==\n\n\ -In general, it is very likely that flashrom works out of the box even if your \ -mainboard is not listed below.\n\nThis is a list of mainboards where we have \ -verified that they either do or do not need any special initialization to \ -make flashrom work (given flashrom supports the respective chipset and flash \ -chip), or that they do not yet work at all. If they do not work, support may \ -or may not be added later.\n\n\ -Mainboards (or individual revisions) which don't appear in the list may or may \ -not work (we don't know, someone has to give it a try). Please report any \ -further verified mainboards on the [[Contact#Mailing_List|mailing list]].\n"; -#endif - -static const char chip_th[] = "\ -! align=\"left\" | Vendor\n\ -! align=\"left\" | Device\n\ -! align=\"center\" | Size [kB]\n\ -! align=\"center\" | Type\n\ -! align=\"center\" colspan=\"4\" | Status\n\ -! align=\"center\" colspan=\"2\" | Voltage [V]\n\n\ -|- bgcolor=\"#6699ff\"\n| colspan=\"4\" |  \n\ -| Probe\n| Read\n| Erase\n| Write\n\ -| align=\"center\" | Min\n| align=\"center\" | Max\n\n"; - -static const char chip_intro[] = "\ -\n== Supported flash chips ==\n\n\ -The list below contains all chips that have some kind of explicit support added to flashrom and their last \ -known test status. Newer SPI flash chips might work even without explicit support if they implement SFDP ([\ -http://www.jedec.org/standards-documents/docs/jesd216 Serial Flash Discoverable Parameters - JESD216]). \ -Flashrom will detect this automatically and inform you about it.\n\n\ -The names used below are designed to be as concise as possible and hence contain only the characters \ -describing properties that are relevant to flashrom. Irrelevant characters specify attributes flashrom can not \ -use or even detect by itself (e.g. the physical package) and have no effect on flashrom's operation. They are \ -replaced by dots ('.') functioning as wildcards (like in Regular Expressions) or are completely omitted at the \ -end of a name.\n"; - -static const char programmer_th[] = "\ -! align=\"left\" | Programmer\n\ -! align=\"left\" | Vendor\n\ -! align=\"left\" | Device\n\ -! align=\"center\" | IDs\n\ -! align=\"center\" | Status\n\n"; - -/* The output of this module relies on MediaWiki templates to select special formatting styles for table cells - * reflecting the test status of the respective hardware. This functions returns the correct template name for - * the supplied enum test_state. */ -static const char *test_state_to_template(enum test_state test_state) -{ - switch (test_state) { - case OK: return "OK"; - case BAD: return "No"; - case NA: return "NA"; - case DEP: return "Dep"; - case NT: - default: return "?3"; - } -} - -#if CONFIG_INTERNAL == 1 -static const char laptop_intro[] = "\n== Supported mobile devices (laptops, tablets etc.) ==\n\n\ -In general, flashing mobile devices is more difficult because they\n\n\ -* often use the flash chip for stuff besides the BIOS,\n\ -* often have special protection stuff which has to be handled by flashrom,\n\ -* often use flash translation circuits which need drivers in flashrom.\n\n\ -<div style=\"margin-top:0.5em; padding:0.5em 0.5em 0.5em 0.5em; \ -background-color:#ff6666; align:right; border:1px solid #000000;\">\n\ -'''IMPORTANT:''' At this point we recommend to '''not''' use flashrom on \ -untested mobile devices unless you have a means to recover from a flashing that goes \ -wrong (a working backup flash chip and/or good soldering skills).\n</div>\n"; - -static void print_supported_chipsets_wiki(int cols) -{ - int i; - unsigned int lines_per_col; - const struct penable *e; - int enablescount = 0, color = 1; - - for (e = chipset_enables; e->vendor_name != NULL; e++) - enablescount++; - - /* +1 to force the resulting number of columns to be < cols */ - lines_per_col = enablescount / cols + ((enablescount%cols) > 0 ? 1 : 0); - - printf("\n== Supported chipsets ==\n\nTotal amount of supported chipsets: '''%d'''\n\n" - "{| border=\"0\" valign=\"top\"\n", enablescount); - - e = chipset_enables; - for (i = 0; e[i].vendor_name != NULL; i++) { - if ((i % lines_per_col) == 0) - printf("%s%s", th_start, chipset_th); - - /* Alternate colors if the vendor changes. */ - if (i > 0 && strcmp(e[i].vendor_name, e[i - 1].vendor_name)) - color = !color; - - printf("|- bgcolor=\"#%s\"\n| %s || %s " - "|| %04x:%04x || {{%s}}\n", (color) ? "eeeeee" : "dddddd", - e[i].vendor_name, e[i].device_name, - e[i].vendor_id, e[i].device_id, - test_state_to_template(e[i].status)); - - if (((i % lines_per_col) + 1) == lines_per_col) - printf("\n|}\n\n"); - } - - /* end inner table if it did not fill the last column fully */ - if (((i % lines_per_col)) > 0) - printf("\n|}\n\n"); - printf("\n\n|}\n"); -} - -static void print_supported_boards_wiki_helper(const char *devicetype, int cols, const struct board_info boards[]) -{ - int i, k; - unsigned int boardcount, lines_per_col; - unsigned int boardcount_good = 0, boardcount_bad = 0, boardcount_nt = 0; - int num_notes = 0, color = 1; - char *notes = calloc(1, 1); - char tmp[900 + 1]; - const struct board_match *b = board_matches; - - for (i = 0; boards[i].vendor != NULL; i++) { - if (boards[i].working == OK) - boardcount_good++; - else if (boards[i].working == NT) - boardcount_nt++; - else - boardcount_bad++; - } - boardcount = boardcount_good + boardcount_nt + boardcount_bad; - - /* +1 to force the resulting number of columns to be < cols */ - lines_per_col = boardcount / cols + ((boardcount%cols) > 0 ? 1 : 0); - - printf("\n\nTotal amount of known good %s: '''%d'''; " - "Untested (e.g. user vanished before testing new code): '''%d'''; " - "Not yet supported (i.e. known-bad): '''%d'''.\n\n" - "{| border=\"0\" valign=\"top\"\n", devicetype, boardcount_good, boardcount_nt, boardcount_bad); - - for (i = 0; boards[i].vendor != NULL; i++) { - if ((i % lines_per_col) == 0) - printf("%s%s", th_start, board_th); - - /* Alternate colors if the vendor changes. */ - if (i > 0 && strcmp(boards[i].vendor, boards[i - 1].vendor)) - color = !color; - - k = 0; - while ((b[k].vendor_name != NULL) && - (strcmp(b[k].vendor_name, boards[i].vendor) || - strcmp(b[k].board_name, boards[i].name))) { - k++; - } - - printf("|- bgcolor=\"#%s\"\n| %s || %s%s %s%s || %s%s%s%s " - "|| {{%s}}", (color) ? "eeeeee" : "dddddd", - boards[i].vendor, - boards[i].url ? "[" : "", - boards[i].url ? boards[i].url : "", - boards[i].name, - boards[i].url ? "]" : "", - b[k].lb_vendor ? "-p internal:mainboard=" : "—", - b[k].lb_vendor ? b[k].lb_vendor : "", - b[k].lb_vendor ? ":" : "", - b[k].lb_vendor ? b[k].lb_part : "", - test_state_to_template(boards[i].working)); - - if (boards[i].note) { - num_notes++; - printf(" <span id=\"%s_ref%d\"><sup>[[#%s_note%d|%d]]</sup></span>\n", - devicetype, num_notes, devicetype, num_notes, num_notes); - int ret = snprintf(tmp, sizeof(tmp), - "<span id=\"%s_note%d\">%d. [[#%s_ref%d|↑]]</span>" - " <nowiki>%s</nowiki><br />\n", devicetype, num_notes, num_notes, - devicetype, num_notes, boards[i].note); - if (ret < 0 || (unsigned int)ret >= sizeof(tmp)) { - fprintf(stderr, "Footnote text #%d of %s truncated (ret=%d, sizeof(tmp)=%zu)\n", - num_notes, devicetype, ret, sizeof(tmp)); - } - notes = strcat_realloc(notes, tmp); - } else { - printf("\n"); - } - - if (((i % lines_per_col) + 1) == lines_per_col) - printf("\n|}\n\n"); - } - - /* end inner table if it did not fill the last column fully */ - if (((i % lines_per_col)) > 0) - printf("\n|}\n\n"); - printf("|}\n"); - - if (num_notes > 0) - printf("\n<small>\n%s</small>\n", notes); - free(notes); -} - -static void print_supported_boards_wiki(void) -{ - printf("%s", board_intro); - print_supported_boards_wiki_helper("mainboards", 2, boards_known); - - printf("%s", laptop_intro); - print_supported_boards_wiki_helper("mobile devices", 1, laptops_known); -} -#endif - -static void print_supported_chips_wiki(int cols) -{ - unsigned int lines_per_col; - char *s; - char vmax[6]; - char vmin[6]; - const struct flashchip *f, *old = NULL; - int i = 0, c = 1, chipcount = 0; - - for (f = flashchips; f->name != NULL; f++) { - /* Don't count generic entries. */ - if (!strncmp(f->vendor, "Unknown", 7) || - !strncmp(f->vendor, "Programmer", 10) || - !strncmp(f->name, "unknown", 7)) - continue; - chipcount++; - } - - /* +1 to force the resulting number of columns to be < cols */ - lines_per_col = chipcount / cols + ((chipcount%cols) > 0 ? 1 : 0); - - printf("%s", chip_intro); - printf("\nTotal amount of supported chips: '''%d'''\n\n" - "{| border=\"0\" valign=\"top\"\n", chipcount); - - for (f = flashchips; f->name != NULL; f++) { - /* Don't print generic entries. */ - if (!strncmp(f->vendor, "Unknown", 7) || - !strncmp(f->vendor, "Programmer", 10) || - !strncmp(f->name, "unknown", 7)) - continue; - - if ((i % lines_per_col) == 0) - printf("%s%s", th_start, chip_th); - - /* Alternate colors if the vendor changes. */ - if (old != NULL && strcmp(old->vendor, f->vendor)) - c = !c; - - old = f; - s = flashbuses_to_text(f->bustype); - sprintf(vmin, "%0.03f", f->voltage.min / (double)1000); - sprintf(vmax, "%0.03f", f->voltage.max / (double)1000); - printf("|- bgcolor=\"#%s\"\n| %s || %s || align=\"right\" | %d " - "|| %s || {{%s}} || {{%s}} || {{%s}} || {{%s}}" - "|| %s || %s\n", - (c == 1) ? "eeeeee" : "dddddd", f->vendor, f->name, - f->total_size, s ? s : "?", - test_state_to_template(f->tested.probe), - test_state_to_template(f->tested.read), - test_state_to_template(f->tested.erase), - test_state_to_template(f->tested.write), - f->voltage.min ? vmin : "?", - f->voltage.max ? vmax : "?"); - free(s); - - if (((i % lines_per_col) + 1) == lines_per_col) - printf("\n|}\n\n"); - i++; - } - /* end inner table if it did not fill the last column fully */ - if (((i % lines_per_col)) > 0) - printf("\n|}\n\n"); - printf("|}\n\n"); -} - -/* Following functions are not needed when no PCI/USB programmers are compiled in, - * but since print_wiki code has no size constraints we include it unconditionally. */ -static int count_supported_devs_wiki(const struct dev_entry *devs) -{ - unsigned int count = 0; - unsigned int i = 0; - for (i = 0; devs[i].vendor_id != 0; i++) - count++; - return count; -} - -static void print_supported_devs_wiki_helper(const struct programmer_entry *const prog) -{ - int i = 0; - static int c = 0; - const struct dev_entry *devs = prog->devs.dev; - const unsigned int count = count_supported_devs_wiki(devs); - - /* Alternate colors if the vendor changes. */ - c = !c; - - for (i = 0; devs[i].vendor_id != 0; i++) { - printf("|- bgcolor=\"#%s\"\n", (c) ? "eeeeee" : "dddddd"); - if (i == 0) - printf("| rowspan=\"%u\" | %s |", count, prog->name); - printf("| %s || %s || %04x:%04x || {{%s}}\n", devs[i].vendor_name, devs[i].device_name, - devs[i].vendor_id, devs[i].device_id, test_state_to_template(devs[i].status)); - } -} - -static void print_supported_devs_wiki() -{ - unsigned int pci_count = 0; - unsigned int usb_count = 0; - unsigned int i; - - for (i = 0; i < programmer_table_size; i++) { - const struct programmer_entry *const prog = programmer_table[i]; - switch (prog->type) { - case USB: - usb_count += count_supported_devs_wiki(prog->devs.dev); - break; - case PCI: - pci_count += count_supported_devs_wiki(prog->devs.dev); - break; - case OTHER: - default: - break; - } - } - - printf("\n== PCI Devices ==\n\n" - "Total amount of supported PCI devices flashrom can use as a programmer: '''%d'''\n\n" - "{%s%s", pci_count, th_start, programmer_th); - - for (i = 0; i < programmer_table_size; i++) { - const struct programmer_entry *const prog = programmer_table[i]; - if (prog->type == PCI) { - print_supported_devs_wiki_helper(prog); - } - } - printf("\n|}\n\n|}\n"); - - printf("\n== USB Devices ==\n\n" - "Total amount of supported USB devices flashrom can use as a programmer: '''%d'''\n\n" - "{%s%s", usb_count, th_start, programmer_th); - - for (i = 0; i < programmer_table_size; i++) { - const struct programmer_entry *const prog = programmer_table[i]; - if (prog->type == USB) { - print_supported_devs_wiki_helper(prog); - } - } - printf("\n|}\n\n|}\n"); - - printf("\n== Other programmers ==\n\n" - "{%s", th_start); - printf("! align=\"left\" | Programmer\n" - "! align=\"left\" | Note\n\n"); - - for (i = 0; i < programmer_table_size; i++) { - static int c = 0; - const struct programmer_entry *const prog = programmer_table[i]; - if (prog->type == OTHER && prog->devs.note != NULL) { - c = !c; - printf("|- bgcolor=\"#%s\"\n", (c) ? "eeeeee" : "dddddd"); - printf("| %s || %s", prog->name, prog->devs.note); - } - } - printf("\n|}\n\n|}\n"); -} - -void print_supported_wiki(void) -{ - time_t t = time(NULL); - char buf[sizeof("1986-02-28T12:37:42Z")]; - strftime(buf, sizeof(buf), "%Y-%m-%dT%H:%M:%SZ", gmtime(&t)); - - printf(wiki_header, buf, flashrom_version); - print_supported_chips_wiki(2); -#if CONFIG_INTERNAL == 1 - print_supported_chipsets_wiki(3); - print_supported_boards_wiki(); -#endif - print_supported_devs_wiki(); -} -- To view, visit https://review.coreboot.org/c/flashrom/+/83941?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9990add27f7fdddc23ddd1f33306566ce7548417 Gerrit-Change-Number: 83941 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in flashrom[main]: ch347_spi: Add spi clock frequency selection
by Anastasia Klimchuk (Code Review) 21 Aug '24

21 Aug '24

Attention is currently required from: Nicholas Chin, ZhiYuanNJ. Anastasia Klimchuk has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email ) Change subject: ch347_spi: Add spi clock frequency selection ...................................................................... Patch Set 13: (1 comment) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82776/comment/569b29f9_5a4fc5fc?us… : PS11, Line 291: speed_index = 1; But you haven't done? :) What I meant is that you don't need `int divisor` at all. You can initialise > int speed_index = 2; /* default 15M SPI */ and then always use `spispeeds[speed_index].divisor` You won't have `int divisor` at all. -- To view, visit https://review.coreboot.org/c/flashrom/+/82776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If2be48929db540a6598ac0b60b37e64597156db7 Gerrit-Change-Number: 82776 Gerrit-PatchSet: 13 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: ZhiYuanNJ Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Aug 2024 03:30:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: ZhiYuanNJ

1 0

[XS] Change in flashrom[main]: flashchips: add GD25B256E and GD25R256E
by Victor Lim (Code Review) 20 Aug '24

20 Aug '24

Victor Lim has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83998?usp=email ) Change subject: flashchips: add GD25B256E and GD25R256E ...................................................................... flashchips: add GD25B256E and GD25R256E GD25B256E: 3V 256Mbit, Quad enabled. GD25R256E: GD25B256E features + RPMC, so they share the same datasheet on flash side https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20230627/DS-0… Tested both models on ch347 with erase, write, read and protection. Change-Id: Ie733e0c2e35fa4797f5198f2c8334469b65f402c Signed-off-by: Victor Lim <vlim(a)gigadevice.com> --- M flashchips.c M include/flashchips.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/83998/1 diff --git a/flashchips.c b/flashchips.c index 2dede76..7a655e6 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7451,7 +7451,7 @@ { .vendor = "GigaDevice", - .name = "GD25Q256D/GD25Q256E", + .name = "GD25Q256E/GD25B256E/GD25R256E/GD25Q256D", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, .model_id = GIGADEVICE_GD25Q256D, @@ -7500,7 +7500,7 @@ .srp = {STATUS1, 7, RW}, .srl = {STATUS2, 6, RW}, .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, - .tb = {STATUS1, 6, RW}, + .tb = {STATUS1, 6, RW}, /* Called BP4 in datasheet, acts like TB */ }, .decode_range = DECODE_RANGE_SPI25, }, diff --git a/include/flashchips.h b/include/flashchips.h index 4e1abc4..9831ebc 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -392,7 +392,7 @@ #define GIGADEVICE_GD25Q32 0x4016 /* Same as GD25Q32B */ #define GIGADEVICE_GD25Q64 0x4017 /* Same as GD25Q64B */ #define GIGADEVICE_GD25Q128 0x4018 /* Same as GD25Q128B, GD25Q127C, GD25Q128C,and GD25Q128E, GD25B128E, GD25R128E can be distinguished by SFDP */ -#define GIGADEVICE_GD25Q256D 0x4019 +#define GIGADEVICE_GD25Q256D 0x4019 /* Same as GD25B256E, GD25Q256E, GD25R256E */ #define GIGADEVICE_GD25VQ21B 0x4212 #define GIGADEVICE_GD25VQ41B 0x4213 /* Same as GD25VQ40C, can be distinguished by SFDP */ #define GIGADEVICE_GD25VQ80C 0x4214 -- To view, visit https://review.coreboot.org/c/flashrom/+/83998?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie733e0c2e35fa4797f5198f2c8334469b65f402c Gerrit-Change-Number: 83998 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com>

1 0

[M] Change in flashrom[main]: flashchips: add GD25LF512MF model
by Anastasia Klimchuk (Code Review) 20 Aug '24

20 Aug '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83912?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: flashchips: add GD25LF512MF model ...................................................................... flashchips: add GD25LF512MF model GD25LF512MF: 1.8V 512Mbit high performance, quad IO enabled. Tested on ch347 with erase, write, read, and protection Change-Id: I3d202f5afcc9c33a4040f8186dc6fef1878ba79a Signed-off-by: Victor Lim <vlim(a)gigadevice.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83912 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M include/flashchips.h 2 files changed, 57 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index e6b4761..4c84a5a 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6644,6 +6644,62 @@ { .vendor = "GigaDevice", + .name = "GD25LF512MF", + .bustype = BUS_SPI, + .manufacture_id = GIGADEVICE_ID, + .model_id = GIGADEVICE_GD25LF512MF, + .total_size = 65536, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_WRSR_EXT2 | FEATURE_4BA, + .tested = TEST_OK_PREWB, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_21, + }, { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = SPI_BLOCK_ERASE_5C, + }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_DC, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD, /* TODO: 2nd status reg (read with 0x35) */ + .unlock = SPI_DISABLE_BLOCKPROTECT_BP4_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1695, 1950}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, + .tb = {STATUS1, 6, RW}, /* Called BP4 in datasheet, acts like TB */ + .srl = {STATUS2, 0, RW}, + .cmp = {STATUS2, 6, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, + }, + + { + .vendor = "GigaDevice", .name = "GD25LQ128E/GD25LB128E/GD25LR128E/GD25LQ128D/GD25LQ128C", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, diff --git a/include/flashchips.h b/include/flashchips.h index d5c0027..3c181a6 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -407,6 +407,7 @@ #define GIGADEVICE_GD25LB512MF 0x601A /* Same as GD25LR512MF */ #define GIGADEVICE_GD25LF128E 0x6318 #define GIGADEVICE_GD25LF256F 0x6319 +#define GIGADEVICE_GD25LF512MF 0x631A #define GIGADEVICE_GD25LR256E 0x6719 #define GIGADEVICE_GD25LR512ME 0x671A /* Same as GD25LB512ME */ #define GIGADEVICE_GD25WQ80E 0x6514 -- To view, visit https://review.coreboot.org/c/flashrom/+/83912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3d202f5afcc9c33a4040f8186dc6fef1878ba79a Gerrit-Change-Number: 83912 Gerrit-PatchSet: 3 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in flashrom[main]: ch347_spi: Add spi clock frequency selection
by ZhiYuanNJ (Code Review) 20 Aug '24

20 Aug '24

Attention is currently required from: Anastasia Klimchuk, Nicholas Chin. ZhiYuanNJ has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email ) Change subject: ch347_spi: Add spi clock frequency selection ...................................................................... Patch Set 13: (3 comments) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82776/comment/14a59a3f_e41cd1cf?us… : PS7, Line 365: 30MHz > I agree with this idea because the default value cannot be determined at the moment. […] Done File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82776/comment/3830f60e_27cc7d96?us… : PS11, Line 291: speed_index = 1; > Default speed_index also needs to be 2 (to index the entry 15M) […] Done File doc/classic_cli_manpage.rst: https://review.coreboot.org/c/flashrom/+/82776/comment/c49cc22b_2929cce4?us… : PS11, Line 1025: The default SPI speed is 30MHz if no value is specified. > Since we are returning back to 15M, you need to update here as well […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/82776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If2be48929db540a6598ac0b60b37e64597156db7 Gerrit-Change-Number: 82776 Gerrit-PatchSet: 13 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 20 Aug 2024 09:36:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: ZhiYuanNJ Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[S] Change in flashrom[main]: stlinkv3_spi: Mark STLinkV3-Mini not working
by Anastasia Klimchuk (Code Review) 20 Aug '24

20 Aug '24

Attention is currently required from: Miklós Márton. Anastasia Klimchuk has posted comments on this change by Miklós Márton. ( https://review.coreboot.org/c/flashrom/+/83921?usp=email ) Change subject: stlinkv3_spi: Mark STLinkV3-Mini not working ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic1ea4ca7acedca5d374cff8fcef450c18e55a9e8 Gerrit-Change-Number: 83921 Gerrit-PatchSet: 4 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Tue, 20 Aug 2024 09:36:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: stlinkv3_spi: Mark STLinkV3-Mini not working
by Miklós Márton (Code Review) 20 Aug '24

20 Aug '24

Attention is currently required from: Anastasia Klimchuk. Miklós Márton has posted comments on this change by Miklós Márton. ( https://review.coreboot.org/c/flashrom/+/83921?usp=email ) Change subject: stlinkv3_spi: Mark STLinkV3-Mini not working ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > Miklos, do you plan to merge this? I did review just in case :) Many thanks for the review, yes Iwould like to merge it. -- To view, visit https://review.coreboot.org/c/flashrom/+/83921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic1ea4ca7acedca5d374cff8fcef450c18e55a9e8 Gerrit-Change-Number: 83921 Gerrit-PatchSet: 4 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 20 Aug 2024 07:31:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: stlinkv3_spi: Mark STLinkV3-Mini not working
by Miklós Márton (Code Review) 20 Aug '24

20 Aug '24

Attention is currently required from: Anastasia Klimchuk. Miklós Márton has posted comments on this change by Miklós Márton. ( https://review.coreboot.org/c/flashrom/+/83921?usp=email ) Change subject: stlinkv3_spi: Mark STLinkV3-Mini not working ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/83921/comment/88acdb8d_de77c498?us… : PS1, Line 7: [stlinkv3_spi]Mark STLinkV3-Mini not working > We usually format commit title like this: […] Done File stlinkv3_spi.c: https://review.coreboot.org/c/flashrom/+/83921/comment/3ef16c68_89c870f1?us… : PS1, Line 504: goto init_err_exit; > You need to do `free(param_str);` before goto Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic1ea4ca7acedca5d374cff8fcef450c18e55a9e8 Gerrit-Change-Number: 83921 Gerrit-PatchSet: 1 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 20 Aug 2024 07:29:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: stlinkv3_spi: Mark STLinkV3-Mini not working
by Miklós Márton (Code Review) 20 Aug '24

20 Aug '24

Attention is currently required from: Miklós Márton. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83921?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: stlinkv3_spi: Mark STLinkV3-Mini not working ...................................................................... stlinkv3_spi: Mark STLinkV3-Mini not working The STLinkV3 Mini does not support the bridge API, it return LIBUSB_IO_ERROR when querying the bridge version. The official ST updater does not lists the bridge version in the info screen. Due to it's construction (additional connector on the bottom) it is likely that ST disabled the bridge functions on the castellated pads. Change-Id: Ic1ea4ca7acedca5d374cff8fcef450c18e55a9e8 Signed-off-by: Miklos Marton <martonmiklosqdev(a)gmail.com> --- M stlinkv3_spi.c 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/83921/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/83921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic1ea4ca7acedca5d374cff8fcef450c18e55a9e8 Gerrit-Change-Number: 83921 Gerrit-PatchSet: 3 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2024