August 2024 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: flashchips: add support for MX77U51250F chip
by Bora Guvendik (Code Review) 12 Aug '24

12 Aug '24

Attention is currently required from: Anastasia Klimchuk, Bora Guvendik, DZ, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, DZ, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/82626?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by DZ, Verified+1 by build bot (Jenkins) Change subject: flashchips: add support for MX77U51250F chip ...................................................................... flashchips: add support for MX77U51250F chip Add initial support for Macronix MX77U51250F. BUG=none BRANCH=none TEST= Tested read, write and probe on google/fatcat with internal programmer. Change-Id: I2c2e94f01dc63f60cf636bc6afe1f033e2a6f83c Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/26/82626/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/82626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2c2e94f01dc63f60cf636bc6afe1f033e2a6f83c Gerrit-Change-Number: 82626 Gerrit-PatchSet: 4 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[S] Change in flashrom[main]: flashchips: add support for MX77U51250F chip
by Subrata Banik (Code Review) 12 Aug '24

12 Aug '24

Attention is currently required from: Anastasia Klimchuk, Bora Guvendik, DZ, Nikolai Artemiev, Stefan Reinauer. Subrata Banik has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/flashrom/+/82626?usp=email ) Change subject: flashchips: add support for MX77U51250F chip ...................................................................... Patch Set 3: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/82626/comment/013a8bd7_8ddc13a5?us… : PS3, Line 11648: }, > Subrata, is it okay if we add this with a later patch? > > In the datasheet I have, I don't see a SRP bit and Status register bit 7 is marked reserved. However, by looking other Macronix parts, seems like srp maybe bit 7 and it seems to work. I would like to clarify this point do more testing before I claim WP works. > > .reg_bits = > { > .srp = {STATUS1, 7, RW}, > .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, > }, > > > --wp-range=0x00000000,0x04000000 --wp-enable -> > Enabled hardware protection > Activated protection range: start=0x00000000 length=0x04000000 (all) > SUCCESS > > > --wp-list -> > Available protection ranges: > start=0x00000000 length=0x00000000 (none) > start=0x03ff0000 length=0x00010000 (upper 1/1024) > start=0x03fe0000 length=0x00020000 (upper 1/512) > start=0x03fc0000 length=0x00040000 (upper 1/256) > start=0x03f80000 length=0x00080000 (upper 1/128) > start=0x03f00000 length=0x00100000 (upper 1/64) > start=0x03e00000 length=0x00200000 (upper 1/32) > start=0x03c00000 length=0x00400000 (upper 1/16) > start=0x03800000 length=0x00800000 (upper 1/8) > start=0x03000000 length=0x01000000 (upper 1/4) > start=0x02000000 length=0x02000000 (upper 1/2) > start=0x00000000 length=0x04000000 (all) sounds good. -- To view, visit https://review.coreboot.org/c/flashrom/+/82626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2c2e94f01dc63f60cf636bc6afe1f033e2a6f83c Gerrit-Change-Number: 82626 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 12 Aug 2024 14:01:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bora Guvendik <bora.guvendik(a)intel.com> Comment-In-Reply-To: DZ <danielzhang(a)mxic.com.cn> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: add GD25LB512ME
by Anastasia Klimchuk (Code Review) 12 Aug '24

12 Aug '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim. Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83795?usp=email ) Change subject: flashchips: add GD25LB512ME ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I04103814f901478098c1a989f4239792b64073ec Gerrit-Change-Number: 83795 Gerrit-PatchSet: 3 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 12 Aug 2024 12:19:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: doc: Add doc describing release process
by Anastasia Klimchuk (Code Review) 12 Aug '24

12 Aug '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83762?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: doc: Add doc describing release process ...................................................................... doc: Add doc describing release process Change-Id: Id6aacf5ef3879a5e236759e7a4a6af3cf7cc0a00 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83762 Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/dev_guide/index.rst A doc/dev_guide/release_process.rst M doc/how_to_support_flashrom.rst 3 files changed, 103 insertions(+), 0 deletions(-) Approvals: Peter Marheine: Looks good to me, approved build bot (Jenkins): Verified diff --git a/doc/dev_guide/index.rst b/doc/dev_guide/index.rst index 457938f..dcd7bd2 100644 --- a/doc/dev_guide/index.rst +++ b/doc/dev_guide/index.rst @@ -6,3 +6,4 @@ building_from_source development_guide + release_process diff --git a/doc/dev_guide/release_process.rst b/doc/dev_guide/release_process.rst new file mode 100644 index 0000000..749779e --- /dev/null +++ b/doc/dev_guide/release_process.rst @@ -0,0 +1,100 @@ +=============== +Release process +=============== + +The document describes the technical aspect of making a flashrom release, +and it assumes that the team of active core maintainers is in agreement to commence the process. + +To go through the process, at least two maintainers are needed to be closely involved, +because it includes sending and approving patches in Gerrit. + +Set up the timeline and announce on the mailing list +==================================================== + +Decide on the bug-fixing and testing window (3-4 weeks), decide exact dates of start and end of the window, +and announce it on the mailing list. Ideally make an announcement a few weeks in advance. + +During the testing and bug-fixing window only bug fixes are merged, and no new features are added. +Typically it's fine to push new features for review, and reviews are fine too, +but merging new features will be delayed until the release is done. +*This should be very clearly explained in the announcement.* + +Start testing and bug-fixing window +=================================== + +* Double-check and merge all the patches that are fully ready (see also :ref:`merge-checklist`) + +* Update VERSION file to first release candidate. Check the git history of VERSION file for a version name pattern. + + * As an example at the time of writing, the version name of the first release candidate was ``1.4.0-rc1``. + * To update the VERSION file, push a patch to Gerrit, and another maintainer should review and approve. + +* After submitting the change to the VERSION file, tag this commit. + You can check `flashrom tags in Gerrit <https://review.coreboot.org/admin/repos/flashrom,tags,25>`_ + for tag name pattern. As an example at the time of writing, the tag name was ``v1.4.0-rc1``. + +* Write an announcement on the mailing list. Be very clear about: + + * start and end date of the window, and what does it mean + * any help with :ref:`building-and-testing` is very much appreciated + +**From this moment and until the release cut, the highest priority is for building and testing on various environments, and bug-fixing.** + +Release candidates +================== + +If any bugs are found and fixed (or reverted), then the second, or third release candidate will be needed. +The process is the same as with the first candidate: + +* Update the VERSION file, and submit this +* Tag the commit which updates the VERSION file +* Post an announcement on mailing list + +Release notes +============= + +During the time in-between releases, ideally most updates are accumulated in the doc :doc:`/release_notes/devel`. +While this doc is helpful, it is not a replacement for a human to go through all development history +since the previous release and prepare release notes. One maintainer is preparing the release notes +and sending them for review, and at least one other maintainer needs to review that (it can be more than one reviewer). + +Ideally the patch with release notes should be prepared, reviewed and approved before the release cut, +so that it can be published by the time of final release announcement. + +For inspiration to write release notes, have a look at prior art :doc:`/release_notes/index`. + +There is one section in release notes, Download, which is not possible to complete before the actual release cut. +Leave it as TODO, but complete the rest. + +Cut the release +=============== + +Wait for at least a week (or two) since the last release candidate. if everything is alright: + +* Submit the release notes, and in the same patch restart :doc:`/release_notes/devel` document. + This way everyone who is syncing the repository by the release tag will have release notes in the tree. + +* Update VERSION file to release version (for example, at the time of writing ``1.4.0``), and submit this + +* Tag the commit which updates the VERSION file. You can check + `flashrom tags in Gerrit <https://review.coreboot.org/admin/repos/flashrom,tags,25>`_ for tag name pattern. + As an example at the time of writing, the tag name was ``v1.4.0``. + +* Create the tarball, sign it, and upload to the server together with the signature. + +* Update release notes with the link to download tarball, signature, and fingerprint. Submit this and check that final release notes are published on the website. + +* Write the release announcement, don't forget to: + + * Link to download the tarball, signature and fingerprint. + * Say thank you to everyone who is helping and supporting flashrom + * Add link to published release notes on the website + +Start the next cycle of development +=================================== + +* Update the VERSION file to the development version. For example, at the time of writing ``1.5.0-devel``, and submit this. + +* Submit all the patches that have been ready and waiting. + +* Celebrate :) diff --git a/doc/how_to_support_flashrom.rst b/doc/how_to_support_flashrom.rst index 372ef38..7fdfdf8 100644 --- a/doc/how_to_support_flashrom.rst +++ b/doc/how_to_support_flashrom.rst @@ -63,6 +63,8 @@ You can check pending patches under review `in Gerrit <https://review.coreboot.org/q/status:open+project:flashrom>`_ and help with code review if a patch looks useful, you understand what it is about, and want to have it submitted. +.. _building-and-testing: + Building and testing ==================== -- To view, visit https://review.coreboot.org/c/flashrom/+/83762?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id6aacf5ef3879a5e236759e7a4a6af3cf7cc0a00 Gerrit-Change-Number: 83762 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in flashrom[main]: doc: Add doc describing release process
by Anastasia Klimchuk (Code Review) 12 Aug '24

12 Aug '24

Attention is currently required from: Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83762?usp=email ) Change subject: doc: Add doc describing release process ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Jenkins didn't post a message, but build successful: https://qa.coreboot.org/job/flashrom_gerrit/11804/ -- To view, visit https://review.coreboot.org/c/flashrom/+/83762?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id6aacf5ef3879a5e236759e7a4a6af3cf7cc0a00 Gerrit-Change-Number: 83762 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Aug 2024 12:16:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Michał Żygowski (Code Review) 12 Aug '24

12 Aug '24

Attention is currently required from: Maciej Pijanowski, Michał Kopeć. Michał Żygowski has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... Patch Set 3: (1 comment) File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/83854/comment/0cc1c03e_b4633b6d?us… : PS3, Line 2193: {0x8086, 0x7a8a, B_S, NT, "Intel", "W685", enable_flash_pch600}, > Same ID in line 2206, presumably W685 was cancelled and the ID was later reused for W790 Exactly, this ID appeared in later Intel documents as W790 -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 3 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Mon, 12 Aug 2024 11:56:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com>

1 0

[XS] Change in flashrom[main]: flashchips: add GD25LB512ME
by Victor Lim (Code Review) 12 Aug '24

12 Aug '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83795?usp=email ) Change subject: flashchips: add GD25LB512ME ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: done Commit Message: https://review.coreboot.org/c/flashrom/+/83795/comment/1a846593_cb43f03f?us… : PS2, Line 18: Victor > I noticed, it's just your name here, we usually have FirstName and LastName […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I04103814f901478098c1a989f4239792b64073ec Gerrit-Change-Number: 83795 Gerrit-PatchSet: 3 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 12 Aug 2024 05:09:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: add GD25LB512ME
by Victor Lim (Code Review) 12 Aug '24

12 Aug '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83795?usp=email to look at the new patch set (#3). Change subject: flashchips: add GD25LB512ME ...................................................................... flashchips: add GD25LB512ME Added GD25LB512ME to Flashchips.C added Sames as GD25LB512ME to GIGADEVICE_GD25LR512ME to flashchips.h GD25LB512ME is 1.8V 512Mbit, Quad enabled when shipped. https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20230627/DS-0… Tested on ch347 with erase, program, read, and protection. Change-Id: I04103814f901478098c1a989f4239792b64073ec Signed-off-by: Victor Lim <vlim(a)gigadevice.com> --- M flashchips.c M include/flashchips.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/83795/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/83795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I04103814f901478098c1a989f4239792b64073ec Gerrit-Change-Number: 83795 Gerrit-PatchSet: 3 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[M] Change in flashrom[main]: doc: Add doc describing release process
by Anastasia Klimchuk (Code Review) 12 Aug '24

12 Aug '24

Attention is currently required from: Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83762?usp=email ) Change subject: doc: Add doc describing release process ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Ready for review, but will need to wait for CB:83673 to be submitted. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83762?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id6aacf5ef3879a5e236759e7a4a6af3cf7cc0a00 Gerrit-Change-Number: 83762 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Aug 2024 04:49:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: add GD25LB512ME
by Anastasia Klimchuk (Code Review) 12 Aug '24

12 Aug '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim. Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83795?usp=email ) Change subject: flashchips: add GD25LB512ME ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/83795/comment/4a96e338_df393163?us… : PS2, Line 18: Victor I noticed, it's just your name here, we usually have FirstName and LastName You had it before, first and last name (see here CB:83140), perhaps and some point you changed you local git config and last name was lost? You can for this patch just add last name manually, but then for future have a look at local git config, make sure you have "Victor Lim", so that you don't have to fix it manually every time. -- To view, visit https://review.coreboot.org/c/flashrom/+/83795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I04103814f901478098c1a989f4239792b64073ec Gerrit-Change-Number: 83795 Gerrit-PatchSet: 2 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 12 Aug 2024 04:39:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2024