Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83234?usp=email )
Change subject: flashchips: Add Support for XMC XM25QU16C
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> But this is one is not done :) I marked the comment unresolved on purpose. […]
Ok, I know,thanks
--
To view, visit https://review.coreboot.org/c/flashrom/+/83234?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0989b5dd239dd32f93e1a338a70e5d7279127d8d
Gerrit-Change-Number: 83234
Gerrit-PatchSet: 1
Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Thu, 04 Jul 2024 01:15:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Comment-In-Reply-To: Ssunk <ssunkkan(a)gmail.com>
Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim.
Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83254?usp=email )
Change subject: flashchips: Add chip models GD25LB256F/GD25LR256F
......................................................................
Patch Set 1:
(2 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83254/comment/dc3ec86d_65feeb85?us… :
PS1, Line 6963: OTP: 1024B total, 256B reserved
Maybe you will help me, how do I find this info in datasheet? I found the commands, but not the size. Maybe you can point me to the section in the doc. Thank you!
https://review.coreboot.org/c/flashrom/+/83254/comment/da150636_86570ac5?us… :
PS1, Line 7006: BP4
We usually add the full comment, as you can see in other chips
> Called BP4 in datasheet, acts like TB
--
To view, visit https://review.coreboot.org/c/flashrom/+/83254?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0fbd270a57999d4131816c48470588bb7ec22d37
Gerrit-Change-Number: 83254
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 13:03:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83235?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: flashchips: Add Support for XMC XM25QH32C/XM25QH32D
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Got it, thanks!
I will mark this unresolved, this is a comment so that no one accidentally submits before the tag.
--
To view, visit https://review.coreboot.org/c/flashrom/+/83235?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ib201ac28384b8db6539e2a82e6f90462d1393208
Gerrit-Change-Number: 83235
Gerrit-PatchSet: 1
Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 11:47:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ssunk <ssunkkan(a)gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83234?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: flashchips: Add Support for XMC XM25QU16C
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Done
But this is one is not done :) I marked the comment unresolved on purpose.
It will be done when we put a tag v1.4.0 and this is estimated on 26 July.
--
To view, visit https://review.coreboot.org/c/flashrom/+/83234?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0989b5dd239dd32f93e1a338a70e5d7279127d8d
Gerrit-Change-Number: 83234
Gerrit-PatchSet: 1
Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 11:46:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ssunk <ssunkkan(a)gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Attention is currently required from: Nikolai Artemiev, Stefan Reinauer.
Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83235?usp=email )
Change subject: flashchips: Add Support for XMC XM25QH32C/XM25QH32D
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […]
Got it, thanks!
--
To view, visit https://review.coreboot.org/c/flashrom/+/83235?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ib201ac28384b8db6539e2a82e6f90462d1393208
Gerrit-Change-Number: 83235
Gerrit-PatchSet: 1
Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 11:28:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Attention is currently required from: Nikolai Artemiev, Stefan Reinauer.
Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83234?usp=email )
Change subject: flashchips: Add Support for XMC XM25QU16C
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […]
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/83234?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0989b5dd239dd32f93e1a338a70e5d7279127d8d
Gerrit-Change-Number: 83234
Gerrit-PatchSet: 1
Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 11:27:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83236?usp=email )
Change subject: flashchips: Add Support for XMC XM25QU32C
......................................................................
Patch Set 2:
(1 comment)
File include/flashchips.h:
https://review.coreboot.org/c/flashrom/+/83236/comment/0bace367_c49ea88e?us… :
PS1, Line 853: XMC_XM25QU32C
> Let's put it after QH (like the other entries, QH and then QU) […]
Got it,
--
To view, visit https://review.coreboot.org/c/flashrom/+/83236?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a
Gerrit-Change-Number: 83236
Gerrit-PatchSet: 2
Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 11:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/83236?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: flashchips: Add Support for XMC XM25QU32C
......................................................................
flashchips: Add Support for XMC XM25QU32C
Add initial support for the SPI flash chip XM25QU32C
Datasheet link: https://www.xmcwh.com/uploads/233/XM25QU32C_Ver2.1.pdf
Tested with ch341a programmer: probe, read, write, erase
Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a
Signed-off-by: Kan Sun <ssunkkan(a)gmail.com>
---
M flashchips.c
M include/flashchips.h
2 files changed, 39 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/83236/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/83236?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a
Gerrit-Change-Number: 83236
Gerrit-PatchSet: 2
Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83236?usp=email )
Change subject: flashchips: Add Support for XMC XM25QU32C
......................................................................
Patch Set 1:
(1 comment)
File include/flashchips.h:
https://review.coreboot.org/c/flashrom/+/83236/comment/18b14b4f_6dc8f180?us… :
PS1, Line 853: XMC_XM25QU32C
Let's put it after QH (like the other entries, QH and then QU)
So basically, just swap lines 853 and 854
--
To view, visit https://review.coreboot.org/c/flashrom/+/83236?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a
Gerrit-Change-Number: 83236
Gerrit-PatchSet: 1
Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 06:22:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83235?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: flashchips: Add Support for XMC XM25QH32C/XM25QH32D
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July.
https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/UUDQ…
--
To view, visit https://review.coreboot.org/c/flashrom/+/83235?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ib201ac28384b8db6539e2a82e6f90462d1393208
Gerrit-Change-Number: 83235
Gerrit-PatchSet: 1
Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 06:06:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No