July 2024 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: flashchips: add support for chip model Winbond W25Q32JV_M
by Anastasia Klimchuk (Code Review) 30 Jul '24

30 Jul '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83586?usp=email ) Change subject: flashchips: add support for chip model Winbond W25Q32JV_M ...................................................................... flashchips: add support for chip model Winbond W25Q32JV_M This is a 4 MiB model with QE=0 factory setting. Tested with ch341a programmer: probe, read, write, erase Link to datasheet: https://www.winbond.com/resource-files/W25Q32JV%20RevI%2005042021%20Plus.pdf Change-Id: I374c466848eabf5647dc88e016ac32b99ec37a06 Signed-off-by: Michael Heimpold <mhei(a)heimpold.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/83586 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 53 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 46b87e3..01cf641 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19992,6 +19992,58 @@ { .vendor = "Winbond", + .name = "W25Q32JV_M", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q32JV_M, + .total_size = 4096, + .page_size = 256, + /* supports SFDP */ + /* OTP: 3x 256B total; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI | + FEATURE_WRSR2 | FEATURE_WRSR3, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 128} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_SRWD_SEC_TB_BP2_WELWIP, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .sec = {STATUS1, 6, RW}, + .tb = {STATUS1, 5, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}}, + .cmp = {STATUS2, 6, RW}, + .srl = {STATUS2, 0, RW}, + .wps = {STATUS3, 2, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, + }, + + { + .vendor = "Winbond", .name = "W25Q32JV", .bustype = BUS_SPI, .manufacture_id = WINBOND_NEX_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 22509c4..c4b13d9 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -1017,6 +1017,7 @@ #define WINBOND_NEX_W25Q128_W 0x6018 /* W25Q128FW; W25Q128FV in QPI mode */ #define WINBOND_NEX_W25Q256_W 0x6019 /* W25Q256JW */ #define WINBOND_NEX_W25Q16JV_M 0x7015 /* W25Q16JV_M (QE=0) */ +#define WINBOND_NEX_W25Q32JV_M 0x7016 /* W25Q32JV_M (QE=0) */ #define WINBOND_NEX_W25Q64JV 0x7017 /* W25Q64JV */ #define WINBOND_NEX_W25Q128_V_M 0x7018 /* W25Q128JVSM */ #define WINBOND_NEX_W25Q256JV_M 0x7019 /* W25Q256JV_M (QE=0) */ -- To view, visit https://review.coreboot.org/c/flashrom/+/83586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I374c466848eabf5647dc88e016ac32b99ec37a06 Gerrit-Change-Number: 83586 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Heimpold <mhei(a)heimpold.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: MAINTAINERS: Add David Reguera for Bus Pirate
by Anastasia Klimchuk (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: David Reguera Garcia. Anastasia Klimchuk has posted comments on this change by David Reguera Garcia. ( https://review.coreboot.org/c/flashrom/+/83681?usp=email ) Change subject: MAINTAINERS: Add David Reguera for Bus Pirate ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0e298732a1464152c0d4cdc728bcdfd1b40ce770 Gerrit-Change-Number: 83681 Gerrit-PatchSet: 2 Gerrit-Owner: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 09:43:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: MAINTAINERS: Add David Reguera for Bus Pirate
by David Reguera Garcia (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Anastasia Klimchuk. David Reguera Garcia has removed a vote from this change. ( https://review.coreboot.org/c/flashrom/+/83681?usp=email ) Change subject: MAINTAINERS: Add David Reguera for Bus Pirate ...................................................................... Removed Code-Review+1 by David Reguera Garcia <regueragarciadavid(a)gmail.com> -- To view, visit https://review.coreboot.org/c/flashrom/+/83681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0e298732a1464152c0d4cdc728bcdfd1b40ce770 Gerrit-Change-Number: 83681 Gerrit-PatchSet: 2 Gerrit-Owner: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: MAINTAINERS: Add David Reguera for Bus Pirate
by David Reguera Garcia (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Anastasia Klimchuk. David Reguera Garcia has posted comments on this change by David Reguera Garcia. ( https://review.coreboot.org/c/flashrom/+/83681?usp=email ) Change subject: MAINTAINERS: Add David Reguera for Bus Pirate ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/83681/comment/963a0579_ef348ac1?us… : PS1, Line 7: Add David Reguera as the Bus Pirate maintainer > We follow the pattern for commit titles in this file, if you could change it slightly, like this: […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0e298732a1464152c0d4cdc728bcdfd1b40ce770 Gerrit-Change-Number: 83681 Gerrit-PatchSet: 2 Gerrit-Owner: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Jul 2024 07:49:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: MAINTAINERS: Add David Reguera for Bus Pirate
by David Reguera Garcia (Code Review) 30 Jul '24

30 Jul '24

David Reguera Garcia has posted comments on this change by David Reguera Garcia. ( https://review.coreboot.org/c/flashrom/+/83681?usp=email ) Change subject: MAINTAINERS: Add David Reguera for Bus Pirate ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Done! -- To view, visit https://review.coreboot.org/c/flashrom/+/83681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0e298732a1464152c0d4cdc728bcdfd1b40ce770 Gerrit-Change-Number: 83681 Gerrit-PatchSet: 2 Gerrit-Owner: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 30 Jul 2024 07:48:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: MAINTAINERS: Add David Reguera for Bus Pirate
by David Reguera Garcia (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: David Reguera Garcia. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83681?usp=email to look at the new patch set (#2). Change subject: MAINTAINERS: Add David Reguera for Bus Pirate ...................................................................... MAINTAINERS: Add David Reguera for Bus Pirate Change-Id: I0e298732a1464152c0d4cdc728bcdfd1b40ce770 Signed-off-by: David Reguera Garcia <regueragarciadavid(a)gmail.com> --- M MAINTAINERS 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/83681/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0e298732a1464152c0d4cdc728bcdfd1b40ce770 Gerrit-Change-Number: 83681 Gerrit-PatchSet: 2 Gerrit-Owner: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Reguera Garcia <regueragarciadavid(a)gmail.com>

1 0

[XS] Change in flashrom[main]: Add David Reguera as the Bus Pirate maintainer
by Anastasia Klimchuk (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: David Reguera Garcia. Anastasia Klimchuk has posted comments on this change by David Reguera Garcia. ( https://review.coreboot.org/c/flashrom/+/83681?usp=email ) Change subject: Add David Reguera as the Bus Pirate maintainer ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Thank you! I have only one comment about commit title. I also wanted to say, for your own patches you don't need to vote on them, because every patch needs to be reviewed by someone else who is not the author. Commit Message: https://review.coreboot.org/c/flashrom/+/83681/comment/cea44cae_5e1be913?us… : PS1, Line 7: Add David Reguera as the Bus Pirate maintainer We follow the pattern for commit titles in this file, if you could change it slightly, like this: > MAINTAINERS: Add David Reguera for Bus Pirate -- To view, visit https://review.coreboot.org/c/flashrom/+/83681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0e298732a1464152c0d4cdc728bcdfd1b40ce770 Gerrit-Change-Number: 83681 Gerrit-PatchSet: 1 Gerrit-Owner: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Reguera Garcia <regueragarciadavid(a)gmail.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 06:50:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in flashrom[main]: Remove the Makefile
by Anastasia Klimchuk (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Peter Marheine. Anastasia Klimchuk has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/83673?usp=email ) Change subject: Remove the Makefile ...................................................................... Patch Set 3: Code-Review+1 (3 comments) Patchset: PS2: > I found those too, and decided they didn't need to be changed. […] Alright, I understand. manibuilder is standalone, is not the part of "building from source" process and is not much documented. Probably could be taken of at some point, but not in this patch. Patchset: PS3: I am thinking, maybe you can do an informational post on the mailing list with the link to the patch? It's not an ordinary patch, it's a result of a lot of work, multi-year effort! How cool is this :) I know it was on release notes, but now it's actually happening! The main pieces of information in the post would be: link to patch and saying "we plan to submit in around 2 weeks, if all goes well". Maybe someone would want to download and run locally, I will for example. Makefile has been around for 20 years, or more even, let's give it last two weeks of goodbye! File README.rst: https://review.coreboot.org/c/flashrom/+/83673/comment/ced09e60_2d3f36f7?us… : PS3, Line 28: TLDR, building with meson : """"""""""""""""""""""""" : : :: I think this is not needed as another nested header (since the other nested header gone now), and probably no need to repeat meson again. So maybe it can be TLDR:: and then the commands? -- To view, visit https://review.coreboot.org/c/flashrom/+/83673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib3cf22cf636ef9b70527b734ffa34aead2a74edd Gerrit-Change-Number: 83673 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Jul 2024 06:35:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XL] Change in flashrom[main]: Remove the Makefile
by Peter Marheine (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83673?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Remove the Makefile ...................................................................... Remove the Makefile As was described in the version 1.4 release notes, this deletes the Makefile and supporting elements leaving Meson as the only supported buildsystem. Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> Change-Id: Ib3cf22cf636ef9b70527b734ffa34aead2a74edd --- M .gitignore M MAINTAINERS D Makefile D Makefile.d/arch_test.h D Makefile.d/cc_test.c D Makefile.d/clock_gettime_test.c D Makefile.d/endian_test.h D Makefile.d/ft232h_test.c D Makefile.d/getopt_test.c D Makefile.d/linux_i2c_test.c D Makefile.d/linux_mtd_test.c D Makefile.d/linux_spi_test.c D Makefile.d/os_test.h D Makefile.d/pciutils_test.c D Makefile.d/utsname_test.c D Makefile.include M README.rst D doc/dev_guide/building_with_make.rst M doc/dev_guide/index.rst A doc/release_notes/devel.rst M doc/release_notes/index.rst M test_build.sh D util/ich_descriptors_tool/Makefile 23 files changed, 27 insertions(+), 1,817 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/83673/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/83673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib3cf22cf636ef9b70527b734ffa34aead2a74edd Gerrit-Change-Number: 83673 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XL] Change in flashrom[main]: Remove the Makefile
by Peter Marheine (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Anastasia Klimchuk. Peter Marheine has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/83673?usp=email ) Change subject: Remove the Makefile ...................................................................... Patch Set 2: (4 comments) Patchset: PS2: > I tried git grep -n 'Makefile' and found some stuff which is not covered in this patch: […] I found those too, and decided they didn't need to be changed. All of the "Makefile" references in `Doxyfile` refer to a Makefile that doxygen can emit, and manibuilder is self-contained (it just happens to use make as a way to specify a lot of similar tasks). manibuilder is partially broken because it tries to use obsolete versions of some distributions (at least of Debian), but at least some of its targets (I tried Fedora 25) still work after applying this patch. File doc/dev_guide/building_with_make.rst: PS2: > Should this be removed from index file of dev_guide directory? I would expect sphinx to complain whe […] It does generate a warning if you refer to a missing file. Removed. File doc/release_notes/v_1_5-devel.rst: https://review.coreboot.org/c/flashrom/+/83673/comment/9f246ab3_def78637?us… : PS2, Line 2: v1.5-devel > I was thinking to have a generic name to this file, for example next_release. […] That makes sense. Renamed and removed references to version 1.5, and I copied the known issue with AMD chipsets since it remains a known issue until it's fixed. https://review.coreboot.org/c/flashrom/+/83673/comment/e7b9afd0_099ddb3d?us… : PS2, Line 4: : This document describes the major changes to flashrom since the release : of version 1.4. These changes will be included in the future v1.5 release. > In the same spirit, I would make the intro generic, so that we need to compose it once and it stays […] Done. -- To view, visit https://review.coreboot.org/c/flashrom/+/83673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib3cf22cf636ef9b70527b734ffa34aead2a74edd Gerrit-Change-Number: 83673 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Jul 2024 05:14:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2024