May 2024 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: flashchips: Add (or update) chip models
by Victor Lim (Code Review) 05 May '24

05 May '24

Victor Lim has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/82190?usp=email ) Change subject: flashchips: Add (or update) chip models ...................................................................... flashchips: Add (or update) chip models These are the model added to flashchips.h The link to the datasheet is also included in the list below. https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20240412/DS-0… https://www.gigadevice.com/message-board?cid=39&id=3018&file_type=Datasheet… https://www.gigadevice.com/message-board?cid=39&id=3001&file_type=Datasheet… https://www.gigadevice.com/message-board?cid=39&id=2985&file_type=Datasheet… https://www.gigadevice.com/message-board?cid=39&id=3871&file_type=Datasheet… https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20230321/DS-0… https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20231213/DS-0… https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20230627/DS-0… https://www.gigadevice.com/message-board?cid=39&id=3876&file_type=Datasheet… https://www.gigadevice.com/message-board?cid=39&id=3874&file_type=Datasheet… https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20230627/DS-0… https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20230627/DS-0… Change-Id: I60b3d3b1cf8890c5d6fb13d76a2fe800b1ffaffc Signed-off-by: Victor Lim <vlim(a)gigadevice.com> --- M include/flashchips.h 1 file changed, 16 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/82190/1 diff --git a/include/flashchips.h b/include/flashchips.h index 6008ad1..c8fcbe3 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -390,20 +390,32 @@ #define GIGADEVICE_GD25Q16 0x4015 /* Same as GD25Q16B (which has OTP) */ #define GIGADEVICE_GD25Q32 0x4016 /* Same as GD25Q32B */ #define GIGADEVICE_GD25Q64 0x4017 /* Same as GD25Q64B */ -#define GIGADEVICE_GD25Q128 0x4018 /* Same as GD25Q128B, GD25Q127C, GD25Q128C, and GD25Q128E, can be distinguished by SFDP */ -#define GIGADEVICE_GD25Q256D 0x4019 +#define GIGADEVICE_GD25Q128 0x4018 /* Same as GD25Q128B, GD25Q127C, GD25Q128C, GD25Q128E, GD25B128E, GD25R128E, can be distinguished by SFDP */ +#define GIGADEVICE_GD25Q256D 0x4019 /* Same as GD25Q256E GD25B256E GD25R256E */ +#define GIGADEVICE_GD25B512MF 0x401A /* Same as GD25R512MF */ #define GIGADEVICE_GD25VQ21B 0x4212 #define GIGADEVICE_GD25VQ41B 0x4213 /* Same as GD25VQ40C, can be distinguished by SFDP */ #define GIGADEVICE_GD25VQ80C 0x4214 #define GIGADEVICE_GD25VQ16C 0x4215 +#define GIGADEVICE_GD25F64F 0x4317 +#define GIGADEVICE_GD25F128F 0x4318 +#define GIGADEVICE_GD25F256F 0x4319 +#define GIGADEVICE_GD25F512MF 0x431A +#define GIGADEVICE_GD25B512ME 0x471A #define GIGADEVICE_GD25LQ40 0x6013 #define GIGADEVICE_GD25LQ80 0x6014 #define GIGADEVICE_GD25LQ16 0x6015 #define GIGADEVICE_GD25LQ32 0x6016 #define GIGADEVICE_GD25LQ64 0x6017 /* Same as GD25LQ64B (which is faster) */ -#define GIGADEVICE_GD25LQ128CD 0x6018 -#define GIGADEVICE_GD25LQ255E 0x6019 +#define GIGADEVICE_GD25LQ128CD 0x6018 /* Same as GD25LQ128E GD25LB128E GD25LR128E GD25LQ128D GD25LQ128C */ +#define GIGADEVICE_GD25LQ255E 0x6019 /* same as GD25LB256F GD25LQ256H GD25LR256F */ +#define GIGADEVICE_GD25LB512MF 0x601A /* Same as GD25LR512MF */ +#define GIGADEVICE_GD25LF128E 0x6318 +#define GIGADEVICE_GD25LF256F 0x6319 +#define GIGADEVICE_GD25LF512MF 0x631A #define GIGADEVICE_GD25WQ80E 0x6514 +#define GIGADEVICE_GD25LB256E 0x6719 +#define GIGADEVICE_GD25LB512ME 0x671A #define GIGADEVICE_GD29GL064CAB 0x7E0601 #define HYUNDAI_ID 0xAD /* Hyundai */ -- To view, visit https://review.coreboot.org/c/flashrom/+/82190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I60b3d3b1cf8890c5d6fb13d76a2fe800b1ffaffc Gerrit-Change-Number: 82190 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <victorswlim(a)yahoo.com> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[main]: flashrom: Change chip unlock error to warning
by Anastasia Klimchuk (Code Review) 03 May '24

03 May '24

Attention is currently required from: Brian Norris, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82175?usp=email ) Change subject: flashrom: Change chip unlock error to warning ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/82175/comment/2fffd5c8_e5f53c72 : PS1, Line 10: and flashrom doesn't treat it as such Just wanted to check: does flashrom never treat it as an error, or does it depend on flags? -- To view, visit https://review.coreboot.org/c/flashrom/+/82175?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I14c3b55e387443909ca1efab2fc1901f87dd66d6 Gerrit-Change-Number: 82175 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 03 May 2024 09:58:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: doc: Add user doc with links to ChromeOS documents
by Anastasia Klimchuk (Code Review) 03 May '24

03 May '24

Attention is currently required from: Hsuan-ting Chen, Stefan Reinauer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82181?usp=email ) Change subject: doc: Add user doc with links to ChromeOS documents ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hsuan-ting, apart from reviewing this patch, I wanted to ask maybe you would agree to maintain this document? You don't need to write any text, however maintain the list of useful links. And if you discover a document is moved to a different location, update the link. The target audience is: people who use flashrom on ChromeOS, but *do not work in ChromeOS*. Which means all links should be publicly available without any accounts, also links need to be relevant to flashrom usage. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/82181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If7b06c077b34f73bc6c33f617332dfc32b982c12 Gerrit-Change-Number: 82181 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 03 May 2024 09:47:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: doc: Add user doc with links to ChromeOS documents
by Anastasia Klimchuk (Code Review) 03 May '24

03 May '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/82181?usp=email ) Change subject: doc: Add user doc with links to ChromeOS documents ...................................................................... doc: Add user doc with links to ChromeOS documents Change-Id: If7b06c077b34f73bc6c33f617332dfc32b982c12 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- A doc/user_docs/chromebooks.rst M doc/user_docs/index.rst 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/82181/1 diff --git a/doc/user_docs/chromebooks.rst b/doc/user_docs/chromebooks.rst new file mode 100644 index 0000000..feb333b --- /dev/null +++ b/doc/user_docs/chromebooks.rst @@ -0,0 +1,8 @@ +============================= +Documentation for Chromebooks +============================= + +Below is the list of documents and pages that can be useful if you use flashrom on ChromeOS. +Note these documents are external to flashrom and maintained outside of upstream flashrom tree. + +* `Write protection <https://www.chromium.org/chromium-os/developer-library/reference/security/w…>`_ diff --git a/doc/user_docs/index.rst b/doc/user_docs/index.rst index b4cca34..5bc93d1 100644 --- a/doc/user_docs/index.rst +++ b/doc/user_docs/index.rst @@ -6,3 +6,4 @@ fw_updates_vs_spi_wp example_partial_wp + chromebooks -- To view, visit https://review.coreboot.org/c/flashrom/+/82181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If7b06c077b34f73bc6c33f617332dfc32b982c12 Gerrit-Change-Number: 82181 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[main]: flashrom_tester: Correct "WP screw" message
by Hsuan-ting Chen (Code Review) 03 May '24

03 May '24

Attention is currently required from: Angel Pons, Brian Norris, Thomas Heijligen. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82083?usp=email ) Change subject: flashrom_tester: Correct "WP screw" message ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: > How about this patch goes ahead and then later we can update the message? Sure -- To view, visit https://review.coreboot.org/c/flashrom/+/82083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270 Gerrit-Change-Number: 82083 Gerrit-PatchSet: 5 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 03 May 2024 09:26:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: flashrom_tester: Correct "WP screw" message
by Anastasia Klimchuk (Code Review) 03 May '24

03 May '24

Attention is currently required from: Angel Pons, Brian Norris, Hsuan-ting Chen, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82083?usp=email ) Change subject: flashrom_tester: Correct "WP screw" message ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > 1. […] 1. Good, let's agree on `open/close` then 2. I think I see your point now. There is a "software way" to enable/disable WP, which is preferred way however not mentioned in the that error message at all. I think this is a valid point, but adding "use the designated command" does not solve the situation. Because only the people who already know what to do can understand it. And those who don't know, what is "designated"? We can do some more thinking how to do this message right. How about this patch goes ahead and then later we can update the message? 3. flashrom_tester only runs on ChromeOS. It checks the system in the beginning, and if it's not ChromeOS it prints a message and exits. Me and Evan did initial research on that, we had the goal to expand flashrom_tester to run on more OSes. But then the time suddenly was over, and we are no longer on that team. From my memory, the obvious non-portable points were calls to `crossystem` command which only exists on ChromeOS, but there can be more things. TLDR maybe this patch can go ahead with open/close, and then message can be upgraded in the next patch? if you agree, you can mark the comment as resolved! -- To view, visit https://review.coreboot.org/c/flashrom/+/82083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270 Gerrit-Change-Number: 82083 Gerrit-PatchSet: 5 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 03 May 2024 09:05:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: Make sleep threshold for delays configurable
by Anastasia Klimchuk (Code Review) 03 May '24

03 May '24

Attention is currently required from: Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81606?usp=email ) Change subject: Make sleep threshold for delays configurable ...................................................................... Patch Set 4: (2 comments) File tests/udelay.c: https://review.coreboot.org/c/flashrom/+/81606/comment/fa51b879_bd7bdbb4 : PS2, Line 52: if (delay_us >= CONFIG_DELAY_MINIMUM_SLEEP_US) > The test always takes at least as long to run as the chosen delay time, so 0. […] I am now re-reading and don't understand myself what I was asking :D File udelay_dos.c: https://review.coreboot.org/c/flashrom/+/81606/comment/6bf73c6e_85bac27b : PS4, Line 161: CONFIG_DELAY_MINIMUM_SLEEP_US probably also needs the same `static const` trick? -- To view, visit https://review.coreboot.org/c/flashrom/+/81606?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ida96e0816ac914ed69d6fd82ad90ebe89cdef1cc Gerrit-Change-Number: 81606 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 03 May 2024 08:10:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: flashchips.c: Add support for XM25RU256C
by Anastasia Klimchuk (Code Review) 03 May '24

03 May '24

Attention is currently required from: Georg Gottleuber, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82101?usp=email ) Change subject: flashchips.c: Add support for XM25RU256C ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Thank you! Do you have a link to the datasheet for the chip? File flashchips.c: https://review.coreboot.org/c/flashrom/+/82101/comment/1fde39ab_ce0b513c : PS1, Line 21731: TEST_UNTESTED You tested it, from the logs your provided you did probe, read, write, so this should be `TEST_OK_PREW` -- To view, visit https://review.coreboot.org/c/flashrom/+/82101?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I431474a662304d09438e274706d3fc9cfbbe0bd6 Gerrit-Change-Number: 82101 Gerrit-PatchSet: 1 Gerrit-Owner: Georg Gottleuber <ggo(a)tuxedo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Georg Gottleuber <ggo(a)tuxedo.de> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 03 May 2024 07:46:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in flashrom[main]: doc: Convert serprog docs to rst and add to doc directory
by Stefan Reinauer (Code Review) 03 May '24

03 May '24

Attention is currently required from: Anastasia Klimchuk, J. Neuschäfer, Riku Viitanen, Swift Geek (Sebastian Grzywna), Thomas Heijligen, Urja Rannikko. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82018?usp=email ) Change subject: doc: Convert serprog docs to rst and add to doc directory ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/82018?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie52f1e051ed215d61d5fb535e3eddeac71f64d13 Gerrit-Change-Number: 82018 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Sydney <git(a)funkeleinhorn.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: J. Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Attention: J. Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Comment-Date: Fri, 03 May 2024 05:21:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: flashchips: Add support for MXIC MX25L1633E
by Anastasia Klimchuk (Code Review) 03 May '24

03 May '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/81836?usp=email ) Change subject: flashchips: Add support for MXIC MX25L1633E ...................................................................... flashchips: Add support for MXIC MX25L1633E The MX25L1633E has been tested by ch341a programmer : read, write, erase and wp. We have tested --wp-enable, --wp-disable, --wp-list and --wp-range commands for write-protect feature. MX25L1633E datasheet is available at the following URL: https://www.macronix.com/Lists/Datasheet/Attachments/8617/MX25L1633E,%203V,… Change-Id: I63ee0182ad6e62b7408136285aa0e927d53f7bc8 Signed-off-by: DanielZhang <danielzhang(a)mxic.com.cn> Reviewed-on: https://review.coreboot.org/c/flashrom/+/81836 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 44 insertions(+), 1 deletion(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/flashchips.c b/flashchips.c index 80355e4..041ac40 100644 --- a/flashchips.c +++ b/flashchips.c @@ -9374,6 +9374,49 @@ { .vendor = "Macronix", + .name = "MX25L1633E", + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25L1635D, + .total_size = 2048, + .page_size = 256, + /* OTP: 64B total; enter 0xB1, exit 0xC1 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP , + .tested = TEST_OK_PREWB, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, /* bit6 is quad enable */ + .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {2700, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, + }, + + .decode_range = DECODE_RANGE_SPI25, + }, + + { + .vendor = "Macronix", .name = "MX25L1635E", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 2add46d..6008ad1 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -518,7 +518,7 @@ #define MACRONIX_MX25L6405 0x2017 /* MX25L6405, MX25L6405D (64k 0x20); MX25L6406E/MX25L6408E (4k 0x20); MX25L6436E/MX25L6445E/MX25L6465E/MX25L6473E (4k 0x20, 32k 0x52) */ #define MACRONIX_MX25L12805D 0x2018 /* MX25L12805D (no 32k); MX25L12865E, MX25L12835F, MX25L12845E, MX25L12873F, MX25L12833F, MX25L12850F (32k 0x52) */ #define MACRONIX_MX25L25635F 0x2019 /* Same as MX25L25639F, but the latter seems to not support REMS */ -#define MACRONIX_MX25L1635D 0x2415 +#define MACRONIX_MX25L1635D 0x2415 /* MX25L1633E */ #define MACRONIX_MX25L1635E 0x2515 /* MX25L1635{E} */ #define MACRONIX_MX66L51235F 0x201a /* MX66L51235F, MX25L51245G */ #define MACRONIX_MX66L1G45G 0x201b /* MX66L1G45G */ -- To view, visit https://review.coreboot.org/c/flashrom/+/81836?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I63ee0182ad6e62b7408136285aa0e927d53f7bc8 Gerrit-Change-Number: 81836 Gerrit-PatchSet: 6 Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2024