May 2024 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: doc: Add doc for dummyflasher
by Anastasia Klimchuk (Code Review) 23 May '24

23 May '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/82482?usp=email ) Change subject: doc: Add doc for dummyflasher ...................................................................... doc: Add doc for dummyflasher Change-Id: I1e2039a3dcb958e96c4f1ff7b99a5629c3e83ed1 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/82482 Reviewed-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- A doc/supported_hw/supported_prog/dummyflasher.rst M doc/supported_hw/supported_prog/index.rst 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Sergii Dmytruk: Looks good to me, approved diff --git a/doc/supported_hw/supported_prog/dummyflasher.rst b/doc/supported_hw/supported_prog/dummyflasher.rst new file mode 100644 index 0000000..d11f59c --- /dev/null +++ b/doc/supported_hw/supported_prog/dummyflasher.rst @@ -0,0 +1,14 @@ +============ +Dummyflasher +============ + +Dummyflasher programmer is software-only implementation of a flashrom programmer. In other words, +it is an emulator which operates on in-memory arrays of bytes instead of a real chip. Dummyflasher does not interact with any hardware. + +This programmer is actively used in unit tests. + +Also, since dummyflasher implements all of the programmers APIs, it can be used as an example or as a starting point for implementing a new programmer. + +Related documents: + +* :doc:`/contrib_howtos/how_to_add_unit_test` diff --git a/doc/supported_hw/supported_prog/index.rst b/doc/supported_hw/supported_prog/index.rst index d8131a6..3f05c25 100644 --- a/doc/supported_hw/supported_prog/index.rst +++ b/doc/supported_hw/supported_prog/index.rst @@ -13,4 +13,5 @@ .. toctree:: :maxdepth: 1 + dummyflasher serprog/index -- To view, visit https://review.coreboot.org/c/flashrom/+/82482?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1e2039a3dcb958e96c4f1ff7b99a5629c3e83ed1 Gerrit-Change-Number: 82482 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: flashchips: Correct feature_bits for MX25L128*
by Hsuan-ting Chen (Code Review) 23 May '24

23 May '24

Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Nikolai Artemiev, Stefan Reinauer. Hsuan-ting Chen has posted comments on this change by Hsuan-ting Chen. ( https://review.coreboot.org/c/flashrom/+/82605?usp=email ) Change subject: flashchips: Correct feature_bits for MX25L128* ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The previous patch should not really work. […] Update: I checked that with `-p internal` the current ToT will pass `--wp-status`; however, with `-p raiden_debug_spi` (CrOS debug route) we will check the `SECURITY `status register, and thus it failed. I haven't traced it in depth yet. -- To view, visit https://review.coreboot.org/c/flashrom/+/82605?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I001cde6816bd099317bc9c23904c5fcbe6003241 Gerrit-Change-Number: 82605 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 23 May 2024 03:46:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com>

1 0

[XS] Change in flashrom[main]: flashchips: Correct feature_bits for MX25L128*
by Hsuan-ting Chen (Code Review) 22 May '24

22 May '24

Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Nikolai Artemiev, Stefan Reinauer. Hsuan-ting Chen has posted comments on this change by Hsuan-ting Chen. ( https://review.coreboot.org/c/flashrom/+/82605?usp=email ) Change subject: flashchips: Correct feature_bits for MX25L128* ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The previous patch should not really work. This time I manually check again with flashrom-over-raiden_debug_spi and ensure pass. I'll check if I could get an ADL-n with MX25L12833F to check if -p internal could pass, too. -- To view, visit https://review.coreboot.org/c/flashrom/+/82605?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I001cde6816bd099317bc9c23904c5fcbe6003241 Gerrit-Change-Number: 82605 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 22 May 2024 10:40:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in flashrom[main]: flashchips: Correct feature_bits for MX25L128*
by Hsuan-ting Chen (Code Review) 22 May '24

22 May '24

Attention is currently required from: Hsuan Ting Chen. Hello Hsuan Ting Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/82605?usp=email to review the following change. Change subject: flashchips: Correct feature_bits for MX25L128* ...................................................................... flashchips: Correct feature_bits for MX25L128* In CB:81792 (CL:5471748) we add write-protect support for MX25L12833F, MX25L12835F/MX25L12873F, and MX25L12845E/MX25L12865E. However, that CL contained a bug that it didn't set the feature_bits correctly. We need to add: * Add FEATURE_CFGR and FEATURE_SCUR for MX25L12833F * Add FEATURE_CFGR and FEATURE_SCUR for MX25L12835F/MX25L12873F * Add FEATURE_SCUR for MX25L12845E/MX25L12865E BUG=b:332486637 TEST=In a host connect to ADL-n ChromeOS via servo, with this patch, flashrom -p raiden_debug_spi:target=AP,custom_rst=true ,serial=$(dut-control -o ccd_serialname -p 9996) --wp-status returns correct WP status. TEST=without this patch, returns error with "Cannot read SECURITY: unsupported by chip" Change-Id: I001cde6816bd099317bc9c23904c5fcbe6003241 Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M flashchips.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/82605/1 diff --git a/flashchips.c b/flashchips.c index 59edeb3..d5b63e9 100644 --- a/flashchips.c +++ b/flashchips.c @@ -9012,7 +9012,7 @@ .total_size = 16384, .page_size = 256, /* OTP: 1KB total; enter 0xB1, exit 0xC1 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_CFGR | FEATURE_SCUR, .tested = TEST_OK_PREWB, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, @@ -9059,7 +9059,7 @@ .total_size = 16384, .page_size = 256, /* OTP: 512B total; enter 0xB1, exit 0xC1 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_CFGR | FEATURE_SCUR, .tested = TEST_OK_PREW, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, @@ -9106,7 +9106,7 @@ .total_size = 16384, .page_size = 256, /* OTP: 512B total; enter 0xB1, exit 0xC1 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_SCUR, .tested = TEST_OK_PREW, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, -- To view, visit https://review.coreboot.org/c/flashrom/+/82605?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I001cde6816bd099317bc9c23904c5fcbe6003241 Gerrit-Change-Number: 82605 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org>

1 0

[S] Change in flashrom[main]: ch347_spi: Add driver support for CH347F packaging
by ZhiYuanNJ (Code Review) 21 May '24

21 May '24

Attention is currently required from: Nicholas Chin, Paul Menzel. ZhiYuanNJ has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82193?usp=email ) Change subject: ch347_spi: Add driver support for CH347F packaging ...................................................................... Patch Set 11: (1 comment) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82193/comment/10c61734_264c794c?us… : PS10, Line 9: * (at your option) any later version. : * This program is distributed in the hope that it will be useful, > Seems like you removed the blank line between the "any later version" line and the "This program is. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/82193?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I693baf1a0d9dc20757f56fba626b5f5ad20f71dd Gerrit-Change-Number: 82193 Gerrit-PatchSet: 11 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 21 May 2024 03:49:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in flashrom[main]: ch347_spi: Add driver support for CH347F packaging
by Nicholas Chin (Code Review) 20 May '24

20 May '24

Attention is currently required from: Paul Menzel, ZhiYuanNJ. Nicholas Chin has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82193?usp=email ) Change subject: ch347_spi: Add driver support for CH347F packaging ...................................................................... Patch Set 10: Code-Review+1 (1 comment) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82193/comment/002bcf5a_ef08a5b7?us… : PS10, Line 9: * (at your option) any later version. : * This program is distributed in the hope that it will be useful, Seems like you removed the blank line between the "any later version" line and the "This program is..." line, but it should be left in place (with no spaces after the *). Looks like Gerrit was updated and now support suggestions, so I think you can just click the "Show Edit" button, then "Apply Fix", and then "Publish Edit" ```suggestion * (at your option) any later version. * * This program is distributed in the hope that it will be useful, ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/82193?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I693baf1a0d9dc20757f56fba626b5f5ad20f71dd Gerrit-Change-Number: 82193 Gerrit-PatchSet: 10 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: ZhiYuanNJ Gerrit-Comment-Date: Mon, 20 May 2024 19:56:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: Add documentation for pico-serprog
by Anastasia Klimchuk (Code Review) 20 May '24

20 May '24

Attention is currently required from: J. Neuschäfer, Riku Viitanen, Sydney, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change by Sydney. ( https://review.coreboot.org/c/flashrom/+/82229?usp=email ) Change subject: Add documentation for pico-serprog ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Patchset: PS3: > Some comments on wording I read the latest version, it seems the comments are resolved? But if not, please tell. Thanks for reviewing! Patchset: PS4: I have a question for all three of you. You all have forks of flashrom, with some cool stuff which people use. What do you think about moving your development upstream? I don't know of the reasons you made forks, are there technical reasons why this can't be upstream? I am interested to discuss. For example, I learned about pico-serprog because from time to time people send patches to add support for a new chip, and they say "tested with pico-serprog". I have seen it several times so I remember. What do you think of adding pico-serprog upstream, can it be a programmer here? This was an example, but the question is to all of you. As for the technical aspects, if you add a new file(s), you add your copyright at the top of the file, also we have the MAINTAINERS file where you identify yourself as a maintainer for your programmer. More details here https://flashrom.org/about_flashrom/team.html This is something to think about, can be for later, not necessarily for right now. What do you think? Also just to be clear: the question does not affect this patch, the patch goes ahead independently of it. It's just convenient, all you are here! :) -- To view, visit https://review.coreboot.org/c/flashrom/+/82229?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I457dfec52f89997f64b6c276c50b329359d61b77 Gerrit-Change-Number: 82229 Gerrit-PatchSet: 4 Gerrit-Owner: Sydney <git(a)funkeleinhorn.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: J. Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: J. Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Sydney <git(a)funkeleinhorn.com> Gerrit-Comment-Date: Mon, 20 May 2024 10:20:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: J. Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

[M] Change in flashrom[main]: ch347_spi: Add driver support for CH347F packaging
by ZhiYuanNJ (Code Review) 20 May '24

20 May '24

Attention is currently required from: Nicholas Chin, Paul Menzel. ZhiYuanNJ has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82193?usp=email ) Change subject: ch347_spi: Add driver support for CH347F packaging ...................................................................... Patch Set 10: (3 comments) Patchset: PS10: Are there any issues with this submission? File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82193/comment/d66c2532_0e34fa6b?us… : PS9, Line 10: > Remove extra spaces Done https://review.coreboot.org/c/flashrom/+/82193/comment/8f4a7d07_9444a82e?us… : PS9, Line 307: > Remove trailing space Done -- To view, visit https://review.coreboot.org/c/flashrom/+/82193?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I693baf1a0d9dc20757f56fba626b5f5ad20f71dd Gerrit-Change-Number: 82193 Gerrit-PatchSet: 10 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 20 May 2024 10:02:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in flashrom[main]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
by Nikolai Artemiev (Code Review) 20 May '24

20 May '24

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Martin L Roth, Martin Roth, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim. Nikolai Artemiev has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/flashrom/+/58025?usp=email ) Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME ...................................................................... Patch Set 10: Code-Review+2 (1 comment) Patchset: PS10: > I don't see copies of the datasheet on the list; it looks like they may have been sent to you privat […] I also don't have access to the datasheets on the mailing list thread. But I agree with Peter's reasoning about BP4/TB, I think we can submit these patches -- To view, visit https://review.coreboot.org/c/flashrom/+/58025?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 10 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Mon, 20 May 2024 06:42:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: flashchips: Add support for chip model GD25LF128E
by Nikolai Artemiev (Code Review) 20 May '24

20 May '24

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer, Victor Lim. Nikolai Artemiev has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/82332?usp=email ) Change subject: flashchips: Add support for chip model GD25LF128E ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/82332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I71fdc7ea1aea69d14db6af3bac2da3e7bee8abbe Gerrit-Change-Number: 82332 Gerrit-PatchSet: 2 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 20 May 2024 06:27:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2024