Attention is currently required from: Brian Norris, Chen, Nikolai Artemiev, Peter Marheine, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80806?usp=email )
Change subject: udelay: clock_getres() does not provide clock_gettime() resolution
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
> Although I use macOS, I can't give an answer to this question. […]
Thanks for quick response anyway, I appreciate it! (sorry my response wasn't that quick)
PS3:
Peter, I wanted to ask you, maybe you have some thoughts on this, you have experience with non-Linux. Thank you!
--
To view, visit https://review.coreboot.org/c/flashrom/+/80806?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Icdc6e184eacb14d3bd27029e3fc75be4431d82b4
Gerrit-Change-Number: 80806
Gerrit-PatchSet: 3
Gerrit-Owner: Brian Norris <briannorris(a)chromium.org>
Gerrit-Reviewer: Chen <c(a)jia.je>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Brian Norris <briannorris(a)chromium.org>
Gerrit-Attention: Chen <c(a)jia.je>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Fri, 22 Mar 2024 03:38:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chen <c(a)jia.je>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/81266?usp=email )
Change subject: cli_common: Add link to the documentation how to mark chip tested
......................................................................
cli_common: Add link to the documentation how to mark chip tested
Perhaps some of the users will be able to follow the instructions
and send a patch to mark chip as tested. The option to send report
to the mailing list remains available as before.
Change-Id: I36105725058f2fecb82408c369b70b3324502ece
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/81266
Reviewed-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Peter Marheine <pmarheine(a)chromium.org>
---
M cli_common.c
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Peter Marheine: Looks good to me, approved
Sergii Dmytruk: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/cli_common.c b/cli_common.c
index 5373585..afcd1f3 100644
--- a/cli_common.c
+++ b/cli_common.c
@@ -80,6 +80,8 @@
"work correctly for you with this flash chip. Please include the flashrom log\n"
"file for all operations you tested (see the man page for details), and mention\n"
"which mainboard or programmer you tested in the subject line.\n"
+ "You can also try to follow the instructions here:\n"
+ "https://www.flashrom.org/contrib_howtos/how_to_mark_chip_tested.html\n"
"Thanks for your help!\n");
}
}
--
To view, visit https://review.coreboot.org/c/flashrom/+/81266?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I36105725058f2fecb82408c369b70b3324502ece
Gerrit-Change-Number: 81266
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
DZ has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81350?usp=email )
Change subject: flashchips: Add support for MXIC MX25L12850F
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Why do you need to add this chip as a standalone entry? It's really similar to `MX25L12833F/MX25L128 […]
MX25L12845E and MX25L12865E have no configuration register.
--
To view, visit https://review.coreboot.org/c/flashrom/+/81350?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I71ac70d273904f94d015401f9d8df587084efad0
Gerrit-Change-Number: 81350
Gerrit-PatchSet: 1
Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Thu, 21 Mar 2024 01:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, DZ, Nikolai Artemiev, Stefan Reinauer.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81350?usp=email )
Change subject: flashchips: Add support for MXIC MX25L12850F
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Why do you need to add this chip as a standalone entry? It's really similar to `MX25L12833F/MX25L12835F/MX25L12845E/MX25L12865E/MX25L12873F`, the only differences are:
1. Extra flag in `feature_bits`
2. Specified `reg_bits`
3. Specified `decode_range`
But quick research through these chips shows me that these changes can be applied to them as well. Does something go wrong when you use the entry I mentioned before?
--
To view, visit https://review.coreboot.org/c/flashrom/+/81350?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I71ac70d273904f94d015401f9d8df587084efad0
Gerrit-Change-Number: 81350
Gerrit-PatchSet: 1
Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Wed, 20 Mar 2024 15:36:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hsuan-ting Chen.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81357?usp=email )
Change subject: ichspi.c: Add support for region 9 and beyond in Meteor Lake
......................................................................
Patch Set 2:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/81357/comment/82abe3d6_838d31df :
PS1, Line 1848: case CHIPSET_METEOR_LAKE:
> It was your previous CL that put MTL in that position
For sure that is my CL which added MTL after ADL but there is no such restriction to maintain the order. You can move the macro at the end of the list.
> (https://review.coreboot.org/c/flashrom/+/62783) Could you share if (1) We could move it to the very end
Please move MTL as the end so we can add LNL and PTL after MTL.
> (2) Will there be any other chipset name which will be moved to make the order makes sense?
Looking at ur current logic, i felt the MTL is the first SOC where we would like to enable this support hence, moving MTL is okay and new Intel SOC can be added after MTL so, the suggested logic (by me) works w/o any maintenance burden.
--
To view, visit https://review.coreboot.org/c/flashrom/+/81357?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I1e06e7b3d470423a6014e623826d9234fdebfbf9
Gerrit-Change-Number: 81357
Gerrit-PatchSet: 2
Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org>
Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 03:15:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81261?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: doc/dev_guide: Add section about Jenkins build, and scan-build
......................................................................
Patch Set 1:
(1 comment)
File doc/dev_guide/development_guide.rst:
https://review.coreboot.org/c/flashrom/+/81261/comment/c9bbd0f9_62450e2c :
PS1, Line 226: need to
"should" seems better, since you're saying authors should review the report but aren't required to.
--
To view, visit https://review.coreboot.org/c/flashrom/+/81261?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I416b632c55d1ceb925456ac8c8947dfbcef2e888
Gerrit-Change-Number: 81261
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Tue, 19 Mar 2024 22:54:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment