March 2024 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: ich: Add names for region 5, 9, 10, 11, 12, 13, 15
by Hsuan-ting Chen (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Stefan Reinauer. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81356?usp=email ) Change subject: ich: Add names for region 5, 9, 10, 11, 12, 13, 15 ...................................................................... Patch Set 1: (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/81356/comment/5c1681e1_94d906a1 : PS1, Line 521: msg_pdbg2(" FD BIOS ME GbE Pltf DE BIOS2 Reg7 EC DE2 "); > Yes, we used to pad names to 4 characters (lines 534 and 538). […] Before: (width=84) ``` --- Details --- FD BIOS ME GbE Pltf Reg5 Reg6 Reg7 EC Reg9 RegA RegB RegC RegD RegE RegF BIOS r rw r r ME r rw ``` After: (width=115) ``` --- Details --- FD BIOS ME GbE Pltf DE BIOS2 Reg7 EC DE2 IE 10GbE0 10GbE1 RegD RegE PTT BIOS r rw r r ME r rw ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/81356?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3b164ce4ae84bfd523fcd8be416c5d13183ed632 Gerrit-Change-Number: 81356 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 26 Mar 2024 06:58:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: flashchips: Add Zetta Device ZD25LQ128
by Anastasia Klimchuk (Code Review) 26 Mar '24

26 Mar '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/81392?usp=email ) Change subject: flashchips: Add Zetta Device ZD25LQ128 ...................................................................... flashchips: Add Zetta Device ZD25LQ128 Datasheet: http://www.zettadevice.com/uploads/files/163410630201e3483211247ac1.pdf Tested probe, read, erase, write, verify on ZD25LQ128AWIG chips using Linux SPI and DediProg SF100 programmers. Renamed ZETTADEVICE_ macros to ZETTA_ to accomodate longer suffixes. Change-Id: I5cb20158e81ab109f16958285b8787858efb4831 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> Reviewed-on: https://review.coreboot.org/c/flashrom/+/81392 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 46 insertions(+), 7 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/flashchips.c b/flashchips.c index 204f34f..74953d1 100644 --- a/flashchips.c +++ b/flashchips.c @@ -21593,8 +21593,8 @@ .vendor = "Zetta Device", .name = "ZD25D20", .bustype = BUS_SPI, - .manufacture_id = ZETTADEVICE_ID, - .model_id = ZETTADEVICE_ZD25D20, + .manufacture_id = ZETTA_ID, + .model_id = ZETTA_ZD25D20, .total_size = 256, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, @@ -21631,8 +21631,8 @@ .vendor = "Zetta Device", .name = "ZD25D40", .bustype = BUS_SPI, - .manufacture_id = ZETTADEVICE_ID, - .model_id = ZETTADEVICE_ZD25D40, + .manufacture_id = ZETTA_ID, + .model_id = ZETTA_ZD25D40, .total_size = 512, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, @@ -21666,6 +21666,44 @@ }, { + .vendor = "Zetta Device", + .name = "ZD25LQ128", + .bustype = BUS_SPI, + .manufacture_id = ZETTA_ID, + .model_id = ZETTA_ZD25LQ128_REMS, + .total_size = 16384, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_REMS, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_PLAIN, /* TODO: improve */ + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1650, 1950}, + }, + + { .vendor = "Unknown", .name = "SFDP-capable chip", .bustype = BUS_SPI, diff --git a/include/flashchips.h b/include/flashchips.h index d0a858b..932e458 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -1055,8 +1055,9 @@ #define XTX_XT25F02E 0x4012 #define XTX_XT25F64B 0x4017 -#define ZETTADEVICE_ID 0xBA /* Zetta Device */ -#define ZETTADEVICE_ZD25D20 0x2012 -#define ZETTADEVICE_ZD25D40 0x2013 +#define ZETTA_ID 0xBA /* Zetta Device */ +#define ZETTA_ZD25D20 0x2012 +#define ZETTA_ZD25D40 0x2013 +#define ZETTA_ZD25LQ128_REMS 0x17 /* RDID = 0x4218 */ #endif /* !FLASHCHIPS_H */ -- To view, visit https://review.coreboot.org/c/flashrom/+/81392?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5cb20158e81ab109f16958285b8787858efb4831 Gerrit-Change-Number: 81392 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[main]: flashchips: Add support for MXIC MX25L12850F
by Alexander Goncharov (Code Review) 25 Mar '24

25 Mar '24

Attention is currently required from: DZ. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81350?usp=email ) Change subject: flashchips: Add support for MXIC MX25L12850F ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yes right, the difference is in configuration register which changes the way `. […] I haven't noticed the configuration register ahah. Thanks for pointing that out, then it's fine! P.S. I feel the same, thank you :) -- To view, visit https://review.coreboot.org/c/flashrom/+/81350?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I71ac70d273904f94d015401f9d8df587084efad0 Gerrit-Change-Number: 81350 Gerrit-PatchSet: 1 Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn> Gerrit-Comment-Date: Mon, 25 Mar 2024 10:39:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: DZ <danielzhang(a)mxic.com.cn> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: ich: Add names for region 5, 9, 10, 11, 12, 13, 15
by Hsuan-ting Chen (Code Review) 25 Mar '24

25 Mar '24

Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Stefan Reinauer. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81356?usp=email ) Change subject: ich: Add names for region 5, 9, 10, 11, 12, 13, 15 ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/81356/comment/64e08be4_fc4f7d5c : PS1, Line 12: * Incorporate missing region names from https://github.com/coreboot/coreboot/blob/main/util/ifdtool/ifdtool.c for completeness. > Thank you for syncing region names in two places! I am curious, is there any official doc from Intel […] I believe there should be a document with its name like 'MTL SPI Programming Guide,' but I don't think it's publicly accessible. (I'm afraid I can't share anything since I don't have access myself.) Perhaps Subrata could share some knowledge about where are those region names? Patchset: PS1: Hi Subrata: Could you share if there's any basic knowledge about how Intel introduce those region names? File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/81356/comment/e0df6408_081eda1f : PS1, Line 521: msg_pdbg2(" FD BIOS ME GbE Pltf DE BIOS2 Reg7 EC DE2 "); > For this line (and diffs below in this file) you have changed the number of spaces between names? So […] Yes, we used to pad names to 4 characters (lines 534 and 538). However, some newer names like '10GbE0' are too long. To accommodate this, I now pad all names to 6 characters (with center alignment). -- To view, visit https://review.coreboot.org/c/flashrom/+/81356?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3b164ce4ae84bfd523fcd8be416c5d13183ed632 Gerrit-Change-Number: 81356 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 25 Mar 2024 03:04:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: Add support for Idaville HCC platform and iRC regions
by Kevin Yu (Code Review) 25 Mar '24

25 Mar '24

Attention is currently required from: Angel Pons, Paul Menzel. Kevin Yu has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81327?usp=email ) Change subject: Add support for Idaville HCC platform and iRC regions ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi Angel Can you help review this? Thanks Kevin Yu -- To view, visit https://review.coreboot.org/c/flashrom/+/81327?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I39e7fa56b1b1de429f413ce32e69c8d8c769b6a9 Gerrit-Change-Number: 81327 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 25 Mar 2024 01:40:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: doc/dev_guide: Add section about Jenkins build, and scan-build
by Peter Marheine (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81261?usp=email ) Change subject: doc/dev_guide: Add section about Jenkins build, and scan-build ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81261?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I416b632c55d1ceb925456ac8c8947dfbcef2e888 Gerrit-Change-Number: 81261 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Mar 2024 22:26:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: doc/dev_guide: Add section about Jenkins build, and scan-build
by Stefan Reinauer (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81261?usp=email ) Change subject: doc/dev_guide: Add section about Jenkins build, and scan-build ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81261?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I416b632c55d1ceb925456ac8c8947dfbcef2e888 Gerrit-Change-Number: 81261 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Mar 2024 14:42:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: serprog: Add SPI Mode and CS Mode commands
by Anastasia Klimchuk (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Funkeleinhorn, Urja Rannikko. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81428?usp=email ) Change subject: serprog: Add SPI Mode and CS Mode commands ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: Urja, good day, I thought maybe you are still around and have some interest to review the update to serprog protocol? Thank you! PS1: Thank you for detailed explanation, I think I understand now. > What do you mean with add implementation to upstream serprog? I was wondering, but you answered just above these words: > so far I only add the commands to the documentation/the spec but do not implement them in flashrom. I wasn't looking into details, but I just quickly looked into the code of avrgirl serprog-programmer and noticed that S_SPI_MODE and S_CS_MODE are handled there, this is where my question came from. I agree supporting dual or quad SPI is a good idea. But I think this patch can go ahead, doesn't have to wait. > Yes sure I am up for reviewing changes to the serprog documentation. Great. I really appreciate it! -- To view, visit https://review.coreboot.org/c/flashrom/+/81428?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Idb5a9a3710fede322def5191d68b7fba0e135292 Gerrit-Change-Number: 81428 Gerrit-PatchSet: 1 Gerrit-Owner: Funkeleinhorn <git(a)funkeleinhorn.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Attention: Funkeleinhorn <git(a)funkeleinhorn.com> Gerrit-Comment-Date: Sun, 24 Mar 2024 12:40:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Funkeleinhorn <git(a)funkeleinhorn.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: serprog: Add SPI Mode and CS Mode commands
by Funkeleinhorn (Code Review) 23 Mar '24

23 Mar '24

Attention is currently required from: Anastasia Klimchuk. Funkeleinhorn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81428?usp=email ) Change subject: serprog: Add SPI Mode and CS Mode commands ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Nice to meet you, and thank you for the patch! […] Heyy nice to meet you too. Sorry that you missed the discussion on IRC. I didn't know about the Discord and that the main discussions are there now. 1 Yess so far I only add the commands to the documentation/the spec but do not implement them in flashrom. This is because as I understand flashrom is targeted at reading/writing flash chips and the current commands suffice for that. But we could add additional SPI modes to the 0x17 SPI mode command which could be useful for the current flashrom implementation. For example we could allow programmers to support dual or quad SPI which could speed up read/writes on supported chips and programmers. I hope that makes some things more clear. What do you mean with add implementation to upstream serprog? Are you talking about adding support for flashing AVR microcontrollers to flashrom? I so far considered this out of scope for the project as it would require some bigger changes like also implementing the AVR ISP protocol. 2 It would be cool to have some group to coordinate the serprog protocol spec across projects using it but as I know there is no central authority or working group for the serprog protocol so far. This is why I would consider flashrom and its fork flashprog the authority over the serprog spec (serprog-protocol.txt) as the protocol evolved there. The numbers 0x17 and 0x18 where chosen because they are the lowest unassigned ones and I tought it would be nice to have no gaps in the specified commands. But we could choose them arbitarily from the unassigned range. 3 Yes sure I am up for reviewing changes to the serprog documentation. -- To view, visit https://review.coreboot.org/c/flashrom/+/81428?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Idb5a9a3710fede322def5191d68b7fba0e135292 Gerrit-Change-Number: 81428 Gerrit-PatchSet: 1 Gerrit-Owner: Funkeleinhorn <git(a)funkeleinhorn.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 23 Mar 2024 22:00:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: serprog: Add SPI Mode and CS Mode commands
by Anastasia Klimchuk (Code Review) 23 Mar '24

23 Mar '24

Attention is currently required from: Funkeleinhorn. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81428?usp=email ) Change subject: serprog: Add SPI Mode and CS Mode commands ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Nice to meet you, and thank you for the patch! Sorry I missed your discussion in IRC (I have relocated to flashrom Discord channel some time ago) but in any case you did the right thing to send the patch! I have a few questions, sorry again if that's something you have discussed on IRC earlier, but I think it's good to have relevant info here on the patch. 1 You are adding the new commands to the documentation, but not to implementation? I understand that it is implemented in the forks you linked. Do you have any plans to add implementation to upstream serprog? That would be so cool! 2 Who decides on the serprog spec, is there a spec somewhere? Basically I want to understand why it's 0x17 and 0x18 and not something else. Can any other number be fine if it's implemented, or is it documented somewhere? 3 Lastly, the question which goes further than this patch! flashrom is currently in the process of reviewing/updating documentation and converting it to a new format. There are a few serprog docs, and I am asking people who have knowledge of it, to help review the docs. I will do the boring part of converting to a new format and creating the patch, would you agree to be one of the reviewers for the content? -- To view, visit https://review.coreboot.org/c/flashrom/+/81428?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Idb5a9a3710fede322def5191d68b7fba0e135292 Gerrit-Change-Number: 81428 Gerrit-PatchSet: 1 Gerrit-Owner: Funkeleinhorn <git(a)funkeleinhorn.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Funkeleinhorn <git(a)funkeleinhorn.com> Gerrit-Comment-Date: Sat, 23 Mar 2024 12:47:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2024