March 2024 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: doc: Add doc how to support flashrom project
by Anastasia Klimchuk (Code Review) 05 Mar '24

05 Mar '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/80729?usp=email ) Change subject: doc: Add doc how to support flashrom project ...................................................................... doc: Add doc how to support flashrom project Change-Id: I59a4f5978bc8ffa8ca3a3dc3f15c770ef5fcedce Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/80729 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M doc/contact.rst M doc/contrib_howtos/index.rst M doc/dev_guide/development_guide.rst A doc/how_to_support_flashrom.rst M doc/index.rst 5 files changed, 177 insertions(+), 2 deletions(-) Approvals: Stefan Reinauer: Looks good to me, approved build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Peter Marheine: Looks good to me, approved diff --git a/doc/contact.rst b/doc/contact.rst index 57a9390..79cdb91 100644 --- a/doc/contact.rst +++ b/doc/contact.rst @@ -33,8 +33,10 @@ If your mail contains any BIOS images or F segment dumps (instead of links which are fine), the mail will be rejected for legal reasons (we do not have the right to distribute BIOS images). -Real time chats ---------------- +.. _real time channels: + +Real time channels +------------------ Flashrom has real time channels where you have the chance to talk to people being involved or interested in the project. Most of the discussion is about flashrom development, contributions, tech talk and user help. diff --git a/doc/contrib_howtos/index.rst b/doc/contrib_howtos/index.rst index b33482d..cb74e1c 100644 --- a/doc/contrib_howtos/index.rst +++ b/doc/contrib_howtos/index.rst @@ -8,3 +8,4 @@ how_to_mark_chip_tested how_to_add_unit_test ../how_to_add_docs + ../how_to_support_flashrom diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index 247a31a..0b64325 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -323,6 +323,8 @@ Note the search is not a replacement for Merge checklist, but it can help find candidates for merging. +.. _bugtracker: + Bugtracker ========== diff --git a/doc/how_to_support_flashrom.rst b/doc/how_to_support_flashrom.rst new file mode 100644 index 0000000..372ef38 --- /dev/null +++ b/doc/how_to_support_flashrom.rst @@ -0,0 +1,169 @@ +======================= +How to support flashrom +======================= + +Intro +========= + +This document is for people and companies who want to help flashrom, and it explains +various ways how to do this. + +There are lots of ways to help (as you can see below), whether you have little time or a lot, +whether you are a developer, a user or a company. +flashrom is a free open source software project, and all the contributions are publicly visible - +which means you get all the glory for your work, and you help the whole open source ecosystem. +Thank you! + +flashrom supports a huge variety of environments, platforms and hardware, and there is +no one person or one company on earth which has setup to test and maintain all of these +(and realistically, never will be). The only way we can maintain all of these, +is together as a community. + +To be aware of what's going on, subscribe to our :ref:`mailing list` and/or join our :ref:`real time channels`. + +Development +=========== + +Development, or in other words, sending patches to flashrom, is what probably comes to mind first +when you think about helping and contributing. And indeed, this is a great help, +and patches are always welcome. + +If your idea fits into one patch, you can just send it. If you have bigger plans in mind, +a large amount of work over a longer time frame, the best way is to start a topic on the mailing list. +This helps with planning, and also people in the community, whoever is interested, +will be able to support your effort. + +If you are new to flashrom development process, please start by reading :doc:`/dev_guide/development_guide`. +It's also useful to check `existing patches <https://review.coreboot.org/q/status:open+project:flashrom>`_ +for examples on how the dev process works. + +For some types of contributions we have more detailed guidelines, check the list :doc:`/contrib_howtos/index`. + +Code reviews +============ + +Did you know: code reviews are equally important as writing the code! + +For each patch, we need at least one reviewer, and often more than one. +Doing code reviews is highly appreciated and highly respected! +All reviewers' names are immortalised in git history together with authors names, +as "Reviewed-by" and "Signed-off-by" tags in a commit message (see `example <https://review.coreboot.org/c/flashrom/+/80729>`_). + +Code review involves carefully inspecting the patch in Gerrit, and adding comments if anything +is unclear/potential errors/issues/something missing etc. If you think the patch is ready, +you can vote on the patch. Every Gerrit user with a registered account can add comments to patches +and vote +1/-1. Note that if you vote -1, you need to add a comment explaining why you gave a negative vote, +and what specific big issues that you see with the patch. Negative vote is a stronger opinion, +and in most cases just adding comments is enough. + +The group of people who can fully approve the patch (i.e. vote +2, see :doc:`/about_flashrom/team`) +is limited, however every Gerrit user can do code reviews. This increases overall confidence +in the reviewed patch. Approving the patch is much easier when the code reviews are done well. + +You can check pending patches under review `in Gerrit <https://review.coreboot.org/q/status:open+project:flashrom>`_ +and help with code review if a patch looks useful, you understand what it is about, and want to have it submitted. + +Building and testing +==================== + +Given the large variety of environments and hardware that flashrom supports, +the question of building and testing flashrom is always relevant. +Try to build flashrom at head on your environment and if it doesn't build, +send a patch to fix (see :doc:`/dev_guide/development_guide`) or file a ticket in :ref:`bugtracker` +with as many details as possible. + +A special case of this is, the time when flashrom team is preparing the release. +The release candidate tag is announced on the mailing list, and it is a great help to try and build and test +a release candidate in whatever your environment is. Both positive and negative results are important, +and you are welcome to share the results, just don't forget to include environment details. +In case of issues, as always: patches are very very welcome. + +Documentation +============= + +You don't have to be a flashrom developer to add, update or review documentation. In fact, +lots of users' docs can greatly benefit from reviews by the users, who are supposed to read and use the docs. +Doc how to update the docs is here: :doc:`/how_to_add_docs` + +As for specific ideas: + +#. If there is an announcement on the mailing list about new doc under review, + have a look and you can join the review + +#. Help migrate information from `old website <https://wiki.flashrom.org/>`_ to `new website <https://www.flashrom.org/>`_. + The rule is, all useful docs need to be migrated but they should be reviewed. Concrete example, + there are docs for programmers, written a while ago. If you are using the programmer regularly + you can review the existing doc and help update it (if needed) and then the updated doc will + go to the new website. + +#. New documentation welcome. + +Mailing list +============ + +If you are not subscribed: please subscribe (see :ref:`mailing list`) so you can see what's going on. + +Oftentimes, mailing list has questions from flashrom users. If it so happens +that you maybe know what they are asking, or have ideas about it - you are welcome to respond! +This will be very helpful. + +Similarly, if there is a development discussion that makes sense to you and is relevant: please join the discussion. + +Mailing list is archived, and archives are public and searchable. Which means, +when you respond to the post you not only help that one person who is asking, +but you also help one hundred people in future, who have the same question and can search the answer on the list archives. + +Joining the team +================ + +If you have experience of flashrom development, good knowledge of some of the areas of flashrom code, +some time and motivation, you can consider joining the team, more info here (:doc:`/about_flashrom/team`). +Unlike the previous ideas, this means some *regular* time commitment (the amount of time +can be small or large, but it is regular). + +If you are not at this stage yet, but are considering this as a potential goal for the future, +check the :doc:`/about_flashrom/team` page for what it means. + +Special appeal for companies +============================ + +There are lots of companies that have their own forks of flashrom, and it would be a great help +if you could contribute back to the upstream project! + +Try to keep your fork as close as possible to upstream, do not diverge without a strong reason. +This makes it easier for you to downstream patches, and also makes it easier to contribute patches +from your fork upstream. As an end result, you will be exchanging code and knowledge with a large ecosystem +rather than hiding in your own corner. Working together we can achieve a higher quality bar, +which is better for the upstream project, and better for your fork. + +Consider the following ideas: + +#. Send upstream the bug fixes you found + +#. Add unit tests for the areas you are using actively + +#. Add new features or add support for new platforms/hardware, especially if you have that in your lab + and can reliably test and maintain + +#. Help with releases: if you have an automated test suite, run it on release candidates. + Build and test flashrom for the devices you have in the lab. + +#. If possible, allocate an engineer(s) to contribute to upstream project (and all their work + you can downstream straight away). Upstream early, upstream often: anything you can upstream sooner + will make your life easier in the future. + +#. Have someone subscribed to the mailing list and respond when the topic is relevant to you, + and you have a knowledge of questions or ideas how to help. + +#. On a long term, consider joining the :doc:`/about_flashrom/team`, pick something to maintain: + for example a programmer you are using often + +Outro +======== + +If you read all of the above and still unsure what to do, but actually want to help, +please don't be afraid to ask flashrom project lead directly (Anastasia Klimchuk, +and you can find email in `Gerrit <https://review.coreboot.org/c/flashrom/+/80729>`_ +or tag aklm on Discord (see :ref:`real time channels`). + +**Every bit of help matters and you can help make flashrom a better place. Thank you!** diff --git a/doc/index.rst b/doc/index.rst index 2fdf778..60c42b0 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -16,6 +16,7 @@ contact release_notes/index about_flashrom/index + how_to_support_flashrom how_to_add_docs documentation_license Old wiki website <https://wiki.flashrom.org/> -- To view, visit https://review.coreboot.org/c/flashrom/+/80729?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I59a4f5978bc8ffa8ca3a3dc3f15c770ef5fcedce Gerrit-Change-Number: 80729 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[main]: fmap: Update major/minor version check
by Anastasia Klimchuk (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Brian Norris, Hsuan-ting Chen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79060?usp=email ) Change subject: fmap: Update major/minor version check ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/79060?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I984835579d3b257a2462906f1f5091b179891bd0 Gerrit-Change-Number: 79060 Gerrit-PatchSet: 3 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Comment-Date: Tue, 05 Mar 2024 11:21:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: fmap: Update major/minor version check
by Brian Norris (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Anastasia Klimchuk, Hsuan-ting Chen. Brian Norris has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79060?usp=email ) Change subject: fmap: Update major/minor version check ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/79060/comment/c19a799b_0e636e17 : PS2, Line 9: It's not valid to separately check the major and minor versions. The : proper minor check would be something like: : : if (fmap->ver_major == FMAP_VER_MAJOR && : fmap->ver_minor > FMAP_VER_MINOR) > Brian, thank you so much for lots of details and links, this is really cool! 👍 > However, I found one gem in cbfstool code , which is a comment for the `is_valid_fmap` function, > > /* Make a best-effort assessment if the given fmap is real */ > > If you could add this comment to the functions, that would be it! Thank you! Done. Thanks for looking! -- To view, visit https://review.coreboot.org/c/flashrom/+/79060?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I984835579d3b257a2462906f1f5091b179891bd0 Gerrit-Change-Number: 79060 Gerrit-PatchSet: 3 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 04 Mar 2024 23:04:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Brian Norris <briannorris(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: fmap: Update major/minor version check
by Brian Norris (Code Review) 05 Mar '24

05 Mar '24

Attention is currently required from: Anastasia Klimchuk, Brian Norris, Hsuan-ting Chen. Hello Anastasia Klimchuk, Arthur Heymans, Edward O'Callaghan, Hsuan-ting Chen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/79060?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Anastasia Klimchuk, Code-Review+2 by Hsuan-ting Chen, Verified+1 by build bot (Jenkins) Change subject: fmap: Update major/minor version check ...................................................................... fmap: Update major/minor version check It's not valid to separately check the major and minor versions. The proper minor check would be something like: if (fmap->ver_major == FMAP_VER_MAJOR && fmap->ver_minor > FMAP_VER_MINOR) ERROR(); But this code was alleged (at introduction in [1]) to have come from cbfstool, and cbfstool doesn't bother with a minor version check. This check is only for finding the FMAP while searching the flash; it isn't actually here for integrity and compatibility purpose. Drop the MINOR version check; align with cbfstool on the MAJOR version check; and match the cbfstool comments for is_valid_fmap(), to emphasize the lack of precision. [1] Commit c82900b66142 ("Add support to get layout from fmap (e.g. coreboot rom)") BRANCH=none BUG=b:288327526 TEST=libflashrom + ChromiumOS flashmap Change-Id: I984835579d3b257a2462906f1f5091b179891bd0 Signed-off-by: Brian Norris <briannorris(a)chromium.org> --- M fmap.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/60/79060/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/79060?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I984835579d3b257a2462906f1f5091b179891bd0 Gerrit-Change-Number: 79060 Gerrit-PatchSet: 3 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[main]: serprog: Fix scan-build warning of resource leak
by Anastasia Klimchuk (Code Review) 03 Mar '24

03 Mar '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/81032?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: serprog: Fix scan-build warning of resource leak ...................................................................... serprog: Fix scan-build warning of resource leak Warning found by the latest scan-build run: *** CID 1534883: (RESOURCE_LEAK) /serprog.c: 853 in serprog_init() 847 "by programmer!\n", cs_num8); 848 goto init_err_cleanup_exit; 849 } 850 } 851 bt = serprog_buses_supported; 852 if (sp_docommand(S_CMD_S_BUSTYPE, 1, &bt, 0, NULL)) >>>CID 1534883: (RESOURCE_LEAK) >>>Variable "cs" going out of scope leaks the storage it points to. 853 goto init_err_cleanup_exit; 854 } Change-Id: Id9cf211de3c482f702adebfcfa274a183c83a33f Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M serprog.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/81032/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81032?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id9cf211de3c482f702adebfcfa274a183c83a33f Gerrit-Change-Number: 81032 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[main]: serprog: Fix scan-build warning of resource leak
by Anastasia Klimchuk (Code Review) 03 Mar '24

03 Mar '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/81032?usp=email ) Change subject: serprog: Fix scan-build warning of resource leak ...................................................................... serprog: Fix scan-build warning of resource leak Warning found by the latest scan-build run: *** CID 1534883: (RESOURCE_LEAK) /serprog.c: 853 in serprog_init() 847 "by programmer!\n", cs_num8); 848 goto init_err_cleanup_exit; 849 } 850 } 851 bt = serprog_buses_supported; 852 if (sp_docommand(S_CMD_S_BUSTYPE, 1, &bt, 0, NULL)) >>>CID 1534883: (RESOURCE_LEAK) >>>Variable "cs" going out of scope leaks the storage it points to. 853 goto init_err_cleanup_exit; 854 } Change-Id: Id9cf211de3c482f702adebfcfa274a183c83a33f Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M serprog.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/81032/1 diff --git a/serprog.c b/serprog.c index c2965c5..4f9bcc7 100644 --- a/serprog.c +++ b/serprog.c @@ -848,6 +848,8 @@ goto init_err_cleanup_exit; } } + free(cs); + bt = serprog_buses_supported; if (sp_docommand(S_CMD_S_BUSTYPE, 1, &bt, 0, NULL)) goto init_err_cleanup_exit; -- To view, visit https://review.coreboot.org/c/flashrom/+/81032?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id9cf211de3c482f702adebfcfa274a183c83a33f Gerrit-Change-Number: 81032 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[main]: doc: Add doc how to support flashrom project
by Stefan Reinauer (Code Review) 02 Mar '24

02 Mar '24

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80729?usp=email ) Change subject: doc: Add doc how to support flashrom project ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/80729?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I59a4f5978bc8ffa8ca3a3dc3f15c770ef5fcedce Gerrit-Change-Number: 80729 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 02 Mar 2024 00:55:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: doc: Add links to Gerrit groups in team page
by Anastasia Klimchuk (Code Review) 01 Mar '24

01 Mar '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/80765?usp=email ) Change subject: doc: Add links to Gerrit groups in team page ...................................................................... doc: Add links to Gerrit groups in team page Change-Id: I493db8c7b2610076136d439e172e3f2cee971346 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/80765 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <patrick(a)coreboot.org> --- M doc/about_flashrom/team.rst 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/doc/about_flashrom/team.rst b/doc/about_flashrom/team.rst index 2c593ec..215d930 100644 --- a/doc/about_flashrom/team.rst +++ b/doc/about_flashrom/team.rst @@ -14,9 +14,11 @@ "flashrom reviewers" group ========================== -Members of the group can do full approval of patches (i.e. vote +2). +Members of the group (see `flashrom reviewers <https://review.coreboot.org/admin/groups/25cadc351dd0492fd2a2a1b1a8e5bb08c2…>`_) +can do full approval of patches (i.e. vote +2). -In general, members of the group have some area of responsibility in the MAINTAINERS file, +In general, members of the group have some area of responsibility in the +`MAINTAINERS <https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/main/MAIN…>`_ file, and are automatically added as reviewers to patches when the patch touches this area. The responsibilities are the following. @@ -31,7 +33,8 @@ "flashrom developers" group =========================== -Members of the group can merge patches. +Members of the group (see `flashrom developers <https://review.coreboot.org/admin/groups/db95ce11b379445ac8c5806ea0b6119555…>`_) +can merge patches. The responsibilities for the members of the group are described in more details below. There is no expectation on how much time you spend on your duties, some non-zero amount of time, -- To view, visit https://review.coreboot.org/c/flashrom/+/80765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I493db8c7b2610076136d439e172e3f2cee971346 Gerrit-Change-Number: 80765 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[main]: fmap: Update major/minor version check
by Anastasia Klimchuk (Code Review) 01 Mar '24

01 Mar '24

Attention is currently required from: Brian Norris. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79060?usp=email ) Change subject: fmap: Update major/minor version check ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/79060/comment/58eb0f9d_06d27983 : PS2, Line 9: It's not valid to separately check the major and minor versions. The : proper minor check would be something like: : : if (fmap->ver_major == FMAP_VER_MAJOR && : fmap->ver_minor > FMAP_VER_MINOR) Brian, thank you so much for lots of details and links, this is really cool! I thought more about it, and I think the patch is fine, please don't drop it :) However, I found one gem in cbfstool code , which is a comment for the `is_valid_fmap` function, /* Make a best-effort assessment if the given fmap is real */ If you could add this comment to the functions, that would be it! Thank you! > I still think it's bad to leave flashrom as it is This is so nice of you, I appreciate a lot! -- To view, visit https://review.coreboot.org/c/flashrom/+/79060?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I984835579d3b257a2462906f1f5091b179891bd0 Gerrit-Change-Number: 79060 Gerrit-PatchSet: 2 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Brian Norris <briannorris(a)chromium.org> Gerrit-Comment-Date: Fri, 01 Mar 2024 08:35:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Brian Norris <briannorris(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: serprog: clean up documentation
by Anastasia Klimchuk (Code Review) 01 Mar '24

01 Mar '24

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80499?usp=email ) Change subject: serprog: clean up documentation ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > you can cc me on that, but no promises. this .rst thing is new to me anyway. sure I understand! I was going to do .rst thing (formatting, images, ref links etc), so that you can maybe read the text and see if it still looks correct, or updates needed. And one half of serprog documentation you read and updated already! (which is this patch!) I will copy the content of serprog-protocol and add formatting. > if its side by side with categories "developers" and "users" my intuitive interpretation of the word "programmers" might not be the one intended. That's a useful feedback, and meanwhile I got an idea #3 of "Supported hardware" as a top item and then Programmers inside. Anyways that will be my task, I will decide on something. thank you so much for help! -- To view, visit https://review.coreboot.org/c/flashrom/+/80499?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic83e7fd80840f2db0b006935a964721da0388068 Gerrit-Change-Number: 80499 Gerrit-PatchSet: 4 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Mar 2024 07:21:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Riku Viitanen <riku.viitanen(a)protonmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2024