May 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Thomas Heijligen (Code Review) 16 May '23

16 May '23

Attention is currently required from: Miklós Márton, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270 ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... Patch Set 1: (1 comment) File doc/dev_guide/building_from_source.rst: https://review.coreboot.org/c/flashrom/+/75270/comment/4772fdbe_9b92a5ff PS1, Line 92: for **32-bit**. Add ``-Dprogrammer=ni845x_spi`` to your meson configuration. > I know that the Makefile build is planned to be deprecated, but would not be useful to add an exampl […] We've the plan to move the make related build instructions in a separate document. See CB:75125. This might be the best place. What do you think? -- To view, visit https://review.coreboot.org/c/flashrom/+/75270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 16 May 2023 17:31:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ni845x_spi: refactor singleton states into reentrant pattern
by Miklós Márton (Code Review) 16 May '23

16 May '23

Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72160 ) Change subject: ni845x_spi: refactor singleton states into reentrant pattern ...................................................................... Patch Set 3: (5 comments) File ni845x_spi.c: https://review.coreboot.org/c/flashrom/+/72160/comment/9e395d63_d624c7df PS3, Line 432: const struct ni845x_spi_data *data = flash->mst->spi.data; I think data shall not be const here. See comments below. https://review.coreboot.org/c/flashrom/+/72160/comment/2b4414b5_df4dd392 PS3, Line 456: &io_voltage_in_mV, The io_voltage_in_mV is not defined anymore. data->io_voltage_in_mV is intended to be used here if I am not mistaken. https://review.coreboot.org/c/flashrom/+/72160/comment/001dbd6f_fc7c4c5a PS3, Line 481: &io_voltage_in_mV, Same as in line 456 https://review.coreboot.org/c/flashrom/+/72160/comment/f08e2e7d_4c961ca7 PS3, Line 566: unsigned char CS_number; The CS_number shall be initialized with 0, io_voltage_in_mV could be removed. https://review.coreboot.org/c/flashrom/+/72160/comment/1231fa59_611159a8 PS3, Line 635: data->io_voltage_in_mV = io_voltage_in_mV; data->io_voltage_in_mV = requested_io_voltage_mV; was intended I think. -- To view, visit https://review.coreboot.org/c/flashrom/+/72160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I45fcb8e20582cb0c532c4a9f0c78543a25f8d484 Gerrit-Change-Number: 72160 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 16 May 2023 17:11:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ni845x_spi: handle errors using goto during initialization
by Miklós Márton (Code Review) 16 May '23

16 May '23

Attention is currently required from: Alexander Goncharov. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72156 ) Change subject: ni845x_spi: handle errors using goto during initialization ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Rebased on master (to fix mingw build), and fixed the variable name shadowing of 72154 and it works ok. -- To view, visit https://review.coreboot.org/c/flashrom/+/72156 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie9620d59db229729fd8523f99b0917d938bcc4ed Gerrit-Change-Number: 72156 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 16 May 2023 16:57:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ni845x_spi: pass global state through func params
by Miklós Márton (Code Review) 16 May '23

16 May '23

Attention is currently required from: Alexander Goncharov. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72154 ) Change subject: ni845x_spi: pass global state through func params ...................................................................... Patch Set 5: (1 comment) File ni845x_spi.c: https://review.coreboot.org/c/flashrom/+/72154/comment/a944b7f7_22f0ffdd PS5, Line 131: static int32 ni845x_spi_open_resource(char *resource_handle, uInt32 *opened_handle, enum USB845x_type device_pid) The compilation fails with: declaration of 'device_pid' shadows a global declaration [-Werror=shadow] I would vote for renaming the parameter to simply pid. -- To view, visit https://review.coreboot.org/c/flashrom/+/72154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Gerrit-Change-Number: 72154 Gerrit-PatchSet: 5 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 16 May 2023 16:39:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add build instructions for NI-845x on Windows
by Miklós Márton (Code Review) 16 May '23

16 May '23

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270 ) Change subject: doc: Add build instructions for NI-845x on Windows ...................................................................... Patch Set 1: (1 comment) File doc/dev_guide/building_from_source.rst: https://review.coreboot.org/c/flashrom/+/75270/comment/bdd6cf9e_488a4490 PS1, Line 92: for **32-bit**. Add ``-Dprogrammer=ni845x_spi`` to your meson configuration. I know that the Makefile build is planned to be deprecated, but would not be useful to add an example make command like make HAS_LIB_NI845X=yes CONFIG_NI845X=yes just to ease the building users. -- To view, visit https://review.coreboot.org/c/flashrom/+/75270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a Gerrit-Change-Number: 75270 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 16 May 2023 16:16:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Makefile: Simplify the NI-845X detection
by Miklós Márton (Code Review) 16 May '23

16 May '23

Attention is currently required from: Nico Huber, Miklós Márton, Thomas Heijligen. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75234 ) Change subject: Makefile: Simplify the NI-845X detection ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/75234/comment/c5e5069f_adb16d4c PS2, Line 217: DIR > That's the broken part, btw. In theory the flashrom-stable Makefile should be working. Well the actual problematic line was in this one: https://review.coreboot.org/c/flashrom/+/75234/2/Makefile#b226 The $(if NI854_X86_LIBRARY_PATH, -L${NI854_X86_LIBRARY_PATH}) expression appended an extra -L which caused linker failure. I personally doubt that NI will ever release a 64 bit NI-845x or change the installation path, but if they ever will it is easily going to be possible to use the modified installation path with the CONFIG_NI845X_LIBRARY_PATH. -- To view, visit https://review.coreboot.org/c/flashrom/+/75234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2115c30d0884e35eb549a31beef04d966ba4f491 Gerrit-Change-Number: 75234 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 16 May 2023 16:13:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Makefile: Simplify the NI-845X detection
by Nico Huber (Code Review) 16 May '23

16 May '23

Attention is currently required from: Miklós Márton, Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75234 ) Change subject: Makefile: Simplify the NI-845X detection ...................................................................... Patch Set 2: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/75234/comment/f9551fd5_222aa170 PS2, Line 217: DIR That's the broken part, btw. In theory the flashrom-stable Makefile should be working. -- To view, visit https://review.coreboot.org/c/flashrom/+/75234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2115c30d0884e35eb549a31beef04d966ba4f491 Gerrit-Change-Number: 75234 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 16 May 2023 14:36:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable.c: Drop `_LARGEFILE64_SOURCE`
by Nico Huber (Code Review) 16 May '23

16 May '23

Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk, Alexander Goncharov. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75271 ) Change subject: chipset_enable.c: Drop `_LARGEFILE64_SOURCE` ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/75271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I866cfa2f996eeea5846e5d9189647ad7a4a4e3e4 Gerrit-Change-Number: 75271 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 16 May 2023 13:35:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable.c: Drop `_LARGEFILE64_SOURCE`
by Angel Pons (Code Review) 16 May '23

16 May '23

Attention is currently required from: Nico Huber, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75271 ) Change subject: chipset_enable.c: Drop `_LARGEFILE64_SOURCE` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > As far as I know, this macro provides functions capable of handling 64-bit file sizes/offsets. […] As you said, file handling is done in a different file, where the macro isn't present. -- To view, visit https://review.coreboot.org/c/flashrom/+/75271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I866cfa2f996eeea5846e5d9189647ad7a4a4e3e4 Gerrit-Change-Number: 75271 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 16 May 2023 13:13:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add README.rst to sphinx docs
by Angel Pons (Code Review) 16 May '23

16 May '23

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75300 ) Change subject: MAINTAINERS: Add README.rst to sphinx docs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie4050f0a6f2da87d2f83edd4f7483b9314d6c7f7 Gerrit-Change-Number: 75300 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 16 May 2023 13:11:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023