May 2023 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: flashrom: Update 'sb600' references to 'amd'
by Martin Roth (Code Review) 19 May '23

19 May '23

Attention is currently required from: Martin L Roth, Thomas Heijligen, Anastasia Klimchuk. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74953 ) Change subject: flashrom: Update 'sb600' references to 'amd' ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Is there a chance to have a run on hardware for this programmer? We don't have unit tests for it, an […] Sure, I can set something up to test it on various chipsets. -- To view, visit https://review.coreboot.org/c/flashrom/+/74953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1200ef25b6765f809c754ae0adcdcfe680c202fd Gerrit-Change-Number: 74953 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 19 May 2023 08:20:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom: rename sb600spi.c to amd_spi.c
by Martin Roth (Code Review) 19 May '23

19 May '23

Attention is currently required from: Martin L Roth, Thomas Heijligen, Angel Pons, Arthur Heymans, Anastasia Klimchuk. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74952 ) Change subject: flashrom: rename sb600spi.c to amd_spi.c ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Given that "sb600_spi" actually supports more chipsets than just sb600, it makes sense to remove "sb […] Yes, I was planning on doing a bunch more. This is just the first set of patches. I wasn't aware of the amd_spi100.c plan when I did this though. My main complaint is that the file isn't SB600 specific, so that name doesn't make sense to me. If others have thoughts, I'm glad to help with whatever is desired. amd_chipsets.c maybe? -- To view, visit https://review.coreboot.org/c/flashrom/+/74952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13859de27e602cc6496684e6cb66b2dc2e21531a Gerrit-Change-Number: 74952 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 19 May 2023 08:19:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: programmer: Use correct type for flashbase
by Martin Roth (Code Review) 19 May '23

19 May '23

Attention is currently required from: Edward O'Callaghan. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75328 ) Change subject: programmer: Use correct type for flashbase ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > Martin does this solves the issue you spotted? Yes, this works. Thank you. -- To view, visit https://review.coreboot.org/c/flashrom/+/75328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9057e438731b9cccde0e24d5c8f758c3af1d47f Gerrit-Change-Number: 75328 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Fri, 19 May 2023 08:15:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson_options.txt: Unquote true
by Anastasia Klimchuk (Code Review) 19 May '23

19 May '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/75149 ) Change subject: meson_options.txt: Unquote true ...................................................................... meson_options.txt: Unquote true Meson 1.1.0 deprecates the translation from 'true' to true and 'false' to false in the boolean typed option. Remove the quotes to keep compatible with newer meson versions. https://mesonbuild.com/Release-notes-for-1-1-0.html#coercing-values-in-the-… Change-Id: Ib3a46112678098ff3b2e92c44cf4539089216106 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/75149 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M meson_options.txt 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/meson_options.txt b/meson_options.txt index 91d3045..732d8d52 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -5,7 +5,7 @@ option('ich_descriptors_tool', type : 'feature', value : 'auto', description : 'Build ich_descriptors_tool') option('bash_completion', type : 'feature', value : 'auto', description : 'Install bash completion') option('tests', type : 'feature', value : 'auto', description : 'Build unit tests') -option('use_internal_dmi', type : 'boolean', value : 'true') +option('use_internal_dmi', type : 'boolean', value : true) option('programmer', type : 'array', value : ['auto'], choices : [ 'auto', 'all', 'group_internal', 'group_external', -- To view, visit https://review.coreboot.org/c/flashrom/+/75149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib3a46112678098ff3b2e92c44cf4539089216106 Gerrit-Change-Number: 75149 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: programmer: Use correct type for flashbase
by Anastasia Klimchuk (Code Review) 19 May '23

19 May '23

Attention is currently required from: Edward O'Callaghan, Martin Roth. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75328 ) Change subject: programmer: Use correct type for flashbase ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Martin does this solves the issue you spotted? -- To view, visit https://review.coreboot.org/c/flashrom/+/75328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9057e438731b9cccde0e24d5c8f758c3af1d47f Gerrit-Change-Number: 75328 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 19 May 2023 08:14:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add Windows MSYS2 build instructions
by Thomas Heijligen (Code Review) 19 May '23

19 May '23

Attention is currently required from: Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75189 ) Change subject: doc: Add Windows MSYS2 build instructions ...................................................................... Patch Set 5: (1 comment) File doc/dev_guide/building_from_source.rst: https://review.coreboot.org/c/flashrom/+/75189/comment/0282847c_29a4eb0a PS3, Line 86: Then update the MSYS2 installation by running ``pacman -Syu`` multiple times. > Rather than duplicating upstream documentation in a confusing way ("multiple times" is usually not r […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/75189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I847428535547242ff32af92c4fe8477241826814 Gerrit-Change-Number: 75189 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 19 May 2023 07:38:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson.build: enable jlink_spi by default
by Thomas Heijligen (Code Review) 19 May '23

19 May '23

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75171 ) Change subject: meson.build: enable jlink_spi by default ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Just to check, if libjaylink is less than required minimum version, the programmer will be disabled […] yes. with `default : true` it is only said, that the automatic programmer selection is considering it. -- To view, visit https://review.coreboot.org/c/flashrom/+/75171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80f204de1bb26f459a38177f54a167db72003dbd Gerrit-Change-Number: 75171 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 19 May 2023 07:37:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: Add support for ni845x_spi on Windows
by Thomas Heijligen (Code Review) 19 May '23

19 May '23

Attention is currently required from: Miklós Márton, Anastasia Klimchuk, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75236 ) Change subject: meson: Add support for ni845x_spi on Windows ...................................................................... Patch Set 4: (3 comments) Patchset: PS4: > Thomas, I wanted to check, is CB:74963 still needed? This patch seems to solve the same task? (or mo […] yes, this chain fixes all ni845x problems, inclusive the changes of CB:74963 PS4: Need testing: what if the include path is not available under windows? will it just ignore the non existing path? File ni845x_spi.c: https://review.coreboot.org/c/flashrom/+/75236/comment/f737d70a_7e21632a PS4, Line 19: * Define it just here, since this driver will only work on 32-bit Windows. > Does it make any more sense to make the build system define this? I believe NI assume that you're bu […] I've to dig deeper into this macro to figure out when it's set from the compiler. But I would move this to an other patchset. -- To view, visit https://review.coreboot.org/c/flashrom/+/75236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973 Gerrit-Change-Number: 75236 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 19 May 2023 07:34:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: programmer: Use correct type for flashbase
by Edward O'Callaghan (Code Review) 19 May '23

19 May '23

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75328 ) Change subject: programmer: Use correct type for flashbase ...................................................................... programmer: Use correct type for flashbase The flashbase is a machine-sized integer representation of address space and so use the appropriate type that is correctly sized to encode such data. Spotted-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Change-Id: Ib9057e438731b9cccde0e24d5c8f758c3af1d47f Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M include/programmer.h 2 files changed, 18 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/28/75328/1 diff --git a/flashrom.c b/flashrom.c index 19afb54..b6e5cf8 100644 --- a/flashrom.c +++ b/flashrom.c @@ -21,6 +21,7 @@ #include <stdbool.h> #include <stdio.h> +#include <stdint.h> #include <sys/types.h> #include <string.h> #include <unistd.h> @@ -48,7 +49,7 @@ struct decode_sizes max_rom_decode; /* If nonzero, used as the start address of bottom-aligned flash. */ -unsigned long flashbase; +uintptr_t flashbase; /* Is writing allowed with this programmer? */ bool programmer_may_write; diff --git a/include/programmer.h b/include/programmer.h index 5b304f5..562f58a 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -292,7 +292,7 @@ // FIXME: These need to be local, not global extern struct decode_sizes max_rom_decode; extern bool programmer_may_write; -extern unsigned long flashbase; +extern uintptr_t flashbase; /* used in programmer_enable.c */ char *extract_programmer_param_str(const struct programmer_cfg *cfg, const char *param_name); /* spi.c */ -- To view, visit https://review.coreboot.org/c/flashrom/+/75328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9057e438731b9cccde0e24d5c8f758c3af1d47f Gerrit-Change-Number: 75328 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: meson: Add support for ni845x_spi on Windows
by Peter Marheine (Code Review) 18 May '23

18 May '23

Attention is currently required from: Miklós Márton, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75236 ) Change subject: meson: Add support for ni845x_spi on Windows ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File ni845x_spi.c: https://review.coreboot.org/c/flashrom/+/75236/comment/7f16dbcf_62cd9ba6 PS4, Line 19: * Define it just here, since this driver will only work on 32-bit Windows. Does it make any more sense to make the build system define this? I believe NI assume that you're building with MSVC (which does define this symbol) so perhaps it makes more sense to let the buildsystem wrangle the library's assumptions? It's probably not an important difference given the current limited support for compilers and platforms for this driver and flashrom as a whole, but putting the define in the build configuration would make potential future portability more convenient. -- To view, visit https://review.coreboot.org/c/flashrom/+/75236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973 Gerrit-Change-Number: 75236 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 18 May 2023 23:49:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023