May 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: erasure_layout: Remove unnecessary includes
by Aarya (Code Review) 18 May '23

18 May '23

Attention is currently required from: Anastasia Klimchuk. Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75322 ) Change subject: erasure_layout: Remove unnecessary includes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6ef34273d088d8fb4559fe3d801d1247ad9b3fa2 Gerrit-Change-Number: 75322 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 18 May 2023 18:02:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable.c: Drop `_LARGEFILE64_SOURCE`
by Angel Pons (Code Review) 18 May '23

18 May '23

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75271 ) Change subject: chipset_enable.c: Drop `_LARGEFILE64_SOURCE` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Also see Nico's comment on CB:75272 > Docs (`info libc`) are quite explicit about the macro only exposing additional > functions and types with *64* in their names. manibuilder agrees too. Can we mark this as resolved? -- To view, visit https://review.coreboot.org/c/flashrom/+/75271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I866cfa2f996eeea5846e5d9189647ad7a4a4e3e4 Gerrit-Change-Number: 75271 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 18 May 2023 17:48:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: erasure_layout: Remove unnecessary includes
by Angel Pons (Code Review) 18 May '23

18 May '23

Attention is currently required from: Aarya, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75322 ) Change subject: erasure_layout: Remove unnecessary includes ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/75322/comment/3f8349bf_ce74dfe6 PS1, Line 7: Remove unnecessary includes This sounds like you're removing lines. How about "Simplify include paths" instead? -- To view, visit https://review.coreboot.org/c/flashrom/+/75322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6ef34273d088d8fb4559fe3d801d1247ad9b3fa2 Gerrit-Change-Number: 75322 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 18 May 2023 17:43:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: erasure_layout: Remove unnecessary includes
by Anastasia Klimchuk (Code Review) 18 May '23

18 May '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/75322 ) Change subject: erasure_layout: Remove unnecessary includes ...................................................................... erasure_layout: Remove unnecessary includes Header files can be found without explicitly specifying include directory on the file path. Change-Id: I6ef34273d088d8fb4559fe3d801d1247ad9b3fa2 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M erasure_layout.c 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/75322/1 diff --git a/erasure_layout.c b/erasure_layout.c index 108fea4..c9ac44b 100644 --- a/erasure_layout.c +++ b/erasure_layout.c @@ -20,9 +20,9 @@ #include <limits.h> #include <string.h> -#include "include/flash.h" -#include "include/layout.h" -#include "include/erasure_layout.h" +#include "flash.h" +#include "layout.h" +#include "erasure_layout.h" static size_t calculate_block_count(const struct flashchip *chip, size_t eraser_idx) { -- To view, visit https://review.coreboot.org/c/flashrom/+/75322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6ef34273d088d8fb4559fe3d801d1247ad9b3fa2 Gerrit-Change-Number: 75322 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: meson.build: enable jlink_spi by default
by Anastasia Klimchuk (Code Review) 18 May '23

18 May '23

Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75171 ) Change subject: meson.build: enable jlink_spi by default ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: Just to check, if libjaylink is less than required minimum version, the programmer will be disabled , right? -- To view, visit https://review.coreboot.org/c/flashrom/+/75171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80f204de1bb26f459a38177f54a167db72003dbd Gerrit-Change-Number: 75171 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 18 May 2023 09:12:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson.build: enable serial programmer on Windows
by Anastasia Klimchuk (Code Review) 18 May '23

18 May '23

Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75170 ) Change subject: meson.build: enable serial programmer on Windows ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie60a25a9305374f9ed84a38f2650d517ec094387 Gerrit-Change-Number: 75170 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 18 May 2023 09:11:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson_options.txt: Unquote true
by Anastasia Klimchuk (Code Review) 18 May '23

18 May '23

Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75149 ) Change subject: meson_options.txt: Unquote true ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/75149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib3a46112678098ff3b2e92c44cf4539089216106 Gerrit-Change-Number: 75149 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 18 May 2023 09:07:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: Add support for ni845x_spi on Windows
by Anastasia Klimchuk (Code Review) 18 May '23

18 May '23

Attention is currently required from: Miklós Márton, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75236 ) Change subject: meson: Add support for ni845x_spi on Windows ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Thomas, I wanted to check, is CB:74963 still needed? This patch seems to solve the same task? (or more precisely, the chain as a whole seems to solve the task) -- To view, visit https://review.coreboot.org/c/flashrom/+/75236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973 Gerrit-Change-Number: 75236 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 18 May 2023 09:06:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable.c: Drop `_LARGEFILE64_SOURCE`
by Angel Pons (Code Review) 17 May '23

17 May '23

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75271 ) Change subject: chipset_enable.c: Drop `_LARGEFILE64_SOURCE` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > How does it work in `hwaccess_x86_msr. […] See commit d54958a3c4724746feb3f721002d056afccd83aa, it used `lseek64()`. This code got rewritten so `lseek64()` is no longer used. -- To view, visit https://review.coreboot.org/c/flashrom/+/75271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I866cfa2f996eeea5846e5d9189647ad7a4a4e3e4 Gerrit-Change-Number: 75271 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 17 May 2023 14:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: README: Extract instructions for meson and make into separate docs
by Anastasia Klimchuk (Code Review) 17 May '23

17 May '23

Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75125 ) Change subject: README: Extract instructions for meson and make into separate docs ...................................................................... Patch Set 3: (2 comments) Commit Message: PS2: > This one is not out of date and should be adapted to the new content of the patch Done (I assume you meant to say "not up to date") File doc/dev_guide/building_from_source.rst: https://review.coreboot.org/c/flashrom/+/75125/comment/cd8620d1_5d75befb PS2, Line 249: To install into a different directory use DESTDIR, like this:: > You can also set the prefix during configuration with `meson setup --prefix <DESTDIR> ... […] Done (added to doc) -- To view, visit https://review.coreboot.org/c/flashrom/+/75125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d5900538d54c43efcc8c5b7010df5d867f3b190 Gerrit-Change-Number: 75125 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 17 May 2023 12:04:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023