April 2023 - flashrom-gerrit - mail.coreboot.org

[L] Change in flashrom[master]: cli_classic: include a fallback inplementation of getopt
by Thomas Heijligen (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Edward O'Callaghan, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73102 ) Change subject: cli_classic: include a fallback inplementation of getopt ...................................................................... Patch Set 10: (1 comment) Patchset: PS1: > Better now? Done -- To view, visit https://review.coreboot.org/c/flashrom/+/73102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6ebbde075014e3b45b0f9e04b34b72aa969e1197 Gerrit-Change-Number: 73102 Gerrit-PatchSet: 10 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Apr 2023 05:45:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Convert build documentation to sphinx
by Anastasia Klimchuk (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Thomas Heijligen, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 ) Change subject: doc: Convert build documentation to sphinx ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Patchset: PS9: > Anything blocking you from merging your work Thomas? I think Thomas will get back from vacation and merge! :) -- To view, visit https://review.coreboot.org/c/flashrom/+/73359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324 Gerrit-Change-Number: 73359 Gerrit-PatchSet: 9 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Apr 2023 03:54:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Convert build documentation to sphinx
by Edward O'Callaghan (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Thomas Heijligen, Stefan Reinauer. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 ) Change subject: doc: Convert build documentation to sphinx ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: Anything blocking you from merging your work Thomas? -- To view, visit https://review.coreboot.org/c/flashrom/+/73359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324 Gerrit-Change-Number: 73359 Gerrit-PatchSet: 9 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Apr 2023 03:45:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: usb_device.c: detach/attach usb kernel driver explicitly
by Edward O'Callaghan (Code Review) 07 Apr '23

07 Apr '23

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67073 ) Change subject: usb_device.c: detach/attach usb kernel driver explicitly ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1363fea13368b7ac1e9a3829864d06d123c4e157 Gerrit-Change-Number: 67073 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Apr 2023 03:44:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: MAINTAINERS: Remove Felix Singer
by Felix Singer (Code Review) 06 Apr '23

06 Apr '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/74274 ) Change subject: MAINTAINERS: Remove Felix Singer ...................................................................... MAINTAINERS: Remove Felix Singer I haven't worked on flashrom in the last months and I'm also not planning to continue working on it again. So I'm removing myself from the maintainers file since I'm not maintaining anymore. Items, which become unmaintained, are removed. Change-Id: I33903c4e38a24e6bf3cb233d28b297d1fa3716a9 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/flashrom/+/74274 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M MAINTAINERS 1 file changed, 18 insertions(+), 11 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/MAINTAINERS b/MAINTAINERS index 294597c..e66b08d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -114,7 +114,6 @@ ################################################################################ MAINTAINERS -M: Felix Singer <felixsinger(a)posteo.net> M: Anastasia Klimchuk <aklm(a)chromium.org> S: Maintained F: MAINTAINERS @@ -184,17 +183,7 @@ S: Maintained F: util/flashrom.bash-completion.tmpl -TEST BUILD SCRIPT -M: Felix Singer <felixsinger(a)posteo.net> -S: Supported -F: test_build.sh - FLASHROM TESTER R: Evan Benn <evanbenn(a)gmail.com> S: Supported F: util/flashrom_tester/ - -NIX SHELL -M: Felix Singer <felixsinger(a)posteo.net> -S: Maintained -F: util/shell.nix -- To view, visit https://review.coreboot.org/c/flashrom/+/74274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I33903c4e38a24e6bf3cb233d28b297d1fa3716a9 Gerrit-Change-Number: 74274 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: MAINTAINERS: Remove Felix Singer
by Felix Singer (Code Review) 06 Apr '23

06 Apr '23

Attention is currently required from: Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74274 ) Change subject: MAINTAINERS: Remove Felix Singer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/74274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I33903c4e38a24e6bf3cb233d28b297d1fa3716a9 Gerrit-Change-Number: 74274 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 06 Apr 2023 19:53:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: MAINTAINERS: Remove Felix Singer
by Felix Singer (Code Review) 06 Apr '23

06 Apr '23

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/74274 ) Change subject: MAINTAINERS: Remove Felix Singer ...................................................................... MAINTAINERS: Remove Felix Singer I haven't worked on flashrom in the last months and I'm also not planning to continue working on it again. So I'm removing myself from the maintainers file since I'm not maintaining anymore. Items, which become unmaintained, are removed. Change-Id: I33903c4e38a24e6bf3cb233d28b297d1fa3716a9 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M MAINTAINERS 1 file changed, 16 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/74274/1 diff --git a/MAINTAINERS b/MAINTAINERS index 294597c..e66b08d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -114,7 +114,6 @@ ################################################################################ MAINTAINERS -M: Felix Singer <felixsinger(a)posteo.net> M: Anastasia Klimchuk <aklm(a)chromium.org> S: Maintained F: MAINTAINERS @@ -184,17 +183,7 @@ S: Maintained F: util/flashrom.bash-completion.tmpl -TEST BUILD SCRIPT -M: Felix Singer <felixsinger(a)posteo.net> -S: Supported -F: test_build.sh - FLASHROM TESTER R: Evan Benn <evanbenn(a)gmail.com> S: Supported F: util/flashrom_tester/ - -NIX SHELL -M: Felix Singer <felixsinger(a)posteo.net> -S: Maintained -F: util/shell.nix -- To view, visit https://review.coreboot.org/c/flashrom/+/74274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I33903c4e38a24e6bf3cb233d28b297d1fa3716a9 Gerrit-Change-Number: 74274 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[L] Change in flashrom[master]: cli_classic: refactor arguments parsing into separate func
by Alexander Goncharov (Code Review) 06 Apr '23

06 Apr '23

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66343 ) Change subject: cli_classic: refactor arguments parsing into separate func ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: The patch is ready for your review :) -- To view, visit https://review.coreboot.org/c/flashrom/+/66343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id573bc74e3bb46b7dc42f1452fff6394d4f091bc Gerrit-Change-Number: 66343 Gerrit-PatchSet: 8 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 06 Apr 2023 13:46:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom: rewrite flashbuses_to_text()
by Alexander Goncharov (Code Review) 06 Apr '23

06 Apr '23

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73039 ) Change subject: flashrom: rewrite flashbuses_to_text() ...................................................................... Patch Set 6: (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/73039/comment/7f242791_a8db8939 PS5, Line 948: if (bustype & (1 << i)) > Oh that my question was a silly one, sorry. […] Came back with fresh ideas, I see that it's possible to use a struct: ``` struct bus_type_info { enum chipbustype type; const char *name; }; static const struct bus_type_info bustypes[] = { { BUS_PARALLEL, "Parallel, " }, { BUS_LPC, "LPC, " }, { BUS_FWH, "FWH, " }, { BUS_SPI, "SPI, " }, { BUS_PROG, "Programmer-specific, " }, }; ``` And then: ``` for (unsigned int i = 0; i < ARRAY_SIZE(bustypes); i++) { if (bustype & bustypes[i].type) { ... } } ``` Looks like it resolves the problem that you mentioned. Do you think that's an appropriate implementation? -- To view, visit https://review.coreboot.org/c/flashrom/+/73039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I59b9044c99b4ba6c00d8c97f1e91af09d70dce2c Gerrit-Change-Number: 73039 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 06 Apr 2023 13:42:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: [WAIT FOR CB:73822]doc: Convert README to sphinx
by Thomas Heijligen (Code Review) 06 Apr '23

06 Apr '23

Attention is currently required from: Stefan Reinauer, Anastasia Klimchuk, Alexander Goncharov. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74216 ) Change subject: [WAIT FOR CB:73822]doc: Convert README to sphinx ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: the README can stay in the top level directory. The index page (first page in sphinx) include this (see doc/index.rst). You can add an .rst suffix to make it clear which formating is used. -- To view, visit https://review.coreboot.org/c/flashrom/+/74216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6e0debc0e15a9c4866f6d16fb010cd3f13171ff3 Gerrit-Change-Number: 74216 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 06 Apr 2023 06:10:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2023