Attention is currently required from: Edward O'Callaghan.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67480 )
Change subject: spi: Make 'default_spi_send_command' the default unless defined
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Patchset:
PS1:
> I totally agree with the second sentence however for the first, is this not just a stepping stone to […]
Ack
--
To view, visit https://review.coreboot.org/c/flashrom/+/67480
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I63abcb8c64f233cdbf58a149a31051fa648305a2
Gerrit-Change-Number: 67480
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Wed, 22 Feb 2023 23:23:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: comment
ChrisEric1 CECL has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/72058 )
Change subject: Add support for AMD Ryzen flashing
......................................................................
Abandoned
See last comment
--
To view, visit https://review.coreboot.org/c/flashrom/+/72058
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ife51f7dec31b51a7416e417112b0eedb21fae6a0
Gerrit-Change-Number: 72058
Gerrit-PatchSet: 9
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: abandon
Attention is currently required from: Arthur Heymans, Nicholas Chin.
ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72058 )
Change subject: Add support for AMD Ryzen flashing
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
And so apparently I was completely wrong. It does hang (progress bar doesn't show until finished) but it still works after a while. Not sure why the one has it but the YANGTZE one doesn't, but even https://en.wikichip.org/wiki/amd/ryzen_3/2200g says my CPU is PROMONTORY, see my logs here: (PROMONTORY): https://raw.githubusercontent.com/CE1CECL/TempFiles/main/HPP590.LOG0 & (YANGTZE): https://raw.githubusercontent.com/CE1CECL/TempFiles/main/HPP590.LOG1 I even put my dumps in the repo for both and diff'd them, both didn't differ.
--
To view, visit https://review.coreboot.org/c/flashrom/+/72058
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ife51f7dec31b51a7416e417112b0eedb21fae6a0
Gerrit-Change-Number: 72058
Gerrit-PatchSet: 9
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 21:12:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Nicholas Chin.
Hello build bot (Jenkins), Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/72058
to look at the new patch set (#9).
Change subject: Add support for AMD Ryzen flashing
......................................................................
Add support for AMD Ryzen flashing
Tested AMD Ryzen Support on HP Pavilion 590-p0077c, I am able to flash
using F.15 or older, but I can downgrade if a newer Firmware is
installed using afuwinx64 which is a vendor tool This is due to
flashrom SPI lockdown on newer firmwares by HP. It seems HP UEFI Diags
uses AFU Flash embedded in. It also comes with a AMD Ryzen 3 2200G with
16MB, so it may not work with chips more that 16MB, it is currently
untested by me, since this is the only AMD PC I own.
Change-Id: Ife51f7dec31b51a7416e417112b0eedb21fae6a0
Signed-off-by: Christopher Lentocha <christopherericlentocha(a)gmail.com>
---
0 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/58/72058/9
--
To view, visit https://review.coreboot.org/c/flashrom/+/72058
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ife51f7dec31b51a7416e417112b0eedb21fae6a0
Gerrit-Change-Number: 72058
Gerrit-PatchSet: 9
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: ChrisEric1 CECL.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73059 )
Change subject: Fix RPi4 VL805 USB controller flashing for W25X10 chips to RDID4
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
> With RDID4: https://gist.github.com/CE1CECL/fc67d51777d1d20b4d849227d2da8b30 […]
Thanks for the logs. I've found an issue with the programmer. The chip entry is correct.
--
To view, visit https://review.coreboot.org/c/flashrom/+/73059
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I346a8292eb345fcdbadcf0e09729a55f411c83e3
Gerrit-Change-Number: 73059
Gerrit-PatchSet: 1
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 16:07:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: comment
Attention is currently required from: ChrisEric1 CECL.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB controller flashing
......................................................................
Patch Set 23: -Code-Review
(1 comment)
Patchset:
PS23:
I found the problem with your chip. The code fails when readcnt != 4
That's the reason why it only recognize your chip with the RDID4 patch.
I'll have a deeper look into the flashing process.
--
To view, visit https://review.coreboot.org/c/flashrom/+/72057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Gerrit-Change-Number: 72057
Gerrit-PatchSet: 23
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha(a)gmail.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 13:35:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72609 )
Change subject: jedec.c: Move probe_timings decode into sep func
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS4:
> it would be good to add a rationale to the commit message
done.
--
To view, visit https://review.coreboot.org/c/flashrom/+/72609
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I638518cd537954172eb774f6d15af0db7e06d1ba
Gerrit-Change-Number: 72609
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 22 Feb 2023 08:06:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: comment
Attention is currently required from: Edward O'Callaghan.
Hello build bot (Jenkins), Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/72609
to look at the new patch set (#5).
Change subject: jedec.c: Move probe_timings decode into sep func
......................................................................
jedec.c: Move probe_timings decode into sep func
The chip data structure packed from the flashchips db
should have the probe_timing field decoded by its own
function.
Change-Id: I638518cd537954172eb774f6d15af0db7e06d1ba
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M jedec.c
1 file changed, 33 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/72609/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/72609
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I638518cd537954172eb774f6d15af0db7e06d1ba
Gerrit-Change-Number: 72609
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newpatchset