Attention is currently required from: Stefan Reinauer, Thomas Heijligen.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72607 )
Change subject: jedec.c: Move printlock stuff into printlock.c
......................................................................
Patch Set 2:
(1 comment)
File printlock.c:
https://review.coreboot.org/c/flashrom/+/72607/comment/bab24b5c_714718a5
PS1, Line 4: * Copyright (C) 2000 Silicon Integrated System Corporation
: * Copyright (C) 2006 Giampiero Giancipoli <gianci(a)email.it>
: * Copyright (C) 2006 coresystems GmbH <info(a)coresystems.de>
: * Copyright (C) 2007-2012 Carl-Daniel Hailfinger
: * Copyright (C) 2009 Sean Nelson <audiohacked(a)gmail.com>
: * Copyright (C) 2014 Stefan Tauner
> Is this list correct for this new file?
honestly no idea.
--
To view, visit https://review.coreboot.org/c/flashrom/+/72607
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iacaa16c81e141aac30feb6871700c4fdc9eec8e9
Gerrit-Change-Number: 72607
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Wed, 01 Feb 2023 02:13:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: comment
Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/72632 )
Change subject: jedec.c: Use JEDEC_ define from spi.h over magic
......................................................................
Abandoned
dont worry about it
--
To view, visit https://review.coreboot.org/c/flashrom/+/72632
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id0c98ee900e37c26dc06f96a9950713f332240fd
Gerrit-Change-Number: 72632
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/72630 )
Change subject: jedec.c: Make programer_delay() usage symetrical
......................................................................
Abandoned
probably wrong.
--
To view, visit https://review.coreboot.org/c/flashrom/+/72630
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia8c22914bc14d39716fb2f82f0b8394edc1cae7f
Gerrit-Change-Number: 72630
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72502 )
Change subject: jedec.c: Consolidate op,operand sequencing into func
......................................................................
Patch Set 5:
(1 comment)
File jedec.c:
https://review.coreboot.org/c/flashrom/+/72502/comment/24bcf3ac_16db0e8b
PS4, Line 325: toggle_ready_jedec_slow(flash, bios);
> It seems that toggle_jedec_slow could dereference flash->virtual_memory itself here.
done here https://review.coreboot.org/c/flashrom/+/72691/1
--
To view, visit https://review.coreboot.org/c/flashrom/+/72502
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9a1b211b49777f6d7f62a052975c1759e036c8df
Gerrit-Change-Number: 72502
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 01 Feb 2023 01:41:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: comment
Attention is currently required from: Edward O'Callaghan.
Hello build bot (Jenkins), Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/72630
to look at the new patch set (#4).
Change subject: jedec.c: Make programer_delay() usage symetrical
......................................................................
jedec.c: Make programer_delay() usage symetrical
Change-Id: Ia8c22914bc14d39716fb2f82f0b8394edc1cae7f
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M jedec.c
1 file changed, 17 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/72630/4
--
To view, visit https://review.coreboot.org/c/flashrom/+/72630
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia8c22914bc14d39716fb2f82f0b8394edc1cae7f
Gerrit-Change-Number: 72630
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Edward O'Callaghan.
Hello build bot (Jenkins), Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/72632
to look at the new patch set (#2).
Change subject: jedec.c: Use JEDEC_ define from spi.h over magic
......................................................................
jedec.c: Use JEDEC_ define from spi.h over magic
Change-Id: Id0c98ee900e37c26dc06f96a9950713f332240fd
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M jedec.c
1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/72632/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/72632
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id0c98ee900e37c26dc06f96a9950713f332240fd
Gerrit-Change-Number: 72632
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newpatchset