October 2023 - flashrom-gerrit

[S] Change in flashrom[main]: ichspi: Add support for C740 PCH
by Patrick Georgi (Code Review) 11 Oct '23

11 Oct '23

Attention is currently required from: Patrick Rudolph. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78186?usp=email ) Change subject: ichspi: Add support for C740 PCH ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Besides the issue Kyösti pointed out, this looks reasonable. -- To view, visit https://review.coreboot.org/c/flashrom/+/78186?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I80eebc0fcc14de9df823aceaee77870ad136f94a Gerrit-Change-Number: 78186 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Oct 2023 09:26:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: ichspi: Add support for C740 PCH
by Kyösti Mälkki (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Patrick Rudolph. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78186?usp=email ) Change subject: ichspi: Add support for C740 PCH ...................................................................... Patch Set 1: (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/78186/comment/9a7a6b03_62046655 : PS1, Line 1032: if (content->ISL == 0x50) That's 80 in decimal and is hit with <= 80 above? -- To view, visit https://review.coreboot.org/c/flashrom/+/78186?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I80eebc0fcc14de9df823aceaee77870ad136f94a Gerrit-Change-Number: 78186 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 10:12:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: flashchips: Add write-protect support for MXIC MX25U25643G
by Anastasia Klimchuk (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen, rogeryou. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78142?usp=email ) Change subject: flashchips: Add write-protect support for MXIC MX25U25643G ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/78142?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Gerrit-Change-Number: 78142 Gerrit-PatchSet: 5 Gerrit-Owner: rogeryou Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: rogeryou Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 05:42:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: flashchips: Add write-protect support for MXIC MX25U25643G
by rogeryou (Code Review) 07 Oct '23

07 Oct '23

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/78142?usp=email to look at the new patch set (#5). Change subject: flashchips: Add write-protect support for MXIC MX25U25643G ...................................................................... flashchips: Add write-protect support for MXIC MX25U25643G The MX25U25643G has a WPSEL bit in the security register, but the MX25U25635F does not. Therefore, take them apart. We have tested --wp-enable, --wp-disable, --wp-list and --wp-range commands for write-protect feature. The MX25U25643G has been tested by ch341a programmer : read, write, erase and wp. MX25U25643G datasheet is available at the following URL: https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… MX25U25635F datasheet is available at the following URL: https://www.macronix.com/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/sp… Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Signed-off-by: rogeryou <rogeryou(a)mxic.com.cn> --- M flashchips.c 1 file changed, 58 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/78142/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/78142?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Gerrit-Change-Number: 78142 Gerrit-PatchSet: 5 Gerrit-Owner: rogeryou Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: flashchips: Add write-protect support for MXIC MX25U25643G
by rogeryou (Code Review) 07 Oct '23

07 Oct '23

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen. rogeryou has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78142?usp=email ) Change subject: flashchips: Add write-protect support for MXIC MX25U25643G ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/78142/comment/ca23a22a_b57abdb6 : PS2, Line 7: Test MXIC MX25U25643G wp > replace with: […] Done File flashchips.c: https://review.coreboot.org/c/flashrom/+/78142/comment/dfaed97e_940a231b : PS2, Line 10308: STATUS2 > Should this be CONFIG ? TB bit is defined in configuration register (Table 8). […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/78142?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Gerrit-Change-Number: 78142 Gerrit-PatchSet: 4 Gerrit-Owner: rogeryou Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 07 Oct 2023 06:53:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: flashchips: Add write-protect support for MXIC MX25U25643G
by rogeryou (Code Review) 07 Oct '23

07 Oct '23

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/78142?usp=email to look at the new patch set (#4). Change subject: flashchips: Add write-protect support for MXIC MX25U25643G ...................................................................... flashchips: Add write-protect support for MXIC MX25U25643G The MX25U25643G has a WPSEL bit in the security register, but the MX25U25635F does not. Therefore, take them apart. The MX25U25643G has been tested by ch341a programmer : read, write, erase and wp. The MX25U25643G has been tested by ch341a programmer : read, write, erase and wp. MX25U25643G datasheet is available at the following URL: https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… MX25U25635F datasheet is available at the following URL: https://www.macronix.com/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/sp… Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Signed-off-by: rogeryou <rogeryou(a)mxic.com.cn> --- M flashchips.c 1 file changed, 58 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/78142/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/78142?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Gerrit-Change-Number: 78142 Gerrit-PatchSet: 4 Gerrit-Owner: rogeryou Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in flashrom[main]: flashchips: Add write-protect support for MXIC MX25U25643G
by rogeryou (Code Review) 07 Oct '23

07 Oct '23

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, rogeryou. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/78142?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add write-protect support for MXIC MX25U25643G ...................................................................... flashchips: Add write-protect support for MXIC MX25U25643G The MX25U25643G has a WPSEL bit in the security register, but the MX25U25635F does not. Therefore, take them apart. The MX25U25643G has been tested by ch341a programmer : read, write, erase and wp. We have tested --wp-enable, --wp-disable, --wp-list and --wp-range commands for write-protect feature. MX25U25643G datasheet is available at the following URL: https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… MX25U25635F datasheet is available at the following URL: https://www.macronix.com/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/sp… Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Signed-off-by: rogeryou <rogeryou(a)mxic.com.cn> --- M doc/contact.rst M doc/dev_guide/development_guide.rst M doc/index.rst A doc/release_notes/index.rst A doc/release_notes/v_1_3.rst A doc/user_docs/example_partial_wp.rst A doc/user_docs/fw_updates_vs_spi_wp.rst A doc/user_docs/index.rst M flashchips.c 9 files changed, 599 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/78142/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/78142?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad Gerrit-Change-Number: 78142 Gerrit-PatchSet: 3 Gerrit-Owner: rogeryou Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: rogeryou Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[main]: doc: Make Time of Meeting more consistent
by Anastasia Klimchuk (Code Review) 07 Oct '23

07 Oct '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/78188?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: doc: Make Time of Meeting more consistent ...................................................................... doc: Make Time of Meeting more consistent Change-Id: I8b37d2913750946c71908e94fcd3041766f1b59d Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/78188 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/contact.rst 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/doc/contact.rst b/doc/contact.rst index 5bcac3f..57a9390 100644 --- a/doc/contact.rst +++ b/doc/contact.rst @@ -111,19 +111,19 @@ also known as - | Wednesday 13.00-14.00 Pacific Standard Time UTC-8 - | Wednesday 22.00-23.00 Central European Time UTC+1 - | Thursday 8.00-9.00am Australian Eastern Daylight Time UTC+11 + | Wednesday 13:00-14:00 Pacific Standard Time UTC-8 + | Wednesday 22:00-23:00 Central European Time UTC+1 + | Thursday 8:00-9:00 Australian Eastern Daylight Time UTC+11 Between April and September (inclusive) - **Thursday 6.00-7.00am UTC+0** + **Thursday 6:00-7:00 UTC+0** also known as - | Wednesday 11pm-midnight Pacific Daylight Time UTC-7 - | Thursday 8.00-9.00am Central European Summer Time UTC+2 - | Thursday 16.00-17.00 Australian Eastern Standard Time UTC+10 + | Wednesday 23:00-midnight Pacific Daylight Time UTC-7 + | Thursday 8:00-9:00 Central European Summer Time UTC+2 + | Thursday 16:00-17:00 Australian Eastern Standard Time UTC+10 The last week of March and 4 weeks of October there are no meetings This is because daylight saving time changes are happening on different dates in different locations, and setting up meeting time becomes too complicated. -- To view, visit https://review.coreboot.org/c/flashrom/+/78188?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8b37d2913750946c71908e94fcd3041766f1b59d Gerrit-Change-Number: 78188 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[main]: flashchips: Mark Atmel AT29C010A chip as tested for write operation
by Anastasia Klimchuk (Code Review) 07 Oct '23

07 Oct '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/78069?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: flashchips: Mark Atmel AT29C010A chip as tested for write operation ...................................................................... flashchips: Mark Atmel AT29C010A chip as tested for write operation As reported on the mailing list in https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/4BU4… Change-Id: I267ed5583e8a9bad0b34b12d73ab2928d65144eb Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/78069 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index db4bea6..db20cba 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2685,7 +2685,7 @@ .total_size = 128, .page_size = 128, .feature_bits = FEATURE_LONG_RESET, - .tested = TEST_OK_PRE, + .tested = TEST_OK_PREW, .probe = PROBE_JEDEC, .probe_timing = 10000, /* 10mS, Enter=Exec */ .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/78069?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I267ed5583e8a9bad0b34b12d73ab2928d65144eb Gerrit-Change-Number: 78069 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[main]: flashrom_tester: Align WP output format with upstream
by Hsuan-ting Chen (Code Review) 04 Oct '23

04 Oct '23

Attention is currently required from: Evan Benn, Scott Chao. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77887?usp=email ) Change subject: flashrom_tester: Align WP output format with upstream ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/77887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Gerrit-Change-Number: 77887 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Evan Benn <evanbenn(a)gmail.com> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 04 Oct 2023 08:41:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2023