flashrom-gerrit October 2023

flashrom-gerrit@flashrom.org

1 participants
102 discussions

[S] Change in flashrom[main]: flashchips: Add support for PUYA P25Q40H
by Anastasia Klimchuk (Code Review) 01 Oct '23

01 Oct '23

Attention is currently required from: Anne Macedo. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76251?usp=email ) Change subject: flashchips: Add support for PUYA P25Q40H ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Thanks for the review! I'll make the changes as soon as I can. Anne, just wanted to ask how are you doing, do you think you can get back to your patch and fix the comments? :) If you need any help, you can ask questions! I am asking because there is another patch adding Puya chip CB:58134, but that is a very old patch and it seems that contributor had left already. Most likely that I will be finishing CB:58134 myself. I can wait for you and do that other patch after yours, or I can do that other one first, and then you will rebase your on the top. What do you think? -- To view, visit https://review.coreboot.org/c/flashrom/+/76251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I58c2c0467ef19f98b7435e84b6978550f029af70 Gerrit-Change-Number: 76251 Gerrit-PatchSet: 1 Gerrit-Owner: Anne Macedo <retpolanne(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anne Macedo <retpolanne(a)posteo.net> Gerrit-Comment-Date: Sun, 01 Oct 2023 09:51:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Anne Macedo <retpolanne(a)posteo.net> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: doc: Fix formatting for the example of commit message
by Anastasia Klimchuk (Code Review) 01 Oct '23

01 Oct '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/78120?usp=email ) Change subject: doc: Fix formatting for the example of commit message ...................................................................... doc: Fix formatting for the example of commit message Example of commit message was formatted with code-block directive which has language argument required or optional depending on the sphinx version. Replace code-block with simpler literal block which never has arguments, and also since the text formatted is not actually a code. Change-Id: If0bc8327e973d9bc9a93eea38c83bfab412fb8f4 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/78120 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-by: Alexander Goncharov <chat(a)joursoir.net> --- M doc/dev_guide/development_guide.rst 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Patrick Georgi: Looks good to me, but someone else must approve Alexander Goncharov: Looks good to me, approved build bot (Jenkins): Verified diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index bdbee37..60c5625 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -51,9 +51,7 @@ Commit message -------------- -Commit messages shall have the following format: - -.. code-block:: +Commit messages shall have the following format:: <component>: Short description (up to 72 characters) -- To view, visit https://review.coreboot.org/c/flashrom/+/78120?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If0bc8327e973d9bc9a93eea38c83bfab412fb8f4 Gerrit-Change-Number: 78120 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2023