January 2023 - flashrom-gerrit

[S] Change in flashrom[master]: MAINTAINERS: Add Miklos Marton for ni854x_spi
by Miklós Márton (Code Review) 22 Jan '23

22 Jan '23

Attention is currently required from: Felix Singer, Miklós Márton, Angel Pons. Hello Felix Singer, build bot (Jenkins), Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72181 to look at the new patch set (#4). Change subject: MAINTAINERS: Add Miklos Marton for ni854x_spi ...................................................................... MAINTAINERS: Add Miklos Marton for ni854x_spi Change-Id: Ia548d23d15f0efa92d83577d3106e6231ed7688f Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M MAINTAINERS 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/72181/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/72181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia548d23d15f0efa92d83577d3106e6231ed7688f Gerrit-Change-Number: 72181 Gerrit-PatchSet: 4 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Miklos Marton for STLINK-V3
by Miklós Márton (Code Review) 22 Jan '23

22 Jan '23

Attention is currently required from: Felix Singer, Miklós Márton, Angel Pons. Hello Felix Singer, build bot (Jenkins), Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72180 to look at the new patch set (#5). Change subject: MAINTAINERS: Add Miklos Marton for STLINK-V3 ...................................................................... MAINTAINERS: Add Miklos Marton for STLINK-V3 Change-Id: I2e5c90af2b7313f933780ea570a23d1d9101ef98 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M MAINTAINERS 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/72180/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/72180 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2e5c90af2b7313f933780ea570a23d1d9101ef98 Gerrit-Change-Number: 72180 Gerrit-PatchSet: 5 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: tests/: Assert on NULL heap allocations in tests
by Anastasia Klimchuk (Code Review) 22 Jan '23

22 Jan '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/71919 ) Change subject: tests/: Assert on NULL heap allocations in tests ...................................................................... tests/: Assert on NULL heap allocations in tests Change-Id: Id2adcfe859fb25d2a7f0734655c6b9a58c0890b6 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/71919 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/chip.c M tests/chip_wp.c M tests/helpers.c M tests/raiden_debug_spi.c 4 files changed, 26 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/tests/chip.c b/tests/chip.c index dc2ca11..ad0d770 100644 --- a/tests/chip.c +++ b/tests/chip.c @@ -279,6 +279,7 @@ const char *const filename = "read_chip.test"; unsigned long size = mock_chip.total_size * 1024; unsigned char *buf = calloc(size, sizeof(unsigned char)); + assert_non_null(buf); printf("Read chip operation started.\n"); assert_int_equal(0, flashrom_image_read(&flashctx, buf, size)); @@ -316,6 +317,7 @@ const char *const filename = "read_chip.test"; unsigned long size = mock_chip.total_size * 1024; unsigned char *buf = calloc(size, sizeof(unsigned char)); + assert_non_null(buf); printf("Read chip operation started.\n"); assert_int_equal(0, flashrom_image_read(&flashctx, buf, size)); @@ -365,6 +367,7 @@ const char *const filename = "-"; unsigned long size = mock_chip.total_size * 1024; uint8_t *const newcontents = malloc(size); + assert_non_null(newcontents); printf("Write chip operation started.\n"); assert_int_equal(0, read_buf_from_file(newcontents, size, filename)); @@ -403,6 +406,7 @@ const char *const filename = "-"; unsigned long size = mock_chip.total_size * 1024; uint8_t *const newcontents = malloc(size); + assert_non_null(newcontents); printf("Write chip operation started.\n"); assert_int_equal(0, read_buf_from_file(newcontents, size, filename)); @@ -542,6 +546,7 @@ const char *const filename = "-"; unsigned long size = mock_chip.total_size * 1024; uint8_t *const newcontents = malloc(size); + assert_non_null(newcontents); printf("Verify chip operation started.\n"); assert_int_equal(0, read_buf_from_file(newcontents, size, filename)); @@ -581,6 +586,7 @@ const char *const filename = "-"; unsigned long size = mock_chip.total_size * 1024; uint8_t *const newcontents = malloc(size); + assert_non_null(newcontents); /* * Dummyflasher controls chip state and fully emulates reads and writes, diff --git a/tests/chip_wp.c b/tests/chip_wp.c index f20b500..cb9b3ab 100644 --- a/tests/chip_wp.c +++ b/tests/chip_wp.c @@ -269,6 +269,7 @@ * be optimized away. */ unsigned long size = flashrom_flash_getsize(&flash); uint8_t *const contents = malloc(size); + assert_non_null(contents); memset(contents, UNERASED_VALUE(&flash), size); assert_int_equal(0, flashrom_image_write(&flash, contents, size, NULL)); free(contents); diff --git a/tests/helpers.c b/tests/helpers.c index e2e652e..271fb48 100644 --- a/tests/helpers.c +++ b/tests/helpers.c @@ -45,6 +45,7 @@ const char src0[] = "hello"; const char src1[] = " world"; char *dest = calloc(1, 1); + assert_non_null(dest); dest = strcat_realloc(dest, src0); dest = strcat_realloc(dest, src1); assert_string_equal("hello world", dest); diff --git a/tests/raiden_debug_spi.c b/tests/raiden_debug_spi.c index f5bf185..5c79a90 100644 --- a/tests/raiden_debug_spi.c +++ b/tests/raiden_debug_spi.c @@ -19,6 +19,7 @@ static ssize_t raiden_debug_libusb_get_device_list(void *state, libusb_context *ctx, libusb_device ***list) { *list = calloc(1, sizeof(**list)); + assert_non_null(*list); /* * libusb_device is opaque type, it is tossed around between libusb functions but always @@ -48,10 +49,14 @@ void *state, libusb_device *dev, uint8_t config_index, struct libusb_config_descriptor **config) { *config = calloc(1, sizeof(**config)); + assert_non_null(*config); struct libusb_endpoint_descriptor *tmp_endpoint = calloc(2, sizeof(*tmp_endpoint)); + assert_non_null(tmp_endpoint); struct libusb_interface_descriptor *tmp_interface_desc = calloc(1, sizeof(*tmp_interface_desc)); + assert_non_null(tmp_interface_desc); struct libusb_interface *tmp_interface = calloc(1, sizeof(*tmp_interface)); + assert_non_null(tmp_interface); /* in endpoint */ tmp_endpoint[0].bEndpointAddress = 0x80; -- To view, visit https://review.coreboot.org/c/flashrom/+/71919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2adcfe859fb25d2a7f0734655c6b9a58c0890b6 Gerrit-Change-Number: 71919 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: tests/lifecycle.c: Avoid unnecessary heap allocations
by Anastasia Klimchuk (Code Review) 22 Jan '23

22 Jan '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/71918 ) Change subject: tests/lifecycle.c: Avoid unnecessary heap allocations ...................................................................... tests/lifecycle.c: Avoid unnecessary heap allocations Just use a static string on the stack. Change-Id: I0414ab9a63867fc58b04ad62ed3ec4f221448a58 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/71918 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/lifecycle.c 1 file changed, 18 insertions(+), 10 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/tests/lifecycle.c b/tests/lifecycle.c index 0c79699..95c4249 100644 --- a/tests/lifecycle.c +++ b/tests/lifecycle.c @@ -40,10 +40,8 @@ struct flashrom_programmer *flashprog; - char *param_dup = param ? strdup(param) : NULL; - printf("Testing flashrom_programmer_init for programmer=%s ...\n", prog->name); - assert_int_equal(0, flashrom_programmer_init(&flashprog, prog->name, param_dup)); + assert_int_equal(0, flashrom_programmer_init(&flashprog, prog->name, param)); printf("... flashrom_programmer_init for programmer=%s successful\n", prog->name); if (action) @@ -53,8 +51,6 @@ assert_int_equal(0, flashrom_programmer_shutdown(flashprog)); printf("... flashrom_programmer_shutdown for programmer=%s successful\n", prog->name); - free(param_dup); - io_mock_register(NULL); } @@ -82,10 +78,9 @@ io_mock_register(io); struct flashrom_programmer *flashprog; - char *param_dup = strdup(param); - printf("Testing init error path for programmer=%s with params: %s ...\n", prog->name, param_dup); - assert_int_equal(error_code, flashrom_programmer_init(&flashprog, prog->name, param_dup)); + printf("Testing init error path for programmer=%s with params: %s ...\n", prog->name, param); + assert_int_equal(error_code, flashrom_programmer_init(&flashprog, prog->name, param)); printf("... init failed with error code %i as expected\n", error_code); /* @@ -99,7 +94,5 @@ assert_int_equal(0, flashrom_programmer_shutdown(flashprog)); printf("... completed\n"); - free(param_dup); - io_mock_register(NULL); } -- To view, visit https://review.coreboot.org/c/flashrom/+/71918 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0414ab9a63867fc58b04ad62ed3ec4f221448a58 Gerrit-Change-Number: 71918 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Miklos Marton for ni854x_spi
by Anastasia Klimchuk (Code Review) 22 Jan '23

22 Jan '23

Attention is currently required from: Felix Singer, Miklós Márton, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72181 ) Change subject: MAINTAINERS: Add Miklos Marton for ni854x_spi ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File MAINTAINERS: https://review.coreboot.org/c/flashrom/+/72181/comment/4bc8edbd_6945f77b PS3, Line 138: Same as in CB:72180 , you need to use tab instead of space. Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/72181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia548d23d15f0efa92d83577d3106e6231ed7688f Gerrit-Change-Number: 72181 Gerrit-PatchSet: 3 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 22 Jan 2023 05:52:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Miklos Marton for STLINK-V3
by Anastasia Klimchuk (Code Review) 22 Jan '23

22 Jan '23

Attention is currently required from: Felix Singer, Miklós Márton, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72180 ) Change subject: MAINTAINERS: Add Miklos Marton for STLINK-V3 ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Patchset: PS4: I rebased and this fixed jenkins build: because it re-run the build with new commit message. One problem solved :) And sorry I just noticed that you need to use tab as a separator (see my other comment). But that should be it, the last thing to do! File MAINTAINERS: https://review.coreboot.org/c/flashrom/+/72180/comment/8f16d368_e2334c17 PS4, Line 138: Oh I just noticed, you need to use tab instead of space as a separator (like the other entries) for M, S, F lines. -- To view, visit https://review.coreboot.org/c/flashrom/+/72180 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2e5c90af2b7313f933780ea570a23d1d9101ef98 Gerrit-Change-Number: 72180 Gerrit-PatchSet: 4 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 22 Jan 2023 05:42:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Miklos Marton for STLINK-V3
by Anastasia Klimchuk (Code Review) 22 Jan '23

22 Jan '23

Attention is currently required from: Felix Singer, Miklós Márton, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72180 ) Change subject: MAINTAINERS: Add Miklos Marton for STLINK-V3 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/72180 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2e5c90af2b7313f933780ea570a23d1d9101ef98 Gerrit-Change-Number: 72180 Gerrit-PatchSet: 4 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 22 Jan 2023 05:38:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: tests/chip{_wp}.c: Avoid unnecessary heap allocations
by Anastasia Klimchuk (Code Review) 22 Jan '23

22 Jan '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/71917 ) Change subject: tests/chip{_wp}.c: Avoid unnecessary heap allocations ...................................................................... tests/chip{_wp}.c: Avoid unnecessary heap allocations Just use a static string on the stack. Change-Id: Ic6cb4f32094ae5868912ebcffc8ab21026c48d32 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/71917 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/chip.c M tests/chip_wp.c 2 files changed, 26 insertions(+), 23 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/tests/chip.c b/tests/chip.c index e82719e..dc2ca11 100644 --- a/tests/chip.c +++ b/tests/chip.c @@ -243,7 +243,7 @@ * Dummyflasher is capable to emulate W25Q128.V, so we ask it to do this. * Nothing to mock, dummy is taking care of this already. */ - char *param_dup = strdup("bus=spi,emulate=W25Q128FV"); + const char *param_dup = "bus=spi,emulate=W25Q128FV"; setup_chip(&flashctx, &layout, &mock_chip, param_dup, &chip_io); @@ -252,8 +252,6 @@ printf("Erase chip operation done.\n"); teardown(&layout); - - free(param_dup); } void read_chip_test_success(void **state) @@ -311,7 +309,7 @@ * Dummyflasher is capable to emulate W25Q128.V, so we ask it to do this. * Nothing to mock, dummy is taking care of this already. */ - char *param_dup = strdup("bus=spi,emulate=W25Q128FV"); + const char *param_dup = "bus=spi,emulate=W25Q128FV"; setup_chip(&flashctx, &layout, &mock_chip, param_dup, &chip_io); @@ -326,7 +324,6 @@ teardown(&layout); - free(param_dup); free(buf); } @@ -398,7 +395,7 @@ * Dummyflasher is capable to emulate W25Q128.V, so we ask it to do this. * Nothing to mock, dummy is taking care of this already. */ - char *param_dup = strdup("bus=spi,emulate=W25Q128FV"); + const char *param_dup = "bus=spi,emulate=W25Q128FV"; setup_chip(&flashctx, &layout, &mock_chip, param_dup, &chip_io); @@ -414,7 +411,6 @@ teardown(&layout); - free(param_dup); free(newcontents); } @@ -438,7 +434,7 @@ * Dummyflasher is capable to emulate W25Q128.V, so we ask it to do this. * Nothing to mock, dummy is taking care of this already. */ - char *param_dup = strdup("bus=spi,emulate=W25Q128FV"); + const char *param_dup = "bus=spi,emulate=W25Q128FV"; /* FIXME: MOCK_CHIP_CONTENT is buggy within setup_chip, it should also * not be either 0x00 or 0xFF as those are specific values related to @@ -505,7 +501,6 @@ printf("Entire chip verify op done.\n"); teardown(&layout); - free(param_dup); free(newcontents); } @@ -578,7 +573,7 @@ * Dummyflasher is capable to emulate W25Q128.V, so we ask it to do this. * Nothing to mock, dummy is taking care of this already. */ - char *param_dup = strdup("bus=spi,emulate=W25Q128FV"); + const char *param_dup = "bus=spi,emulate=W25Q128FV"; setup_chip(&flashctx, &layout, &mock_chip, param_dup, &verify_chip_io); @@ -605,6 +600,5 @@ teardown(&layout); - free(param_dup); free(newcontents); } diff --git a/tests/chip_wp.c b/tests/chip_wp.c index 40303ff..f20b500 100644 --- a/tests/chip_wp.c +++ b/tests/chip_wp.c @@ -106,7 +106,7 @@ { (void) state; /* unused */ - char *param_dup = strdup("bus=spi,emulate=W25Q128FV,hwwp=no"); + const char *param_dup = "bus=spi,emulate=W25Q128FV,hwwp=no"; struct flashrom_flashctx flash = { 0 }; struct flashchip mock_chip = chip_W25Q128_V; @@ -123,7 +123,6 @@ teardown(NULL); flashrom_wp_cfg_release(wp_cfg); - free(param_dup); } /* Enabling hardware WP with a valid range succeeds */ @@ -131,7 +130,7 @@ { (void) state; /* unused */ - char *param_dup = strdup("bus=spi,emulate=W25Q128FV,hwwp=no"); + const char *param_dup = "bus=spi,emulate=W25Q128FV,hwwp=no"; struct flashrom_flashctx flash = { 0 }; struct flashchip mock_chip = chip_W25Q128_V; @@ -158,7 +157,6 @@ teardown(NULL); flashrom_wp_cfg_release(wp_cfg); - free(param_dup); } /* Enable hardware WP and verify that it can not be unset */ @@ -166,7 +164,7 @@ { (void) state; /* unused */ - char *param_dup = strdup("bus=spi,emulate=W25Q128FV,hwwp=yes"); + const char *param_dup = "bus=spi,emulate=W25Q128FV,hwwp=yes"; struct flashrom_flashctx flash = { 0 }; struct flashchip mock_chip = chip_W25Q128_V; @@ -198,7 +196,6 @@ teardown(NULL); flashrom_wp_cfg_release(wp_cfg); - free(param_dup); } /* WP state is decoded correctly from status registers */ @@ -220,7 +217,7 @@ * Multiplaying that by base unit gives 16 KiB protected region at the * bottom (start of the chip), which is then complemented. */ - char *param_dup = strdup("bus=spi,emulate=W25Q128FV,spi_status=0x41ec"); + const char *param_dup = "bus=spi,emulate=W25Q128FV,spi_status=0x41ec"; struct flashrom_flashctx flash = { 0 }; struct flashchip mock_chip = chip_W25Q128_V; @@ -243,7 +240,6 @@ teardown(NULL); flashrom_wp_cfg_release(wp_cfg); - free(param_dup); } /* Enabled WP makes full chip erasure fail */ @@ -256,7 +252,7 @@ struct flashchip mock_chip = chip_W25Q128_V; struct flashrom_wp_cfg *wp_cfg; - char *param_dup = strdup("bus=spi,emulate=W25Q128FV,hwwp=yes"); + const char *param_dup = "bus=spi,emulate=W25Q128FV,hwwp=yes"; setup_chip(&flash, &layout, &mock_chip, param_dup); /* Layout regions are created by setup_chip(). */ @@ -293,7 +289,6 @@ teardown(&layout); flashrom_wp_cfg_release(wp_cfg); - free(param_dup); } /* Enabled WP does not block erasing unprotected parts of the chip */ @@ -306,7 +301,7 @@ struct flashchip mock_chip = chip_W25Q128_V; struct flashrom_wp_cfg *wp_cfg; - char *param_dup = strdup("bus=spi,emulate=W25Q128FV,hwwp=yes"); + const char *param_dup = "bus=spi,emulate=W25Q128FV,hwwp=yes"; setup_chip(&flash, &layout, &mock_chip, param_dup); /* Layout region is created by setup_chip(). */ @@ -330,5 +325,4 @@ teardown(&layout); flashrom_wp_cfg_release(wp_cfg); - free(param_dup); } -- To view, visit https://review.coreboot.org/c/flashrom/+/71917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic6cb4f32094ae5868912ebcffc8ab21026c48d32 Gerrit-Change-Number: 71917 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Miklos Marton for STLINK-V3
by Miklós Márton (Code Review) 21 Jan '23

21 Jan '23

Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72180 ) Change subject: MAINTAINERS: Add Miklos Marton for STLINK-V3 ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/72180/comment/c792fa66_03a9ef10 PS2, Line 10: > Same as another patch: you need to add sign-off tag. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/72180 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2e5c90af2b7313f933780ea570a23d1d9101ef98 Gerrit-Change-Number: 72180 Gerrit-PatchSet: 3 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 21 Jan 2023 17:53:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Miklos Marton for ni854x_spi
by Miklós Márton (Code Review) 21 Jan '23

21 Jan '23

Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72181 ) Change subject: MAINTAINERS: Add Miklos Marton for ni854x_spi ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/72181/comment/4a0cf5a9_51b22fe4 PS1, Line 10: > You need to add Signed-off-by tag with you name and email (it's a requirement for flashrom, see guid […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/72181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia548d23d15f0efa92d83577d3106e6231ed7688f Gerrit-Change-Number: 72181 Gerrit-PatchSet: 2 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 21 Jan 2023 17:52:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2023