January 2023 - flashrom-gerrit

[S] Change in flashrom[master]: MAINTAINERS: Add Miklos Marton for ni854x_spi
by Anastasia Klimchuk (Code Review) 23 Jan '23

23 Jan '23

Attention is currently required from: Felix Singer, Miklós Márton, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72181 ) Change subject: MAINTAINERS: Add Miklos Marton for ni854x_spi ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Oh you know what happened: this patch is now in "Merge Conflict" state because I merged CB:72180 and it needs manual rebase because both entries are at the end of list, after Linux MTD :D If you could do the rebase, that would be great! I suspect if I upload manual rebase my approval won't be counted.. Thank you so much! -- To view, visit https://review.coreboot.org/c/flashrom/+/72181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia548d23d15f0efa92d83577d3106e6231ed7688f Gerrit-Change-Number: 72181 Gerrit-PatchSet: 4 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 23 Jan 2023 22:51:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Miklos Marton for STLINK-V3
by Anastasia Klimchuk (Code Review) 23 Jan '23

23 Jan '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/72180 ) Change subject: MAINTAINERS: Add Miklos Marton for STLINK-V3 ...................................................................... MAINTAINERS: Add Miklos Marton for STLINK-V3 Change-Id: I2e5c90af2b7313f933780ea570a23d1d9101ef98 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/72180 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M MAINTAINERS 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/MAINTAINERS b/MAINTAINERS index 6e4c40e..b70d5e0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -134,6 +134,11 @@ S: Supported F: linux_mtd.c +STLINK-V3 +M: Miklos Marton <martonmiklosqdev(a)gmail.com> +S: Maintained +F: stlinkv3_spi.c + ################################################################################ # TESTS ################################################################################ -- To view, visit https://review.coreboot.org/c/flashrom/+/72180 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2e5c90af2b7313f933780ea570a23d1d9101ef98 Gerrit-Change-Number: 72180 Gerrit-PatchSet: 6 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: maintainers: Add Alexander Goncharov for bash completion
by Alexander Goncharov (Code Review) 23 Jan '23

23 Jan '23

Alexander Goncharov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/72393 ) Change subject: maintainers: Add Alexander Goncharov for bash completion ...................................................................... maintainers: Add Alexander Goncharov for bash completion Change-Id: I5cdae05a46dbd61060ff2b84accb9297334a6301 Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- M MAINTAINERS 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/72393/1 diff --git a/MAINTAINERS b/MAINTAINERS index 6e4c40e..f4f210b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -153,6 +153,11 @@ S: Supported F: test_build.sh +BASH COMPLETION +M: Alexander Goncharov <chat(a)joursoir.net> +S: Maintained +F: util/flashrom.bash-completion.tmpl + FLASHROM TESTER M: Evan Benn <evanbenn(a)chromium.org> S: Supported -- To view, visit https://review.coreboot.org/c/flashrom/+/72393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5cdae05a46dbd61060ff2b84accb9297334a6301 Gerrit-Change-Number: 72393 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: buspirate_spi: Add 'aux' programmer option to control AUX pin.
by David Norris (Code Review) 23 Jan '23

23 Jan '23

David Norris has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/72198 ) Change subject: buspirate_spi: Add 'aux' programmer option to control AUX pin. ...................................................................... buspirate_spi: Add 'aux' programmer option to control AUX pin. Set aux=0 to drive AUX to GND. Set aux=1 to drive AUX to +3.3 V (the previous behavior). It is often convenient to use the AUX pin to control something on the target board like a reset pin. This option allows for cases when AUX should be driven to GND instead of +3.3 V as was the previous behavior. Unfortunately the Bus Pirate's raw SPI mode does not appear to easily support a High-Z mode for AUX but if I'm mistaken, "aux=z" should be added to this patch accordingly. Change-Id: I463ff7c57a67a3132d2fb3608f1d8408b84febd7 Signed-off-by: David A Norris <danorris(a)gmail.com> --- M buspirate_spi.c 1 file changed, 36 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/72198/1 diff --git a/buspirate_spi.c b/buspirate_spi.c index a40fb70..3aa13d4 100644 --- a/buspirate_spi.c +++ b/buspirate_spi.c @@ -331,6 +331,7 @@ bool psu = false; unsigned char *bp_commbuf; int bp_commbufsize; + int aux = 1; dev = extract_programmer_param_str(cfg, "dev"); if (dev && !strlen(dev)) { @@ -391,6 +392,17 @@ } free(tmp); + tmp = extract_programmer_param_str(cfg, "aux"); + if (aux) { + if (strcmp("1", tmp) == 0) + aux = 1; + else if (strcmp("0", tmp) == 0) + aux = 0; + else + msg_perr("Invalid aux state, leaving high (the default).\n"); + } + free(tmp); + /* Default buffer size is 19: 16 bytes data, 3 bytes control. */ #define DEFAULT_BUFSIZE (16 + 3) bp_commbuf = malloc(DEFAULT_BUFSIZE); @@ -650,6 +662,10 @@ bp_commbuf[0] |= (1 << 2); msg_pdbg("Enabling pull-up resistors.\n"); } + if (aux == 0) { + bp_commbuf[0] &= ~(1 << 1); + msg_pdbg("Setting AUX low.\n"); + } if (psu) { bp_commbuf[0] |= (1 << 3); msg_pdbg("Enabling PSUs.\n"); -- To view, visit https://review.coreboot.org/c/flashrom/+/72198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I463ff7c57a67a3132d2fb3608f1d8408b84febd7 Gerrit-Change-Number: 72198 Gerrit-PatchSet: 1 Gerrit-Owner: David Norris <danorris(a)gmail.com> Gerrit-MessageType: newchange

1 0

[L] Change in flashrom[master]: programmer: Add bitbanging programmer driver for Linux libgpiod
by Thomas Heijligen (Code Review) 23 Jan '23

23 Jan '23

Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk, Steve Markgraf. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71801 ) Change subject: programmer: Add bitbanging programmer driver for Linux libgpiod ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Hi, Great work. I have two suggestions: - Can you rename this driver to `linux_gpio_spi`, this would make it clear which protocol is used. - Can you convert the `gpiochip=X` parameter to `dev=/dev/gpiochipX` to be aligned with linux_spi or linux_mtd -- To view, visit https://review.coreboot.org/c/flashrom/+/71801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icad3eb7764f28feaea51bda3a7893da724c86d06 Gerrit-Change-Number: 71801 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Markgraf <steve(a)steve-m.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Steve Markgraf <steve(a)steve-m.de> Gerrit-Comment-Date: Mon, 23 Jan 2023 14:02:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: writeprotect: Add function to get register values and WP bit masks
by Sergii Dmytruk (Code Review) 23 Jan '23

23 Jan '23

Attention is currently required from: Nikolai Artemiev, Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69847 ) Change subject: writeprotect: Add function to get register values and WP bit masks ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/69847/comment/f32cc611_9af65311 PS5, Line 7: writeprotect: Add function to get register values and WP bit masks Is this to allow updating WP registers via some non-standard method? Would be nice to have outline of this function's purpose in the commit message. -- To view, visit https://review.coreboot.org/c/flashrom/+/69847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a47153b230c9f82bb4eca357c335f2abbacc20 Gerrit-Change-Number: 69847 Gerrit-PatchSet: 5 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 23 Jan 2023 13:00:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ni845x_spi: handle errors using goto during initialization
by Alexander Goncharov (Code Review) 23 Jan '23

23 Jan '23

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72156 to look at the new patch set (#2). Change subject: ni845x_spi: handle errors using goto during initialization ...................................................................... ni845x_spi: handle errors using goto during initialization This patch prepares the programmer to move global singleton states into a struct. TOPIC=register_master_api Change-Id: Ie9620d59db229729fd8523f99b0917d938bcc4ed Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Ticket: https://ticket.coreboot.org/issues/391 --- M ni845x_spi.c 1 file changed, 24 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/56/72156/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/72156 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie9620d59db229729fd8523f99b0917d938bcc4ed Gerrit-Change-Number: 72156 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ni845x_spi: pass global state through func params
by Alexander Goncharov (Code Review) 23 Jan '23

23 Jan '23

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/72154 to look at the new patch set (#2). Change subject: ni845x_spi: pass global state through func params ...................................................................... ni845x_spi: pass global state through func params Instead of relying on global variables, pass and use their value or pointer to functions where possible. This patch prepares the programmer to move global singleton states into a struct. TOPIC=register_master_api Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Ticket: https://ticket.coreboot.org/issues/391 --- M ni845x_spi.c 1 file changed, 29 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/72154/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/72154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Gerrit-Change-Number: 72154 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: writeprotect: Add function to get register values and WP bit masks
by Edward O'Callaghan (Code Review) 23 Jan '23

23 Jan '23

Attention is currently required from: Nikolai Artemiev, Anastasia Klimchuk, Sergii Dmytruk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69847 ) Change subject: writeprotect: Add function to get register values and WP bit masks ...................................................................... Patch Set 5: Code-Review+2 (2 comments) File tests/chip_wp.c: https://review.coreboot.org/c/flashrom/+/69847/comment/159a48cb_1821a4ab PS5, Line 363: strdup( you do not need a heap allocation, just a `const char *` https://review.coreboot.org/c/flashrom/+/69847/comment/06a61abb_7b8ff2fe PS5, Line 396: free(param_dup); drop -- To view, visit https://review.coreboot.org/c/flashrom/+/69847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a47153b230c9f82bb4eca357c335f2abbacc20 Gerrit-Change-Number: 69847 Gerrit-PatchSet: 5 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 23 Jan 2023 07:12:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: opaque: make opaque programmers expose register read/write capability
by Nikolai Artemiev (Code Review) 23 Jan '23

23 Jan '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66032 ) Change subject: opaque: make opaque programmers expose register read/write capability ...................................................................... Patch Set 3: (1 comment) File ichspi.c: https://review.coreboot.org/c/flashrom/+/66032/comment/255a7293_2eaf13b1 PS2, Line 1413: static bool ich_hwseq_can_read_register(const struct flashctx *flash, enum flash_reg reg) : { : return reg == STATUS1; : } : : static bool ich_hwseq_can_write_register(const struct flashctx *flash, enum flash_reg reg) : { : return reg == STATUS1; : } > It might be better to use functions instead of structs, given the many-to-one relationship between d […] Marking resolved, reopen if you want to discuss it more though. -- To view, visit https://review.coreboot.org/c/flashrom/+/66032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9ec34a8d6f55a76f890e0066d0b896560331ede0 Gerrit-Change-Number: 66032 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 23 Jan 2023 06:04:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2023