January 2023 - flashrom-gerrit

[S] Change in flashrom[master]: ni845x_spi: introduce a separate func for cleaning up
by Alexander Goncharov (Code Review) 20 Jan '23

20 Jan '23

Alexander Goncharov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/72159 ) Change subject: ni845x_spi: introduce a separate func for cleaning up ...................................................................... ni845x_spi: introduce a separate func for cleaning up TODO: desc TOPIC=register_master_api Change-Id: I8b32129b8d0dff9a7516973893fa4bf92f9e64db Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- M ni845x_spi.c 1 file changed, 22 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/72159/1 diff --git a/ni845x_spi.c b/ni845x_spi.c index 0a5c46d..de907af 100644 --- a/ni845x_spi.c +++ b/ni845x_spi.c @@ -386,7 +386,7 @@ ni845x_report_error("ni845xCloseFindDeviceHandle", tmp); } -static int ni845x_spi_shutdown(void *data) +static void ni845x_spi_cleanup(NiHandle configuration_handle, uInt32 device_handle) { int32 ret = 0; @@ -401,6 +401,12 @@ if (ret) ni845x_report_error("ni845xClose", ret); } +} + +static int ni845x_spi_shutdown(void *data) +{ + ni845x_spi_cleanup(configuration_handle, device_handle); + return 0; } @@ -630,7 +636,7 @@ return register_spi_master(&spi_programmer_ni845x, NULL); err: - ni845x_spi_shutdown(NULL); + ni845x_spi_cleanup(configuration_handle, device_handle); return 1; } -- To view, visit https://review.coreboot.org/c/flashrom/+/72159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b32129b8d0dff9a7516973893fa4bf92f9e64db Gerrit-Change-Number: 72159 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: ni845x_spi: handle errors using goto during initialization
by Alexander Goncharov (Code Review) 20 Jan '23

20 Jan '23

Alexander Goncharov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/72156 ) Change subject: ni845x_spi: handle errors using goto during initialization ...................................................................... ni845x_spi: handle errors using goto during initialization This patch prepares the programmer to move global singleton states into a struct. TOPIC=register_master_api Change-Id: Ie9620d59db229729fd8523f99b0917d938bcc4ed Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- M ni845x_spi.c 1 file changed, 23 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/56/72156/1 diff --git a/ni845x_spi.c b/ni845x_spi.c index 493e8a1..0a5c46d 100644 --- a/ni845x_spi.c +++ b/ni845x_spi.c @@ -614,22 +614,24 @@ tmp = ni845xSpiConfigurationOpen(&configuration_handle); if (tmp != 0) { ni845x_report_error("ni845xSpiConfigurationOpen", tmp); - ni845x_spi_shutdown(NULL); - return 1; + goto err; } if (usb8452_spi_set_io_voltage(requested_io_voltage_mV, &io_voltage_in_mV, USE_LOWER) < 0) { - ni845x_spi_shutdown(NULL); - return 1; // no alert here usb8452_spi_set_io_voltage already printed that + // no alert here usb8452_spi_set_io_voltage already printed that + goto err; } if (ni845x_spi_set_speed(configuration_handle, spi_speed_KHz)) { msg_perr("Unable to set SPI speed\n"); - ni845x_spi_shutdown(NULL); - return 1; + goto err; } return register_spi_master(&spi_programmer_ni845x, NULL); + +err: + ni845x_spi_shutdown(NULL); + return 1; } const struct programmer_entry programmer_ni845x_spi = { -- To view, visit https://review.coreboot.org/c/flashrom/+/72156 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie9620d59db229729fd8523f99b0917d938bcc4ed Gerrit-Change-Number: 72156 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: ni845x_spi: pass global state through func params
by Alexander Goncharov (Code Review) 20 Jan '23

20 Jan '23

Alexander Goncharov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/72154 ) Change subject: ni845x_spi: pass global state through func params ...................................................................... ni845x_spi: pass global state through func params TODO: desc TOPIC=register_master_api Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- M ni845x_spi.c 1 file changed, 26 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/72154/1 diff --git a/ni845x_spi.c b/ni845x_spi.c index fd5057d..493e8a1 100644 --- a/ni845x_spi.c +++ b/ni845x_spi.c @@ -128,7 +128,8 @@ * @param opened_handle the opened handle from the ni845xOpen * @return the 0 on successful competition, negative error code on failure positive code on warning */ -static int32 ni845x_spi_open_resource(char *resource_handle, uInt32 *opened_handle) +static int32 ni845x_spi_open_resource(char *resource_handle, uInt32 *opened_handle, + enum USB845x_type device_pid) { // NI-845x driver loads the FPGA bitfile at the first time // which can take couple seconds @@ -148,7 +149,8 @@ * @param serial a null terminated string containing the serial number of the specific device or NULL * @return the 0 on successful completion, negative error code on failure */ -static int ni845x_spi_open(const char *serial, uInt32 *return_handle) +static int ni845x_spi_open(const char *serial, uInt32 *return_handle, + enum USB845x_type *device_pid) { char resource_name[256]; NiHandle device_find_handle; @@ -183,7 +185,7 @@ continue; } - device_pid = pid; + *device_pid = pid; if (!serial || strtol(serial, NULL, 16) == serial_as_number) break; @@ -198,7 +200,7 @@ } if (found_devices_count) - ret = ni845x_spi_open_resource(resource_name, return_handle); + ret = ni845x_spi_open_resource(resource_name, return_handle, *device_pid); _close_ret: tmp = ni845xCloseFindDeviceHandle(device_find_handle); @@ -220,14 +222,15 @@ */ static int usb8452_spi_set_io_voltage(uint16_t requested_io_voltage_mV, uint16_t *set_io_voltage_mV, - enum voltage_coerce_mode coerce_mode) + enum voltage_coerce_mode coerce_mode, + enum USB845x_type device_pid) { int i = 0; uint8_t selected_voltage_100mV = 0; uint8_t requested_io_voltage_100mV = 0; if (device_pid == USB8451) { - io_voltage_in_mV = 3300; + *set_io_voltage_mV = 3300; msg_pwarn("USB-8451 does not support the changing of the SPI IO voltage\n"); return 0; } @@ -300,7 +303,7 @@ * @param SCK_freq_in_KHz SCK speed in KHz * @return */ -static int ni845x_spi_set_speed(uint16_t SCK_freq_in_KHz) +static int ni845x_spi_set_speed(NiHandle configuration_handle, uint16_t SCK_freq_in_KHz) { int32 i = ni845xSpiConfigurationSetClockRate(configuration_handle, SCK_freq_in_KHz); uInt16 clock_freq_read_KHz; @@ -591,7 +594,7 @@ ignore_io_voltage_limits = true; } - if (ni845x_spi_open(serial_number, &device_handle)) { + if (ni845x_spi_open(serial_number, &device_handle, &device_pid)) { if (serial_number) { msg_pinfo("Could not find any connected NI USB-8451/8452 with serialnumber: %s!\n", serial_number); @@ -620,7 +623,7 @@ return 1; // no alert here usb8452_spi_set_io_voltage already printed that } - if (ni845x_spi_set_speed(spi_speed_KHz)) { + if (ni845x_spi_set_speed(configuration_handle, spi_speed_KHz)) { msg_perr("Unable to set SPI speed\n"); ni845x_spi_shutdown(NULL); return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/72154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61 Gerrit-Change-Number: 72154 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newchange

1 0

[L] Change in flashrom[master]: Add initial CH347T SPI programmer
by Anastasia Klimchuk (Code Review) 20 Jan '23

20 Jan '23

Attention is currently required from: Angel Pons, qianfan, Nicholas Chin. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70529 ) Change subject: Add initial CH347T SPI programmer ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: qianfan, I wanted to check with you about your patch. As you know, as a complete coincidence, we now have two patches implementing a programmer for ch347: CB:70573 and yours. After several discussions, we decided to take CB:70573 as a baseline patch for ch347. There are technical reasons for this decision: 1) CB:70573 has less layers of indirection 2) the preference is for arrays and manual shifts/masks because they are the only portable way of guaranteeing things end up in the right place 3) the general style (naming, function ordering) follows the style of flashrom more closely 4) CB:70573 does not use global state for a programmer Important thing for now is to figure out if there are some useful features from your patch that can be introduced on the top of CB:70573 ? What do you think? -- To view, visit https://review.coreboot.org/c/flashrom/+/70529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6da5e308af76693e60308c8165349128e517e09a Gerrit-Change-Number: 70529 Gerrit-PatchSet: 9 Gerrit-Owner: qianfan <qianfanguijin(a)163.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: qianfan <qianfanguijin(a)163.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Fri, 20 Jan 2023 10:20:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: ch347_spi.c: Add initial support for the WCH CH347
by Anastasia Klimchuk (Code Review) 20 Jan '23

20 Jan '23

Attention is currently required from: Thomas Heijligen, Angel Pons, qianfan, Nicholas Chin. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70573 ) Change subject: ch347_spi.c: Add initial support for the WCH CH347 ...................................................................... Patch Set 3: (5 comments) Patchset: PS3: > Nicholas, just to check: is this patch still needed? It seems like CB:70529 + CB:71066 add new progr […] After a number of discussions in several irc channels, the conclusion is: this patch is going ahead and anything extra from CB:70529 can be added on the top. Few things that are missing to add a new programmer: There a few things need to be added to this patch: 1) add new programmer to meson build system (currently only added to make) 2) add man page entry for new programmer 3) add to test_build.sh 4) add yourself to MAINTAINERS file (if you agree!) This is a coincidence, but: there is one more new programmer being under review at the moment in CB:71801 . The programmer is independent of this one, but it can be a useful example as of all the places that need to be updated when introducing new programmer. Thank you for your work! File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/70573/comment/4f38919c_e448ce7b PS3, Line 62: /* TODO: Set this depending on the mode */ new line before https://review.coreboot.org/c/flashrom/+/70573/comment/95361b93_0ce0253b PS3, Line 68: ch347_data->handle = NULL; new line before https://review.coreboot.org/c/flashrom/+/70573/comment/4fba5271_da300058 PS3, Line 69: free(data); > Both my code and `ft2232_spi` allocate memory for the data passed around in flashctx, so I would thi […] Yes please, free the data :) Nicholas, you did the right thing, thank you for not introducing the global state in a new programmer. The reason `ch341a_spi` still has global state (and therefore does not have data to free) is because removing global state was blocked by refactoring of `programmer_delay`, which took a long time in review. However, that refactoring merged, and now `ch341a_spi` is unblocked and global state will be removed soon. Another relevant point is that: if programmer has a lifecycle unit test, the test can check that there are no memory leaks at shutdown. `ch341a_spi` already has unit test. Maybe, at some point later, we can add a unit test for `ch347_spi`. Not now of course, but this would be a good idea for future, especially that existing test for ch341 can be taken as a starting point. https://review.coreboot.org/c/flashrom/+/70573/comment/14f4aa3f_05ffdf34 PS3, Line 123: Could not read write response It is confusing, given that both "read" and "write" are the operations, what does it mean "Could not read write response" ? is it read response or write response? If you looks at the source code, you can see this is in the context of `ch347_write` so probably about "write response" but imagine a user looking into the logs. TLDR: Lets make it clear this is about write operation. Could not parse response from write operation? Maybe something else, this is just my suggestion. -- To view, visit https://review.coreboot.org/c/flashrom/+/70573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I31b86c41076cc45d4a416a73fa1131350fb745ba Gerrit-Change-Number: 70573 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: qianfan <qianfanguijin(a)163.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: qianfan <qianfanguijin(a)163.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 20 Jan 2023 10:20:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: flashrom.c: Add functions for new erase selction algorithm
by Aarya (Code Review) 20 Jan '23

20 Jan '23

Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Anastasia Klimchuk. Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 ) Change subject: flashrom.c: Add functions for new erase selction algorithm ...................................................................... Patch Set 84: (13 comments) File erasure_layout.c: https://review.coreboot.org/c/flashrom/+/65844/comment/eb3b7217_22ddeac1 PS83, Line 245: uint8_t* old_start_buf = (uint8_t*)malloc(old_start - region_start); > new line before Done https://review.coreboot.org/c/flashrom/+/65844/comment/75f1783f_34c868d5 PS83, Line 268: //select erase functions > new line before Done https://review.coreboot.org/c/flashrom/+/65844/comment/11ec5e07_f7c797b9 PS83, Line 268: //s > when you are going through code to check for line limit 112chars, try to add a space between `//` an […] Done https://review.coreboot.org/c/flashrom/+/65844/comment/a2379325_ae82db4b PS83, Line 277: for (i = 0; i < erasefn_count; i++) { > new line before Done https://review.coreboot.org/c/flashrom/+/65844/comment/3af1be5a_75020c69 PS83, Line 285: > comment is misaligned, too many tabs ? Done https://review.coreboot.org/c/flashrom/+/65844/comment/c13fb12a_ef83e2cc PS83, Line 325: //adjust curcontents > new line before Done https://review.coreboot.org/c/flashrom/+/65844/comment/c2433199_ec8090ee PS83, Line 336: *all_skipped = false; > new line before Done https://review.coreboot.org/c/flashrom/+/65844/comment/8079dac2_c1d18645 PS83, Line 339: //write > new line before Done https://review.coreboot.org/c/flashrom/+/65844/comment/d068288f_bc7e09bd PS83, Line 343: > trailing space (Gerrit shows it bright pink :)) Done https://review.coreboot.org/c/flashrom/+/65844/comment/513b4ddd_755402d4 PS83, Line 352: //adjust curcontents > new line before Done https://review.coreboot.org/c/flashrom/+/65844/comment/05f68cf2_601fe515 PS83, Line 355: *all_skipped = false; > new line before Done https://review.coreboot.org/c/flashrom/+/65844/comment/95cab8dc_47fd8f12 PS83, Line 366: free(old_start_buf); > new line before Done https://review.coreboot.org/c/flashrom/+/65844/comment/b5e40493_37fde7f3 PS83, Line 368: msg_cinfo("Erase/write done from %x to %x\n", region_start, region_end); > new line before Done -- To view, visit https://review.coreboot.org/c/flashrom/+/65844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256 Gerrit-Change-Number: 65844 Gerrit-PatchSet: 84 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 20 Jan 2023 04:51:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: flashrom.c: Add functions for new erase selction algorithm
by Aarya (Code Review) 20 Jan '23

20 Jan '23

Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Aarya. Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/65844 to look at the new patch set (#84). Change subject: flashrom.c: Add functions for new erase selction algorithm ...................................................................... flashrom.c: Add functions for new erase selction algorithm 1) Add function to flatten out the addresses of the flash chip as per the different erase functions. This function will return a list of layouts which is dynamically allocated. So after use all the layouts as well as the list itself should be freed. The free_erase_layout function does that. 2) Add function to align start and end address of the region (in struct walk_info) to some erase sector boundaries and modify the region start and end addresses to match nearest erase sector boundaries. This function will be used in the new algorithm for erase function selection. 3) Add function that returns a list of sectors (as seen by the first erase function) that need erasing. 4) Add a function to call the erase algorithm. Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- A erasure_layout.c A erasure_layout.h 2 files changed, 471 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/65844/84 -- To view, visit https://review.coreboot.org/c/flashrom/+/65844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256 Gerrit-Change-Number: 65844 Gerrit-PatchSet: 84 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashrom.c: Supplement `chip->unlock()` calls with wp unlocking
by Anastasia Klimchuk (Code Review) 20 Jan '23

20 Jan '23

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69517 ) Change subject: flashrom.c: Supplement `chip->unlock()` calls with wp unlocking ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69517 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I74b3f5d3a17749ea60485b916b2d87467a5d8b2f Gerrit-Change-Number: 69517 Gerrit-PatchSet: 12 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 20 Jan 2023 03:13:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: writeprotect: add WP function to expose register state and WP bit masks
by Edward O'Callaghan (Code Review) 20 Jan '23

20 Jan '23

Attention is currently required from: Nikolai Artemiev, Sergii Dmytruk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69847 ) Change subject: writeprotect: add WP function to expose register state and WP bit masks ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: rebase File include/writeprotect.h: https://review.coreboot.org/c/flashrom/+/69847/comment/355e4286_515cbeca PS1, Line 96: wp_cfg_to_reg_values > Add a unit-test ping -- To view, visit https://review.coreboot.org/c/flashrom/+/69847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2a47153b230c9f82bb4eca357c335f2abbacc20 Gerrit-Change-Number: 69847 Gerrit-PatchSet: 4 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Fri, 20 Jan 2023 02:40:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: programmer: Add bitbanging programmer driver for Linux libgpiod
by Steve Markgraf (Code Review) 19 Jan '23

19 Jan '23

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/71801 to look at the new patch set (#6). Change subject: programmer: Add bitbanging programmer driver for Linux libgpiod ...................................................................... programmer: Add bitbanging programmer driver for Linux libgpiod With this driver, any single board computer, old smartphone, etc. with a few spare GPIOs can be used for flashrom. Tested by reading of a 2048 kB flash chip on a Qualcomm MSM8916 SoC @800 MHz, ran the following command: time flashrom -p linux_gpiod:gpiochip=0,cs=18,sck=19,mosi=13,miso=56 -r test.bin This command uses /dev/gpiochip0 with the specified GPIO numbers for the SPI lines. All arguments are mandatory. Output: [...] Found GigaDevice flash chip "GD25LQ16" (2048 kB, SPI) on linux_gpiod. [...] real 1m 33.96s Change-Id: Icad3eb7764f28feaea51bda3a7893da724c86d06 Signed-off-by: Steve Markgraf <steve(a)steve-m.de> --- M Documentation/building.md M MAINTAINERS M Makefile M README M flashrom.8.tmpl M include/programmer.h A linux_gpiod.c M meson.build M meson_options.txt M programmer_table.c M test_build.sh M util/manibuilder/Dockerfile.alpine M util/manibuilder/Dockerfile.centos M util/manibuilder/Dockerfile.debian-debootstrap M util/manibuilder/Dockerfile.fedora M util/manibuilder/Dockerfile.ubuntu-debootstrap M util/shell.nix 17 files changed, 289 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/71801/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/71801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icad3eb7764f28feaea51bda3a7893da724c86d06 Gerrit-Change-Number: 71801 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Markgraf <steve(a)steve-m.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2023