Attention is currently required from: Khoa Hoang.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67714 )
Change subject: stlinkv3_spi.c: Fix 'stlinkv3_handle' may be used uninitialized
......................................................................
Patch Set 2:
Dup of CB:67700 and others
--
To view, visit https://review.coreboot.org/c/flashrom/+/67714
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id80eaa2e27902351b40bea3fb66eb368680f4ff4
Gerrit-Change-Number: 67714
Gerrit-PatchSet: 2
Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Khoa Hoang <admin(a)khoahoang.com>
Gerrit-Comment-Date: Tue, 20 Sep 2022 00:14:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67713
to look at the new patch set (#3).
Change subject: flashchips.c: Add write protect support for W25Q16.V
......................................................................
flashchips.c: Add write protect support for W25Q16.V
Enable WRSR2 feature flag and define reg_bits and decode_range for
W25Q16.V to enable write protect support.
Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75
Signed-off-by: Khoa Hoang <admin(a)khoahoang.com>
---
M flashchips.c
1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/67713/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/67713
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75
Gerrit-Change-Number: 67713
Gerrit-PatchSet: 3
Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Khoa Hoang has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67714 )
Change subject: stlinkv3_spi.c: Fix 'stlinkv3_handle' may be used uninitialized
......................................................................
stlinkv3_spi.c: Fix 'stlinkv3_handle' may be used uninitialized
This change fix stlinkv3_handle may be used uninitialized compiler error.
Set stlinkv3_handle initial value to NULL.
Change-Id: Id80eaa2e27902351b40bea3fb66eb368680f4ff4
Signed-off-by: Khoa Hoang <admin(a)khoahoang.com>
---
M stlinkv3_spi.c
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/67714/1
diff --git a/stlinkv3_spi.c b/stlinkv3_spi.c
index 38fe9f9..8dc0cb3 100644
--- a/stlinkv3_spi.c
+++ b/stlinkv3_spi.c
@@ -482,7 +482,7 @@
int ret = 1;
int devIndex = 0;
struct libusb_context *usb_ctx;
- libusb_device_handle *stlinkv3_handle;
+ libusb_device_handle *stlinkv3_handle = NULL;
struct stlinkv3_spi_data *stlinkv3_data;
if (libusb_init(&usb_ctx)) {
--
To view, visit https://review.coreboot.org/c/flashrom/+/67714
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id80eaa2e27902351b40bea3fb66eb368680f4ff4
Gerrit-Change-Number: 67714
Gerrit-PatchSet: 1
Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com>
Gerrit-MessageType: newchange
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67713
to look at the new patch set (#2).
Change subject: flashchips.c: Add write protect support for W25Q16.V
......................................................................
flashchips.c: Add write protect support for W25Q16.V
Enable WRSR2 feature flag and define reg_bits and decode_range for
W25Q16.V to enable write protect support.
Signed-off-by: Khoa Hoang <admin(a)khoahoang.com>
Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75
---
M flashchips.c
1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/67713/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/67713
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75
Gerrit-Change-Number: 67713
Gerrit-PatchSet: 2
Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67700 )
Change subject: stlinkv3_spi: fix uninitialized pointer
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
There is a patch covering the same topic: CB:66225
--
To view, visit https://review.coreboot.org/c/flashrom/+/67700
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibaf25f67186724d9045ade849026782c3eac4952
Gerrit-Change-Number: 67700
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Mon, 19 Sep 2022 08:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment