September 2022 - flashrom-gerrit

[M] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par_master
by Jonathon Hall (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Edward O'Callaghan, Jonathon Hall, Nikolai Artemiev, Peter Marheine. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67695 to look at the new patch set (#4). Change subject: drivers: Move (un)map_flash_region from programmer to par_master ...................................................................... drivers: Move (un)map_flash_region from programmer to par_master Move (un)map_flash_region function pointers from programmer_entry to par_master. Only parallel masters require specialized flash mapping, and that mapping is closely tied to the way the memory is accessed using the other functions in par_master. ICH SPI internal programming now works with flash >16 MB. Previously it would fail due to attempting to mmap 32 MB or more, which is not possible as only the top 16 MB of flash is mapped into the address space. Validate that FWH/LPC programmers provide specialized mapping in register_par_master(); this is needed for chips with FEATURE_REGISTERMAP, which only exist on FWH or LPC buses. atapromise.c: Remove atapromise_map(); same behavior as fallback_map. dummyflasher.c: Use dummy mapper for parallel buses only. internal.c: Use physmap for parallel buses only. serprog.c: Replace mapper hack for 16 MB limit with max_rom_decode. programmer.c: Update comment in fallback_map(), NULL return is the desired behavior. Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Signed-off-by: Jonathon Hall <jonathon.hall(a)puri.sm> --- M atahpt.c M atapromise.c M atavia.c M buspirate_spi.c M ch341a_spi.c M dediprog.c M developerbox_spi.c M digilent_spi.c M drkaiser.c M dummyflasher.c M flashrom.c M ft2232_spi.c M gfxnvidia.c M hwaccess_physmap.c M include/flash.h M include/hwaccess_physmap.h M include/programmer.h M internal.c M it8212.c M jlink_spi.c M linux_mtd.c M linux_spi.c M mediatek_i2c_spi.c M mstarddc_spi.c M ni845x_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M ogp_spi.c M parade_lspcon.c M parallel.c M pickit2_spi.c M pony_spi.c M programmer.c M raiden_debug_spi.c M rayer_spi.c M realtek_mst_i2c_spi.c M satamv.c M satasii.c M serprog.c M stlinkv3_spi.c M usbblaster_spi.c 45 files changed, 98 insertions(+), 122 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/67695/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 4 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: internal: Pass programmer_cfg() through to MTD init
by Jonathon Hall (Code Review) 20 Sep '22

20 Sep '22

Jonathon Hall has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67744 ) Change subject: internal: Pass programmer_cfg() through to MTD init ...................................................................... internal: Pass programmer_cfg() through to MTD init extract_programmer_param_str() requires a valid cfg since 813c68a. Pass cfg through to try_mtd() and linux_mtd_init(). Test: Build with linux_mtd enabled, run with -p internal to ensure flashrom doesn't crash. Change-Id: I194ee0318c3bf829868e7b3c368ab45b3d2b3721 Signed-off-by: Jonathon Hall <jonathon.hall(a)puri.sm> --- M include/programmer.h M internal.c 2 files changed, 20 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/67744/1 diff --git a/include/programmer.h b/include/programmer.h index a7cea5e..12d7d7b 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -377,9 +377,9 @@ #if CONFIG_LINUX_MTD == 1 /* trivial wrapper to avoid cluttering internal_init() with #if */ -static inline int try_mtd(void) { return programmer_linux_mtd.init(NULL); }; +static inline int try_mtd(const struct programmer_cfg *cfg) { return programmer_linux_mtd.init(cfg); }; #else -static inline int try_mtd(void) { return 1; }; +static inline int try_mtd(const struct programmer_cfg *cfg) { return 1; }; #endif /* mcp6x_spi.c */ diff --git a/internal.c b/internal.c index 43aa51b..6a8db5e 100644 --- a/internal.c +++ b/internal.c @@ -215,7 +215,7 @@ */ internal_buses_supported = BUS_NONSPI; - if (try_mtd() == 0) { + if (try_mtd(cfg) == 0) { ret = 0; goto internal_init_exit; } -- To view, visit https://review.coreboot.org/c/flashrom/+/67744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I194ee0318c3bf829868e7b3c368ab45b3d2b3721 Gerrit-Change-Number: 67744 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par_master
by Thomas Heijligen (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Edward O'Callaghan, Jonathon Hall, Nikolai Artemiev, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 ) Change subject: drivers: Move (un)map_flash_region from programmer to par_master ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I've some WIP patches for atavia and atapromise. I try to get the hardware to test them, but this will take a month or so. CB:67655 CB:67656 -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 20 Sep 2022 16:46:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par_master
by Thomas Heijligen (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Edward O'Callaghan, Jonathon Hall, Nikolai Artemiev, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 ) Change subject: drivers: Move (un)map_flash_region from programmer to par_master ...................................................................... Patch Set 3: (1 comment) File serprog.c: https://review.coreboot.org/c/flashrom/+/67695/comment/1bb47bfc_58261087 PS2, Line 582: .map_flash_region = serprog_map, > Does anyone know if this is needed? […] This is a hack to make sure the chips have a max size of 16MB. It could be replaces by `max_rom_decode.spi` -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 20 Sep 2022 16:36:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par_master
by Jonathon Hall (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine. Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 ) Change subject: drivers: Move (un)map_flash_region from programmer to par_master ...................................................................... Patch Set 3: (4 comments) Patchset: PS2: > Yeah I think that would also work. […] Got this reworked, I agree that it's a lot cleaner. Only par_master provides mapping functions now, so this supersedes the specific change to ICH SPI hwseq, and the other SPI masters no longer use specialized mappers. File atapromise.c: https://review.coreboot.org/c/flashrom/+/67695/comment/3d7c69d8_2fbbd3dd PS2, Line 133: atapromise_map > Agree, will tweak this when I'm back Tuesday. Removed this, also updated the comment in fallback_map() since returning NULL is the desired behavior. File atavia.c: https://review.coreboot.org/c/flashrom/+/67695/comment/51d68ad5_45734160 PS2, Line 147: atavia_map > If you can test that would be awesome, FWIW I could keep this around even if we move the mapper into […] I kept this around for now since I can't test it and it doesn't hurt the overall structure. We could always remove it later, or if anybody tests it let me know and I can take it out. File serprog.c: https://review.coreboot.org/c/flashrom/+/67695/comment/6251a499_1080b494 PS2, Line 582: .map_flash_region = serprog_map, > Does anyone know if this is needed? […] I had to take this out to rework the mapper into par_master - I'm pretty sure it's not needed, but I don't have any hardware to test on. -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 20 Sep 2022 16:28:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par_master
by Jonathon Hall (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67695 to look at the new patch set (#3). Change subject: drivers: Move (un)map_flash_region from programmer to par_master ...................................................................... drivers: Move (un)map_flash_region from programmer to par_master Move (un)map_flash_region function pointers from programmer_entry to par_master. Only parallel masters require specialized flash mapping, and that mapping is closely tied to the way the memory is accessed using the other functions in par_master. ICH SPI internal programming now works with flash >16 MB. Previously it would fail due to attempting to mmap 32 MB or more, which is not possible as only the top 16 MB of flash is mapped into the address space. Validate that FWH/LPC programmers provide specialized mapping in register_par_master(); this is needed for chips with FEATURE_REGISTERMAP, which only exist on FWH or LPC buses. atapromise.c: Remove atapromise_map(); same behavior as fallback_map. dummy.c, internal.c, serprog.c: Only use programmer-specific flash mapping for parallel buses. programmer.c: Update comment in fallback_map(), NULL return is the desired behavior. Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Signed-off-by: Jonathon Hall <jonathon.hall(a)puri.sm> --- M atahpt.c M atapromise.c M atavia.c M buspirate_spi.c M ch341a_spi.c M dediprog.c M developerbox_spi.c M digilent_spi.c M drkaiser.c M dummyflasher.c M flashrom.c M ft2232_spi.c M gfxnvidia.c M hwaccess_physmap.c M include/flash.h M include/hwaccess_physmap.h M include/programmer.h M internal.c M it8212.c M jlink_spi.c M linux_mtd.c M linux_spi.c M mediatek_i2c_spi.c M mstarddc_spi.c M ni845x_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M ogp_spi.c M parade_lspcon.c M parallel.c M pickit2_spi.c M pony_spi.c M programmer.c M raiden_debug_spi.c M rayer_spi.c M realtek_mst_i2c_spi.c M satamv.c M satasii.c M serprog.c M stlinkv3_spi.c M usbblaster_spi.c 45 files changed, 101 insertions(+), 122 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/67695/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: test_build.sh: Improve robustness when dealing with empty $CC
by Felix Singer (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Patrick Georgi. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67740 ) Change subject: test_build.sh: Improve robustness when dealing with empty $CC ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb Gerrit-Change-Number: 67740 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Sep 2022 13:29:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: test_build.sh: Identify runs for Coverity Scan
by Felix Singer (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Patrick Georgi. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67739 ) Change subject: test_build.sh: Identify runs for Coverity Scan ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249 Gerrit-Change-Number: 67739 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Tue, 20 Sep 2022 13:29:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: cli_classic.c: Early init of layout obscures invalid memory access
by Angel Pons (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67723 ) Change subject: cli_classic.c: Early init of layout obscures invalid memory access ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/67723/comment/baf5c132_77550e60 PS2, Line 541: struct flashrom_layout *layout = NULL; This means "no layout", which is true: initially, the flashrom classic CLI doesn't have any layout to work with, yet. If you don't initialize this variable, it has no meaning: it's impossible to check if a variable has been initialized or not, and relying on compiler warnings is something I'd prefer not to do. https://review.coreboot.org/c/flashrom/+/67723/comment/41d15ca8_55748353 PS2, Line 1110: msg_gdbg("Valid layout could not be found without image.\n"); What does this message even mean? -- To view, visit https://review.coreboot.org/c/flashrom/+/67723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3df61b873da27f6945d60916a1c3713dedfc3924 Gerrit-Change-Number: 67723 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 20 Sep 2022 13:29:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: test_build.sh: Improve robustness when dealing with empty $CC
by Patrick Georgi (Code Review) 20 Sep '22

20 Sep '22

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67740 ) Change subject: test_build.sh: Improve robustness when dealing with empty $CC ...................................................................... test_build.sh: Improve robustness when dealing with empty $CC Add quotes so that = knows what to compare, otherwise the shell complains: ./test_build.sh: 16: [: =: unexpected operator Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M test_build.sh 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/67740/1 diff --git a/test_build.sh b/test_build.sh index 4d6570b..0a4506a 100755 --- a/test_build.sh +++ b/test_build.sh @@ -13,7 +13,7 @@ CH341A_SPI DIGILENT_SPI JLINK_SPI" -if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then +if [ "$(basename "${CC}")" = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then is_scan_build_env=1 fi -- To view, visit https://review.coreboot.org/c/flashrom/+/67740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb Gerrit-Change-Number: 67740 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022