September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: test_build.sh: Identify runs for Coverity Scan
by Patrick Georgi (Code Review) 20 Sep '22

20 Sep '22

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67739 ) Change subject: test_build.sh: Identify runs for Coverity Scan ...................................................................... test_build.sh: Identify runs for Coverity Scan For Coverity Scan[0] the same build rules apply as for scan-build. [0] https://scan.coverity.com/projects/flashrom Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M test_build.sh 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/67739/1 diff --git a/test_build.sh b/test_build.sh index b2320b8..4d6570b 100755 --- a/test_build.sh +++ b/test_build.sh @@ -13,7 +13,7 @@ CH341A_SPI DIGILENT_SPI JLINK_SPI" -if [ $(basename "${CC}") = "ccc-analyzer" ]; then +if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then is_scan_build_env=1 fi -- To view, visit https://review.coreboot.org/c/flashrom/+/67739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249 Gerrit-Change-Number: 67739 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
by Felix Singer (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Felix Singer, Shreeyash . Felix Singer has uploaded a new patch set (#2) to the change originally created by Shreeyash . ( https://review.coreboot.org/c/flashrom/+/66225 ) Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ...................................................................... stlinkv3_spi: Bug fix, Initialize uninitialized pointers Discovered by clang static analysis, `stlinkv3_handle` on line 510 was a potential comparison of an un-initialized variable. Initializing it and two other pointers (usb_ctx and stlinkv3_data) to NULL fixes this. Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f Signed-off-by: Shreeyash Pandey <shreeyash335(a)gmail.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M stlinkv3_spi.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/66225/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f Gerrit-Change-Number: 66225 Gerrit-PatchSet: 2 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Shreeyash <shreeyash335(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: stlinkv3_spi: fix uninitialized pointer
by Felix Singer (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk, Alexander Goncharov. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67700 ) Change subject: stlinkv3_spi: fix uninitialized pointer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > +1 to Thomas' observation. I prefer using CB:66225 since the patch was pushed earlier. -- To view, visit https://review.coreboot.org/c/flashrom/+/67700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibaf25f67186724d9045ade849026782c3eac4952 Gerrit-Change-Number: 67700 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 20 Sep 2022 12:48:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: cli_classic.c: Early init of layout obscures invalid memory access
by Thomas Heijligen (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67723 ) Change subject: cli_classic.c: Early init of layout obscures invalid memory access ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/67723/comment/b0a4558f_2d21dc1e PS2, Line 7: cli_classic.c: Early init of layout obscures invalid memory access Can you give the codepath for the invalid memory access and why the patch helps to fix this? IMO settings flashrom_layout only when some valid layout is found is a good behavior. -- To view, visit https://review.coreboot.org/c/flashrom/+/67723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3df61b873da27f6945d60916a1c3713dedfc3924 Gerrit-Change-Number: 67723 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 20 Sep 2022 12:28:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: stlinkv3_spi: fix uninitialized pointer
by Angel Pons (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67700 ) Change subject: stlinkv3_spi: fix uninitialized pointer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > As I mention in CB:66225 the `maybe-uninitialized` or scan-builds `core.uninitialized. […] +1 to Thomas' observation. -- To view, visit https://review.coreboot.org/c/flashrom/+/67700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibaf25f67186724d9045ade849026782c3eac4952 Gerrit-Change-Number: 67700 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 20 Sep 2022 12:24:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: layout.c: Validate _layout_entry_by_name() arguments before use
by Angel Pons (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67722 ) Change subject: layout.c: Validate _layout_entry_by_name() arguments before use ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/67722/comment/e5e2a9f6_113693cc PS2, Line 9: It maybe It may be https://review.coreboot.org/c/flashrom/+/67722/comment/9613fcd5_aee05b8d PS2, Line 10: feed with a NULL pointer. being fed a NULL pointer. -- To view, visit https://review.coreboot.org/c/flashrom/+/67722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2a19c0e586f8575b8b3c2c02b5afad312efacfc9 Gerrit-Change-Number: 67722 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 20 Sep 2022 11:42:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: cli_classic.c: Add error messages for invalid --wp-region use
by Angel Pons (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67725 ) Change subject: cli_classic.c: Add error messages for invalid --wp-region use ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/67725/comment/b3617fe4_705aea86 PS1, Line 1126: goto out_release; No error code? *reads the if-block's condition* ... I'm stupid, don't mind me... -- To view, visit https://review.coreboot.org/c/flashrom/+/67725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie606ba7f8a423405099679ca62169c395d994b5d Gerrit-Change-Number: 67725 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 20 Sep 2022 11:40:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: stlinkv3_spi: fix uninitialized pointer
by Thomas Heijligen (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67700 ) Change subject: stlinkv3_spi: fix uninitialized pointer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Thomas what do you think is the state of CB:66225 ? It does seem to cover a bit more (3 lines vs 1 l […] As I mention in CB:66225 the `maybe-uninitialized` or scan-builds `core.uninitialized.Branch` are false positives in this case. My suggestion would be to add a comment `libusb_device_handle *stlinkv3_handle = NULL; /* NULL for suppressing scan-build false positive core.uninitialized.Branch */` The other lines of CB:66225 are not needed any longer. The underlaying is solved I don't care which patch will make it. -- To view, visit https://review.coreboot.org/c/flashrom/+/67700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibaf25f67186724d9045ade849026782c3eac4952 Gerrit-Change-Number: 67700 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 20 Sep 2022 10:02:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: cli_classic.c: Add error messages for invalid --wp-region use
by Edward O'Callaghan (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67725 ) Change subject: cli_classic.c: Add error messages for invalid --wp-region use ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie606ba7f8a423405099679ca62169c395d994b5d Gerrit-Change-Number: 67725 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 20 Sep 2022 07:34:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: cli_classic.c: Add error messages for invalid --wp-region use
by Nikolai Artemiev (Code Review) 20 Sep '22

20 Sep '22

Attention is currently required from: Edward O'Callaghan. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67725 ) Change subject: cli_classic.c: Add error messages for invalid --wp-region use ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: N.B. This isn't required to fix the segfault in b/247055486 but may help reduce future confusion around --wp-region use. -- To view, visit https://review.coreboot.org/c/flashrom/+/67725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie606ba7f8a423405099679ca62169c395d994b5d Gerrit-Change-Number: 67725 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 20 Sep 2022 05:50:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022