September 2022 - flashrom-gerrit

[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer
by Jean THOMAS (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Thomas Heijligen. Jean THOMAS has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 ) Change subject: dirtyjtag: Add DirtyJTAG programmer ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: Hi, I changed the way kernel driver detatch is done. Let me know if you need other fixes. File dirtyjtag_spi.c: https://review.coreboot.org/c/flashrom/+/67878/comment/bae4f6af_36ffa890 PS1, Line 214: ret = libusb_set_auto_detach_kernel_driver(handle, 1); > I mean CB:67071 Done -- To view, visit https://review.coreboot.org/c/flashrom/+/67878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Gerrit-Change-Number: 67878 Gerrit-PatchSet: 4 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 27 Sep 2022 19:26:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer
by Jean THOMAS (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Jean THOMAS. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67878 to look at the new patch set (#4). Change subject: dirtyjtag: Add DirtyJTAG programmer ...................................................................... dirtyjtag: Add DirtyJTAG programmer Add a new programmer driver for the DirtyJTAG project (a USB-JTAG firmware for STM32 MCUs). Successfully tested with DirtyJTAG 1.4 running on an Olimex STM32-H103 development board and a SST25VF020B SPI flash chip. Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Signed-off-by: Jean THOMAS <virgule(a)jeanthomas.me> --- M Makefile A dirtyjtag_spi.c M flashrom.8.tmpl M include/programmer.h M meson.build M meson_options.txt M programmer_table.c 7 files changed, 374 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/67878/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/67878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Gerrit-Change-Number: 67878 Gerrit-PatchSet: 4 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: newpatchset

1 0

[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer
by Jean THOMAS (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Jean THOMAS. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67878 to look at the new patch set (#3). Change subject: dirtyjtag: Add DirtyJTAG programmer ...................................................................... dirtyjtag: Add DirtyJTAG programmer Add a new programmer driver for the DirtyJTAG project (a USB-JTAG firmware for STM32 MCUs). Successfully tested with DirtyJTAG 1.4 running on an Olimex STM32-H103 development board and a SST25VF020B SPI flash chip. Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Signed-off-by: Jean THOMAS <virgule(a)jeanthomas.me> --- M Makefile A dirtyjtag_spi.c M flashrom.8.tmpl M include/programmer.h M meson.build M meson_options.txt M programmer_table.c 7 files changed, 373 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/67878/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Gerrit-Change-Number: 67878 Gerrit-PatchSet: 3 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: cli_classic.c: Add error messages for invalid --wp-region use
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Nikolai Artemiev. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67725 ) Change subject: cli_classic.c: Add error messages for invalid --wp-region use ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/67725/comment/66e44803_e16aa77b PS6, Line 9: warning errors -- To view, visit https://review.coreboot.org/c/flashrom/+/67725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie606ba7f8a423405099679ca62169c395d994b5d Gerrit-Change-Number: 67725 Gerrit-PatchSet: 6 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 27 Sep 2022 17:23:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips.c: Add write protect support for W25Q16.V
by Khoa Hoang (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Khoa Hoang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67713 ) Change subject: flashchips.c: Add write protect support for W25Q16.V ...................................................................... Patch Set 4: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/67713/comment/6e1b632b_05dece13 PS4, Line 17543: .sec = {STATUS1, 6, RW}, > Maybe we should add `. […] I just check the datasheet for W25Q16DV and it doesn't support that register bit. Datasheet only mention status1,2 and I don't think it support wps bit. -- To view, visit https://review.coreboot.org/c/flashrom/+/67713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Gerrit-Change-Number: 67713 Gerrit-PatchSet: 4 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 27 Sep 2022 16:57:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[1.2.x]: chipset_enable.c: Disable SPI on ICH7 if booted from LPC
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Nico Huber. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67863 ) Change subject: chipset_enable.c: Disable SPI on ICH7 if booted from LPC ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: I5e59e66a2dd16b07f2dca410997fce38ab9c8fd1 Gerrit-Change-Number: 67863 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 27 Sep 2022 16:43:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[1.2.x]: helpers.c: Fix undefined behavior in strndup()
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Nico Huber, Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67870 ) Change subject: helpers.c: Fix undefined behavior in strndup() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: Id34127024085879228626fbad59af03268ec5255 Gerrit-Change-Number: 67870 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 27 Sep 2022 16:42:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[1.2.x]: linux_mtd: Disable buffering on the mtd device
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Nico Huber, Douglas Anderson, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67871 ) Change subject: linux_mtd: Disable buffering on the mtd device ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: I989afd83a33013b2756a0090d6b08245613215c6 Gerrit-Change-Number: 67871 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Sep 2022 16:42:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ft2232_spi.c: Split out most programmer param parsing
by Angel Pons (Code Review) 27 Sep '22

27 Sep '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67908 ) Change subject: ft2232_spi.c: Split out most programmer param parsing ...................................................................... ft2232_spi.c: Split out most programmer param parsing Separate most programmer parameter parsing into a helper function. Change-Id: I25faac1060fc2bcd6042e34802e5bc493c936377 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M ft2232_spi.c 1 file changed, 52 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/67908/1 diff --git a/ft2232_spi.c b/ft2232_spi.c index 4edbf71..b41ee74 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -326,37 +326,10 @@ uint8_t pindir_high; }; -/* Returns 0 upon success, a negative number upon errors. */ -static int ft2232_spi_init(const struct programmer_cfg *cfg) +static int ft2232_get_params(struct ft2232_parameters *const parameters, const struct programmer_cfg *cfg) { - int ret = 0; - unsigned char buf[512]; int channel_count = 4; /* Stores the number of channels of the device. */ - /* - * The 'H' chips can run with an internal clock of either 12 MHz or 60 MHz, - * but the non-H chips can only run at 12 MHz. We disable the divide-by-5 - * prescaler on 'H' chips so they run at 60MHz. - */ - bool clock_5x = true; - int f; - char *arg, *arg2; - double mpsse_clk; - - struct ft2232_parameters programmer_parameters = { - .ft2232_vid = FTDI_VID, - .ft2232_type = FTDI_FT4232H_PID, - .ft2232_interface = INTERFACE_A, - .divisor = DEFAULT_DIVISOR, - .cs_bits = 0x08, - .aux_bits = 0x00, - .pindir = 0x0b, - .aux_bits_high = 0x00, - .pindir_high = 0x00, - }; - struct ft2232_parameters *const parameters = &programmer_parameters; - - struct ftdi_context ftdic; - struct ft2232_data *spi_data; + char *arg; arg = extract_programmer_param_str(cfg, "type"); if (arg) { @@ -603,6 +576,44 @@ return -2; } + return 0; +} + +/* Returns 0 upon success, a negative number upon errors. */ +static int ft2232_spi_init(const struct programmer_cfg *cfg) +{ + int ret; + unsigned char buf[512]; + /* + * The 'H' chips can run with an internal clock of either 12 MHz or 60 MHz, + * but the non-H chips can only run at 12 MHz. We disable the divide-by-5 + * prescaler on 'H' chips so they run at 60MHz. + */ + bool clock_5x = true; + int f; + char *arg, *arg2; + double mpsse_clk; + + struct ft2232_parameters programmer_parameters = { + .ft2232_vid = FTDI_VID, + .ft2232_type = FTDI_FT4232H_PID, + .ft2232_interface = INTERFACE_A, + .divisor = DEFAULT_DIVISOR, + .cs_bits = 0x08, + .aux_bits = 0x00, + .pindir = 0x0b, + .aux_bits_high = 0x00, + .pindir_high = 0x00, + }; + struct ft2232_parameters *const parameters = &programmer_parameters; + + struct ftdi_context ftdic; + struct ft2232_data *spi_data; + + ret = ft2232_get_params(parameters, cfg); + if (ret) + return ret; + msg_pdbg("Using device type %s %s ", get_ft2232_vendorname(parameters->ft2232_vid, parameters->ft2232_type), get_ft2232_devicename(parameters->ft2232_vid, parameters->ft2232_type)); -- To view, visit https://review.coreboot.org/c/flashrom/+/67908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25faac1060fc2bcd6042e34802e5bc493c936377 Gerrit-Change-Number: 67908 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: ft2232_spi.c: Add struct for programmer params
by Angel Pons (Code Review) 27 Sep '22

27 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67906 to look at the new patch set (#2). Change subject: ft2232_spi.c: Add struct for programmer params ...................................................................... ft2232_spi.c: Add struct for programmer params Introduce a struct to store ft2232_spi programmer parameters. This struct allows separating the parsing of programmer params from the code that uses the values, which should allow specifying parameter values directly into this struct. Introduce a pointer to reference struct members to reduce diffstat noise in subsequent commits. Change-Id: I36b9f5f8481907bd605e9310bef08592bb7d9827 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M ft2232_spi.c 1 file changed, 127 insertions(+), 94 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/67906/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I36b9f5f8481907bd605e9310bef08592bb7d9827 Gerrit-Change-Number: 67906 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022