September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: manibuilder/debian: Add Bullseye image tags
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67010 ) Change subject: manibuilder/debian: Add Bullseye image tags ...................................................................... manibuilder/debian: Add Bullseye image tags Add new image tags for all architectures but aarch64 and mips. Alas, the aarch64 image makes QEMU segfault atm. The mips image lacks most packages. Change-Id: If2e58adc25412d3618a5c19a61feab44a3bf916f Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67010 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M util/manibuilder/Makefile.targets 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Makefile.targets b/util/manibuilder/Makefile.targets index f372f10..5bde7d5 100644 --- a/util/manibuilder/Makefile.targets +++ b/util/manibuilder/Makefile.targets @@ -17,7 +17,10 @@ $(foreach v,34 33 32 31 30 29, \ fedora\:$(v)-$(a))) \ fedora\:28-armhfp \ - $(foreach a,ppc64el arm64 armhf mips mipsel amd64 i386, \ + $(foreach a,ppc64el armhf mipsel amd64 i386, \ + $(foreach v,bullseye buster stretch, \ + debian-debootstrap\:$(a)-$(v))) \ + $(foreach a,arm64 mips, \ $(foreach v,buster stretch, \ debian-debootstrap\:$(a)-$(v))) \ $(foreach a,ppc64el arm64 armhf amd64 i386, \ -- To view, visit https://review.coreboot.org/c/flashrom/+/67010 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If2e58adc25412d3618a5c19a61feab44a3bf916f Gerrit-Change-Number: 67010 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: mainbuilder/debian,ubuntu: Disable TLS verification for Git commands
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66999 ) Change subject: mainbuilder/debian,ubuntu: Disable TLS verification for Git commands ...................................................................... mainbuilder/debian,ubuntu: Disable TLS verification for Git commands Disable certificate verification for Git commands, including those that run during tests. At some point, the `ca-certificates` won't get updates anymore and, ideally, existing docker images will keep working. Change-Id: I8d7dedeb97777d2f1e6e7e69aefb8cc7ca604940 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/66999 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M util/manibuilder/Dockerfile.debian-debootstrap M util/manibuilder/Dockerfile.ubuntu-debootstrap 2 files changed, 20 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Dockerfile.debian-debootstrap b/util/manibuilder/Dockerfile.debian-debootstrap index ce201f8..d2e0eee 100644 --- a/util/manibuilder/Dockerfile.debian-debootstrap +++ b/util/manibuilder/Dockerfile.debian-debootstrap @@ -10,6 +10,7 @@ { apt-get -qqy install libjaylink-dev || true; } && \ apt-get clean +ENV GIT_SSL_NO_VERIFY=1 USER mani RUN \ cd && \ diff --git a/util/manibuilder/Dockerfile.ubuntu-debootstrap b/util/manibuilder/Dockerfile.ubuntu-debootstrap index fe3ad1e..f002d9a 100644 --- a/util/manibuilder/Dockerfile.ubuntu-debootstrap +++ b/util/manibuilder/Dockerfile.ubuntu-debootstrap @@ -23,6 +23,7 @@ { apt-get -qqy install libjaylink-dev || true; } && \ apt-get clean +ENV GIT_SSL_NO_VERIFY=1 USER mani RUN \ cd && \ -- To view, visit https://review.coreboot.org/c/flashrom/+/66999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8d7dedeb97777d2f1e6e7e69aefb8cc7ca604940 Gerrit-Change-Number: 66999 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: manibuilder/debian: Drop all sid image tags
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66998 ) Change subject: manibuilder/debian: Drop all sid image tags ...................................................................... manibuilder/debian: Drop all sid image tags Sid is the codename of Debian unstable, it's a moving target. Thus, we can never hope to be able to reproduce what an older image did. Change-Id: I637daffae8a5f33493de02dc240df63eefcc9aa1 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/66998 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M util/manibuilder/Makefile.targets 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Makefile.targets b/util/manibuilder/Makefile.targets index d4ad1b6..f372f10 100644 --- a/util/manibuilder/Makefile.targets +++ b/util/manibuilder/Makefile.targets @@ -18,7 +18,7 @@ fedora\:$(v)-$(a))) \ fedora\:28-armhfp \ $(foreach a,ppc64el arm64 armhf mips mipsel amd64 i386, \ - $(foreach v,sid buster stretch, \ + $(foreach v,buster stretch, \ debian-debootstrap\:$(a)-$(v))) \ $(foreach a,ppc64el arm64 armhf amd64 i386, \ $(foreach v,bionic xenial, \ @@ -69,7 +69,6 @@ debian-debootstrap\:mipsel-stretch \ debian-debootstrap\:amd64-stretch \ debian-debootstrap\:i386-stretch \ - debian-debootstrap\:amd64-sid \ ubuntu-debootstrap\:arm64-xenial \ ubuntu-debootstrap\:amd64-xenial \ ubuntu-debootstrap\:powerpc-xenial \ -- To view, visit https://review.coreboot.org/c/flashrom/+/66998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I637daffae8a5f33493de02dc240df63eefcc9aa1 Gerrit-Change-Number: 66998 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: manibuilder/fedora: Add newer image tags
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66997 ) Change subject: manibuilder/fedora: Add newer image tags ...................................................................... manibuilder/fedora: Add newer image tags Also order tags by their architecture for readability. Change-Id: I68ad93ed26ae11c05b93b4d097478e471f65abc4 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/66997 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M util/manibuilder/Makefile.targets 1 file changed, 25 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Makefile.targets b/util/manibuilder/Makefile.targets index d24c3c0..d4ad1b6 100644 --- a/util/manibuilder/Makefile.targets +++ b/util/manibuilder/Makefile.targets @@ -7,12 +7,16 @@ centos\:7.6-armhfp-clean centos\:7.6-amd64-clean \ centos\:7.3-aarch64-clean centos\:7.3-amd64-clean \ centos\:7.2-amd64-clean \ - $(foreach a,x86_64 s390x aarch64, fedora\:30-$(a)) \ - $(foreach a,x86_64 s390x ppc64le aarch64, fedora\:29-$(a)) \ - fedora\:28-armhfp \ - $(foreach a,x86_64 ppc64le aarch64, \ - $(foreach v,25 24, \ + $(foreach a,x86_64 aarch64, \ + $(foreach v,34 33 32 31 30 29 25 24, \ fedora\:$(v)-$(a))) \ + $(foreach a,ppc64le, \ + $(foreach v,34 33 29 25 24, \ + fedora\:$(v)-$(a))) \ + $(foreach a,s390x, \ + $(foreach v,34 33 32 31 30 29, \ + fedora\:$(v)-$(a))) \ + fedora\:28-armhfp \ $(foreach a,ppc64el arm64 armhf mips mipsel amd64 i386, \ $(foreach v,sid buster stretch, \ debian-debootstrap\:$(a)-$(v))) \ -- To view, visit https://review.coreboot.org/c/flashrom/+/66997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I68ad93ed26ae11c05b93b4d097478e471f65abc4 Gerrit-Change-Number: 66997 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: manibuilder/alpine: Add newer image tags
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66995 ) Change subject: manibuilder/alpine: Add newer image tags ...................................................................... manibuilder/alpine: Add newer image tags Most of the images built out of the box. Only `alpine:armhf-v3.11` needs a little workaround for wrong filesystem permissions. Change-Id: Iac5fea993e6345c7507bd381550f3fbfe55341f9 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/66995 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M util/manibuilder/Dockerfile.alpine M util/manibuilder/Makefile.targets 2 files changed, 22 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Dockerfile.alpine b/util/manibuilder/Dockerfile.alpine index 35d787a..91b8806 100644 --- a/util/manibuilder/Dockerfile.alpine +++ b/util/manibuilder/Dockerfile.alpine @@ -6,6 +6,10 @@ apk add ca-certificates build-base linux-headers git ccache \ pciutils-dev libusb-compat-dev libusb-dev +# fix weird permissions in armhf-v3.11 +RUN [ -d /usr/share/git-core/templates ] && \ + chmod -R a+r /usr/share/git-core/templates + ENV GIT_SSL_NO_VERIFY=1 USER mani RUN \ diff --git a/util/manibuilder/Makefile.targets b/util/manibuilder/Makefile.targets index 13b0503..d24c3c0 100644 --- a/util/manibuilder/Makefile.targets +++ b/util/manibuilder/Makefile.targets @@ -21,7 +21,7 @@ ubuntu-debootstrap\:$(a)-$(v))) \ ubuntu-debootstrap\:powerpc-xenial \ $(foreach a,aarch64 armhf amd64 i386, \ - $(foreach v,v3.9 v3.8 v3.7 v3.6, \ + $(foreach v,v3.14 v3.13 v3.12 v3.11 v3.10 v3.9 v3.8 v3.7 v3.6, \ alpine\:$(a)-$(v))) \ OTHER_TAGS := djgpp\:6.1.0 -- To view, visit https://review.coreboot.org/c/flashrom/+/66995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iac5fea993e6345c7507bd381550f3fbfe55341f9 Gerrit-Change-Number: 66995 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: manibuilder/fedora: Disable TLS verification for Git commands
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66988 ) Change subject: manibuilder/fedora: Disable TLS verification for Git commands ...................................................................... manibuilder/fedora: Disable TLS verification for Git commands Pull the `ca-certificates` package but also disable certificate verification for Git commands, including those that run during tests. At some point, the `ca-certificates` won't get updates anymore and, ideally, existing docker images will keep working. Change-Id: Iaac1defd2dc640a9cf9c317d3b13ded5743390df Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/66988 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M util/manibuilder/Dockerfile.fedora 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Dockerfile.fedora b/util/manibuilder/Dockerfile.fedora index fa2ff2f..79a939a 100644 --- a/util/manibuilder/Dockerfile.fedora +++ b/util/manibuilder/Dockerfile.fedora @@ -2,11 +2,12 @@ RUN \ useradd -p locked -m mani && \ - dnf install -q -y git gcc ccache make systemd-devel \ + dnf install -q -y ca-certificates git gcc ccache make systemd-devel \ pciutils-devel libusb-devel libusbx-devel libftdi-devel \ libjaylink-devel && \ dnf clean -q -y all +ENV GIT_SSL_NO_VERIFY=1 USER mani RUN \ cd && \ -- To view, visit https://review.coreboot.org/c/flashrom/+/66988 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaac1defd2dc640a9cf9c317d3b13ded5743390df Gerrit-Change-Number: 66988 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: manibuilder/fedora: Install `systemd-devel` package
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66987 ) Change subject: manibuilder/fedora: Install `systemd-devel` package ...................................................................... manibuilder/fedora: Install `systemd-devel` package This adds `libudev` which is linked by `libusb`. Generally, this wouldn't be required with shared libraries, however we ask pkg- config for the full dependency graph to support static libraries alike. Change-Id: I50f5333a7a9eae174eff8ae9cf451de3080f9fa8 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/66987 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M util/manibuilder/Dockerfile.fedora 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Dockerfile.fedora b/util/manibuilder/Dockerfile.fedora index 319039b..fa2ff2f 100644 --- a/util/manibuilder/Dockerfile.fedora +++ b/util/manibuilder/Dockerfile.fedora @@ -2,7 +2,7 @@ RUN \ useradd -p locked -m mani && \ - dnf install -q -y git gcc ccache make \ + dnf install -q -y git gcc ccache make systemd-devel \ pciutils-devel libusb-devel libusbx-devel libftdi-devel \ libjaylink-devel && \ dnf clean -q -y all -- To view, visit https://review.coreboot.org/c/flashrom/+/66987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50f5333a7a9eae174eff8ae9cf451de3080f9fa8 Gerrit-Change-Number: 66987 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: manibuilder/alpine: Disable TLS verification for Git commands
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66984 ) Change subject: manibuilder/alpine: Disable TLS verification for Git commands ...................................................................... manibuilder/alpine: Disable TLS verification for Git commands Pull the `ca-certificates` package but also disable certificate verification for Git commands, including those that run during tests. At some point, the `ca-certificates` won't get updates anymore and, ideally, existing docker images will keep working. Change-Id: I38c2404c50c97f3ae38fad602f587ce25719a6f3 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/66984 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M util/manibuilder/Dockerfile.alpine 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Dockerfile.alpine b/util/manibuilder/Dockerfile.alpine index 63d4ba3..35d787a 100644 --- a/util/manibuilder/Dockerfile.alpine +++ b/util/manibuilder/Dockerfile.alpine @@ -3,9 +3,10 @@ RUN \ adduser -D mani mani && \ apk update && \ - apk add build-base linux-headers git ccache \ + apk add ca-certificates build-base linux-headers git ccache \ pciutils-dev libusb-compat-dev libusb-dev +ENV GIT_SSL_NO_VERIFY=1 USER mani RUN \ cd && \ -- To view, visit https://review.coreboot.org/c/flashrom/+/66984 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I38c2404c50c97f3ae38fad602f587ce25719a6f3 Gerrit-Change-Number: 66984 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: manibuilder/centos: Install `systemd-devel` package
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66983 ) Change subject: manibuilder/centos: Install `systemd-devel` package ...................................................................... manibuilder/centos: Install `systemd-devel` package This adds `libudev` which is linked by `libusb`. Generally, this wouldn't be required with shared libraries, however we ask pkg- config for the full dependency graph to support static libraries alike. Change-Id: I50ba939c51215089b2e48b92779a1e6b49939b32 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/66983 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M util/manibuilder/Dockerfile.centos 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Dockerfile.centos b/util/manibuilder/Dockerfile.centos index 16ea921..aa28fc4 100644 --- a/util/manibuilder/Dockerfile.centos +++ b/util/manibuilder/Dockerfile.centos @@ -2,7 +2,7 @@ RUN \ useradd -p locked -m mani && \ - yum install -q -y ca-certificates git gcc \ + yum install -q -y ca-certificates git gcc systemd-devel \ pciutils-devel libusb-devel libusbx-devel && \ yum clean -q -y all -- To view, visit https://review.coreboot.org/c/flashrom/+/66983 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50ba939c51215089b2e48b92779a1e6b49939b32 Gerrit-Change-Number: 66983 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: manibuilder/centos: Disable TLS verification for Git commands
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66982 ) Change subject: manibuilder/centos: Disable TLS verification for Git commands ...................................................................... manibuilder/centos: Disable TLS verification for Git commands Pull the `ca-certificates` package but also disable certificate verification for Git commands, including those that run during tests. At some point, the `ca-certificates` won't get updates anymore and, ideally, existing docker images will keep working. Change-Id: I6bc2a85c67b84e89656fe5d7191d354c2f97ff05 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/66982 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M util/manibuilder/Dockerfile.centos 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Dockerfile.centos b/util/manibuilder/Dockerfile.centos index fcae9c8..16ea921 100644 --- a/util/manibuilder/Dockerfile.centos +++ b/util/manibuilder/Dockerfile.centos @@ -2,9 +2,11 @@ RUN \ useradd -p locked -m mani && \ - yum install -q -y git gcc pciutils-devel libusb-devel libusbx-devel && \ + yum install -q -y ca-certificates git gcc \ + pciutils-devel libusb-devel libusbx-devel && \ yum clean -q -y all +ENV GIT_SSL_NO_VERIFY=1 USER mani RUN \ cd && \ -- To view, visit https://review.coreboot.org/c/flashrom/+/66982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6bc2a85c67b84e89656fe5d7191d354c2f97ff05 Gerrit-Change-Number: 66982 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022