September 2022 - flashrom-gerrit

[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer
by Jean THOMAS (Code Review) 28 Sep '22

28 Sep '22

Attention is currently required from: Thomas Heijligen, Jean THOMAS. Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67878 to look at the new patch set (#5). Change subject: dirtyjtag: Add DirtyJTAG programmer ...................................................................... dirtyjtag: Add DirtyJTAG programmer Add a new programmer driver for the DirtyJTAG project (a USB-JTAG firmware for STM32 MCUs). Successfully tested with DirtyJTAG 1.4 running on an Olimex STM32-H103 development board and a SST25VF020B SPI flash chip. Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Signed-off-by: Jean THOMAS <virgule(a)jeanthomas.me> --- M Makefile A dirtyjtag_spi.c M flashrom.8.tmpl M include/programmer.h M meson.build M meson_options.txt M programmer_table.c 7 files changed, 365 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/67878/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/67878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Gerrit-Change-Number: 67878 Gerrit-PatchSet: 5 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashchips.c: Add write protect support for W25Q16.V
by Nikolai Artemiev (Code Review) 28 Sep '22

28 Sep '22

Attention is currently required from: Khoa Hoang, Edward O'Callaghan. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67713 ) Change subject: flashchips.c: Add write protect support for W25Q16.V ...................................................................... Patch Set 4: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/67713/comment/49fd6fde_2b036a63 PS4, Line 17543: .sec = {STATUS1, 6, RW}, > I just check the datasheet for W25Q16DV and it doesn't support that register bit. […] Ack, I had the wrong datasheet. I forgot that this chip entry is for the W25Q16DV and not W25Q16JV. -- To view, visit https://review.coreboot.org/c/flashrom/+/67713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Gerrit-Change-Number: 67713 Gerrit-PatchSet: 4 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 28 Sep 2022 03:36:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Khoa Hoang <admin(a)khoahoang.com> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[1.0.x]: spi25: Debug flashrom crash when Write Protect is ON
by Nikolai Artemiev (Code Review) 28 Sep '22

28 Sep '22

Attention is currently required from: Nico Huber, Stefan Reinauer, SANTHOSH JANARDHANA HASSAN. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67840 ) Change subject: spi25: Debug flashrom crash when Write Protect is ON ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/67840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I81094ab5f16a85871fc9869a2e285eddbbbdec4e Gerrit-Change-Number: 67840 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN <sahassan(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yuji Sasaki <sasakiy(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: SANTHOSH JANARDHANA HASSAN <sahassan(a)google.com> Gerrit-Comment-Date: Wed, 28 Sep 2022 03:02:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: tree: provide flashrom context into programmer's delay
by Edward O'Callaghan (Code Review) 28 Sep '22

28 Sep '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66373 ) Change subject: tree: provide flashrom context into programmer's delay ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/66373/comment/c0b875b4_742059aa PS4, Line 10: This is an important step to : remove the global state because it'll allow the programmer's data : to be used in delay functions. Maybe just drop part of this sentence after 'because' as its not what this patch does specifically following the advise Felix gave me earlier on another related patch. https://review.coreboot.org/c/flashrom/+/66373/comment/4b284599_5a50c4d7 PS4, Line 13: : Programmers that use internal delay can provide NULL as a context. Move this up to the last paragraph. https://review.coreboot.org/c/flashrom/+/66373/comment/d8b04c3f_7c80a654 PS4, Line 16: This is one of the steps on the way to move master's data : memory management behind the initialisation API, for more : context see other patches under the same topic specified below. Drop this paragraph. -- To view, visit https://review.coreboot.org/c/flashrom/+/66373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229 Gerrit-Change-Number: 66373 Gerrit-PatchSet: 4 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 28 Sep 2022 02:32:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tree/: plumb flashctx into programmer_delay()
by Edward O'Callaghan (Code Review) 28 Sep '22

28 Sep '22

Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67392 ) Change subject: tree/: plumb flashctx into programmer_delay() ...................................................................... Abandoned duplicates https://review.coreboot.org/c/flashrom/+/66373 -- To view, visit https://review.coreboot.org/c/flashrom/+/67392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I51792168525c145092f78236265ba43acf70bfad Gerrit-Change-Number: 67392 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move variable `enable_target_power` into parameter struct
by Felix Singer (Code Review) 28 Sep '22

28 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67889 to look at the new patch set (#2). Change subject: jlink_spi.c: Move variable `enable_target_power` into parameter struct ...................................................................... jlink_spi.c: Move variable `enable_target_power` into parameter struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Id32a6866372658a04fd62385d226294cfbcd4227 --- M jlink_spi.c 1 file changed, 16 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/67889/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id32a6866372658a04fd62385d226294cfbcd4227 Gerrit-Change-Number: 67889 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move variable `reset_cs` into parameter struct
by Felix Singer (Code Review) 28 Sep '22

28 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67888 to look at the new patch set (#3). Change subject: jlink_spi.c: Move variable `reset_cs` into parameter struct ...................................................................... jlink_spi.c: Move variable `reset_cs` into parameter struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I79f9009b407bc5601fa03878b6fe53c190214c3f --- M jlink_spi.c 1 file changed, 16 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/67888/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/67888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I79f9009b407bc5601fa03878b6fe53c190214c3f Gerrit-Change-Number: 67888 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move serial number vars into parameter struct
by Felix Singer (Code Review) 28 Sep '22

28 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67887 to look at the new patch set (#4). Change subject: jlink_spi.c: Move serial number vars into parameter struct ...................................................................... jlink_spi.c: Move serial number vars into parameter struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ib22224cca4c02f82a643488c118b88cba6b6a50a --- M jlink_spi.c 1 file changed, 19 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/67887/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/67887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib22224cca4c02f82a643488c118b88cba6b6a50a Gerrit-Change-Number: 67887 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move variable `speed` into parameter struct
by Felix Singer (Code Review) 28 Sep '22

28 Sep '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67886 to look at the new patch set (#4). Change subject: jlink_spi.c: Move variable `speed` into parameter struct ...................................................................... jlink_spi.c: Move variable `speed` into parameter struct Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I7af29e4bd107bfcda929155bbe603798d092fa79 --- M jlink_spi.c 1 file changed, 24 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/67886/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/67886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7af29e4bd107bfcda929155bbe603798d092fa79 Gerrit-Change-Number: 67886 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: jlink_spi.c: Rename variable `arg` to `param_str`
by Felix Singer (Code Review) 28 Sep '22

28 Sep '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67882 ) Change subject: jlink_spi.c: Rename variable `arg` to `param_str` ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ca561611691a550ece79727621bc93da94cf461 Gerrit-Change-Number: 67882 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022