Attention is currently required from: Nico Huber, Namyoon Woo, Thomas Heijligen, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63831 )
Change subject: dummyflasher: move struct declaration & probe_variable_size to spi.(h|c)
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63831/comment/0e847ab8_a0c5c1db
PS2, Line 9: This is needed to build flashrom without the internal programmer
Maybe you can add testing info: my guess you did build with/without internal, with/without dummy, maybe you can add build commands that you performed.
Patchset:
PS1:
> Might be best to figure out first what the code tries to express. If this […]
I have a question. I created https://ticket.coreboot.org/issues/365 which hopefully represents the situation. There are 3 items in there, and this patch fixes first item (as I understand). Do you think this patch can go first?
File spi.c:
https://review.coreboot.org/c/flashrom/+/63831/comment/f031cb13_233c1605
PS1, Line 133: int probe_variable_size(struct flashctx *flash)
: {
: unsigned int i;
: const struct emu_data *emu_data = flash->mst->spi.data;
> I've no clue what this function is doing and if it's working as expected. […]
Yes I agree. First step can be fix building, and second can be fix the code.
Since the time of my previous comment, I created https://ticket.coreboot.org/issues/365 :) which I think represent second step.
Yes the code was like this before, you are just moving it into a different place. It is just that when it was in dummy, it was less obvious there are issues.
--
To view, visit https://review.coreboot.org/c/flashrom/+/63831
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic93c8b9ba7b9f7ce5fe49326c8de34070ca83a2e
Gerrit-Change-Number: 63831
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Namyoon Woo <namyoon(a)google.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Mon, 02 May 2022 03:31:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63826 )
Change subject: meson: outsource platform specific code to `platform/meson.build`
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/63826/comment/8a1b9861_2e74305b
PS2, Line 80: host_is_x86 = ['x86', 'x86_64'].contains(host_machine.cpu_family())
> The term "outsource platform specific code" was maybe a bit to much for this commit message. […]
Okay so maybe you can update commit message and add more info about future plans?
--
To view, visit https://review.coreboot.org/c/flashrom/+/63826
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I88044a3f903f316138483dd872a6d95f8686ae69
Gerrit-Change-Number: 63826
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Mon, 02 May 2022 03:09:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Jack Rosenthal, Tim Wawrzynczak, Edward O'Callaghan, Angel Pons, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63975 )
Change subject: util/flashrom_tester: Update sys-info crate to version 0.9
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/flashrom/+/63975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3b6b21e830ff3107860f7bcbfe2d58b29efe0c12
Gerrit-Change-Number: 63975
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Mon, 02 May 2022 01:27:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment