May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: util/flashrom_tester: Update sys-info crate to version 0.9
by Angel Pons (Code Review) 02 May '22

02 May '22

Attention is currently required from: Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63975 ) Change subject: util/flashrom_tester: Update sys-info crate to version 0.9 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/63975/comment/c0edd0a0_bd908154 PS1, Line 13: > mention CVE-2020-36434 for sauce? I just checked again, it's indeed this CVE ID. Done. -- To view, visit https://review.coreboot.org/c/flashrom/+/63975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3b6b21e830ff3107860f7bcbfe2d58b29efe0c12 Gerrit-Change-Number: 63975 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 02 May 2022 22:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: util/flashrom_tester: Update sys-info crate to version 0.9
by Angel Pons (Code Review) 02 May '22

02 May '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Tim Wawrzynczak, Jack Rosenthal, Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63975 to look at the new patch set (#2). Change subject: util/flashrom_tester: Update sys-info crate to version 0.9 ...................................................................... util/flashrom_tester: Update sys-info crate to version 0.9 An issue was discovered in the sys-info crate before 0.8.0 for Rust. sys_info::disk_info calls can trigger a double free. To prevent any potential problems, update this crate to version 0.9 (as of writing, sys-info version 0.9.1 is the latest). Refer to CVE-2020-36434 for more details about the sys-info crate bug. TEST=Run `cargo build` in `util/flashrom_tester`, it still works fine. Change-Id: I3b6b21e830ff3107860f7bcbfe2d58b29efe0c12 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/flashrom_tester/Cargo.toml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/63975/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3b6b21e830ff3107860f7bcbfe2d58b29efe0c12 Gerrit-Change-Number: 63975 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: util/flashrom_tester: Update sys-info crate to version 0.9
by Angel Pons (Code Review) 02 May '22

02 May '22

Attention is currently required from: Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63975 ) Change subject: util/flashrom_tester: Update sys-info crate to version 0.9 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I assume it's this issue? https://www.cve.org/CVERecord?id=CVE-2020-36434 […] I think so, I only noticed the issue because GitHub warned about it. -- To view, visit https://review.coreboot.org/c/flashrom/+/63975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3b6b21e830ff3107860f7bcbfe2d58b29efe0c12 Gerrit-Change-Number: 63975 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 02 May 2022 22:42:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher: move struct declaration & probe_variable_size to spi.(h|c)
by Nico Huber (Code Review) 02 May '22

02 May '22

Attention is currently required from: Namyoon Woo, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63831 ) Change subject: dummyflasher: move struct declaration & probe_variable_size to spi.(h|c) ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: > I have a question. I created https://ticket.coreboot. […] We discussed this in a meeting today. I think the best is to temporarily move the code as is into a separate file that re- flects that there is more to do, e.g. `fixme.c`. Then this patch can go in and Thomas doesn't have to wait for some- body to fix the code. File spi.c: https://review.coreboot.org/c/flashrom/+/63831/comment/2ea3669e_39c783e4 PS1, Line 133: int probe_variable_size(struct flashctx *flash) : { : unsigned int i; : const struct emu_data *emu_data = flash->mst->spi.data; > Also it relies on emu_data, what happens if there is some other data in the context? another struct type? You are spot-on, this is most likely undefined behavior. Probably what I had in mind when I added this feature to the list of release-blocking issues. I guess I commented about that on Gerrit a while ago (CB:44879). It's a perfect example how merging without proper review and keeping broken code(!) affects the project. -- To view, visit https://review.coreboot.org/c/flashrom/+/63831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic93c8b9ba7b9f7ce5fe49326c8de34070ca83a2e Gerrit-Change-Number: 63831 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Namyoon Woo <namyoon(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 02 May 2022 20:13:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: util/flashrom_tester: Update sys-info crate to version 0.9
by Tim Wawrzynczak (Code Review) 02 May '22

02 May '22

Attention is currently required from: Edward O'Callaghan, Angel Pons. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63975 ) Change subject: util/flashrom_tester: Update sys-info crate to version 0.9 ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63975/comment/198e0c57_c23e5f18 PS1, Line 13: mention CVE-2020-36434 for sauce? Patchset: PS1: I assume it's this issue? https://www.cve.org/CVERecord?id=CVE-2020-36434 I thought the whole point of Rust was to avoid memory errors like these 😕 -- To view, visit https://review.coreboot.org/c/flashrom/+/63975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3b6b21e830ff3107860f7bcbfe2d58b29efe0c12 Gerrit-Change-Number: 63975 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 02 May 2022 19:58:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Global cleanup: Fix a few spelling errors
by Elyes Haouas (Code Review) 02 May '22

02 May '22

Attention is currently required from: Martin L Roth, Edward O'Callaghan, Anastasia Klimchuk. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62840 ) Change subject: Global cleanup: Fix a few spelling errors ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4e3b277f220fa70dcab21912c30f1d26d9bd8749 Gerrit-Change-Number: 62840 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 02 May 2022 19:14:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Global cleanup: Fix a few spelling errors
by Martin L Roth (Code Review) 02 May '22

02 May '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62840 ) Change subject: Global cleanup: Fix a few spelling errors ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Had to do a manual rebase. No other changes. -- To view, visit https://review.coreboot.org/c/flashrom/+/62840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4e3b277f220fa70dcab21912c30f1d26d9bd8749 Gerrit-Change-Number: 62840 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 02 May 2022 17:56:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Global cleanup: Fix a few spelling errors
by Martin L Roth (Code Review) 02 May '22

02 May '22

Attention is currently required from: Martin L Roth. Hello Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62840 to look at the new patch set (#2). Change subject: Global cleanup: Fix a few spelling errors ...................................................................... Global cleanup: Fix a few spelling errors Just a trivial patch to fix a few errors found by codespell. Here's the command I used: codespell -S subprojects,out \ -L fwe,dout,tast,crate,parms,claus,nt,nd,te,truns,trun Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I4e3b277f220fa70dcab21912c30f1d26d9bd8749 --- M Makefile M ch341a_spi.c M flashrom.8.tmpl M flashrom.c M ft2232_spi.c M ich_descriptors.c M ichspi.c M include/flash.h M include/i2c_helper.h M lspcon_i2c_spi.c M ni845x_spi.c M s25f.c M stlinkv3_spi.c M util/flashrom_tester/src/utils.rs M util/ubertest/ubertest.sh 15 files changed, 26 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/62840/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4e3b277f220fa70dcab21912c30f1d26d9bd8749 Gerrit-Change-Number: 62840 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: util/flashrom_tester: Update sys-info crate to version 0.9
by Jack Rosenthal (Code Review) 02 May '22

02 May '22

Attention is currently required from: Tim Wawrzynczak, Edward O'Callaghan, Angel Pons. Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63975 ) Change subject: util/flashrom_tester: Update sys-info crate to version 0.9 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/63975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3b6b21e830ff3107860f7bcbfe2d58b29efe0c12 Gerrit-Change-Number: 63975 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 02 May 2022 16:21:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom: Move documentation to header
by Angel Pons (Code Review) 02 May '22

02 May '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Evan Benn. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63903 ) Change subject: libflashrom: Move documentation to header ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/63903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I856b74d5bfea13722539be15496755a95e701eea Gerrit-Change-Number: 63903 Gerrit-PatchSet: 6 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Evan Benn <evanbenn(a)google.com> Gerrit-Comment-Date: Mon, 02 May 2022 14:39:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022