Attention is currently required from: Edward O'Callaghan, Angel Pons.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63975 )
Change subject: util/flashrom_tester: Update sys-info crate to version 0.9
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63975/comment/198e0c57_c23e5f18
PS1, Line 13:
mention CVE-2020-36434 for sauce?
Patchset:
PS1:
I assume it's this issue? https://www.cve.org/CVERecord?id=CVE-2020-36434
I thought the whole point of Rust was to avoid memory errors like these 😕
--
To view, visit https://review.coreboot.org/c/flashrom/+/63975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3b6b21e830ff3107860f7bcbfe2d58b29efe0c12
Gerrit-Change-Number: 63975
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 02 May 2022 19:58:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Edward O'Callaghan, Anastasia Klimchuk.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62840 )
Change subject: Global cleanup: Fix a few spelling errors
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/62840
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4e3b277f220fa70dcab21912c30f1d26d9bd8749
Gerrit-Change-Number: 62840
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <martinroth(a)google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <martinroth(a)google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Mon, 02 May 2022 19:14:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62840 )
Change subject: Global cleanup: Fix a few spelling errors
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Had to do a manual rebase. No other changes.
--
To view, visit https://review.coreboot.org/c/flashrom/+/62840
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4e3b277f220fa70dcab21912c30f1d26d9bd8749
Gerrit-Change-Number: 62840
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <martinroth(a)google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Mon, 02 May 2022 17:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/62840
to look at the new patch set (#2).
Change subject: Global cleanup: Fix a few spelling errors
......................................................................
Global cleanup: Fix a few spelling errors
Just a trivial patch to fix a few errors found by codespell.
Here's the command I used:
codespell -S subprojects,out \
-L fwe,dout,tast,crate,parms,claus,nt,nd,te,truns,trun
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I4e3b277f220fa70dcab21912c30f1d26d9bd8749
---
M Makefile
M ch341a_spi.c
M flashrom.8.tmpl
M flashrom.c
M ft2232_spi.c
M ich_descriptors.c
M ichspi.c
M include/flash.h
M include/i2c_helper.h
M lspcon_i2c_spi.c
M ni845x_spi.c
M s25f.c
M stlinkv3_spi.c
M util/flashrom_tester/src/utils.rs
M util/ubertest/ubertest.sh
15 files changed, 26 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/62840/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/62840
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4e3b277f220fa70dcab21912c30f1d26d9bd8749
Gerrit-Change-Number: 62840
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <martinroth(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Edward O'Callaghan, Angel Pons.
Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63975 )
Change subject: util/flashrom_tester: Update sys-info crate to version 0.9
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/flashrom/+/63975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3b6b21e830ff3107860f7bcbfe2d58b29efe0c12
Gerrit-Change-Number: 63975
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 02 May 2022 16:21:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Evan Benn.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63903 )
Change subject: libflashrom: Move documentation to header
......................................................................
Patch Set 6:
(10 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63903/comment/6d157803_6df90e63
PS6, Line 10: FFI
What's this?
https://review.coreboot.org/c/flashrom/+/63903/comment/c6439a62_1535d331
PS6, Line 16: and after the change.
And what's the result of the test?
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/63903/comment/80ae6f83_e7982ad1
PS6, Line 65: file
a file
I'm not sure if the examples are needed.
https://review.coreboot.org/c/flashrom/+/63903/comment/3dc6d0b6_95569b72
PS6, Line 118: /**
: * @brief Returns list of supported flash chips
: * @return List of supported flash chips, or NULL if an error occurred
: */
: struct flashrom_flashchip_info *flashrom_supported_flash_chips(void);
: /**
: * @brief Returns list of supported mainboards
: * @return List of supported mainboards, or NULL if an error occurred
: */
: struct flashrom_board_info *flashrom_supported_boards(void);
: /**
: * @brief Returns list of supported chipsets
: * @return List of supported chipsets, or NULL if an error occurred
: */
: struct flashrom_chipset_info *flashrom_supported_chipsets(void);
Unrelated question, but how does one know the length of the returned list?
https://review.coreboot.org/c/flashrom/+/63903/comment/67b4e967_0a4d0374
PS6, Line 262: short
small
https://review.coreboot.org/c/flashrom/+/63903/comment/5143f914_6cb7e45d
PS6, Line 356: buffer
a buffer
https://review.coreboot.org/c/flashrom/+/63903/comment/aaa7232b_6d9fc741
PS6, Line 372: another
I'd use `a` to be more precise, as `flashrom_layout_new()` returns layouts with no regions.
https://review.coreboot.org/c/flashrom/+/63903/comment/30327834_ed495b52
PS6, Line 398: * @param start The start address to be written.
: * @param len The length of the region to be written.
Maybe @param[out] ?
https://review.coreboot.org/c/flashrom/+/63903/comment/132288c4_2f501720
PS6, Line 416: he
I'd avoid using personal pronouns in documentation, the caller isn't necessarily a "he". How about:
The caller must not release the layout as long as it is used through the given flash context.
Here, "it" refers to "the layout".
https://review.coreboot.org/c/flashrom/+/63903/comment/496a5c4f_902d2778
PS6, Line 463: [out]
Why is this an out parameter?
--
To view, visit https://review.coreboot.org/c/flashrom/+/63903
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I856b74d5bfea13722539be15496755a95e701eea
Gerrit-Change-Number: 63903
Gerrit-PatchSet: 6
Gerrit-Owner: Evan Benn <evanbenn(a)google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Evan Benn <evanbenn(a)google.com>
Gerrit-Comment-Date: Mon, 02 May 2022 14:39:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jack Rosenthal, Tim Wawrzynczak, Edward O'Callaghan, Angel Pons.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63975 )
Change subject: util/flashrom_tester: Update sys-info crate to version 0.9
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/flashrom/+/63975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3b6b21e830ff3107860f7bcbfe2d58b29efe0c12
Gerrit-Change-Number: 63975
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 02 May 2022 05:34:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63826 )
Change subject: meson: outsource platform specific code to `platform/meson.build`
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63826/comment/396c85cd_133db9bf
PS3, Line 7: outsource
I would use "move"
https://review.coreboot.org/c/flashrom/+/63826/comment/289aa82d_f7c0b698
PS3, Line 8:
Please state the reason for this change. What does it improve?
--
To view, visit https://review.coreboot.org/c/flashrom/+/63826
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I88044a3f903f316138483dd872a6d95f8686ae69
Gerrit-Change-Number: 63826
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Mon, 02 May 2022 05:18:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment