Change in flashrom[master]: meson: outsource platform specific code to `platform/meson.build`
Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63826 ) Change subject: meson: outsource platform specific code to `platform/meson.build` ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/63826/comment/8a1b9861_2e74305b PS2, Line 80: host_is_x86 = ['x86', 'x86_64'].contains(host_machine.cpu_family())
The term "outsource platform specific code" was maybe a bit to much for this commit message. […] Okay so maybe you can update commit message and add more info about future plans?
-- To view, visit https://review.coreboot.org/c/flashrom/+/63826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I88044a3f903f316138483dd872a6d95f8686ae69 Gerrit-Change-Number: 63826 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Thomas Heijligen <src@posteo.de> Gerrit-Comment-Date: Mon, 02 May 2022 03:09:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src@posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Anastasia Klimchuk (Code Review)