May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: meson: relocate source file list
by Thomas Heijligen (Code Review) 06 May '22

06 May '22

Attention is currently required from: Felix Singer. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64026 ) Change subject: meson: relocate source file list ...................................................................... Patch Set 1: (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/64026/comment/06265ca8_67636284 PS1, Line 395: # core modules needed by both the library and the CLI > the comment got lost I don't see this comment as important. Later in the chain it gets also irrelevant because we are linking against all those files in libflashrom.a -- To view, visit https://review.coreboot.org/c/flashrom/+/64026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I921be8a8a99b93d23c1dbd4ea54672ba9998558d Gerrit-Change-Number: 64026 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Fri, 06 May 2022 20:56:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform.h: Add support for Synopsis ARC64 architecture
by Thomas Heijligen (Code Review) 06 May '22

06 May '22

Attention is currently required from: Felix Singer, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63896 ) Change subject: platform.h: Add support for Synopsis ARC64 architecture ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Looks like Synopsys implemented ARC64 support in a downstream fork: […] Thanks for picking it up. -- To view, visit https://review.coreboot.org/c/flashrom/+/63896 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8707394871994f600b345d76614c5689fd081db4 Gerrit-Change-Number: 63896 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 06 May 2022 18:52:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform.h: Add support for Synopsis ARC64 architecture
by Angel Pons (Code Review) 06 May '22

06 May '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63896 ) Change subject: platform.h: Add support for Synopsis ARC64 architecture ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I assume this macro is correct because an employee of synopsys hat add this. […] Looks like Synopsys implemented ARC64 support in a downstream fork: https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/blob/9256d481ed… -- To view, visit https://review.coreboot.org/c/flashrom/+/63896 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8707394871994f600b345d76614c5689fd081db4 Gerrit-Change-Number: 63896 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 06 May 2022 18:26:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Review access change
by Nico Huber (Code Review) 06 May '22

06 May '22

Attention is currently required from: Martin L Roth, Patrick Georgi, Stefan Reinauer, Stefan T. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64101 ) Change subject: Review access change ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: Any reason for these elaborate changes? -- To view, visit https://review.coreboot.org/c/flashrom/+/64101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: If675a0782521b58ecef60e56305016acc24e0cd8 Gerrit-Change-Number: 64101 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Fri, 06 May 2022 18:24:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform/swap: move swap inline functions & macros into an own header
by Angel Pons (Code Review) 06 May '22

06 May '22

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63825 ) Change subject: platform/swap: move swap inline functions & macros into an own header ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2326e6a4eb5e000a0eace857d040372e2e9e561 Gerrit-Change-Number: 63825 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 06 May 2022 18:21:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Review access change
by Angel Pons (Code Review) 06 May '22

06 May '22

Attention is currently required from: Nico Huber, Martin L Roth, Patrick Georgi, Stefan Reinauer, Stefan T. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64101 ) Change subject: Review access change ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: Do flashrom developers inherit the rights from flashrom reviewers? Also, please note that flashrom developers != flashrom owners (Nico, stefanct, dhendrix, Th3Fanbus). File project.config: https://review.coreboot.org/c/flashrom/+/64101/comment/18d326e2_f0199146 PS2, Line 35: label-Verified = -1..+1 group flashrom reviewers flashrom reviewers shouldn't be able to set Verified scores, did you mean flashrom developers? -- To view, visit https://review.coreboot.org/c/flashrom/+/64101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: If675a0782521b58ecef60e56305016acc24e0cd8 Gerrit-Change-Number: 64101 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Fri, 06 May 2022 17:54:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Review access change
by Martin L Roth (Code Review) 06 May '22

06 May '22

Attention is currently required from: Patrick Georgi, Stefan Reinauer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64101 ) Change subject: Review access change ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Add flashrom reviewers group to give +2, -1 reviews. Add flashrom developers to the other rights. -- To view, visit https://review.coreboot.org/c/flashrom/+/64101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: If675a0782521b58ecef60e56305016acc24e0cd8 Gerrit-Change-Number: 64101 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 06 May 2022 17:43:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Review access change
by Martin L Roth (Code Review) 06 May '22

06 May '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64101 ) Change subject: Review access change ...................................................................... Review access change Change-Id: If675a0782521b58ecef60e56305016acc24e0cd8 --- M groups M project.config 2 files changed, 7 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/64101/1 diff --git a/groups b/groups index eb8ff72..504d392 100644 --- a/groups +++ b/groups @@ -1,5 +1,6 @@ # UUID Group Name # +25cadc351dd0492fd2a2a1b1a8e5bb08c29e411f flashrom reviewers db95ce11b379445ac8c5806ea0b61195555b338d flashrom developers global:Project-Owners Project Owners user:Nico user/Nico Huber (Nico) diff --git a/project.config b/project.config index d2b472f..6a01eda 100644 --- a/project.config +++ b/project.config @@ -32,30 +32,17 @@ defaultValue = 0 [access "refs/*"] + label-Verified = -1..+1 group flashrom reviewers label-Verified = -1..+1 group user/Angel Pons (Th3Fanbus) label-Verified = -1..+1 group user/David Hendricks (dhendrix) label-Verified = -1..+1 group user/Nico Huber (Nico) label-Verified = -1..+1 group user/Stefan T (stefanct) - submit = group user/Angel Pons (Th3Fanbus) - submit = group user/David Hendricks (dhendrix) - submit = group user/Nico Huber (Nico) - submit = group user/Stefan T (stefanct) - label-Code-Review = -2..+2 group user/Angel Pons (Th3Fanbus) - label-Code-Review = -2..+2 group user/David Hendricks (dhendrix) - label-Code-Review = -2..+2 group user/Nico Huber (Nico) - label-Code-Review = -2..+2 group user/Stefan T (stefanct) - owner = group user/Angel Pons (Th3Fanbus) - owner = group user/David Hendricks (dhendrix) - owner = group user/Nico Huber (Nico) - owner = group user/Stefan T (stefanct) + submit = group flashrom developers + label-Code-Review = -2..+2 group flashrom developers + owner = group flashrom developers [access "refs/heads/*"] - exclusiveGroupPermissions = create delete submit - create = group user/David Hendricks (dhendrix) - create = group user/Nico Huber (Nico) - create = group user/Stefan T (stefanct) - delete = group user/David Hendricks (dhendrix) - delete = group user/Nico Huber (Nico) - delete = group user/Stefan T (stefanct) + exclusiveGroupPermissions = label-Code-Review label-Verified submit + create = group flashrom developers submit = group flashrom developers label-Code-Review = -2..+2 group flashrom developers label-Verified = -1..+1 group flashrom developers -- To view, visit https://review.coreboot.org/c/flashrom/+/64101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: If675a0782521b58ecef60e56305016acc24e0cd8 Gerrit-Change-Number: 64101 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashrom: initialize restore func count in correct place
by Angel Pons (Code Review) 06 May '22

06 May '22

Attention is currently required from: Nico Huber, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63881 ) Change subject: flashrom: initialize restore func count in correct place ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4c7df424bd2ae2b5fb2a2ab6b47a3c9ff3233acf Gerrit-Change-Number: 63881 Gerrit-PatchSet: 6 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 06 May 2022 10:32:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Implement wp
by Edward O'Callaghan (Code Review) 06 May '22

06 May '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64083 ) Change subject: realtek_mst_i2c_spi.c: Implement wp ...................................................................... realtek_mst_i2c_spi.c: Implement wp WIP/RFC Change-Id: I8fe6a3b4e7a8637ec9215351f66f5b96054c550d Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M realtek_mst_i2c_spi.c 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/64083/1 diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index 954150d..4128cb1 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -432,6 +432,33 @@ return ret; } +static enum flashrom_wp_result realtek_mst_i2c_spi_wp_read_cfg(struct flashrom_wp_cfg *cfg, struct flashctx *flash) +{ + /* Not supported. */ + return FLASHROM_WP_ERR_RANGE_LIST_UNAVAILABLE; +} + +static enum flashrom_wp_result realtek_mst_i2c_spi_wp_write_cfg(struct flashctx *flash, const struct flashrom_wp_cfg *cfg) +{ + struct realtek_mst_i2c_spi_data *realtek_mst_data = + (struct realtek_mst_i2c_spi_data *)data; + int fd = realtek_mst_data->fd; + + int ret = realtek_mst_i2c_spi_toggle_gpio_88_strap(fd, (cfg->mode == FLASHROM_WP_MODE_DISABLED)); + if (ret) { + msg_perr("Unable to toggle gpio 88 strap to True.\n"); + return FLASHROM_WP_ERR_WRITE_FAILED; + } + + return FLASHROM_WP_OK; +} + +static enum flashrom_wp_result realtek_mst_i2c_spi_wp_get_available_ranges(struct flashrom_wp_ranges **list, struct flashctx *flash) +{ + /* Not supported. */ + return FLASHROM_WP_ERR_RANGE_LIST_UNAVAILABLE; +} + static const struct spi_master spi_master_i2c_realtek_mst = { .max_data_read = 16, .max_data_write = 8, @@ -441,6 +468,9 @@ .write_256 = realtek_mst_i2c_spi_write_256, .write_aai = realtek_mst_i2c_spi_write_aai, .shutdown = realtek_mst_i2c_spi_shutdown, + .wp_read_cfg = realtek_mst_i2c_spi_wp_read_cfg, + .wp_write_cfg = realtek_mst_i2c_spi_wp_write_cfg, + .wp_get_ranges = realtek_mst_i2c_spi_wp_get_available_ranges, }; static int get_params(int *reset, int *enter_isp) -- To view, visit https://review.coreboot.org/c/flashrom/+/64083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8fe6a3b4e7a8637ec9215351f66f5b96054c550d Gerrit-Change-Number: 64083 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022