May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: meson: use built-in options for install paths
by Felix Singer (Code Review) 08 May '22

08 May '22

Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64028 ) Change subject: meson: use built-in options for install paths ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/64028/comment/fab888ff_6dd3f5e9 PS2, Line 13: Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> > I noticed you are using different emails, the owner is one and signed-off is different, is it WAI? The "Owner" in the left top corner just refers to the Gerrit user who pushed the commit. -- To view, visit https://review.coreboot.org/c/flashrom/+/64028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cb9faf4bdbcfd66098478cc3a260eb3b664a2e6 Gerrit-Change-Number: 64028 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 08 May 2022 23:35:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: use built-in options for install paths
by Anastasia Klimchuk (Code Review) 08 May '22

08 May '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64028 ) Change subject: meson: use built-in options for install paths ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/64028/comment/16f46c8c_b875c10c PS2, Line 13: Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> I noticed you are using different emails, the owner is one and signed-off is different, is it WAI? File meson.build: https://review.coreboot.org/c/flashrom/+/64028/comment/0fd8d017_244c70f1 PS2, Line 408: libdir = join_paths(prefix, get_option('libdir')) So `libdir` was unused?! -- To view, visit https://review.coreboot.org/c/flashrom/+/64028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cb9faf4bdbcfd66098478cc3a260eb3b664a2e6 Gerrit-Change-Number: 64028 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 08 May 2022 23:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: add option to disable tests
by Anastasia Klimchuk (Code Review) 08 May '22

08 May '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 ) Change subject: meson: add option to disable tests ...................................................................... Patch Set 7: (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/63832/comment/c520f397_3729f941 PS1, Line 522: if cmocka_dep.found() > `auto` - the old behavior, which is default I was trying to find in meson doc what exactly `auto` means and what it is doing, I am still not clear on that. I wanted to verify whether `auto` is equivalent to old behavior, I can't understand from the docs :\ For example, docs for dependency.required say just this: "when set to false, Meson will proceed with the build" what happens when it's set to `auto`? do you know? For testing, the commit I linked has testing scenarios in commit message (which is really cool), I am copying them here: $ mkdir build && cd build/ $ meson --wrap-mode=nodownload --wrap-mode=nofallback ../ $ ninja test # validate configs, builds and no tests are run. -- $ sudo apt install libcmocka-dev $ mkdir build && cd build/ $ meson --wrap-mode=nodownload --wrap-mode=nofallback ../ $ ninja test # validate configs, builds and tests are run. -- To view, visit https://review.coreboot.org/c/flashrom/+/63832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b Gerrit-Change-Number: 63832 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 08 May 2022 23:13:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: use `platform/` as subdir()
by Anastasia Klimchuk (Code Review) 08 May '22

08 May '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63826 ) Change subject: meson: use `platform/` as subdir() ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I88044a3f903f316138483dd872a6d95f8686ae69 Gerrit-Change-Number: 63826 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 08 May 2022 22:36:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform/swap: move swap inline functions & macros into an own header
by Thomas Heijligen (Code Review) 08 May '22

08 May '22

Thomas Heijligen has submitted this change. ( https://review.coreboot.org/c/flashrom/+/63825 ) Change subject: platform/swap: move swap inline functions & macros into an own header ...................................................................... platform/swap: move swap inline functions & macros into an own header These inline functions and macros are only used in platform/endian_(big|little).c and do not need to be compiled into every object which includes `platform.h`. Change-Id: Ib2326e6a4eb5e000a0eace857d040372e2e9e561 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/63825 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M include/platform.h A include/platform/swap.h M platform/endian_big.c M platform/endian_little.c 4 files changed, 82 insertions(+), 53 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/include/platform.h b/include/platform.h index d15082f..3cde2ed 100644 --- a/include/platform.h +++ b/include/platform.h @@ -25,59 +25,6 @@ #include <stddef.h> #include <stdint.h> -/* swap bytes */ -/* OpenBSD has conflicting definitions for swapX and __swapX */ -static inline uint8_t ___swap8(const uint8_t value) -{ - return (value & (uint8_t)0xffU); -} - -static inline uint16_t ___swap16(const uint16_t value) -{ - return ((value & (uint16_t)0x00ffU) << 8) | - ((value & (uint16_t)0xff00U) >> 8); -} - -static inline uint32_t ___swap32(const uint32_t value) -{ - return ((value & (uint32_t)0x000000ffUL) << 24) | - ((value & (uint32_t)0x0000ff00UL) << 8) | - ((value & (uint32_t)0x00ff0000UL) >> 8) | - ((value & (uint32_t)0xff000000UL) >> 24); -} - -static inline uint64_t ___swap64(const uint64_t value) -{ - return ((value & (uint64_t)0x00000000000000ffULL) << 56) | - ((value & (uint64_t)0x000000000000ff00ULL) << 40) | - ((value & (uint64_t)0x0000000000ff0000ULL) << 24) | - ((value & (uint64_t)0x00000000ff000000ULL) << 8) | - ((value & (uint64_t)0x000000ff00000000ULL) >> 8) | - ((value & (uint64_t)0x0000ff0000000000ULL) >> 24) | - ((value & (uint64_t)0x00ff000000000000ULL) >> 40) | - ((value & (uint64_t)0xff00000000000000ULL) >> 56); -} - -/* - * macro to return the same value as passed. - * - * `___return_same(cpu_to_le, 8)` - * expands to - * `uint8_t cpu_to_le8 (const uint8_t value) { return value; }` - */ -#define ___return_same(name, bits) \ - uint##bits##_t name##bits (const uint##bits##_t value) { return value; } - -/* - * macro to return the swapped value as passed. - * - * `___return_swapped(cpu_to_be, 8)` - * expands to - * `uint8_t cpu_to_be8 (const uint8_t value) { return ___swap8 (value); }` - */ -#define ___return_swapped(name, bits) \ - uint##bits##_t name##bits (const uint##bits##_t value) { return ___swap##bits (value); } - /* convert cpu native endian to little endian */ uint8_t cpu_to_le8 (uint8_t value); uint16_t cpu_to_le16(uint16_t value); diff --git a/include/platform/swap.h b/include/platform/swap.h new file mode 100644 index 0000000..12f3106 --- /dev/null +++ b/include/platform/swap.h @@ -0,0 +1,80 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2009 Carl-Daniel Hailfinger + * Copyright (C) 2022 secunet Security Networks AG + * (written by Thomas Heijligen <thomas.heijligen(a)secunet.com) + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +/* + * inline functions and macros shared by endian conversion functions + */ + +#ifndef ___SWAP_H___ +#define ___SWAP_H___ 1 + +#include <stdint.h> + +/* swap bytes */ +/* OpenBSD has conflicting definitions for swapX, _swap_X and __swapX */ +static inline uint8_t ___swap8(const uint8_t value) +{ + return (value & (uint8_t)0xffU); +} + +static inline uint16_t ___swap16(const uint16_t value) +{ + return ((value & (uint16_t)0x00ffU) << 8) | + ((value & (uint16_t)0xff00U) >> 8); +} + +static inline uint32_t ___swap32(const uint32_t value) +{ + return ((value & (uint32_t)0x000000ffUL) << 24) | + ((value & (uint32_t)0x0000ff00UL) << 8) | + ((value & (uint32_t)0x00ff0000UL) >> 8) | + ((value & (uint32_t)0xff000000UL) >> 24); +} + +static inline uint64_t ___swap64(const uint64_t value) +{ + return ((value & (uint64_t)0x00000000000000ffULL) << 56) | + ((value & (uint64_t)0x000000000000ff00ULL) << 40) | + ((value & (uint64_t)0x0000000000ff0000ULL) << 24) | + ((value & (uint64_t)0x00000000ff000000ULL) << 8) | + ((value & (uint64_t)0x000000ff00000000ULL) >> 8) | + ((value & (uint64_t)0x0000ff0000000000ULL) >> 24) | + ((value & (uint64_t)0x00ff000000000000ULL) >> 40) | + ((value & (uint64_t)0xff00000000000000ULL) >> 56); +} + +/* + * macro to return the same value as passed. + * + * `___return_same(cpu_to_le, 8)` + * expands to + * `uint8_t cpu_to_le8 (const uint8_t value) { return value; }` + */ +#define ___return_same(name, bits) \ + uint##bits##_t name##bits (const uint##bits##_t value) { return value; } + +/* + * macro to return the swapped value as passed. + * + * `___return_swapped(cpu_to_be, 8)` + * expands to + * `uint8_t cpu_to_be8 (const uint8_t value) { return ___swap8 (value); }` + */ +#define ___return_swapped(name, bits) \ + uint##bits##_t name##bits (const uint##bits##_t value) { return ___swap##bits (value); } + +#endif /* !___SWAP_H___ */ diff --git a/platform/endian_big.c b/platform/endian_big.c index 6541a83..4565534 100644 --- a/platform/endian_big.c +++ b/platform/endian_big.c @@ -16,6 +16,7 @@ */ #include "platform.h" +#include "platform/swap.h" /* convert cpu native endian to little endian */ ___return_swapped(cpu_to_le, 8) diff --git a/platform/endian_little.c b/platform/endian_little.c index aeb9d57..690f383 100644 --- a/platform/endian_little.c +++ b/platform/endian_little.c @@ -16,6 +16,7 @@ */ #include "platform.h" +#include "platform/swap.h" /* convert cpu native endian to little endian */ ___return_same(cpu_to_le, 8) -- To view, visit https://review.coreboot.org/c/flashrom/+/63825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib2326e6a4eb5e000a0eace857d040372e2e9e561 Gerrit-Change-Number: 63825 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: flashchips: Add support for XMC XM25QH80B
by Name of user not set (Code Review) 08 May '22

08 May '22

Attention is currently required from: Angel Pons. Hello Felix Singer, build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63516 to look at the new patch set (#2). Change subject: flashchips: Add support for XMC XM25QH80B ...................................................................... flashchips: Add support for XMC XM25QH80B XM25QH80B has the same ID as M45PE80, but has more features. Tested with CH341A. Change-Id: Ib51225426d8d1a381d45af3574e5ba2bf02837aa Signed-off-by: Sungbo Eo <mans0n(a)gorani.run> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/63516/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63516 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib51225426d8d1a381d45af3574e5ba2bf02837aa Gerrit-Change-Number: 63516 Gerrit-PatchSet: 2 Gerrit-Owner: mans0n+coreboot(a)gorani.run Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ich_descriptors.c: Initialize structures
by Light (Code Review) 07 May '22

07 May '22

Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62763 ) Change subject: ich_descriptors.c: Initialize structures ...................................................................... Patch Set 11: (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/62763/comment/5a6ace2e_8043335e PS7, Line 1364: int ret = read_ich_descriptors_from_dump(dump, len, &cs, &desc); > I also want to understand what to do with this patch. […] Yes I agree garbage values are more difficult to spot than zeroes. I was thinking if there could be any another value that we could initialize the structure with to indicate that it is uninitialized. -- To view, visit https://review.coreboot.org/c/flashrom/+/62763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6e5bc84c6199a0731db0a9c8ef56f1215686dab2 Gerrit-Change-Number: 62763 Gerrit-PatchSet: 11 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 07 May 2022 12:12:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Light <aarya.chaumal(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: serprog.c: Avoid calling memcpy with NULL pointer arguments
by Light (Code Review) 07 May '22

07 May '22

Attention is currently required from: Felix Singer, Paul Menzel, Edward O'Callaghan, Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62726 ) Change subject: serprog.c: Avoid calling memcpy with NULL pointer arguments ...................................................................... Patch Set 16: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62726/comment/f96c9fbb_2574d7e8 PS12, Line 10: Although, since parmlen is also 0 at that time I : don't think it would make much difference. > Are there any suggestions here or can we resolve this issue? Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I850123237e328f9548ba7f77a01888be2cbc9e7b Gerrit-Change-Number: 62726 Gerrit-PatchSet: 16 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 07 May 2022 12:08:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Light <aarya.chaumal(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [WIP] meson: rework the programmer selection
by Thomas Heijligen (Code Review) 06 May '22

06 May '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 ) Change subject: [WIP] meson: rework the programmer selection ...................................................................... Patch Set 15: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63724/comment/2cfeb50d_64b84875 PS11, Line 10: has some known and unknown bugs. > Speaking about bugs, and especially unknown bugs, can we collectively try detect them? Is this patch […] Yes, everything should work as expected. The tests are currently a problem when not selecting all programmers. File meson.build: https://review.coreboot.org/c/flashrom/+/63724/comment/32e2bf9d_878b5f8c PS2, Line 464: if host_machine.system() in systems_serial_support > For now the serial support is build as part of the programmer. […] Done File meson_options.txt: https://review.coreboot.org/c/flashrom/+/63724/comment/dbd57eef_925b6a7e PS7, Line 6: choices > yes, the choices ensure at least one programmer is enabled, there can't be a string which is no prog […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/63724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Gerrit-Change-Number: 63724 Gerrit-PatchSet: 15 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 06 May 2022 21:26:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: use static library for tests
by Thomas Heijligen (Code Review) 06 May '22

06 May '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64031 ) Change subject: meson: use static library for tests ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'm going to look if there is an other, maybe better, solution than linking with the static library. -- To view, visit https://review.coreboot.org/c/flashrom/+/64031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Gerrit-Change-Number: 64031 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 06 May 2022 21:23:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022