May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: tests: Rearange CPP guards
by Thomas Heijligen (Code Review) 09 May '22

09 May '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/64224 ) Change subject: tests: Rearange CPP guards ...................................................................... tests: Rearange CPP guards This fixes -Werror=unused-function when not all programmer tests are build. `run_basic_lifecycle` and `run_probe_lifecycle` need to have a prototype to not throw a -Werror=unused-function if no programmer needs them. Change-Id: I02880e73996b30df618738e86b8a52126fbe5b3b Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M tests/lifecycle.c M tests/tests.h 2 files changed, 42 insertions(+), 34 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/64224/1 diff --git a/tests/lifecycle.c b/tests/lifecycle.c index 63fcc3c..4e191ed 100644 --- a/tests/lifecycle.c +++ b/tests/lifecycle.c @@ -23,6 +23,9 @@ #include "programmer.h" #include "spi.h" +#define SKIP_TEST(name) \ + void name (void **state) { skip(); } + static void probe_chip(const struct programmer_entry *prog, struct flashrom_programmer *flashprog, const char *const chip_name) @@ -65,7 +68,7 @@ io_mock_register(NULL); } -static void run_basic_lifecycle(void **state, const struct io_mock *io, +void run_basic_lifecycle(void **state, const struct io_mock *io, const struct programmer_entry *prog, const char *param) { /* Basic lifecycle only does init and shutdown, @@ -73,7 +76,7 @@ run_lifecycle(state, io, prog, param, NULL /* chip_name */, NULL /* action */); } -static void run_probe_lifecycle(void **state, const struct io_mock *io, +void run_probe_lifecycle(void **state, const struct io_mock *io, const struct programmer_entry *prog, const char *param, const char *const chip_name) { /* Each probe lifecycle should run independently, without cache. */ @@ -81,9 +84,9 @@ run_lifecycle(state, io, prog, param, chip_name, &probe_chip); } +#if CONFIG_DUMMY == 1 void dummy_basic_lifecycle_test_success(void **state) { -#if CONFIG_DUMMY == 1 static struct io_mock_fallback_open_state dummy_fallback_open_state = { .noc = 0, .paths = { NULL }, @@ -93,14 +96,10 @@ }; run_basic_lifecycle(state, &dummy_io, &programmer_dummy, "bus=parallel+lpc+fwh+spi"); -#else - skip(); -#endif } void dummy_probe_lifecycle_test_success(void **state) { -#if CONFIG_DUMMY == 1 static struct io_mock_fallback_open_state dummy_fallback_open_state = { .noc = 0, .paths = { NULL }, @@ -110,14 +109,16 @@ }; run_probe_lifecycle(state, &dummy_io, &programmer_dummy, "bus=spi,emulate=W25Q128FV", "W25Q128.V"); -#else - skip(); -#endif } +#else + SKIP_TEST(dummy_basic_lifecycle_test_success) + SKIP_TEST(dummy_probe_lifecycle_test_success) +#endif /* CONFIG_DUMMY */ + +#if CONFIG_NICREALTEK == 1 void nicrealtek_basic_lifecycle_test_success(void **state) { -#if CONFIG_NICREALTEK == 1 static struct io_mock_fallback_open_state nicrealtek_fallback_open_state = { .noc = 0, .paths = { NULL }, @@ -127,11 +128,12 @@ }; run_basic_lifecycle(state, &nicrealtek_io, &programmer_nicrealtek, ""); -#else - skip(); -#endif } +#else + SKIP_TEST(nicrealtek_basic_lifecycle_test_success) +#endif /* CONFIG_NICREALTEK */ +#if CONFIG_RAIDEN_DEBUG_SPI == 1 static ssize_t raiden_debug_libusb_get_device_list(void *state, libusb_context *ctx, libusb_device ***list) { *list = calloc(1, sizeof(**list)); @@ -202,7 +204,6 @@ void raiden_debug_basic_lifecycle_test_success(void **state) { -#if CONFIG_RAIDEN_DEBUG_SPI == 1 static struct io_mock_fallback_open_state raiden_debug_fallback_open_state = { .noc = 0, .paths = { NULL }, @@ -224,11 +225,12 @@ snprintf(raiden_debug_param, 12, "address=%d", USB_DEVICE_ADDRESS); run_basic_lifecycle(state, &raiden_debug_io, &programmer_raiden_debug_spi, raiden_debug_param); -#else - skip(); -#endif } +#else + SKIP_TEST(raiden_debug_basic_lifecycle_test_success) +#endif /* CONFIG_RAIDEN_DEBUG_SPI */ +#if CONFIG_DEDIPROG == 1 static int dediprog_libusb_init(void *state, libusb_context **ctx) { *ctx = not_null(); @@ -254,7 +256,6 @@ void dediprog_basic_lifecycle_test_success(void **state) { -#if CONFIG_DEDIPROG == 1 static struct io_mock_fallback_open_state dediprog_fallback_open_state = { .noc = 0, .paths = { NULL }, @@ -266,11 +267,12 @@ }; run_basic_lifecycle(state, &dediprog_io, &programmer_dediprog, "voltage=3.5V"); -#else - skip(); -#endif } +#else + SKIP_TEST(dediprog_basic_lifecycle_test_success) +#endif /* CONFIG_DEDIPROG */ +#if CONFIG_LINUX_MTD == 1 struct linux_mtd_io_state { char *fopen_path; }; @@ -329,7 +331,6 @@ void linux_mtd_probe_lifecycle_test_success(void **state) { -#if CONFIG_LINUX_MTD == 1 struct linux_mtd_io_state linux_mtd_io_state = { NULL }; static struct io_mock_fallback_open_state linux_mtd_fallback_open_state = { .noc = 0, @@ -344,11 +345,12 @@ }; run_probe_lifecycle(state, &linux_mtd_io, &programmer_linux_mtd, "", "Opaque flash chip"); -#else - skip(); -#endif } +#else + SKIP_TEST(linux_mtd_probe_lifecycle_test_success) +#endif /* CONFIG_LINUX_MTD */ +#if CONFIG_LINUX_SPI == 1 static int linux_spi_ioctl(void *state, int fd, unsigned long request, va_list args) { if (request == SPI_IOC_MESSAGE(2)) { /* ioctl code for read request */ @@ -387,7 +389,6 @@ * Current implementation tests a particular path of the init procedure. * Specifically, it is reading the buffer size from sysfs. */ -#if CONFIG_LINUX_SPI == 1 static struct io_mock_fallback_open_state linux_spi_fallback_open_state = { .noc = 0, .paths = { "/dev/null", NULL }, @@ -400,11 +401,12 @@ }; run_probe_lifecycle(state, &linux_spi_io, &programmer_linux_spi, "dev=/dev/null", "W25Q128.V"); -#else - skip(); -#endif } +#else + SKIP_TEST(linux_spi_probe_lifecycle_test_success) +#endif /* CONFIG_LINUX_SPI */ +#if CONFIG_REALTEK_MST_I2C_SPI == 1 static int realtek_mst_ioctl(void *state, int fd, unsigned long request, va_list args) { assert_int_equal(fd, MOCK_FD); @@ -433,7 +435,6 @@ void realtek_mst_basic_lifecycle_test_success(void **state) { -#if CONFIG_REALTEK_MST_I2C_SPI == 1 static struct io_mock_fallback_open_state realtek_mst_fallback_open_state = { .noc = 0, .paths = { "/dev/i2c-254", NULL }, @@ -447,7 +448,7 @@ }; run_basic_lifecycle(state, &realtek_mst_io, &programmer_realtek_mst_i2c_spi, "bus=254,enter-isp=0"); -#else - skip(); -#endif /* CONFIG_REALTEK_I2C_SPI */ } +#else + SKIP_TEST(realtek_mst_basic_lifecycle_test_success) +#endif /* CONFIG_REALTEK_I2C_SPI */ diff --git a/tests/tests.h b/tests/tests.h index 68f7781..6fa3c14 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -41,6 +41,13 @@ void probe_spi_st95_test_success(void **state); /* spi95.c */ /* lifecycle.c */ +struct io_mock; +struct programmer_entry; +void run_basic_lifecycle(void **state, const struct io_mock *io, + const struct programmer_entry *prog, const char *param); +void run_probe_lifecycle(void **state, const struct io_mock *io, + const struct programmer_entry *prog, const char *param, const char *chip_name); + void dummy_basic_lifecycle_test_success(void **state); void dummy_probe_lifecycle_test_success(void **state); void nicrealtek_basic_lifecycle_test_success(void **state); -- To view, visit https://review.coreboot.org/c/flashrom/+/64224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I02880e73996b30df618738e86b8a52126fbe5b3b Gerrit-Change-Number: 64224 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: [WIP] meson: rework the programmer selection
by Thomas Heijligen (Code Review) 09 May '22

09 May '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63724 to look at the new patch set (#16). Change subject: [WIP] meson: rework the programmer selection ...................................................................... [WIP] meson: rework the programmer selection This is a WIP implementation for a new programmer selection. It should work by now but has some known and unknown bugs. (see Gerrit Comments) - Each dependency is optional and gets mandatory when the programmer is selected as active. - Each programmer is defined through an entry in the programmer dictionary - The entry lists systems & cpu_families where the programmer is supported; Dependencies, sources and flags. The group parameter is for selecting a set of programmer, the default parameter is to include the programmer to the `all` and `auto` set. - If the programmer gets selected the `active` entry is set to true. The `active` entry can be used afterwards to determine if the programmer should be included in sources, config, documentation - Needed system headers are represended through a pseudo dependency. - The programmer's `srcs` attribute contains all files which are needed to build the programmer. Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build M meson_options.txt M tests/meson.build 3 files changed, 412 insertions(+), 341 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/63724/16 -- To view, visit https://review.coreboot.org/c/flashrom/+/63724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1 Gerrit-Change-Number: 63724 Gerrit-PatchSet: 16 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson: use static library for tests
by Thomas Heijligen (Code Review) 09 May '22

09 May '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Anastasia Klimchuk. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64031 to look at the new patch set (#3). Change subject: meson: use static library for tests ...................................................................... meson: use static library for tests Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build M tests/chip.c M tests/flashrom.c M tests/helpers.c M tests/lifecycle.c M tests/meson.build M tests/tests.c 7 files changed, 33 insertions(+), 44 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/64031/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/64031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Gerrit-Change-Number: 64031 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson: use static library for tests
by Thomas Heijligen (Code Review) 09 May '22

09 May '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64031 ) Change subject: meson: use static library for tests ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'm going to look if there is an other, maybe better, solution than linking with the static library. Using the srcs + https://mesonbuild.com/Reference-manual_returned_extracted_obj.html (As an alternative to linking) -- To view, visit https://review.coreboot.org/c/flashrom/+/64031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Gerrit-Change-Number: 64031 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 09 May 2022 15:29:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: add option to disable tests
by Felix Singer (Code Review) 09 May '22

09 May '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 ) Change subject: meson: add option to disable tests ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/63832/comment/5d078dee_e1028bb6 PS6, Line 509: # .allowed() is introduced in 0.59.0 > I've updated the comment. […] Looks good now, thanks! Done. -- To view, visit https://review.coreboot.org/c/flashrom/+/63832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b Gerrit-Change-Number: 63832 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 09 May 2022 15:11:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: relocate source file list
by Felix Singer (Code Review) 09 May '22

09 May '22

Attention is currently required from: Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64026 ) Change subject: meson: relocate source file list ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/64026/comment/31a38318_d081fcd2 PS1, Line 395: # core modules needed by both the library and the CLI > I don't see this comment as important. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/64026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I921be8a8a99b93d23c1dbd4ea54672ba9998558d Gerrit-Change-Number: 64026 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 09 May 2022 15:06:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Review access change
by Nico Huber (Code Review) 09 May '22

09 May '22

Attention is currently required from: Felix Singer, Martin L Roth, Patrick Georgi, Stefan Reinauer, Angel Pons, Stefan T. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64101 ) Change subject: Review access change ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > Which of the flashrom developers should not have the rights of the admins? and why not? Couldn't we as well ask the same question for coreboot? Why don't all "coreboot developers" have these rights for coreboot? Or even why not make everybody an admin? To me it's about safety. The more privileged people you have, the more can go wrong. PS2: > Add flashrom reviewers group to give +2, -1 reviews. […] That's what this change tries to do. But I asked for the reason, i.e. why do it? -- To view, visit https://review.coreboot.org/c/flashrom/+/64101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: If675a0782521b58ecef60e56305016acc24e0cd8 Gerrit-Change-Number: 64101 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Mon, 09 May 2022 13:21:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)tutanota.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Review access change
by Martin L Roth (Code Review) 09 May '22

09 May '22

Attention is currently required from: Felix Singer, Nico Huber, Patrick Georgi, Stefan Reinauer, Angel Pons, Stefan T. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64101 ) Change subject: Review access change ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > > Just wondering, what does "flashrom owners" mean? […] right, all flashrom developers are also in the flashrom reviews group. Which of the flashrom developers should not have the rights of the admins? and why not? File project.config: https://review.coreboot.org/c/flashrom/+/64101/comment/c5d39528_4c11d269 PS2, Line 35: label-Verified = -1..+1 group flashrom reviewers > flashrom reviewers shouldn't be able to set Verified scores, did you mean flashrom developers? yeah, my mistake. thanks. -- To view, visit https://review.coreboot.org/c/flashrom/+/64101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: If675a0782521b58ecef60e56305016acc24e0cd8 Gerrit-Change-Number: 64101 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Mon, 09 May 2022 10:35:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Review access change
by Martin L Roth (Code Review) 09 May '22

09 May '22

Attention is currently required from: Felix Singer, Nico Huber, Patrick Georgi, Stefan Reinauer, Stefan T. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64101 ) Change subject: Review access change ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Any reason for these elaborate changes? Add flashrom reviewers group to give +2, -1 reviews. Add flashrom developers to the other rights. -- To view, visit https://review.coreboot.org/c/flashrom/+/64101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: If675a0782521b58ecef60e56305016acc24e0cd8 Gerrit-Change-Number: 64101 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Mon, 09 May 2022 10:28:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Review access change
by Angel Pons (Code Review) 09 May '22

09 May '22

Attention is currently required from: Felix Singer, Martin L Roth, Patrick Georgi, Stefan Reinauer, Stefan T. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64101 ) Change subject: Review access change ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Just wondering, what does "flashrom owners" mean? The people with full access to the project repo on Gerrit: Nico, stefanct, dhendrix, Th3Fanbus (me). This full access includes permission to create branches and to approve access changes (like this one), for example. -- To view, visit https://review.coreboot.org/c/flashrom/+/64101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: If675a0782521b58ecef60e56305016acc24e0cd8 Gerrit-Change-Number: 64101 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Mon, 09 May 2022 09:35:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022