May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Add Macronix MX25V8035F
by Name of user not set (Code Review) 24 May '22

24 May '22

Attention is currently required from: Felix Singer. roman.stingler(a)gmail.com has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63906 ) Change subject: flashchips: Add Macronix MX25V8035F ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Hi sorry for the late reply. Thanks for the fix and it looks good to me. -- To view, visit https://review.coreboot.org/c/flashrom/+/63906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icaf19910703c5322054c92dda9d27d34c6678526 Gerrit-Change-Number: 63906 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: roman.stingler(a)gmail.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Tue, 24 May 2022 10:53:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Add reviewers group to allow +1, -1 changes.
by Anastasia Klimchuk (Code Review) 24 May '22

24 May '22

Attention is currently required from: Felix Singer, Nico Huber, Martin L Roth. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64499 ) Change subject: Add reviewers group to allow +1, -1 changes. ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > We can discuss that in the flashrom meeting and see if more changes are desired. I remember you asked me on the meeting, but I got a bit confused (I wasn't entirely sure whether I understood your explanations). Sorry for that! Yes the decision was for "flashrom reviewers" to have -1..+2 permissions, and no submit, no -2. Just -1..+2. > I suspect that permissions given by the 'all projects' group are still going to be active unless negated here. What are the permissions given by "all projects" group? If that's -1..+1 this is fine. All Gerrit users have -1..+1. I also have another question: when the change gets into effect, is it after the patch is submitted? Does it mean that we need to immediately populate "flashrom reviewers" with people? Because as I understand, this patch creates a group but does not populate with it people. Another reason I am asking about when the change gets into effect, I am thinking to write an email to coreboot people who lose +2 on flashrom as a result. I have some vague ideas of what should be in the email, but roughly it should explain "what has happened", "reasons for this", "how to get +2 back". Thank you for the patch, sorry I only noticed it today. -- To view, visit https://review.coreboot.org/c/flashrom/+/64499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I6af85c58d9a8c37c8bf17181c83720332a474cc8 Gerrit-Change-Number: 64499 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Comment-Date: Tue, 24 May 2022 06:11:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)tutanota.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi25_statusreg.c: Allow opaque masters to hook spi_{rw}_register()
by Subrata Banik (Code Review) 24 May '22

24 May '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Sergii Dmytruk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64375 ) Change subject: spi25_statusreg.c: Allow opaque masters to hook spi_{rw}_register() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3ab0d7f5f48338c8ecb118a69651c203fbc516ac Gerrit-Change-Number: 64375 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Tue, 24 May 2022 03:54:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add W25Q512NW-IM ID to flashrom
by Nikolai Artemiev (Code Review) 24 May '22

24 May '22

Attention is currently required from: Vadim Bendebury, Angel Pons. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64405 ) Change subject: Add W25Q512NW-IM ID to flashrom ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/64405/comment/0d822abd_d2bbf353 PS2, Line 23: Signed-off-by > move this line to after the Change-Id: line. Done File flashchips.c: https://review.coreboot.org/c/flashrom/+/64405/comment/4098dc33_7116e7fa PS1, Line 17973: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ, > Thanks Angel! Please mention the 4BA corrections in the commit message too, maybe with Spotted-by: A […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/64405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Gerrit-Change-Number: 64405 Gerrit-PatchSet: 4 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 24 May 2022 00:12:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add W25Q512NW-IM ID to flashrom
by Nikolai Artemiev (Code Review) 24 May '22

24 May '22

Attention is currently required from: Vadim Bendebury, Angel Pons, Nikolai Artemiev. Hello build bot (Jenkins), Vadim Bendebury, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64405 to look at the new patch set (#4). Change subject: Add W25Q512NW-IM ID to flashrom ...................................................................... Add W25Q512NW-IM ID to flashrom Add Winbond W25Q512NW-IM chip ID and specs to flashrom. BUG=b:200173901 BRANCH=none TEST=flash W25Q512NW-IM using CCD. Original-Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Original-Signed-off-by: Atul Dhudase <adhudase(a)codeaurora.org> Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/… Original-Reviewed-by: Shelley Chen <shchen(a)chromium.org> Original-Reviewed-by: Vadim Bendebury <vbendeb(a)chromium.org> Original-Tested-by: Shelley Chen <shchen(a)chromium.org> Original-Commit-Queue: Shelley Chen <shchen(a)chromium.org> (cherry picked from commit facb282e8939b8e4ad15d2478ed9ef86d98aed61) Note: this commit was cherry-picked from the cros tree but includes corrections to errors in the original commit's 4BA feature flags that were spotted by Angel Pons Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M flashchips.c M include/flashchips.h 2 files changed, 44 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/64405/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/64405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Gerrit-Change-Number: 64405 Gerrit-PatchSet: 4 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Add W25Q512NW-IM ID to flashrom
by Nikolai Artemiev (Code Review) 24 May '22

24 May '22

Attention is currently required from: Vadim Bendebury, Angel Pons, Nikolai Artemiev. Hello build bot (Jenkins), Vadim Bendebury, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/64405 to look at the new patch set (#3). Change subject: Add W25Q512NW-IM ID to flashrom ...................................................................... Add W25Q512NW-IM ID to flashrom Add Winbond W25Q512NW-IM chip ID and specs to flashrom. BUG=b:200173901 BRANCH=none TEST=flash W25Q512NW-IM using CCD. Original-Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Original-Signed-off-by: Atul Dhudase <adhudase(a)codeaurora.org> Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/… Original-Reviewed-by: Shelley Chen <shchen(a)chromium.org> Original-Reviewed-by: Vadim Bendebury <vbendeb(a)chromium.org> Original-Tested-by: Shelley Chen <shchen(a)chromium.org> Original-Commit-Queue: Shelley Chen <shchen(a)chromium.org> (cherry picked from commit facb282e8939b8e4ad15d2478ed9ef86d98aed61) Note: this commit was cherry-picked from the cros tree but includes corrections to errors in the original commit's the 4BA feature flags that were spotted by Angel Pons Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M flashchips.c M include/flashchips.h 2 files changed, 44 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/64405/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/64405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65 Gerrit-Change-Number: 64405 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[refs/meta/config]: Add reviewers group to allow +1, -1 changes.
by Nico Huber (Code Review) 24 May '22

24 May '22

Attention is currently required from: Felix Singer, Martin L Roth, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64499 ) Change subject: Add reviewers group to allow +1, -1 changes. ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I guess we need the `exclusive` flag on label-Code-Review. That shouldn't […] Sorry, I meant -1..+2 was decided. The usual reviewer rule. I let the symmetry confuse myself :) -- To view, visit https://review.coreboot.org/c/flashrom/+/64499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I6af85c58d9a8c37c8bf17181c83720332a474cc8 Gerrit-Change-Number: 64499 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 23 May 2022 22:55:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)tutanota.com> Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Add reviewers group to allow +1, -1 changes.
by Nico Huber (Code Review) 24 May '22

24 May '22

Attention is currently required from: Felix Singer, Martin L Roth, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64499 ) Change subject: Add reviewers group to allow +1, -1 changes. ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'm not convinced that this is going to do everything that is desired. […] I guess we need the `exclusive` flag on label-Code-Review. That shouldn't be an issue with the rules for "refs/*" because the owners should be all in the flashrom developers group. The decision was to grant -2..+2. And if we set that to `exclusive` I hope the All-Projects rules for -1..+1 still apply. -- To view, visit https://review.coreboot.org/c/flashrom/+/64499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I6af85c58d9a8c37c8bf17181c83720332a474cc8 Gerrit-Change-Number: 64499 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 23 May 2022 22:51:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)tutanota.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi25_statusreg.c: Allow opaque masters to hook spi_{rw}_register()
by Anastasia Klimchuk (Code Review) 23 May '22

23 May '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64375 ) Change subject: spi25_statusreg.c: Allow opaque masters to hook spi_{rw}_register() ...................................................................... Patch Set 4: (1 comment) File spi25_statusreg.c: https://review.coreboot.org/c/flashrom/+/64375/comment/c538b410_20d2360f PS3, Line 35: } > Might be, I haven't seen it being documented though. Flashrom coding style is documented in Development Guidelines: https://www.flashrom.org/Development_Guidelines#Coding_style This specific question is covered in p.3 "Placing Braces and Spaces" -- To view, visit https://review.coreboot.org/c/flashrom/+/64375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3ab0d7f5f48338c8ecb118a69651c203fbc516ac Gerrit-Change-Number: 64375 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 23 May 2022 21:54:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: use objects form libflashrom
by Anastasia Klimchuk (Code Review) 23 May '22

23 May '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64031 ) Change subject: meson: use objects form libflashrom ...................................................................... Patch Set 6: Code-Review-1 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/64031/comment/d9739a26_594a832c PS6, Line 512: compile_args : [ : '-includestdlib.h', : '-includeunittest_env.h', : '-includehwaccess_x86_io_unittest.h' : ], > The -includestdlib.h is handled in the previous patch in the chain. […] I added a long comment into previous patch CB:64385 which applies to both patches. Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/64031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Gerrit-Change-Number: 64031 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 23 May 2022 21:39:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022