April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
by Ravishankar Sarawadi (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Felix Singer, Angel Pons. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025 ) Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58025/comment/de803a19_d3f7de38 PS2, Line 7: [WIP] > Also, remove this please Done File flashchips.h: https://review.coreboot.org/c/flashrom/+/58025/comment/4ea9ccec_dfc8c854 PS1, Line 403: #define GIGADEVICE_GD25LR256E 0x6719 > Please keep the ordering and move it down one more line. Done File flashchips.c: https://review.coreboot.org/c/flashrom/+/58025/comment/845e609b_eeaea493 PS2, Line 6452: }, > Please use tabs Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 3 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 05 Apr 2022 22:27:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
by Ravishankar Sarawadi (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Ravishankar Sarawadi, Angel Pons. Hello build bot (Jenkins), Angel Pons, Sukumar Ghorai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58025 to look at the new patch set (#4). Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME ...................................................................... flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME Datasheets: https://www.gigadevice.com/datasheet/gd25r256e/ https://www.gigadevice.com/datasheet/gd25lr512me/ BUG=none BRANCH=none TEST= Flash image using Flashrom Tool sudo dut-control cold_reset:on fw_wp_en:off spi2_buf_en:on spi2_buf_on_flex_en:on spi2_vref:pp1800 spi_hold:off sudo flashrom -V -p raiden_debug_spi -w <test_binary> sudo dut-control spi2_buf_en:off spi2_buf_on_flex_en:off spi2_vref:off spi_hold:off cold_reset:off Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> --- M flashchips.c M flashchips.h 2 files changed, 95 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/58025/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/58025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 4 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
by Ravishankar Sarawadi (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Ravishankar Sarawadi, Angel Pons. Hello build bot (Jenkins), Angel Pons, Sukumar Ghorai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58025 to look at the new patch set (#3). Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME ...................................................................... flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME Datasheets: https://www.gigadevice.com/datasheet/gd25r256e/ https://www.gigadevice.com/datasheet/gd25lr512me/ BUG=none BRANCH=none TEST= Flash image using Flashrom Tool sudo dut-control cold_reset:on fw_wp_en:off spi2_buf_en:on spi2_buf_on_flex_en:on spi2_vref:pp1800 spi_hold:off sudo flashrom -V -p raiden_debug_spi -w <test_binary> sudo dut-control spi2_buf_en:off spi2_buf_on_flex_en:off spi2_vref:off spi_hold:off cold_reset:off Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> --- M flashchips.c M flashchips.h 2 files changed, 96 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/58025/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 3 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ch341a_spi.c: Reset device before use
by Thomas Heijligen (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Nico Huber, Arthur Heymans. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63258 ) Change subject: ch341a_spi.c: Reset device before use ...................................................................... Patch Set 1: (1 comment) File ch341a_spi.c: https://review.coreboot.org/c/flashrom/+/63258/comment/c85474e4_e6a02306 PS1, Line 452: if (ret != 0) { From the libusb API doc: "If the reset fails, [...]. This means that the device handle is no longer valid [...]." A no longer valid libusb handle is not caught. -- To view, visit https://review.coreboot.org/c/flashrom/+/63258 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iff824c22dc871bb2d9504abe8b5ad4e4c191c4af Gerrit-Change-Number: 63258 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 05 Apr 2022 18:53:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer: Use C linkage when compiling with C++
by Thomas Heijligen (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Tom Hughes, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63001 ) Change subject: programmer: Use C linkage when compiling with C++ ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: flashrom is entirely written in C and should only be compiled with a proper C compiler. Since programmer.h is a internal header of flashrom I see no need to guard id for C++ usage. -- To view, visit https://review.coreboot.org/c/flashrom/+/63001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7e12ead58dee07313d756f1afcc687ba12b6392b Gerrit-Change-Number: 63001 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 05 Apr 2022 18:37:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dmi.c: Hide has_dmi_support global behind method
by Thomas Heijligen (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59283 ) Change subject: dmi.c: Hide has_dmi_support global behind method ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/59283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibded9714998ea6f2e5d4e0512fa7c6b105f9638a Gerrit-Change-Number: 59283 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 05 Apr 2022 18:31:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add AT45DB641E
by Angel Pons (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Nico Huber, Savva. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63345 ) Change subject: flashchips: Add AT45DB641E ...................................................................... Patch Set 1: (1 comment) File flashchips.h: https://review.coreboot.org/c/flashrom/+/63345/comment/1a75021c_eafaf6fc PS1, Line 196: #define ATMEL_AT45DB642D 0x280000 : #define ATMEL_AT45DB641E 0x280001 Hmmm, how exactly does this work? `probe_spi_at45db()` calls `probe_spi_rdid()`, which only reads 3 bytes (one byte for vendor ID, two bytes for device ID). -- To view, visit https://review.coreboot.org/c/flashrom/+/63345 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I56843b02bee74918a5131326627941ea82003f1f Gerrit-Change-Number: 63345 Gerrit-PatchSet: 1 Gerrit-Owner: Savva <savvamtr(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Savva <savvamtr(a)gmail.com> Gerrit-Comment-Date: Tue, 05 Apr 2022 15:37:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: enable write-protection for W25Q{64,128}.V
by Sergii Dmytruk (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Nico Huber, Angel Pons. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59071 ) Change subject: flashchips: enable write-protection for W25Q{64,128}.V ...................................................................... Patch Set 25: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/59071/comment/ce844fbb_27a4c755 PS25, Line 18017: W25Q64JV > We already have the same name in the entry below (with a different […] Thanks, I didn't notice that this entry was added. I think proposed names are correct. -- To view, visit https://review.coreboot.org/c/flashrom/+/59071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iccb69a8d3a0dd2192e2c938caddaf07b1889ed35 Gerrit-Change-Number: 59071 Gerrit-PatchSet: 25 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 05 Apr 2022 15:36:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi25_statusreg.c: add SR3 read/write support
by Sergii Dmytruk (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Nico Huber. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60230 ) Change subject: spi25_statusreg.c: add SR3 read/write support ...................................................................... Patch Set 9: (1 comment) File flash.h: https://review.coreboot.org/c/flashrom/+/60230/comment/407f5415_fe88f429 PS2, Line 148: FEATURE_SR3 > As mentioned above SR2 is a different case no matter what we do, as […] I think Nico is right and this flag is not actually useful, because it never on its own controls whether SR3 access will occur. Removed it. -- To view, visit https://review.coreboot.org/c/flashrom/+/60230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id987c544c02da2b956e6ad2c525265cac8f15be1 Gerrit-Change-Number: 60230 Gerrit-PatchSet: 9 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 15:35:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC][OTP] spi25_statusreg: support reading/writing security register
by Sergii Dmytruk (Code Review) 05 Apr '22

05 Apr '22

Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/59709 to look at the new patch set (#23). Change subject: [RFC][OTP] spi25_statusreg: support reading/writing security register ...................................................................... [RFC][OTP] spi25_statusreg: support reading/writing security register Not to be confused with "secure registers" of OTP. Security register is a dedicated status register for security-related bits. You don't write its value directly, issuing corresponding write command with no data just sets OTP bit to 1 automatically. No WREN is necessary, but at least some datasheets indicate BUSY state after write command. Unlike cases where OTP bit is part of SR and can only be written while in OTP mode, security register can only be written outside of the mode. Change-Id: Iae1753ca4cb051127a5bcbeba7f064053adb8dae Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M flash.h M spi.h M spi25_statusreg.c 3 files changed, 75 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/59709/23 -- To view, visit https://review.coreboot.org/c/flashrom/+/59709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iae1753ca4cb051127a5bcbeba7f064053adb8dae Gerrit-Change-Number: 59709 Gerrit-PatchSet: 23 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022