April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: ichspi: Use `pprint_reg` macro for PCH100 HSFC FCYCLE offset
by Subrata Banik (Code Review) 11 Apr '22

11 Apr '22

Attention is currently required from: Edward O'Callaghan, Angel Pons. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63470 ) Change subject: ichspi: Use `pprint_reg` macro for PCH100 HSFC FCYCLE offset ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Changes > print(FLASHROM_MSG_DEBUG, "%s=%d" ", ", "HSFC", (reg_val & (0xf << (17 - 16))) >> (17 - 16)); > > to > print(FLASHROM_MSG_DEBUG, "%s=%d" ", ", "FCYCLE", (reg_val & (0xf << (17 - 16))) >> (17 - 16)); > > which actually fixes it. No idea what I originally intended with > the `_pprint_reg` macro. I guess we can/should drop it now. good point, there is no user of _pprint_reg() function now, we can drop this. will add a CL in between for this. -- To view, visit https://review.coreboot.org/c/flashrom/+/63470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a8d84639b7226bf82458a7310f306c5232cffe3 Gerrit-Change-Number: 63470 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Apr 2022 11:39:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Use `pprint_reg` macro for PCH100 HSFC FCYCLE offset
by Nico Huber (Code Review) 11 Apr '22

11 Apr '22

Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63470 ) Change subject: ichspi: Use `pprint_reg` macro for PCH100 HSFC FCYCLE offset ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Changes print(FLASHROM_MSG_DEBUG, "%s=%d" ", ", "HSFC", (reg_val & (0xf << (17 - 16))) >> (17 - 16)); to print(FLASHROM_MSG_DEBUG, "%s=%d" ", ", "FCYCLE", (reg_val & (0xf << (17 - 16))) >> (17 - 16)); which actually fixes it. No idea what I originally intended with the `_pprint_reg` macro. I guess we can/should drop it now. -- To view, visit https://review.coreboot.org/c/flashrom/+/63470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a8d84639b7226bf82458a7310f306c5232cffe3 Gerrit-Change-Number: 63470 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Apr 2022 11:35:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Add `PCH100_` prefix for `Write Enable Type (WET)` macros
by Nico Huber (Code Review) 11 Apr '22

11 Apr '22

Attention is currently required from: Subrata Banik, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62888 ) Change subject: ichspi: Add `PCH100_` prefix for `Write Enable Type (WET)` macros ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Patchset: PS9: Doesn't change the pre-processor output (IMHO a much better test). -- To view, visit https://review.coreboot.org/c/flashrom/+/62888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id32cb4ccb83dd08e9b0b1ab30cc8e041dd059f5f Gerrit-Change-Number: 62888 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Apr 2022 11:33:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess: use __asm__ as it is done elsewhere
by Nico Huber (Code Review) 11 Apr '22

11 Apr '22

Attention is currently required from: Felix Singer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63487 ) Change subject: hwaccess: use __asm__ as it is done elsewhere ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: IIRC, we discussed this change earlier already. I wanted to stall it until a release (which didn't happen, and we don't seem closer). We do more build-testing now, so I guess it's ok (to try). This was also the or one of the things that held us back from setting a `--std=cxx`. -- To view, visit https://review.coreboot.org/c/flashrom/+/63487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I834fa6e171d2b20e1a5faa5a2e8f54caf107171a Gerrit-Change-Number: 63487 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Mon, 11 Apr 2022 11:22:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Fix -Wmissing-prototypes warnings
by Nico Huber (Code Review) 11 Apr '22

11 Apr '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63489 ) Change subject: tests: Fix -Wmissing-prototypes warnings ...................................................................... Patch Set 1: (1 comment) File tests/chip.c: https://review.coreboot.org/c/flashrom/+/63489/comment/2e6d78f5_388192e4 PS1, Line 50: static > It's part of fixing the warnings, though. The scope is set by the commit message. So currently Angel seems right, but splitting the commit would also make it easier to have a good commit message that explains what changes and not how the change was triggered :) -- To view, visit https://review.coreboot.org/c/flashrom/+/63489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia1ff22deb2354569f277649c6575ef2d5ffbb6e0 Gerrit-Change-Number: 63489 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 11 Apr 2022 11:07:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors.c: Ensure unsigned types >=0 on to prevent underflow
by Nico Huber (Code Review) 11 Apr '22

11 Apr '22

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 ) Change subject: ich_descriptors.c: Ensure unsigned types >=0 on to prevent underflow ...................................................................... Patch Set 18: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62764/comment/d7318e5e_e684d231 PS18, Line 11: this value for left shifting could be even more dangerous. Just for future commits. If the nature of the patch changes during review, the commit message should be updated. At least I can't see how this reflects the change now. It looks like the commit message assumes a possible error. -- To view, visit https://review.coreboot.org/c/flashrom/+/62764 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5921cc571f3dca5188ca1973dba6ececbcbe2f39 Gerrit-Change-Number: 62764 Gerrit-PatchSet: 18 Gerrit-Owner: Light <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:49:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: regroup parts for the internal programmer
by Thomas Heijligen (Code Review) 11 Apr '22

11 Apr '22

Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63468 ) Change subject: programmer.h: regroup parts for the internal programmer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > It doesn't seem trivial to say how this makes things better. I can […] +1, making a header file for the shared things of the internal programmer. I'll keep this Gerrit ID for this change. -- To view, visit https://review.coreboot.org/c/flashrom/+/63468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0dcdb6c7998eec36e619f6e5c82825f60a2435ac Gerrit-Change-Number: 63468 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:46:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: regroup parts for the internal programmer
by Thomas Heijligen (Code Review) 11 Apr '22

11 Apr '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Thomas Heijligen has removed a vote from this change. ( https://review.coreboot.org/c/flashrom/+/63468 ) Change subject: programmer.h: regroup parts for the internal programmer ...................................................................... Removed Code-Review+2 by Edward O'Callaghan <quasisec(a)chromium.org> -- To view, visit https://review.coreboot.org/c/flashrom/+/63468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0dcdb6c7998eec36e619f6e5c82825f60a2435ac Gerrit-Change-Number: 63468 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: deleteVote

1 0

Change in flashrom[master]: programmer.h: regroup parts for the internal programmer
by Nico Huber (Code Review) 11 Apr '22

11 Apr '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63468 ) Change subject: programmer.h: regroup parts for the internal programmer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: It doesn't seem trivial to say how this makes things better. I can see that for the removed #endif/#ifdef` pairs, but not for everything. IMO, we should put such things into individual header files eventually. So should we maybe do that right away and skip shuffling things around? (which would only make the Git history harder to follow) -- To view, visit https://review.coreboot.org/c/flashrom/+/63468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0dcdb6c7998eec36e619f6e5c82825f60a2435ac Gerrit-Change-Number: 63468 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:36:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Drop STANDALONE mode
by Nico Huber (Code Review) 11 Apr '22

11 Apr '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63469 ) Change subject: Drop STANDALONE mode ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I58fb82270a9884a323d9850176708d230fdc5165 Gerrit-Change-Number: 63469 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:26:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022