April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: util/ich_descriptors_tool: Remove unneeded meson dependencies
by Thomas Heijligen (Code Review) 24 Apr '22

24 Apr '22

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63757 ) Change subject: util/ich_descriptors_tool: Remove unneeded meson dependencies ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/63757/comment/1ce4026d_1e479378 PS1, Line 7: meson: ich_descriptors_tool remove unneeded dependencies > How about: util/ich_descriptors_tool: Remove unneeded meson dependencies Done -- To view, visit https://review.coreboot.org/c/flashrom/+/63757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ice1437cb294729b6af0e24f0a02692459b7a1412 Gerrit-Change-Number: 63757 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Apr 2022 22:38:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: util/ich_descriptors_tool: Remove unneeded meson dependencies
by Thomas Heijligen (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63757 to look at the new patch set (#2). Change subject: util/ich_descriptors_tool: Remove unneeded meson dependencies ...................................................................... util/ich_descriptors_tool: Remove unneeded meson dependencies Change-Id: Ice1437cb294729b6af0e24f0a02692459b7a1412 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M util/ich_descriptors_tool/meson.build 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/63757/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ice1437cb294729b6af0e24f0a02692459b7a1412 Gerrit-Change-Number: 63757 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Introduce an `include` directory for header files
by Thomas Heijligen (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Felix Singer, Nico Huber, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 ) Change subject: Introduce an `include` directory for header files ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58622/comment/2a0764c4_73aec586 PS3, Line 9: dicrectory > directory Done https://review.coreboot.org/c/flashrom/+/58622/comment/fdd8bb65_0e3cebe6 PS3, Line 10: buildsystems > Add a space in between Done https://review.coreboot.org/c/flashrom/+/58622/comment/42341bc0_4b407ba0 PS3, Line 10: `#include`s > nit: include directives Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf Gerrit-Change-Number: 58622 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <martinroth(a)google.com> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Apr 2022 22:35:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Introduce an `include` directory for header files
by Thomas Heijligen (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Anastasia Klimchuk. Thomas Heijligen has uploaded a new patch set (#4) to the change originally created by Felix Singer. ( https://review.coreboot.org/c/flashrom/+/58622 ) Change subject: Introduce an `include` directory for header files ...................................................................... Introduce an `include` directory for header files Move all header files to the new `include` directory. Adapt include directives and build systems to the new directory. Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf Signed-off-by: Felix Singer <felix.singer(a)secunet.com> Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile R include/chipdrivers.h R include/coreboot_tables.h R include/custom_baud.h R include/edi.h R include/ene.h R include/flash.h R include/flashchips.h R include/fmap.h R include/hwaccess_physmap.h R include/hwaccess_x86_io.h R include/hwaccess_x86_msr.h R include/i2c_helper.h R include/ich_descriptors.h R include/layout.h R include/libflashrom.h R include/platform.h R include/platform/pci.h R include/programmer.h R include/spi.h R include/usb_device.h R include/writeprotect.h M meson.build M platform/endian_big.c M platform/endian_little.c M platform/memaccess.c M util/ich_descriptors_tool/Makefile M util/ich_descriptors_tool/meson.build 28 files changed, 14 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/58622/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/58622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf Gerrit-Change-Number: 58622 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <martinroth(a)google.com> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Introduce an `include` directory for header files
by Felix Singer (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 ) Change subject: Introduce an `include` directory for header files ...................................................................... Patch Set 3: Code-Review+2 (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58622/comment/d88bf870_366e7552 PS3, Line 9: dicrectory directory https://review.coreboot.org/c/flashrom/+/58622/comment/28c89456_d98200f5 PS3, Line 10: buildsystems Add a space in between https://review.coreboot.org/c/flashrom/+/58622/comment/dddcb2f0_572c5a6e PS3, Line 10: `#include`s nit: include directives -- To view, visit https://review.coreboot.org/c/flashrom/+/58622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf Gerrit-Change-Number: 58622 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <martinroth(a)google.com> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:28:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Introduce an `include` directory for header files
by Martin L Roth (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Anastasia Klimchuk. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 ) Change subject: Introduce an `include` directory for header files ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Good call. Thanks. -- To view, visit https://review.coreboot.org/c/flashrom/+/58622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf Gerrit-Change-Number: 58622 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <martinroth(a)google.com> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:08:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Close GitHub PRs and issues automatically
by Felix Singer (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Martin L Roth, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63671 ) Change subject: Close GitHub PRs and issues automatically ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > It looks like it might be able to install a github plugin that automatically sends PRs to gerrit ins […] My reply became much bigger as I intended it to be, but I think it's a good analysis at least :) To be honest, I don't see a reason why we should put more effort into this. Sure, it would be great if we also could cover GitHub PRs, but why don't people just use Gerrit? In my opinion it's a mix of some people who don't know better and some people who are just too lazy to deal with something else. Using a plugin, that integrates GitHub into Gerrit, feels more like a ugly workaround or hack for me. So I think for some people the GitHub repository looks like as we would maintain it (when I search for "flashrom" then it's also the second hit on Google for me). It gets new commits and it also contains lots of issues and PRs, which make it look like very active. So some people might create a PR there, because they are not aware of Gerrit and they might think that the GitHub repository is the point for contact (reaching out for issues, sending patches). Thus, we have to reduce the amount of open issues and PRs. This GitHub Action hook is meant as a first step. The remaining issues and PRs will be closed by time. I will look over them and see what's useful. Creating yet another account somewhere could also be a reason, but we allow using different authentication providers, including GitHub. So this is not a problem here. Though, it could be that people don't know that, but that's a different problem then. In both cases, we would have to think of how to improve our documentation and how we can make them aware of Gerrit or the different authentication providers. An automated message, as it is done with this GitHub Action hook, is a very simple and cheap solution. We don't even have to set up something ourselves. The people, who are really interested in contributing, will look at our guidelines and push their patch to Gerrit. And also, there might be people who are just too lazy to deal with something else, as demonstrated in this PR [1], and they refused using Gerrit because "git send-mail is simple enough". Their reasoning is pretty poor and I am not able to get anything out of it. However, sending patches over mail is absolutely fine for me. Another person said they don't want to use Gerrit because it is developed by Google. That's nothing I can work with. We shouldn't create workarounds for these people. So I think we shouldn't put any more effort into this and we shouldn't support this because there is no actual reason. If anything, then we should improve our documentation, but adding a 3rd party plugin is just too much here. Not speaking of the potential issues the plugin might cause, e.g. new Gerrit version is out and we can't do the update because the plugin doesn't support it yet or the plugin breaks for some other reason. [1] https://github.com/flashrom/flashrom/pull/154 -- To view, visit https://review.coreboot.org/c/flashrom/+/63671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8076f0fb964970ffd05f355b9d1e33a65aa7a3c8 Gerrit-Change-Number: 63671 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Apr 2022 17:07:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi: Reduce read size for FT232H
by Peter Farley (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Nico Huber, Angel Pons. Peter Farley has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63798 ) Change subject: ft2232_spi: Reduce read size for FT232H ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/63798/comment/0450bb6d_606759ea PS1, Line 9: FT232H-based devices are unable to read over 256 bytes of flash in one > > ftdi_read_data: -1, usb bulk read failed […] I get the same result for wMaxPacketSize. Decreasing the read chunk size below 512 (if I have not also decreased the max_data_read) causes a segfault when writing to the output file. (I assume it's trying to read beyond the buffer size, but I haven't looked too deeply into it.) Looking at Wireshark captures of the USB communication, it does look like the device is transmitting all the data. I'm not familiar enough with the FTDI protocols to see if something looks wrong there though. I don't see any way to upload files here, so here are the verbose outputs from tshark, if they might be helpful at all: 64K: https://pastebin.com/er7mv3tT 256B: https://pastebin.com/jfb2yv3d (Cut short due to its length) The 64K reads start around frame 43. And frame 45 for the 256B reads. -- To view, visit https://review.coreboot.org/c/flashrom/+/63798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2a45fb8ac8ff37bbf01b0cb6b88851cf74af495d Gerrit-Change-Number: 63798 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Farley <far.peter1(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 16:36:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Peter Farley <far.peter1(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Close GitHub PRs and issues automatically
by Nico Huber (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63671 ) Change subject: Close GitHub PRs and issues automatically ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/63671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8076f0fb964970ffd05f355b9d1e33a65aa7a3c8 Gerrit-Change-Number: 63671 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Apr 2022 16:30:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: mark IS25LP064 as TEST_OK_PREW
by Nico Huber (Code Review) 24 Apr '22

24 Apr '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/58472 ) Change subject: flashchips.c: mark IS25LP064 as TEST_OK_PREW ...................................................................... flashchips.c: mark IS25LP064 as TEST_OK_PREW Tested '-w', '-E' and '-r' successfully with my FT2232H programmer. Change-Id: I2197ce0be9db7c3d74b24c7445dc06238584ffea Signed-off-by: Simon Buhrow <simon.buhrow(a)posteo.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/58472 Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 04a8dda..0a1d21d 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7387,7 +7387,7 @@ .page_size = 256, /* OTP: 1024B total; read 0x48; write 0x42 */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/58472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2197ce0be9db7c3d74b24c7445dc06238584ffea Gerrit-Change-Number: 58472 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022