April 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips.c: mark IS25LP064 as TEST_OK_PREW
by Nico Huber (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Felix Singer, Simon Buhrow, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58472 ) Change subject: flashchips.c: mark IS25LP064 as TEST_OK_PREW ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58472/comment/d23ae4ea_cdf805b0 PS2, Line 10: my FT2232H programmer. > Please move this into the previous line. Let's keep such style choices to the author (as long as it complies with the general rules). -- To view, visit https://review.coreboot.org/c/flashrom/+/58472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2197ce0be9db7c3d74b24c7445dc06238584ffea Gerrit-Change-Number: 58472 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 24 Apr 2022 15:35:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: Mark GD25Q40(B) as tested
by Nico Huber (Code Review) 24 Apr '22

24 Apr '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/62712 ) Change subject: flashchips.c: Mark GD25Q40(B) as tested ...................................................................... flashchips.c: Mark GD25Q40(B) as tested As mentioned by Wolf Dieter Brandt in his mail from 07.Feb.22. Change-Id: Idec3d82efbdf095c3d57bfe5f0fd487007b554cb Signed-off-by: Simon Buhrow <simon.buhrow(a)posteo.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/62712 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 3224142..04a8dda 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6859,7 +6859,7 @@ .total_size = 512, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/62712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idec3d82efbdf095c3d57bfe5f0fd487007b554cb Gerrit-Change-Number: 62712 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: ft2232_spi: Reduce read size for FT232H
by Nico Huber (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Angel Pons, Peter Farley. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63798 ) Change subject: ft2232_spi: Reduce read size for FT232H ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/63798/comment/6a47f435_67a9ea3b PS1, Line 9: FT232H-based devices are unable to read over 256 bytes of flash in one > ftdi_read_data: -1, usb bulk read failed Hmmm, looks at least like something one could debug further in libftdi. I'm also on Arch and just updated libftdi and libusb to the latest, still works... There are two possible issues to consider: Is the amount of data limited per MPSSE_DO_READ command or per individual USB transfer. For the latter there's a max-packet-size in the USB descriptor (see `lsusb -v` mine says "wMaxPacketSize 0x0200 1x 512 bytes" for both IN and OUT endpoints). However, this is something the USB stack should take care of (if the descriptor is valid). I've played around with ftdi_read_data_set_chunksize(). This limits the size of transfers libftdi requests from libusb. It actually only works as long as I keep it above and a multiple of 512. -- To view, visit https://review.coreboot.org/c/flashrom/+/63798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2a45fb8ac8ff37bbf01b0cb6b88851cf74af495d Gerrit-Change-Number: 63798 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Farley <far.peter1(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Peter Farley <far.peter1(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 14:41:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Peter Farley <far.peter1(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi: Reduce read size for FT232H
by Peter Farley (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Nico Huber, Angel Pons. Peter Farley has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63798 ) Change subject: ft2232_spi: Reduce read size for FT232H ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/63798/comment/d12652f4_7334957d PS1, Line 9: FT232H-based devices are unable to read over 256 bytes of flash in one > Is this documented anywhere? Or how did you figure this out? The other person I've seen report this issue was also using the same board, so it could be an issue with the chip. https://github.com/flashrom/flashrom/issues/237 I got the board recently, and I believe it's a recent revision of the board. It's an FT232H board from Adafruit. It's also using the FT232HQ. As for SW, I'm running Arch Linux, with Linux 5.17, libftdi 1.5, and libusb 1.0.26. I also have another board with an FT2232HQ on it, I could test with that if that would be useful. If it works, that wouldn't really say much, but if it didn't work it might point to an issue in the libraries being more likely. -- To view, visit https://review.coreboot.org/c/flashrom/+/63798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2a45fb8ac8ff37bbf01b0cb6b88851cf74af495d Gerrit-Change-Number: 63798 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Farley <far.peter1(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 13:58:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi: Reduce read size for FT232H
by Nico Huber (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Angel Pons, Peter Farley. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63798 ) Change subject: ft2232_spi: Reduce read size for FT232H ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/63798/comment/17d0ec1a_4ddfbe69 PS1, Line 9: FT232H-based devices are unable to read over 256 bytes of flash in one > Is this documented anywhere? Or how did you figure this out? I've just re-tested my UM232H (with an FT232HQ). It works without patch as it should oO Limits in transfer size could also be due to a broken USB library/stack. Or it might be an odd revision of the chip? Seems unlikely because the FT232H is actually younger than the FT2232H. OTOH, a fake chip could be possible. Peter, please describe your overall setup. What OS and version do you use and what library versions are used (libusb & libftdi)? What FT232H device/board do you have and where did you get it (is it rather old/new)? -- To view, visit https://review.coreboot.org/c/flashrom/+/63798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2a45fb8ac8ff37bbf01b0cb6b88851cf74af495d Gerrit-Change-Number: 63798 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Farley <far.peter1(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Peter Farley <far.peter1(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Apr 2022 13:38:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: mark IS25LP064 as TEST_OK_PREW
by Felix Singer (Code Review) 24 Apr '22

24 Apr '22

Attention is currently required from: Simon Buhrow. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58472 ) Change subject: flashchips.c: mark IS25LP064 as TEST_OK_PREW ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58472/comment/cefcda9a_f30dc30a PS2, Line 10: my FT2232H programmer. Please move this into the previous line. -- To view, visit https://review.coreboot.org/c/flashrom/+/58472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2197ce0be9db7c3d74b24c7445dc06238584ffea Gerrit-Change-Number: 58472 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Buhrow Gerrit-Comment-Date: Sun, 24 Apr 2022 02:34:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi: Reduce read size for FT232H
by Angel Pons (Code Review) 23 Apr '22

23 Apr '22

Attention is currently required from: Nico Huber, Peter Farley. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63798 ) Change subject: ft2232_spi: Reduce read size for FT232H ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/63798/comment/cc8f3642_d3482011 PS1, Line 9: FT232H-based devices are unable to read over 256 bytes of flash in one Is this documented anywhere? Or how did you figure this out? File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/63798/comment/145fa391_b7fa057a PS1, Line 291: static struct spi_master spi_master_ft2232 = { I'd prefer having two structs. -- To view, visit https://review.coreboot.org/c/flashrom/+/63798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2a45fb8ac8ff37bbf01b0cb6b88851cf74af495d Gerrit-Change-Number: 63798 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Farley <far.peter1(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Peter Farley <far.peter1(a)gmail.com> Gerrit-Comment-Date: Sat, 23 Apr 2022 21:00:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi: Reduce read size for FT232H
by Peter Farley (Code Review) 23 Apr '22

23 Apr '22

Peter Farley has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/63798 ) Change subject: ft2232_spi: Reduce read size for FT232H ...................................................................... ft2232_spi: Reduce read size for FT232H FT232H-based devices are unable to read over 256 bytes of flash in one go. This change decreases the max_data_read to 256 when the selected type is "232H". Change-Id: I2a45fb8ac8ff37bbf01b0cb6b88851cf74af495d Signed-off-by: Peter Farley <far.peter1(a)gmail.com> --- M ft2232_spi.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/63798/1 diff --git a/ft2232_spi.c b/ft2232_spi.c index ccd5f4c..94107c3 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -288,7 +288,7 @@ return ret ? -1 : 0; } -static const struct spi_master spi_master_ft2232 = { +static struct spi_master spi_master_ft2232 = { .features = SPI_MASTER_4BA, .max_data_read = 64 * 1024, .max_data_write = 256, @@ -346,6 +346,7 @@ } else if (!strcasecmp(arg, "232H")) { ft2232_type = FTDI_FT232H_PID; channel_count = 1; + spi_master_ft2232.max_data_read = 256; } else if (!strcasecmp(arg, "4233H")) { ft2232_type = FTDI_FT4233H_PID; channel_count = 4; -- To view, visit https://review.coreboot.org/c/flashrom/+/63798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2a45fb8ac8ff37bbf01b0cb6b88851cf74af495d Gerrit-Change-Number: 63798 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Farley <far.peter1(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashchips.c: Mark GD25Q40(B) as tested
by Felix Singer (Code Review) 23 Apr '22

23 Apr '22

Attention is currently required from: Simon Buhrow, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62712 ) Change subject: flashchips.c: Mark GD25Q40(B) as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idec3d82efbdf095c3d57bfe5f0fd487007b554cb Gerrit-Change-Number: 62712 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 23 Apr 2022 12:36:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for XMC XM25QH80B
by Name of user not set (Code Review) 23 Apr '22

23 Apr '22

Attention is currently required from: Felix Singer, Angel Pons. mans0n+coreboot(a)gorani.run has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/flashrom/+/63516 ) Change subject: flashchips: Add support for XMC XM25QH80B ...................................................................... Removed reviewer build bot (Jenkins) with the following votes: * Verified+1 by build bot (Jenkins) <no-reply(a)coreboot.org> -- To view, visit https://review.coreboot.org/c/flashrom/+/63516 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib51225426d8d1a381d45af3574e5ba2bf02837aa Gerrit-Change-Number: 63516 Gerrit-PatchSet: 1 Gerrit-Owner: mans0n+coreboot(a)gorani.run Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: deleteReviewer

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2022