March 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: ichspi: Introduce HSFC FDBC(n) macro
by Subrata Banik (Code Review) 17 Mar '22

17 Mar '22

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62892 ) Change subject: ichspi: Introduce HSFC FDBC(n) macro ...................................................................... ichspi: Introduce HSFC FDBC(n) macro This patch introduces useful HSFC_FDBC(n) macros to use in SPI read and write operations. Also, renamed HSFC_FDBC -> HSFC_FDBC_MASK. BUG=b:223630977 TEST=Able to perform read/write/erase operation on brya. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ie2512c85de9fc21286234b97f5842ecef1729787 --- M ichspi.c 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/62892/1 diff --git a/ichspi.c b/ichspi.c index 3f7083c..080eb10 100644 --- a/ichspi.c +++ b/ichspi.c @@ -144,7 +144,8 @@ #define HSFC_WET (0x1 << HSFC_WET_OFF) /* 3-7: reserved */ #define HSFC_FDBC_OFF 8 /* 8-13: Flash Data Byte Count */ -#define HSFC_FDBC (0x3f << HSFC_FDBC_OFF) +#define HSFC_FDBC_MASK (0x3f << HSFC_FDBC_OFF) +#define HSFC_FDBC(n) (((n) << HSFC_FDBC_OFF) & HSFC_FDBC_MASK) /* 14: reserved */ #define HSFC_SME_OFF 15 /* 15: SPI SMI# Enable */ #define HSFC_SME (0x1 << HSFC_SME_OFF) @@ -505,7 +506,7 @@ reg_val, ", "); break; } - pprint_reg(HSFC, FDBC, reg_val, ", "); + _pprint_reg(HSFC, HSFC_FDBC_MASK, HSFC_FDBC_OFF, reg_val, ", "); pprint_reg(HSFC, SME, reg_val, "\n"); } @@ -1484,9 +1485,9 @@ hsfc = REGREAD16(ICH9_REG_HSFC); hsfc &= ~hwseq_data.hsfc_fcycle; /* set read operation */ - hsfc &= ~HSFC_FDBC; /* clear byte count */ + hsfc &= ~HSFC_FDBC_MASK; /* clear byte count */ /* set byte count */ - hsfc |= (((block_len - 1) << HSFC_FDBC_OFF) & HSFC_FDBC); + hsfc |= HSFC_FDBC(block_len - 1); hsfc |= HSFC_FGO; /* start */ REGWRITE16(ICH9_REG_HSFC, hsfc); @@ -1531,9 +1532,9 @@ hsfc = REGREAD16(ICH9_REG_HSFC); hsfc &= ~hwseq_data.hsfc_fcycle; /* clear operation */ hsfc |= (0x2 << HSFC_FCYCLE_OFF); /* set write operation */ - hsfc &= ~HSFC_FDBC; /* clear byte count */ + hsfc &= ~HSFC_FDBC_MASK; /* clear byte count */ /* set byte count */ - hsfc |= (((block_len - 1) << HSFC_FDBC_OFF) & HSFC_FDBC); + hsfc |= HSFC_FDBC(block_len - 1); hsfc |= HSFC_FGO; /* start */ REGWRITE16(ICH9_REG_HSFC, hsfc); -- To view, visit https://review.coreboot.org/c/flashrom/+/62892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie2512c85de9fc21286234b97f5842ecef1729787 Gerrit-Change-Number: 62892 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ichspi: Introduce HSFC FCYCLE(cyc)/FCYCLE_MASK(n) macros
by Subrata Banik (Code Review) 17 Mar '22

17 Mar '22

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62891 ) Change subject: ichspi: Introduce HSFC FCYCLE(cyc)/FCYCLE_MASK(n) macros ...................................................................... ichspi: Introduce HSFC FCYCLE(cyc)/FCYCLE_MASK(n) macros This patch introduces useful HSFC_FCYCLE(cyc) and HSFC_FCYCLE_MASK(n) macros to cover both ICH and PCH hardware sequencing FCYCLE Bit width. Also, drops unused macros (PCH100_HSFC_FCYCLE_OFF and PCH100_HSFC_FCYCLE). BUG=b:223630977 TEST=Able to perform read/write/erase operation on brya. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Id222304165610c7ae48e365d72ec8fdeea51c51d --- M ichspi.c 1 file changed, 11 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/62891/1 diff --git a/ichspi.c b/ichspi.c index 9146dac..3f7083c 100644 --- a/ichspi.c +++ b/ichspi.c @@ -78,8 +78,6 @@ */ /* Changed HSFC Control bits */ -#define PCH100_HSFC_FCYCLE_OFF (17 - 16) /* 1-4: FLASH Cycle */ -#define PCH100_HSFC_FCYCLE (0xf << PCH100_HSFC_FCYCLE_OFF) /* New HSFC Control bit */ #define PCH100_FADDR_FLA 0x07ffffff @@ -137,8 +135,11 @@ #define ICH9_REG_HSFC 0x06 /* 16 Bits Hardware Sequencing Flash Control */ #define HSFC_FGO_OFF 0 /* 0: Flash Cycle Go */ #define HSFC_FGO (0x1 << HSFC_FGO_OFF) -#define HSFC_FCYCLE_OFF 1 /* 1-2: FLASH Cycle */ -#define HSFC_FCYCLE (0x3 << HSFC_FCYCLE_OFF) +#define HSFC_FCYCLE_BIT_WIDTH_ICH9 3 /* 2 bits */ +#define HSFC_FCYCLE_BIT_WIDTH_PCH 0xf /* 4 bits */ +#define HSFC_FCYCLE_OFF 1 /* 1-HSFC_FCYCLE_BIT_WIDTH_x: FLASH Cycle */ +#define HSFC_FCYCLE_MASK(n) (n << HSFC_FCYCLE_OFF) +#define HSFC_FCYCLE(cyc) ((cyc) << HSFC_FCYCLE_OFF) #define HSFC_WET_OFF 5 /* 5: Write Enable Type */ #define HSFC_WET (0x1 << HSFC_WET_OFF) /* 3-7: reserved */ @@ -495,11 +496,13 @@ case CHIPSET_400_SERIES_COMET_POINT: case CHIPSET_500_SERIES_TIGER_POINT: case CHIPSET_ELKHART_LAKE: - _pprint_reg(HSFC, PCH100_HSFC_FCYCLE, PCH100_HSFC_FCYCLE_OFF, reg_val, ", "); + _pprint_reg(HSFC, HSFC_FCYCLE_MASK(HSFC_FCYCLE_BIT_WIDTH_PCH), HSFC_FCYCLE_OFF, + reg_val, ", "); pprint_reg(HSFC, WET, reg_val, ", "); break; default: - pprint_reg(HSFC, FCYCLE, reg_val, ", "); + _pprint_reg(HSFC, HSFC_FCYCLE_MASK(HSFC_FCYCLE_BIT_WIDTH_ICH9), HSFC_FCYCLE_OFF, + reg_val, ", "); break; } pprint_reg(HSFC, FDBC, reg_val, ", "); @@ -1838,7 +1841,7 @@ swseq->reg_opmenu = PCH100_REG_OPMENU; hwseq->addr_mask = PCH100_FADDR_FLA; hwseq->only_4k = true; - hwseq->hsfc_fcycle = PCH100_HSFC_FCYCLE; + hwseq->hsfc_fcycle = HSFC_FCYCLE_MASK(HSFC_FCYCLE_BIT_WIDTH_PCH); break; default: *num_pr = 5; @@ -1849,7 +1852,7 @@ swseq->reg_opmenu = ICH9_REG_OPMENU; hwseq->addr_mask = ICH9_FADDR_FLA; hwseq->only_4k = false; - hwseq->hsfc_fcycle = HSFC_FCYCLE; + hwseq->hsfc_fcycle = HSFC_FCYCLE_MASK(HSFC_FCYCLE_BIT_WIDTH_ICH9); break; } -- To view, visit https://review.coreboot.org/c/flashrom/+/62891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id222304165610c7ae48e365d72ec8fdeea51c51d Gerrit-Change-Number: 62891 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ichspi: Define `Write Enable Type (WET)` register under HSFC
by Subrata Banik (Code Review) 17 Mar '22

17 Mar '22

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62888 ) Change subject: ichspi: Define `Write Enable Type (WET)` register under HSFC ...................................................................... ichspi: Define `Write Enable Type (WET)` register under HSFC This patch moves the `WET` macro definition under HSFC offset to make it more readable. BUG=b:223630977 TEST=Able to perform read/write/erase operation on brya. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Id32cb4ccb83dd08e9b0b1ab30cc8e041dd059f5f --- M ichspi.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/62888/1 diff --git a/ichspi.c b/ichspi.c index c1c80e5..9146dac 100644 --- a/ichspi.c +++ b/ichspi.c @@ -81,8 +81,6 @@ #define PCH100_HSFC_FCYCLE_OFF (17 - 16) /* 1-4: FLASH Cycle */ #define PCH100_HSFC_FCYCLE (0xf << PCH100_HSFC_FCYCLE_OFF) /* New HSFC Control bit */ -#define HSFC_WET_OFF (21 - 16) /* 5: Write Enable Type */ -#define HSFC_WET (0x1 << HSFC_WET_OFF) #define PCH100_FADDR_FLA 0x07ffffff @@ -141,6 +139,8 @@ #define HSFC_FGO (0x1 << HSFC_FGO_OFF) #define HSFC_FCYCLE_OFF 1 /* 1-2: FLASH Cycle */ #define HSFC_FCYCLE (0x3 << HSFC_FCYCLE_OFF) +#define HSFC_WET_OFF 5 /* 5: Write Enable Type */ +#define HSFC_WET (0x1 << HSFC_WET_OFF) /* 3-7: reserved */ #define HSFC_FDBC_OFF 8 /* 8-13: Flash Data Byte Count */ #define HSFC_FDBC (0x3f << HSFC_FDBC_OFF) -- To view, visit https://review.coreboot.org/c/flashrom/+/62888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id32cb4ccb83dd08e9b0b1ab30cc8e041dd059f5f Gerrit-Change-Number: 62888 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ichspi: Unify timeout (5sec) across all SPI operations
by Subrata Banik (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62867 to look at the new patch set (#3). Change subject: ichspi: Unify timeout (5sec) across all SPI operations ...................................................................... ichspi: Unify timeout (5sec) across all SPI operations This patch removes taking `timeout` argument for different operations using `ich_hwseq_wait_for_cycle_complete()`. Make use of 5sec unified timeout for all SPI operations. Document Number: TBD (supporting document for multi-master accessing the SPI Flash device is awaited from Intel.) BUG=b:223630977 TEST=Able to perform read/write/erase/status operation on brya. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ifa910dea794175d8ee2ad277549e5a0d69cba45b --- M ichspi.c 1 file changed, 37 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/62867/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/62867 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifa910dea794175d8ee2ad277549e5a0d69cba45b Gerrit-Change-Number: 62867 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ichspi: Maximize usage of `ich_generation` global variable
by Subrata Banik (Code Review) 17 Mar '22

17 Mar '22

Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/62866 ) Change subject: ichspi: Maximize usage of `ich_generation` global variable ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/62866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7f37894b683196e741b6a95e290a68e83a550205 Gerrit-Change-Number: 62866 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: ichspi: Maximize usage of `ich_generation` global variable
by Subrata Banik (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62866 ) Change subject: ichspi: Maximize usage of `ich_generation` global variable ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Like I was saying internally, we want to do the opposite of this. We want functions *not* to be a closure of the global of ich_generation. > > In other words, ich_generation should be a parameter to all functions that use it. Sure, understood, there are several instances of global variable in current ichspi.c file as below, I hope you have plan to clean that up at once 1. https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/ic… 2. https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/ic… 3.https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/… 4.https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/… ... Total there are > 10 instances of `ich_generation` global variable. -- To view, visit https://review.coreboot.org/c/flashrom/+/62866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7f37894b683196e741b6a95e290a68e83a550205 Gerrit-Change-Number: 62866 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 17 Mar 2022 06:41:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Refactor Flashrom HW Sequencing Operation Part I
by Subrata Banik (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons, Anastasia Klimchuk. Subrata Banik has uploaded a new patch set (#2) to the change originally created by Subrata Banik. ( https://review.coreboot.org/c/flashrom/+/62868 ) Change subject: ichspi: Refactor Flashrom HW Sequencing Operation Part I ...................................................................... ichspi: Refactor Flashrom HW Sequencing Operation Part I List of changes: 1. Introduced useful macros (read/write/erase/status etc.) and used throughout the SPI operations. 2. Drop unused macros. BUG=b:223630977 TEST=Able to perform read/write/erase operation on brya. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80 --- M ichspi.c 1 file changed, 29 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/62868/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80 Gerrit-Change-Number: 62868 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests: add more mock wrappers
by Daniel Campello (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Anastasia Klimchuk. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62844 to look at the new patch set (#2). Change subject: tests: add more mock wrappers ...................................................................... tests: add more mock wrappers This change allows for tests to run when the compiler is inlining some other interfaces. * __fgets_chk() is being used instead of fgets() in get_max_kernel_buf_size() on linux_spi.c * __vfprintf_chk() is being used instead of fprintf() in disable_power_management() on power.c * __open64_2() is being used instead of open() in i2c_open_path() on i2c_helper_linux.c BUG=b:224828279 TEST=FEATURES=test emerge-volteer flashrom Signed-off-by: Daniel Campello <campello(a)chromium.org> Change-Id: I9776104d655c37891093da08789d37e5e27700de --- M tests/meson.build M tests/tests.c 2 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/62844/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9776104d655c37891093da08789d37e5e27700de Gerrit-Change-Number: 62844 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests: add more mock wrappers
by Daniel Campello (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Anastasia Klimchuk. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62844 ) Change subject: tests: add more mock wrappers ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62844/comment/8a0b7091_c9c3cc56 PS1, Line 9: This change allows for tests to run when the compiler is inlining some : other interfaces. > While I know what you mean here about clang but can you elaborate in a similar fashion to the corebo […] Even when I did read the coreboot patch, it did not help me figure out what was actually needed. What I did end up doing was to use `nm` on each of the compliled object files that were giving me troubles and finding the appropriate undefined symbols to be mocked. * __fgets_chk was being used instead of fgets in get_max_kernel_buf_size() on linux_spi.c * __vfprintf_chk was being used instead of fprintf in disable_power_management() on power.c * __open64_2() was being used instead of open() in i2c_open_path() on i2c_helper_linux.c -- To view, visit https://review.coreboot.org/c/flashrom/+/62844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9776104d655c37891093da08789d37e5e27700de Gerrit-Change-Number: 62844 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 17 Mar 2022 03:32:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi: Refactor Flashrom HW Sequencing Operation Part I
by Edward O'Callaghan (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62868 ) Change subject: ichspi: Refactor Flashrom HW Sequencing Operation Part I ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62868/comment/20dbf823_6c60a490 PS1, Line 9: List of changes: : 1. Introduced useful macros (read/write/erase/status etc.) and used : throughout the SPI operations. : 2. Drop unused macros. : 3. SPI operations are using `control register (offset 0x6)` hence : converted 32-bit reads into 16-bit read to cover the only hardware : sequencing control register alone. > As commented in the pre-review this needs to be split up into multiple patches. […] commit message is also misaligned with the patch content. For example (3) doesn't apply here? -- To view, visit https://review.coreboot.org/c/flashrom/+/62868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80 Gerrit-Change-Number: 62868 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 17 Mar 2022 01:58:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2022