February 2022 - flashrom-gerrit

Change in flashrom[master]: flash.h,flashchips.c: add writeprotect bit layout map to chips
by Nikolai Artemiev (Code Review) 24 Feb '22

24 Feb '22

Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58477 to look at the new patch set (#33). Change subject: flash.h,flashchips.c: add writeprotect bit layout map to chips ...................................................................... flash.h,flashchips.c: add writeprotect bit layout map to chips This patch adds a register bit map `struct reg_bit_info`, with fields for storing the register, bit index, and writability of each bit that affects the chip's write protection. This allows writeprotect code to be independent of the register layout of any specific chip. The new fields have been filled out for example chips. The representation is centered around describing how bits can be accessed and modified, rather than the layout of registers. This is generally easier to work with in code that needs to access specific bits and typically requires specifying the locations of fewer bits overall. BUG=b:195381327,b:153800563 BRANCH=none TEST=flashrom --wp-{enable,disable,range,list,status} at end of patch series Change-Id: Id08d77e6d4ca5109c0d698271146d026dbc21284 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M flash.h M flashchips.c M writeprotect.h 3 files changed, 77 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/77/58477/33 -- To view, visit https://review.coreboot.org/c/flashrom/+/58477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id08d77e6d4ca5109c0d698271146d026dbc21284 Gerrit-Change-Number: 58477 Gerrit-PatchSet: 33 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: file_lock.c: fails unit tests HACK [NOT-FOR-MERGE]
by Edward O'Callaghan (Code Review) 24 Feb '22

24 Feb '22

Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/62313 ) Change subject: file_lock.c: fails unit tests HACK [NOT-FOR-MERGE] ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/62313 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I83caf28ca6528b4e0e7f21539c5019160ba6404e Gerrit-Change-Number: 62313 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: tests/chips.c: Mock out open() for lock file
by Edward O'Callaghan (Code Review) 24 Feb '22

24 Feb '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62324 ) Change subject: tests/chips.c: Mock out open() for lock file ...................................................................... tests/chips.c: Mock out open() for lock file Change-Id: I527a266233648b0eef11a89108e82d0a008eeb8d Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M tests/chip.c 1 file changed, 105 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/62324/1 diff --git a/tests/chip.c b/tests/chip.c index fe12533..51d7011 100644 --- a/tests/chip.c +++ b/tests/chip.c @@ -186,10 +186,41 @@ }, }; +#define DEFAULT_MOCK_FD 0xC0FE + +struct default_io_mock_state { + unsigned int noc; + const char *paths[2]; // no. of subsequent paths to check. + int flags; + int fd; +}; + +static int default_open(void *state, const char *pathname, int flags) +{ + struct default_io_mock_state * io_state = state; + const char *path = io_state->paths[io_state->noc]; + io_state->noc++; // proceed to the next path upon next call. + assert_string_equal(pathname, path); + assert_int_equal(flags & io_state->flags, io_state->flags); + return io_state->fd; +} + void erase_chip_test_success(void **state) { (void) state; /* unused */ + static struct default_io_mock_state data = { + .paths = {"/run/lock/flashrom_lock"}, + .noc = 0, + .fd = DEFAULT_MOCK_FD, + }; + const struct io_mock chip_io = { + .open = default_open, + .state = &data, + }; + + io_mock_register(&chip_io); + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_8MiB; @@ -208,6 +239,18 @@ { (void) state; /* unused */ + static struct default_io_mock_state data = { + .paths = {"/run/lock/flashrom_lock"}, + .noc = 0, + .fd = DEFAULT_MOCK_FD, + }; + const struct io_mock chip_io = { + .open = default_open, + .state = &data, + }; + + io_mock_register(&chip_io); + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_W25Q128_V; @@ -232,6 +275,18 @@ { (void) state; /* unused */ + static struct default_io_mock_state data = { + .paths = {"/run/lock/flashrom_lock"}, + .noc = 0, + .fd = DEFAULT_MOCK_FD, + }; + const struct io_mock chip_io = { + .open = default_open, + .state = &data, + }; + + io_mock_register(&chip_io); + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_8MiB; @@ -257,6 +312,18 @@ { (void) state; /* unused */ + static struct default_io_mock_state data = { + .paths = {"/run/lock/flashrom_lock"}, + .noc = 0, + .fd = DEFAULT_MOCK_FD, + }; + const struct io_mock chip_io = { + .open = default_open, + .state = &data, + }; + + io_mock_register(&chip_io); + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_W25Q128_V; @@ -287,6 +354,18 @@ { (void) state; /* unused */ + static struct default_io_mock_state data = { + .paths = {"/run/lock/flashrom_lock"}, + .noc = 0, + .fd = DEFAULT_MOCK_FD, + }; + const struct io_mock chip_io = { + .open = default_open, + .state = &data, + }; + + io_mock_register(&chip_io); + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_8MiB; @@ -325,6 +404,18 @@ { (void) state; /* unused */ + static struct default_io_mock_state data = { + .paths = {"/run/lock/flashrom_lock"}, + .noc = 0, + .fd = DEFAULT_MOCK_FD, + }; + const struct io_mock chip_io = { + .open = default_open, + .state = &data, + }; + + io_mock_register(&chip_io); + struct flashrom_flashctx flashctx = { 0 }; struct flashrom_layout *layout; struct flashchip mock_chip = chip_W25Q128_V; @@ -367,8 +458,15 @@ { (void) state; /* unused */ + static struct default_io_mock_state data = { + .paths = {"/run/lock/flashrom_lock"}, + .noc = 0, + .fd = DEFAULT_MOCK_FD, + }; const struct io_mock verify_chip_io = { .fread = verify_chip_fread, + .open = default_open, + .state = &data, }; io_mock_register(&verify_chip_io); @@ -401,8 +499,15 @@ { (void) state; /* unused */ + static struct default_io_mock_state data = { + .paths = {"/run/lock/flashrom_lock"}, + .noc = 0, + .fd = DEFAULT_MOCK_FD, + }; const struct io_mock verify_chip_io = { .fread = verify_chip_fread, + .open = default_open, + .state = &data, }; io_mock_register(&verify_chip_io); -- To view, visit https://review.coreboot.org/c/flashrom/+/62324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I527a266233648b0eef11a89108e82d0a008eeb8d Gerrit-Change-Number: 62324 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests/: Allow for file path validation
by Edward O'Callaghan (Code Review) 24 Feb '22

24 Feb '22

Attention is currently required from: Anastasia Klimchuk. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62320 to look at the new patch set (#3). Change subject: tests/: Allow for file path validation ...................................................................... tests/: Allow for file path validation BUG=b:217629892,b:215255210 TEST=`ninja test`. Change-Id: I892fa1ecee26ebce9640893edbb228fa9aa7b0b6 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M tests/init_shutdown.c 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/62320/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/62320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I892fa1ecee26ebce9640893edbb228fa9aa7b0b6 Gerrit-Change-Number: 62320 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests/linux_spi: Validate param file path
by Edward O'Callaghan (Code Review) 24 Feb '22

24 Feb '22

Attention is currently required from: Anastasia Klimchuk. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62319 to look at the new patch set (#3). Change subject: tests/linux_spi: Validate param file path ...................................................................... tests/linux_spi: Validate param file path BUG=b:217629892,b:215255210 TEST=`ninja test`. Change-Id: If5d24c65f291c53a35509fea5d2f5b3fdb51c306 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M tests/init_shutdown.c 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/19/62319/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/62319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If5d24c65f291c53a35509fea5d2f5b3fdb51c306 Gerrit-Change-Number: 62319 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests/: Allow realtek_mst test to check multiple paths
by Edward O'Callaghan (Code Review) 24 Feb '22

24 Feb '22

Attention is currently required from: Anastasia Klimchuk. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62311 to look at the new patch set (#6). Change subject: tests/: Allow realtek_mst test to check multiple paths ...................................................................... tests/: Allow realtek_mst test to check multiple paths While working on writing file-based locking for flashrom it was observed that the realtek_mst unit-test does not check subsequent paths from the io_mock state tracker. Add infrasture into the realtek_mst unit-test to allow for subsequent path validation. BUG=b:217629892,b:215255210 TEST=`ninja test`. Change-Id: I80d5e1fc26ad9caf49a98a7671d069bbd8428045 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M tests/init_shutdown.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/62311/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/62311 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80d5e1fc26ad9caf49a98a7671d069bbd8428045 Gerrit-Change-Number: 62311 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom.c: Implement file-based locking semantics
by Edward O'Callaghan (Code Review) 24 Feb '22

24 Feb '22

Attention is currently required from: Hung-Te Lin, Nico Huber, Subrata Banik, Edward O'Callaghan. Hello Hung-Te Lin, build bot (Jenkins), Nico Huber, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62213 to look at the new patch set (#9). Change subject: flashrom.c: Implement file-based locking semantics ...................................................................... flashrom.c: Implement file-based locking semantics This upstreams the ChromiumOS implementation of file-based locking for multiple instances of flashrom that could be spawned either from libflashrom (perhaps by fwupd for example) and user cli as another example. Since flashrom is programming singleton state of hardware from userspace there is no way to exclusively own the address space and therefore a file-based locking semantic is considered here. BUG=b:217629892,b:215255210 BRANCH=none TEST=nm -gD /build/brya/usr/lib64/libflashrom.so | grep "flock" Test futility update with multiple instances of flashrom running. Change-Id: I19cb4e3bf14caeb67c3e8100a20395b264c5113a Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M Makefile A big_lock.c A big_lock.h A file_lock.c M flashrom.c A ipc_lock.h M meson.build M tests/init_shutdown.c 8 files changed, 452 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/62213/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/62213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I19cb4e3bf14caeb67c3e8100a20395b264c5113a Gerrit-Change-Number: 62213 Gerrit-PatchSet: 9 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests/: Allow for file path validation
by Edward O'Callaghan (Code Review) 24 Feb '22

24 Feb '22

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62320 to look at the new patch set (#2). Change subject: tests/: Allow for file path validation ...................................................................... tests/: Allow for file path validation BUG=b:217629892,b:215255210 TEST=`ninja test`. Change-Id: I892fa1ecee26ebce9640893edbb228fa9aa7b0b6 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M tests/init_shutdown.c 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/62320/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I892fa1ecee26ebce9640893edbb228fa9aa7b0b6 Gerrit-Change-Number: 62320 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests/linux_spi: Validate param file path
by Edward O'Callaghan (Code Review) 24 Feb '22

24 Feb '22

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62319 to look at the new patch set (#2). Change subject: tests/linux_spi: Validate param file path ...................................................................... tests/linux_spi: Validate param file path BUG=b:217629892,b:215255210 TEST=`ninja test`. Change-Id: If5d24c65f291c53a35509fea5d2f5b3fdb51c306 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M tests/init_shutdown.c 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/19/62319/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If5d24c65f291c53a35509fea5d2f5b3fdb51c306 Gerrit-Change-Number: 62319 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests/linux_mtd: Allow for checking open() calls
by Edward O'Callaghan (Code Review) 24 Feb '22

24 Feb '22

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62318 to look at the new patch set (#2). Change subject: tests/linux_mtd: Allow for checking open() calls ...................................................................... tests/linux_mtd: Allow for checking open() calls BUG=b:217629892,b:215255210 TEST=`ninja test`. Change-Id: I06e54c0bdc4f5320904e2ab6542345721f1ca370 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M tests/init_shutdown.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/62318/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I06e54c0bdc4f5320904e2ab6542345721f1ca370 Gerrit-Change-Number: 62318 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2022