December 2022 - flashrom-gerrit

[M] Change in flashrom[master]: flashrom.c: Add new erase_by_layout and walk_bylayout implementations
by Aarya (Code Review) Dec. 23, 2022

Dec. 23, 2022

Attention is currently required from: Simon Buhrow, Thomas Heijligen, Aarya. Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/71173 to look at the new patch set (#7). Change subject: flashrom.c: Add new erase_by_layout and walk_bylayout implementations ...................................................................... flashrom.c: Add new erase_by_layout and walk_bylayout implementations Add [erase,walk]_by_layout_new to use optimised implementations of the erase function selection algorithm. Change-Id: Id79ae943eb9d6a817da28381db477725834faaf6 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M flashrom.c 1 file changed, 92 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/71173/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/71173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id79ae943eb9d6a817da28381db477725834faaf6 Gerrit-Change-Number: 71173 Gerrit-PatchSet: 7 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashrom.c: Add wrapper function to use the erase algorithm
by Edward O'Callaghan (Code Review) Dec. 23, 2022

Dec. 23, 2022

Attention is currently required from: Simon Buhrow, Nico Huber, Aarya, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 ) Change subject: flashrom.c: Add wrapper function to use the erase algorithm ...................................................................... Patch Set 91: (8 comments) File erasure_layout.c: https://review.coreboot.org/c/flashrom/+/66104/comment/8fb97c19_b1d7589d PS91, Line 1: /* you can use clang-format to help with formatting like line wraps or do it manually but whatever you do you should try to keep consistent with generally kernel C style and you wont be far off. https://www.kernel.org/doc/html/v4.10/process/coding-style.html https://review.coreboot.org/c/flashrom/+/66104/comment/45429ca9_5bcb04ee PS91, Line 165: s `const s` https://review.coreboot.org/c/flashrom/+/66104/comment/e47d5bf7_b747cf71 PS91, Line 170: old_start_buf allocation never checked. https://review.coreboot.org/c/flashrom/+/66104/comment/698e2517_e9b37ae5 PS91, Line 182: // add some `\n` to help readability of the function. https://review.coreboot.org/c/flashrom/+/66104/comment/f1466463_521e44ef PS91, Line 188: ( trivial: ` (` https://review.coreboot.org/c/flashrom/+/66104/comment/07bc1f69_04439fea PS91, Line 189: ( trivial: ` (` https://review.coreboot.org/c/flashrom/+/66104/comment/37d0fadf_f54d1d10 PS91, Line 194: if(erase_layout[i].layout_list[j].selected) { consider identifying more base-cases to early return/continue/break to avoid deep loops and branches. For example in this case, the inverse case gives you a continue base case: ``` if (!erase_layout[i].layout_list[j].selected) { continue; } [..] ``` https://review.coreboot.org/c/flashrom/+/66104/comment/953096fc_fba6f404 PS91, Line 195: //execute erase : erasefunc_t *erasefn = lookup_erase_func_ptr(erase_layout[i].eraser); : ret = erasefn(flashctx, start_addr, block_len); : if (ret) { : msg_cerr("Failed to execute erase command for offset %#x to %#x.\n", start_addr, start_addr + block_len); : ret = -1; : goto _end; : } : //adjust curcontents : memset(curcontents+start_addr, erased_value, block_len); : //after erase make it unselected again : erase_layout[i].layout_list[j].selected = false; : msg_cdbg("E(%x:%x)", start_addr, start_addr + block_len - 1); : //verify erase : ret = check_erased_range(flashctx, start_addr, block_len); : if (ret) { : msg_cerr("Verifying flash. Erase failed for range %#x : %#x, Abort.\n", start_addr, start_addr + block_len - 1); : goto _end; : } integrate CB:70517 -- To view, visit https://review.coreboot.org/c/flashrom/+/66104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Gerrit-Change-Number: 66104 Gerrit-PatchSet: 91 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 23 Dec 2022 10:50:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi: Make 'default_spi_send_multicommand' the default unless defined
by Edward O'Callaghan (Code Review) Dec. 23, 2022

Dec. 23, 2022

Attention is currently required from: Thomas Heijligen. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67481 ) Change subject: spi: Make 'default_spi_send_multicommand' the default unless defined ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/67481/comment/04dd808a_04c1c39f PS1, Line 9: Drop the explicit need to specify the default > Please mention the struct where you perform the changes on Done Patchset: PS1: > The same as in CB:67480 applies here. see CB:67480 for dicussion. -- To view, visit https://review.coreboot.org/c/flashrom/+/67481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6cc24bf982da3d5251d391eb397db43dd10280e8 Gerrit-Change-Number: 67481 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 08:06:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi: Make 'default_spi_send_multicommand' the default unless defined
by Edward O'Callaghan (Code Review) Dec. 23, 2022

Dec. 23, 2022

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Thomas Heijligen, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67481 to look at the new patch set (#2). Change subject: spi: Make 'default_spi_send_multicommand' the default unless defined ...................................................................... spi: Make 'default_spi_send_multicommand' the default unless defined A NULL func pointer is necessary and sufficient for the condition `NULL func pointer => default_spi_send_multicommand' as to not need this explicit specification of 'default'. Therefore drop the explicit need to specify the 'default_spi_send_multicommand' callback function pointer in the spi_master struct. This is a reasonable default for every other driver in the tree with only a few exceptions. This simplifies the code and driver development. Change-Id: I6cc24bf982da3d5251d391eb397db43dd10280e8 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M bitbang_spi.c M buspirate_spi.c M ch341a_spi.c M dediprog.c M digilent_spi.c M dummyflasher.c M it87spi.c M jlink_spi.c M linux_spi.c M mediatek_i2c_spi.c M mstarddc_spi.c M ni845x_spi.c M parade_lspcon.c M pickit2_spi.c M raiden_debug_spi.c M realtek_mst_i2c_spi.c M sb600spi.c M serprog.c M spi.c M stlinkv3_spi.c M usbblaster_spi.c M wbsio_spi.c 22 files changed, 24 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/67481/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6cc24bf982da3d5251d391eb397db43dd10280e8 Gerrit-Change-Number: 67481 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashrom.c:Add function to get a flattened view of the chip erase blocks
by Edward O'Callaghan (Code Review) Dec. 23, 2022

Dec. 23, 2022

Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen, Paul Menzel, Aarya. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65879 ) Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks ...................................................................... Patch Set 54: (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/65879/comment/7c59cb72_2957dd84 PS41, Line 1237: : struct erase_layout *create_erase_layout(struct flashctx *const flashctx); : > Done well done! -- To view, visit https://review.coreboot.org/c/flashrom/+/65879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4 Gerrit-Change-Number: 65879 Gerrit-PatchSet: 54 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Dec 2022 07:29:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: Add switch for legacy impl of erasure path
by Edward O'Callaghan (Code Review) Dec. 23, 2022

Dec. 23, 2022

Attention is currently required from: Felix Singer, Thomas Heijligen, Aarya. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71119 ) Change subject: flashrom.c: Add switch for legacy impl of erasure path ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: You can keep this early in your series, we should keep your patches flowing in as we get though each part instead of a all or nothing and them hanging in review forever. Thanks for working so hard on this erasure optimisation stuff! -- To view, visit https://review.coreboot.org/c/flashrom/+/71119 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib5660db0067c1c799dcb5c8e83b4a4826b236442 Gerrit-Change-Number: 71119 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Dec 2022 07:28:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c:Add a function to get list of sectors that need erasing
by Edward O'Callaghan (Code Review) Dec. 23, 2022

Dec. 23, 2022

Attention is currently required from: Simon Buhrow, Aarya. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 ) Change subject: flashrom.c:Add a function to get list of sectors that need erasing ...................................................................... Patch Set 73: Code-Review+2 (6 comments) File erasure_layout.c: https://review.coreboot.org/c/flashrom/+/65844/comment/10acfaa5_736a3d05 PS73, Line 127: void * `void *` in type system speak is mostly like putting on a blind-fold and jumping between a large canyon hoping you will arrive on the other side safely. These contents buffers are byte array's on the heap, use the correct type of `uint8_t`. https://review.coreboot.org/c/flashrom/+/65844/comment/4eda0de4_5f8081d4 PS73, Line 127: region_start `rstart` and Doxygen. https://review.coreboot.org/c/flashrom/+/65844/comment/460a9985_2047f4bf PS73, Line 127: region_end `rend` and Doxygen. https://review.coreboot.org/c/flashrom/+/65844/comment/6412aab7_4c1e4220 PS73, Line 127: struct flashctx *flashctx, by convention, keep the `flashctx` as the first argument to the function, it helps keep the code-base more consistent for one reason of a few. like wrap the function definition. https://review.coreboot.org/c/flashrom/+/65844/comment/65363ac0_60541c38 PS73, Line 127: function_index `findex` and in the Doxygen comment you can say "function index". https://review.coreboot.org/c/flashrom/+/65844/comment/81e7ac06_e23e463a PS73, Line 130: function_index == 0 `!foo` is canonical for the 0 or NULL case. -- To view, visit https://review.coreboot.org/c/flashrom/+/65844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256 Gerrit-Change-Number: 65844 Gerrit-PatchSet: 73 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Dec 2022 07:26:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c:Add function to align region to sector boundaries
by Edward O'Callaghan (Code Review) Dec. 23, 2022

Dec. 23, 2022

Attention is currently required from: Aarya. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65642 ) Change subject: flashrom.c:Add function to align region to sector boundaries ...................................................................... Patch Set 74: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/65642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I215ea4986aa23360fc65ff761f4e49c6069160ac Gerrit-Change-Number: 65642 Gerrit-PatchSet: 74 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Dec 2022 07:20:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom.c:Add function to get a flattened view of the chip erase blocks
by Edward O'Callaghan (Code Review) Dec. 23, 2022

Dec. 23, 2022

Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen, Paul Menzel, Aarya. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65879 ) Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks ...................................................................... Patch Set 54: (9 comments) File erasure_layout.c: https://review.coreboot.org/c/flashrom/+/65879/comment/75da22dc_7cc888bb PS54, Line 26: if (layout) { rewrite your function like this: ``` if (!layout) return; for (unsigned int i = 0; i < erasefn_count; i++) { free(layout[i].layout_list); } free(layout); ``` https://review.coreboot.org/c/flashrom/+/65879/comment/9aad4e8a_84f60ab1 PS54, Line 34: ) The signature of this function should be, ``` unsigned int create_erase_layout(struct flashctx *const flashctx, struct erase_layout **elayout) { ``` ret is <0 on error, =0 on no erasefn_count's or >0 with no. of erasefn_count's. https://review.coreboot.org/c/flashrom/+/65879/comment/4479918a_b8c1a4b2 PS54, Line 34: create_erase_layout with the comments below I am expecting a few static functions that should be relatively small and this function will stitch them together. https://review.coreboot.org/c/flashrom/+/65879/comment/80303a73_0fb8a18e PS54, Line 48: ; \n https://review.coreboot.org/c/flashrom/+/65879/comment/b7f4e7a5_9f0b45e8 PS54, Line 54: int j = 0; : while(addr < chip->total_size * 1024) { ok `j` is shadowed below. Rewrite this while-loop construct as a `for` loop construct as: ``` for (unsigned i = 0; addr < chip->total_size * 1024; i++) { const struct eraseblock *block = &chip->block_erasers[eraser_idx].eraseblocks[i]; block_count += block->count; addr += block->size * block->count; } ``` to avoid shadowing or scope to a helper function. * The key message I am communicating here is minimum scope. The other secondary message I am pealing back at is how these loops can become infinite or undefined. https://review.coreboot.org/c/flashrom/+/65879/comment/8df0ae7e_206596a2 PS54, Line 55: ( > trivial: `e (` Ack https://review.coreboot.org/c/flashrom/+/65879/comment/59ca8312_cfe70e94 PS54, Line 62: (struct eraseblock_data *)malloc use `calloc()`. Is the construction of `layout[layout_idx].layout_list` on the heap it's own function? It would make digesting how deep these loops are tractable as to maintain this code. https://review.coreboot.org/c/flashrom/+/65879/comment/4ac13ba1_a5da5a8f PS54, Line 86: (layout[layout_idx-1].layout_list[sub_block_index].start_addr >= start_addr && : layout[layout_idx-1].layout_list[sub_block_index].end_addr <= end_addr && : sub_block_index < layout[layout_idx-1].block_count) in this new function made out of this `if`-block turn this wild predicate into a intermediate with a name. https://review.coreboot.org/c/flashrom/+/65879/comment/fff59680_94925c32 PS54, Line 84: if (layout_idx > 0) { : layout[layout_idx].layout_list[block_num].first_sub_block_index = sub_block_index; : while (layout[layout_idx-1].layout_list[sub_block_index].start_addr >= start_addr && : layout[layout_idx-1].layout_list[sub_block_index].end_addr <= end_addr && : sub_block_index < layout[layout_idx-1].block_count) { : sub_block_index++; : } : layout[layout_idx].layout_list[block_num].last_sub_block_index = sub_block_index - 1; : } looks like another function with a base case of `layout_idx == 0 => return`. -- To view, visit https://review.coreboot.org/c/flashrom/+/65879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4 Gerrit-Change-Number: 65879 Gerrit-PatchSet: 54 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Dec 2022 07:19:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flash.h: Make functions global that will be used for new erase algorithm
by Edward O'Callaghan (Code Review) Dec. 23, 2022

Dec. 23, 2022

Attention is currently required from: Simon Buhrow, Thomas Heijligen, Aarya. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71174 ) Change subject: flash.h: Make functions global that will be used for new erase algorithm ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/71174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ee7e208948337b88467935fd2861b5f9ad6af9d Gerrit-Change-Number: 71174 Gerrit-PatchSet: 2 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Dec 2022 06:47:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0