Attention is currently required from: Peter Stuge, Name of user not set #1004601.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70571 )
Change subject: serial: Add Darwin/macOS support for custom and >230400 baudrates
......................................................................
Patch Set 4:
(1 comment)
File serial.c:
https://review.coreboot.org/c/flashrom/+/70571/comment/287680a9_0a63f066
PS4, Line 78: #if !IS_DARWIN
why guard the higher boudrates additionally for darwin? When looking at https://opensource.apple.com/source/xnu/xnu-792.2.4/bsd/sys/termios.h.auto.… those macros are not defined. so they should not be present in the list.
--
To view, visit https://review.coreboot.org/c/flashrom/+/70571
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3e6b88d2b4c2a130b16456752681fd9f807bf6f0
Gerrit-Change-Number: 70571
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Stuge <peter(a)stuge.se>
Gerrit-Reviewer: Name of user not set #1004601
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Peter Stuge <peter(a)stuge.se>
Gerrit-Attention: Name of user not set #1004601
Gerrit-Comment-Date: Thu, 15 Dec 2022 10:16:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nikolai Artemiev.
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70458 )
Change subject: ichspi.c: Clean up HSFC FCYCLE definitions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/70458
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0996c5331837276049241600e0ffac21a47ec3af
Gerrit-Change-Number: 70458
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Thu, 15 Dec 2022 02:02:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Edward O'Callaghan, Nikolai Artemiev.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70548 )
Change subject: flashchips.c: Add reg_bits for W25Q512NW-IM
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> i have landed this https://review.coreboot.org/c/flashrom/+/67827/7/flashchips. […]
Thanks, abandoning this one.
--
To view, visit https://review.coreboot.org/c/flashrom/+/70548
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97c24682bb0c8ea67ef5617567cd99f6526ba2da
Gerrit-Change-Number: 70548
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 12:55:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment