November 2022 - flashrom-gerrit

[M] Change in flashrom[master]: tests: Convert selfcheck to unit tests
by Evan Benn (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Evan Benn. Hello build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69620 to look at the new patch set (#5). Change subject: tests: Convert selfcheck to unit tests ...................................................................... tests: Convert selfcheck to unit tests Add unit tests for programmer_table, flashchips, and board_matches structs. The tests are derived from the selfcheck function, checking that the required fields have been filled in. BUG=b:140595239 BRANCH=None TEST=meson test Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Signed-off-by: Evan Benn <evanbenn(a)chromium.org> --- M board_enable.c M include/programmer.h M tests/meson.build M tests/tests.c M tests/tests.h A tests/well_formed_tables.c 6 files changed, 118 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/69620/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/69620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Gerrit-Change-Number: 69620 Gerrit-PatchSet: 5 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Evan Benn <evanbenn(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: tests: Move SKIP_TEST macro to common header
by Evan Benn (Code Review) 15 Nov '22

15 Nov '22

Evan Benn has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69621 ) Change subject: tests: Move SKIP_TEST macro to common header ...................................................................... tests: Move SKIP_TEST macro to common header BUG=None BRANCH=None TEST=None Change-Id: I6cca635212867dad5a8e391a46b1d943530c539a --- M tests/include/test.h M tests/lifecycle.h 2 files changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/69621/1 diff --git a/tests/include/test.h b/tests/include/test.h index 88ac16d..ef0b9a6 100644 --- a/tests/include/test.h +++ b/tests/include/test.h @@ -31,6 +31,9 @@ #define MOCK_FD (0x10ec) +#define SKIP_TEST(name) \ + void name (void **state) { skip(); } + /* * Having this as function allows to set a breakpoint on the address, * as it has a named symbol associated with the address number. diff --git a/tests/lifecycle.h b/tests/lifecycle.h index 69f1119..b4c2fbe 100644 --- a/tests/lifecycle.h +++ b/tests/lifecycle.h @@ -28,9 +28,6 @@ #include "programmer.h" #include "spi.h" -#define SKIP_TEST(name) \ - void name (void **state) { skip(); } - void run_basic_lifecycle(void **state, const struct io_mock *io, const struct programmer_entry *prog, const char *param); -- To view, visit https://review.coreboot.org/c/flashrom/+/69621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6cca635212867dad5a8e391a46b1d943530c539a Gerrit-Change-Number: 69621 Gerrit-PatchSet: 1 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: tests: Convert selfcheck to unit tests
by Evan Benn (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Evan Benn. Hello build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69620 to look at the new patch set (#3). Change subject: tests: Convert selfcheck to unit tests ...................................................................... tests: Convert selfcheck to unit tests Add unit tests for programmer_table, flashchips, and board_matches structs. The tests are derived from the selfcheck function, checking that the required fields have been filled in. BUG=b:140595239 BRANCH=None TEST=meson test Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Signed-off-by: Evan Benn <evanbenn(a)chromium.org> --- M board_enable.c M include/programmer.h M tests/meson.build M tests/tests.c M tests/tests.h A tests/well_formed_tables.c 6 files changed, 120 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/69620/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/69620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Gerrit-Change-Number: 69620 Gerrit-PatchSet: 3 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Evan Benn <evanbenn(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: tests: Convert selfcheck to unit tests
by Evan Benn (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Hello Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69620 to look at the new patch set (#2). Change subject: tests: Convert selfcheck to unit tests ...................................................................... tests: Convert selfcheck to unit tests Add unit tests for programmer_table, flashchips, and board_matches structs. The tests are derived from the selfcheck function, checking that the required fields have been filled in. BUG=b:140595239 BRANCH=None TEST=meson test Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Signed-off-by: Evan Benn <evanbenn(a)chromium.org> --- M board_enable.c M include/programmer.h M tests/meson.build M tests/tests.c M tests/tests.h A tests/well_formed_tables.c 6 files changed, 114 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/69620/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Gerrit-Change-Number: 69620 Gerrit-PatchSet: 2 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: tests: Convert selfcheck to unit tests
by Evan Benn (Code Review) 15 Nov '22

15 Nov '22

Evan Benn has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69620 ) Change subject: tests: Convert selfcheck to unit tests ...................................................................... tests: Convert selfcheck to unit tests Add unit tests for programmer_table, flashchips, and board_matches structs. The tests are derived from the selfcheck function, checking that the required fields have been filled in. BUG=b:140595239 BRANCH=None TEST=meson test Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Signed-off-by: Evan Benn <evanbenn(a)chromium.org> --- M board_enable.c M include/programmer.h M tests/meson.build M tests/tests.c M tests/tests.h A tests/well_formed_tables.c 6 files changed, 109 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/69620/1 diff --git a/board_enable.c b/board_enable.c index 4903c0f..bf26173 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2524,6 +2524,7 @@ #endif { 0, 0, 0, 0, 0, 0, 0, 0, NULL, NULL, NULL, P3, NULL, NULL, 0, NT, NULL}, /* end marker */ }; +const size_t board_matches_size = ARRAY_SIZE(board_matches); int selfcheck_board_enables(void) { diff --git a/include/programmer.h b/include/programmer.h index 386e6ec..f979c25 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -193,6 +193,7 @@ }; extern const struct board_match board_matches[]; +extern const size_t board_matches_size; struct board_info { const char *vendor; diff --git a/tests/meson.build b/tests/meson.build index 66adb92..86d2f30 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -31,6 +31,7 @@ 'layout.c', 'chip.c', 'chip_wp.c', + 'well_formed_tables.c', ) if not programmer.get('dummy').get('active') diff --git a/tests/tests.c b/tests/tests.c index ea416b8..0b1752e 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -381,6 +381,13 @@ }; ret |= cmocka_run_group_tests_name("helpers.c tests", helpers_tests, NULL, NULL); + const struct CMUnitTest well_formed_tables[] = { + cmocka_unit_test(well_formed_programmer_table), + cmocka_unit_test(well_formed_flashchips_table), + cmocka_unit_test(well_formed_board_matches_table), + }; + ret |= cmocka_run_group_tests_name("well_formed_tables.c tests", well_formed_tables, NULL, NULL); + const struct CMUnitTest flashrom_tests[] = { cmocka_unit_test(flashbuses_to_text_test_success), }; diff --git a/tests/tests.h b/tests/tests.h index 7d84101..230c042 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -87,4 +87,9 @@ void full_chip_erase_with_wp_dummyflasher_test_success(void **state); void partial_chip_erase_with_wp_dummyflasher_test_success(void **state); +/* well_formed_tables.c */ +void well_formed_programmer_table(void **state); +void well_formed_flashchips_table(void **state); +void well_formed_board_matches_table(void **state); + #endif /* TESTS_H */ diff --git a/tests/well_formed_tables.c b/tests/well_formed_tables.c new file mode 100644 index 0000000..67593d8 --- /dev/null +++ b/tests/well_formed_tables.c @@ -0,0 +1,76 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2022 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include "string.h" + +#include "include/test.h" +#include "programmer.h" +#include "tests.h" + + +#define assert_table(assertion, index, name) do { \ + if (!(assertion)) \ + fail_msg(#assertion " is false for index:%zu name:%s", \ + (index), \ + (name) ? (name) : "unknown" \ + ); \ +} while (0) + + +void well_formed_programmer_table(void **state) { + (void) state; /* unused */ + size_t i; + for (i = 0; i < programmer_table_size; i++) { + const struct programmer_entry *const p = programmer_table[i]; + assert_table(p, i, programmer_table[i]->name); + assert_table(p->name, i, programmer_table[i]->name); + assert_table(p->type, i, programmer_table[i]->name); + if (strcmp("internal", p->name) != 0) { /* This one has its device list stored separately. */ + assert_table(p->devs.note, i, programmer_table[i]->name); + } + assert_table(p->init, i, programmer_table[i]->name); + } +} + +void well_formed_flashchips_table(void **state) { + (void) state; /* unused */ + size_t i; + assert_false(flashchips_size <= 1 || flashchips[flashchips_size - 1].name != NULL); + for (i = 0; i < flashchips_size - 1; i++) { + const struct flashchip *chip = &flashchips[i]; + assert_table(chip->vendor, i, flashchips[i].name); + assert_table(chip->name, i, flashchips[i].name); + assert_table(chip->bustype != BUS_NONE, i, flashchips[i].name); + } +} + +void well_formed_board_matches_table(void **state) { + (void) state; /* unused */ + size_t i; + assert_false(board_matches_size <= 1 || board_matches[board_matches_size - 1].vendor_name != NULL); + for (i = 0; i < board_matches_size - 1; i++) { + const struct board_match *b = &board_matches[i]; + assert_table(b->vendor_name, i, b->board_name); + assert_table(b->board_name, i, b->board_name); + assert_table(b->board_name, i, b->board_name); + if ((b->first_vendor == 0 || b->first_device == 0 || + b->second_vendor == 0 || b->second_device == 0) || + ((b->lb_vendor == NULL) ^ (b->lb_part == NULL)) || + (b->max_rom_decode_parallel == 0 && b->enable == NULL)) { + fail_msg("Board enable for %s %s is misdefined.\n", + b->vendor_name, b->board_name); + } + } +} -- To view, visit https://review.coreboot.org/c/flashrom/+/69620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I41cd014d9bf909296b6c28e3e00548e6883ff41a Gerrit-Change-Number: 69620 Gerrit-PatchSet: 1 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: tests: Add llvm-cov option and run target for code coverage
by Evan Benn (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69268 ) Change subject: tests: Add llvm-cov option and run target for code coverage ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: > You should test if `llvm-cov-cli` can be found […] I dont mind doing that, but is it necessary? The script is in the repo. It would be like checking for the presence of every .c file before trying to compile it. -- To view, visit https://review.coreboot.org/c/flashrom/+/69268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id6c73bff46e7b88d425956a80def97082b201f56 Gerrit-Change-Number: 69268 Gerrit-PatchSet: 11 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 14 Nov 2022 23:12:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom.c: Supplement `chip->unlock()` calls with wp unlocking
by Sergii Dmytruk (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69517 ) Change subject: flashrom.c: Supplement `chip->unlock()` calls with wp unlocking ...................................................................... Patch Set 1: (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/69517/comment/214e9956_e3b7adb1 PS1, Line 1741: goto err_out; As the failing test shows, exiting on error here prevents using chip when WP is locked even if operation doesn't touch protected region. -- To view, visit https://review.coreboot.org/c/flashrom/+/69517 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I74b3f5d3a17749ea60485b916b2d87467a5d8b2f Gerrit-Change-Number: 69517 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 18:14:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: util: add bash completion script
by Felix Singer (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Thomas Heijligen, Alexander Goncharov. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 ) Change subject: util: add bash completion script ...................................................................... Patch Set 8: (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/68247/comment/7200a138_8cb83f44 PS4, Line 611: share/bash-completion/completions > Done. If I didn't do what you want, feel free to reopen the comment. Using pkg-config is better. Looks good to me. -- To view, visit https://review.coreboot.org/c/flashrom/+/68247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie68bc91c3cea4de2ffdbeffd07e48edd8d5590e1 Gerrit-Change-Number: 68247 Gerrit-PatchSet: 8 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 14 Nov 2022 13:29:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: linux_mtd: Mark Opaque chip as tested for WP
by Sergii Dmytruk (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69518 ) Change subject: linux_mtd: Mark Opaque chip as tested for WP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/69518 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc0521c28555a93f26ce66bdbeaa68590f10c358 Gerrit-Change-Number: 69518 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 13:26:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: ichspi.c: Read chip ID and use it to identify chip
by Edward O'Callaghan (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69195 ) Change subject: ichspi.c: Read chip ID and use it to identify chip ...................................................................... Patch Set 2: (8 comments) File ichspi.c: https://review.coreboot.org/c/flashrom/+/69195/comment/894d29fb_0da1439d PS2, Line 1472: entry == NULL `!entry` https://review.coreboot.org/c/flashrom/+/69195/comment/350c6139_b671d4f4 PS2, Line 1475: return 0; `return -1;` https://review.coreboot.org/c/flashrom/+/69195/comment/f2c77aa2_b2a83d5c PS2, Line 1476: } else { no need for a `else` as you have a early return in the `if` branch. https://review.coreboot.org/c/flashrom/+/69195/comment/1d289c72_cc5b605e PS2, Line 1486: flash->chip->tested = entry->tested; drop line, it is overwritten in the eulogy of `ich_hwseq_probe()`, the call site of this function. https://review.coreboot.org/c/flashrom/+/69195/comment/d11146c5_876f4a3f PS2, Line 1492: return 1; `return 0;` https://review.coreboot.org/c/flashrom/+/69195/comment/59afdf05_ac4142af PS2, Line 1502: != 1 `< 0` https://review.coreboot.org/c/flashrom/+/69195/comment/765bad5e_418f1a21 PS2, Line 1503: msg_perr("Unable to read flash chip ID\n"); drop as you already have a `msg_perr()` call in the func. https://review.coreboot.org/c/flashrom/+/69195/comment/1440fe6d_2b9237e9 PS2, Line 1552: TEST_OK_PREW; https://review.coreboot.org/c/flashrom/+/69518 `TEST_OK_PREWB;` -- To view, visit https://review.coreboot.org/c/flashrom/+/69195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia408e1e45dc6f53c0934afd6558e301abfa48ee6 Gerrit-Change-Number: 69195 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 09:55:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2022