Attention is currently required from: Felix Singer.
Artur Kowalski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68557 )
Change subject: flashchips: add support for MX77L25650F chip
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68557/comment/31f3f490_070f114a
PS1, Line 7: flashrom
> flashchips
fixed
https://review.coreboot.org/c/flashrom/+/68557/comment/8e293850_de30f7d3
PS1, Line 9: read and write
> What about erasing?
Erasing was done before writing and it worked properly, updated commit message accordingly
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/68557/comment/26a2d324_26f4766a
PS1, Line 10215: // TODO: add 64K block erase
> What about this todo?
We haven't tested 64K erase so I didn't add it here.
--
To view, visit https://review.coreboot.org/c/flashrom/+/68557
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaea5485f8b59b8538dc47beada2c308376ea027c
Gerrit-Change-Number: 68557
Gerrit-PatchSet: 3
Gerrit-Owner: Artur Kowalski <artur.kowalski(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Tue, 25 Oct 2022 10:28:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Artur Kowalski.
Hello build bot (Jenkins), Maciej Pijanowski, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68557
to look at the new patch set (#2).
Change subject: flashchips: add support for MX77L25650F chip
......................................................................
flashchips: add support for MX77L25650F chip
Add basic support Macronix MX77L25650F. Can read, write and erase the
chip as long as write protection is not enabled (WP is not supported at
the moment so can't disable it).
Change-Id: Iaea5485f8b59b8538dc47beada2c308376ea027c
Signed-off-by: Artur Kowalski <artur.kowalski(a)3mdeb.com>
---
M flashchips.c
M include/flashchips.h
2 files changed, 39 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/57/68557/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/68557
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaea5485f8b59b8538dc47beada2c308376ea027c
Gerrit-Change-Number: 68557
Gerrit-PatchSet: 2
Gerrit-Owner: Artur Kowalski <artur.kowalski(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Artur Kowalski <artur.kowalski(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Peter Marheine.
Hello build bot (Jenkins), Angel Pons, Peter Marheine,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68643
to look at the new patch set (#3).
Change subject: flashrom_tester: Use Path type for test data
......................................................................
flashrom_tester: Use Path type for test data
Update many str types to Path.
BUG=b:243460685
BRANCH=None
TEST=/usr/bin/flashrom_tester --flashrom_binary /usr/sbin/flashrom host
Change-Id: I4a0b25c8c70fa6dfd682fba3db7d3bf06b2eb7ac
Signed-off-by: Evan Benn <evanbenn(a)chromium.org>
---
M util/flashrom_tester/flashrom/src/cmd.rs
M util/flashrom_tester/flashrom/src/flashromlib.rs
M util/flashrom_tester/flashrom/src/lib.rs
M util/flashrom_tester/src/rand_util.rs
M util/flashrom_tester/src/tester.rs
M util/flashrom_tester/src/tests.rs
6 files changed, 127 insertions(+), 88 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/68643/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/68643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4a0b25c8c70fa6dfd682fba3db7d3bf06b2eb7ac
Gerrit-Change-Number: 68643
Gerrit-PatchSet: 3
Gerrit-Owner: Evan Benn <evanbenn(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: newpatchset
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68778 )
Change subject: include/flash.h: Turn defines into a flashrom error enum type
......................................................................
include/flash.h: Turn defines into a flashrom error enum type
Change-Id: I6d0e6626b15ce54672a560741a1f1b3d3c2a3ab1
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M include/flash.h
1 file changed, 23 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/68778/1
diff --git a/include/flash.h b/include/flash.h
index 8ee603d..d7fa3b4 100644
--- a/include/flash.h
+++ b/include/flash.h
@@ -436,18 +436,20 @@
void finalize_flash_access(struct flashctx *);
int register_chip_restore(chip_restore_fn_cb_t func, struct flashctx *flash, uint8_t status);
-/* Something happened that shouldn't happen, but we can go on. */
-#define ERROR_FLASHROM_NONFATAL 0x100
+typedef enum {
+ /* Something happened that shouldn't happen, but we can go on. */
+ ERROR_FLASHROM_NONFATAL = 0x100,
+ /* Something happened that shouldn't happen, we'll abort. */
+ ERROR_FLASHROM_FATAL = -0xee,
-/* Something happened that shouldn't happen, we'll abort. */
-#define ERROR_FLASHROM_FATAL -0xee
-#define ERROR_FLASHROM_BUG -200
-/* We reached one of the hardcoded limits of flashrom. This can be fixed by
- * increasing the limit of a compile-time allocation or by switching to dynamic
- * allocation.
- * Note: If this warning is triggered, check first for runaway registrations.
- */
-#define ERROR_FLASHROM_LIMIT -201
+ ERROR_FLASHROM_BUG = -200,
+ /* We reached one of the hardcoded limits of flashrom. This can be fixed by
+ * increasing the limit of a compile-time allocation or by switching to dynamic
+ * allocation.
+ * Note: If this warning is triggered, check first for runaway registrations.
+ */
+ ERROR_FLASHROM_LIMIT = -201,
+} flashrom_error_t;
/* cli_common.c */
void print_chip_support_status(const struct flashchip *chip);
--
To view, visit https://review.coreboot.org/c/flashrom/+/68778
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6d0e6626b15ce54672a560741a1f1b3d3c2a3ab1
Gerrit-Change-Number: 68778
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange