October 2022 - flashrom-gerrit

[S] Change in flashrom[master]: tests/meson.build: Turn file list into list of file objects
by Felix Singer (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68197 ) Change subject: tests/meson.build: Turn file list into list of file objects ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > > Patch Set 2: […] Done in CB:68228 -- To view, visit https://review.coreboot.org/c/flashrom/+/68197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b9144a6b76c1772833817b4e6873818dcf36b05 Gerrit-Change-Number: 68197 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 20:10:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: tests/meson.build: Rename list of source files to `test_srcs`
by Felix Singer (Code Review) 07 Oct '22

07 Oct '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68228 ) Change subject: tests/meson.build: Rename list of source files to `test_srcs` ...................................................................... tests/meson.build: Rename list of source files to `test_srcs` Rename the list of source files to `test_srcs` so that there is less confusion with the variable `srcs` from the top-level meson.build file containing the flashrom source files. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ica0fc3923070bff63323204bd58edb5276dc9493 --- M tests/meson.build 1 file changed, 18 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/28/68228/1 diff --git a/tests/meson.build b/tests/meson.build index 6229a59..6ce0f31 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -11,7 +11,7 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -srcs = files( +test_srcs = files( 'io_mock.c', 'tests.c', 'libusb_wraps.c', @@ -25,14 +25,14 @@ ) if not programmer.get('dummy').get('active') - srcs += programmer.get('dummy').get('srcs') + test_srcs += programmer.get('dummy').get('srcs') endif foreach p_name, p_data : programmer p_data += { 'testsrc' : p_data.get('testsrc', []), } - srcs += p_data.get('testsrc') + test_srcs += p_data.get('testsrc') endforeach mocks = [ @@ -108,7 +108,7 @@ ] flashrom_tests = executable('flashrom_unit_tests', - srcs, + test_srcs, c_args : [ cargs, '-ffunction-sections', -- To view, visit https://review.coreboot.org/c/flashrom/+/68228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica0fc3923070bff63323204bd58edb5276dc9493 Gerrit-Change-Number: 68228 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: meson: Move programmer test sources into programmer definition
by Felix Singer (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Thomas Heijligen, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68162 to look at the new patch set (#9). Change subject: meson: Move programmer test sources into programmer definition ...................................................................... meson: Move programmer test sources into programmer definition Move the definition of the programmer test source files into the dictionary defining the programmers itself. This way there is a better overview about which of the available programmers have tests and which don't. Also, to keep the tests working, iterate over all programmers and add their test source files to the list of sources that should be built. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I307faaf8a9f7ae3c54bd96e7d871a3abb8aadea3 --- M meson.build M tests/meson.build 2 files changed, 34 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/68162/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/68162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I307faaf8a9f7ae3c54bd96e7d871a3abb8aadea3 Gerrit-Change-Number: 68162 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: meson: Move programmer test sources into programmer definition
by Felix Singer (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68162 ) Change subject: meson: Move programmer test sources into programmer definition ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/flashrom/+/68162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I307faaf8a9f7ae3c54bd96e7d871a3abb8aadea3 Gerrit-Change-Number: 68162 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 19:57:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson.build: Fix indentation of mstarddc_spi definition
by Thomas Heijligen (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Felix Singer. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68163 ) Change subject: meson.build: Fix indentation of mstarddc_spi definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68163 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I064b50f87760fd7ad40b3629b3fa68552c8ddb46 Gerrit-Change-Number: 68163 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Fri, 07 Oct 2022 19:26:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: tests/meson.build: Turn file list into list of file objects
by Felix Singer (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68197 ) Change subject: tests/meson.build: Turn file list into list of file objects ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Patch Set 2: > > when we are onto this, we might rename srcs to not be confusing with srcs from the top-level meson file Sure. I will create a follow-up. -- To view, visit https://review.coreboot.org/c/flashrom/+/68197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b9144a6b76c1772833817b4e6873818dcf36b05 Gerrit-Change-Number: 68197 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 19:25:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: tests/meson.build: Turn file list into list of file objects
by Thomas Heijligen (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Felix Singer, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68197 ) Change subject: tests/meson.build: Turn file list into list of file objects ...................................................................... Patch Set 2: when we are onto this, we might rename srcs to not be confusing with srcs from the top-level meson file -- To view, visit https://review.coreboot.org/c/flashrom/+/68197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b9144a6b76c1772833817b4e6873818dcf36b05 Gerrit-Change-Number: 68197 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 19:23:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: writeprotect.c: differentiate lack of WP from lack of implementation
by Sergii Dmytruk (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Hello Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68221 to review the following change. Change subject: writeprotect.c: differentiate lack of WP from lack of implementation ...................................................................... writeprotect.c: differentiate lack of WP from lack of implementation .tested.wp field allows telling these two cases apart, potentially preventing confusion on seeing the error. Change-Id: I6e75b124c21ccab51a9b5e1cd344b5310d384187 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M cli_classic.c M include/libflashrom.h M writeprotect.c 3 files changed, 35 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/68221/1 diff --git a/cli_classic.c b/cli_classic.c index 3de0020..f790a83 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -202,6 +202,8 @@ return "the requested protection range is not supported"; case FLASHROM_WP_ERR_RANGE_LIST_UNAVAILABLE: return "could not determine what protection ranges are available"; + case FLASHROM_WP_ERR_CHIP_HAS_NO_WP: + return "this chip doesn't support WP"; } return "unknown WP error"; } diff --git a/include/libflashrom.h b/include/libflashrom.h index 9bbdcc5..822877c 100644 --- a/include/libflashrom.h +++ b/include/libflashrom.h @@ -464,7 +464,8 @@ FLASHROM_WP_ERR_VERIFY_FAILED = 5, FLASHROM_WP_ERR_RANGE_UNSUPPORTED = 6, FLASHROM_WP_ERR_MODE_UNSUPPORTED = 7, - FLASHROM_WP_ERR_RANGE_LIST_UNAVAILABLE = 8 + FLASHROM_WP_ERR_RANGE_LIST_UNAVAILABLE = 8, + FLASHROM_WP_ERR_CHIP_HAS_NO_WP = 9 }; enum flashrom_wp_mode { diff --git a/writeprotect.c b/writeprotect.c index 57d0f9b..a55b173 100644 --- a/writeprotect.c +++ b/writeprotect.c @@ -422,11 +422,20 @@ } } -static bool chip_supported(struct flashctx *flash) +static bool verify_chip_support(struct flashctx *flash) { - return (flash->chip != NULL) && (flash->chip->decode_range != NULL); -} + if (flash->chip == NULL) + return FLASHROM_WP_ERR_CHIP_HAS_NO_WP; + /* When not tested assume the chip has WP */ + if (flash->chip->tested.wp == NA) + return FLASHROM_WP_ERR_CHIP_HAS_NO_WP; + + if (flash->chip->decode_range == NULL) + return FLASHROM_WP_ERR_CHIP_UNSUPPORTED; + + return FLASHROM_WP_OK; +} bool wp_operations_available(struct flashrom_flashctx *flash) { @@ -439,10 +448,7 @@ enum flashrom_wp_result wp_read_cfg(struct flashrom_wp_cfg *cfg, struct flashctx *flash) { struct wp_bits bits; - enum flashrom_wp_result ret = FLASHROM_WP_OK; - - if (!chip_supported(flash)) - ret = FLASHROM_WP_ERR_CHIP_UNSUPPORTED; + enum flashrom_wp_result ret = verify_chip_support(flash); if (ret == FLASHROM_WP_OK) ret = read_wp_bits(&bits, flash); @@ -459,10 +465,7 @@ enum flashrom_wp_result wp_write_cfg(struct flashctx *flash, const struct flashrom_wp_cfg *cfg) { struct wp_bits bits; - enum flashrom_wp_result ret = FLASHROM_WP_OK; - - if (!chip_supported(flash)) - ret = FLASHROM_WP_ERR_CHIP_UNSUPPORTED; + enum flashrom_wp_result ret = verify_chip_support(flash); if (ret == FLASHROM_WP_OK) ret = read_wp_bits(&bits, flash); @@ -488,10 +491,11 @@ struct wp_range_and_bits *range_pairs = NULL; size_t count; - if (!chip_supported(flash)) - return FLASHROM_WP_ERR_CHIP_UNSUPPORTED; + enum flashrom_wp_result ret = verify_chip_support(flash); + if (ret != FLASHROM_WP_OK) + return ret; - enum flashrom_wp_result ret = read_wp_bits(&bits, flash); + ret = read_wp_bits(&bits, flash); if (ret != FLASHROM_WP_OK) return ret; -- To view, visit https://review.coreboot.org/c/flashrom/+/68221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6e75b124c21ccab51a9b5e1cd344b5310d384187 Gerrit-Change-Number: 68221 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: flashchips.c: mark WP of 8 entries as tested
by Sergii Dmytruk (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Nico Huber, Kamil Pokornicki, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Hello build bot (Jenkins), Nico Huber, Kamil Pokornicki, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68180 to look at the new patch set (#3). Change subject: flashchips.c: mark WP of 8 entries as tested ...................................................................... flashchips.c: mark WP of 8 entries as tested This is based on information from: * commit a850fd0aa8054a1125a9231fa3317428f15900f4 - GD25LQ128C/GD25LQ128D/GD25LQ128E - GD25LQ64(B) - GD25Q127C/GD25Q128C - GD25Q256D/GD25Q256E - GD25Q64(B) * commit a8204dd34d90ac9ab2783e1dd486ec781d4c0dba - GD25Q32(B) * commit 7b4c4f36113c4b7ed5c985d4cf51733639e69bf8 - W25Q64BV/W25Q64CV/W25Q64FV * https://github.com/Dasharo/dasharo-issues/issues/67 - W25Q128.V..M Change-Id: I090188bad568885f78778e7fc7d8dbe20fb2445f Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Tested-by: Nikolai Artemiev <nartemiev(a)google.com> Tested-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Tested-by: Kamil Pokornicki <kamil.pokornicki(a)3mdeb.com> Tested-by: Przemyslaw Banasiak <przemyslaw.banasiak(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M flashchips.c 1 file changed, 37 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/68180/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/68180 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I090188bad568885f78778e7fc7d8dbe20fb2445f Gerrit-Change-Number: 68180 Gerrit-PatchSet: 3 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Kamil Pokornicki <kamil.pokornicki(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Kamil Pokornicki <kamil.pokornicki(a)3mdeb.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: writeprotect.c: skip unnecessary writes
by Sergii Dmytruk (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Nico Huber. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66754 ) Change subject: writeprotect.c: skip unnecessary writes ...................................................................... Patch Set 2: (1 comment) File writeprotect.c: https://review.coreboot.org/c/flashrom/+/66754/comment/11f49b70_f41bc7bc PS1, Line 159: new > I don't quite follow, how can it be expected? Should the flash chip […] I'm also not sure if test terminology is more appropriate here than old/new or current/new, but one can think of "expected" meaning "state expected at the end of the operation". -- To view, visit https://review.coreboot.org/c/flashrom/+/66754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I81d2d3fc0a103ee00ced78838d77fe33a9d3056a Gerrit-Change-Number: 66754 Gerrit-PatchSet: 2 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 07 Oct 2022 12:35:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022