October 2022 - flashrom-gerrit

[S] Change in flashrom[master]: rayer_spi.c: Move rget_io_perms() check to pre-amble
by Angel Pons (Code Review) 08 Oct '22

08 Oct '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68231 ) Change subject: rayer_spi.c: Move rget_io_perms() check to pre-amble ...................................................................... Patch Set 1: (1 comment) File rayer_spi.c: https://review.coreboot.org/c/flashrom/+/68231/comment/33301c6a_1c34a8b9 PS1, Line 292: if (get_params(cfg, &lpt_iobase, &prog_type) < 0) Hmmm, does it make sense to get I/O perms before parsing programmer params? -- To view, visit https://review.coreboot.org/c/flashrom/+/68231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieb0a494bd49f6986e9ac230b7b123329493a82bc Gerrit-Change-Number: 68231 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sat, 08 Oct 2022 08:18:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: rayer_spi.c: Drop lpt_outbyte intermediate var
by Felix Singer (Code Review) 08 Oct '22

08 Oct '22

Attention is currently required from: Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68232 ) Change subject: rayer_spi.c: Drop lpt_outbyte intermediate var ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/68232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idedabb7b1c401d666b3b7e621e75704c7e765fd1 Gerrit-Change-Number: 68232 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sat, 08 Oct 2022 06:15:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: rayer_spi.c: Drop lpt_outbyte intermediate var
by Felix Singer (Code Review) 08 Oct '22

08 Oct '22

Attention is currently required from: Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68232 ) Change subject: rayer_spi.c: Drop lpt_outbyte intermediate var ...................................................................... Patch Set 1: (1 comment) File rayer_spi.c: https://review.coreboot.org/c/flashrom/+/68232/comment/65a6f84c_1bb56d3f PS1, Line 321: /* Get the initial value before writing to any line. */ I would rewrite or remove the comment. I don't understand it. -- To view, visit https://review.coreboot.org/c/flashrom/+/68232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idedabb7b1c401d666b3b7e621e75704c7e765fd1 Gerrit-Change-Number: 68232 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sat, 08 Oct 2022 06:15:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: rayer_spi.c: Move rget_io_perms() check to pre-amble
by Felix Singer (Code Review) 08 Oct '22

08 Oct '22

Attention is currently required from: Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68231 ) Change subject: rayer_spi.c: Move rget_io_perms() check to pre-amble ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieb0a494bd49f6986e9ac230b7b123329493a82bc Gerrit-Change-Number: 68231 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sat, 08 Oct 2022 06:12:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: rayer_spi.c: Drop lpt_outbyte intermediate var
by Edward O'Callaghan (Code Review) 08 Oct '22

08 Oct '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68232 ) Change subject: rayer_spi.c: Drop lpt_outbyte intermediate var ...................................................................... rayer_spi.c: Drop lpt_outbyte intermediate var The itermediate variable in this case serves no extra assistance in readability or additional control flow branching. Just assign the result directly into the driver state tracker. Change-Id: Idedabb7b1c401d666b3b7e621e75704c7e765fd1 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M rayer_spi.c 1 file changed, 17 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/68232/1 diff --git a/rayer_spi.c b/rayer_spi.c index a64496d..14eb0ea 100644 --- a/rayer_spi.c +++ b/rayer_spi.c @@ -283,7 +283,6 @@ const struct rayer_programmer *prog = rayer_spi_types; struct rayer_pinout *pinout = NULL; uint16_t lpt_iobase; - uint8_t lpt_outbyte; char *prog_type; if (rget_io_perms()) @@ -312,9 +311,6 @@ msg_pinfo("Using %s pinout.\n", prog->description); pinout = (struct rayer_pinout *)prog->dev_data; - /* Get the initial value before writing to any line. */ - lpt_outbyte = INB(lpt_iobase); - struct rayer_spi_data *data = calloc(1, sizeof(*data)); if (!data) { msg_perr("Unable to allocate space for SPI master data\n"); @@ -322,7 +318,8 @@ } data->pinout = pinout; data->lpt_iobase = lpt_iobase; - data->lpt_outbyte = lpt_outbyte; + /* Get the initial value before writing to any line. */ + data->lpt_outbyte = INB(lpt_iobase); if (pinout->shutdown) register_shutdown(pinout->shutdown, data); -- To view, visit https://review.coreboot.org/c/flashrom/+/68232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idedabb7b1c401d666b3b7e621e75704c7e765fd1 Gerrit-Change-Number: 68232 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: rayer_spi.c: Move rget_io_perms() check to pre-amble
by Edward O'Callaghan (Code Review) 08 Oct '22

08 Oct '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68231 ) Change subject: rayer_spi.c: Move rget_io_perms() check to pre-amble ...................................................................... rayer_spi.c: Move rget_io_perms() check to pre-amble Move the 'rget_io_perms()' check to the pre-amble of the main 'rayer_spi_init()' entry-point. If we do not have the required permissions there is no need to continue. Change-Id: Ieb0a494bd49f6986e9ac230b7b123329493a82bc Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M rayer_spi.c 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/68231/1 diff --git a/rayer_spi.c b/rayer_spi.c index 8632f8c..a64496d 100644 --- a/rayer_spi.c +++ b/rayer_spi.c @@ -286,6 +286,9 @@ uint8_t lpt_outbyte; char *prog_type; + if (rget_io_perms()) + return 1; + if (get_params(cfg, &lpt_iobase, &prog_type) < 0) return 1; @@ -309,9 +312,6 @@ msg_pinfo("Using %s pinout.\n", prog->description); pinout = (struct rayer_pinout *)prog->dev_data; - if (rget_io_perms()) - return 1; - /* Get the initial value before writing to any line. */ lpt_outbyte = INB(lpt_iobase); -- To view, visit https://review.coreboot.org/c/flashrom/+/68231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieb0a494bd49f6986e9ac230b7b123329493a82bc Gerrit-Change-Number: 68231 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: rayer_spi.c: Move param parse logic into own func
by Edward O'Callaghan (Code Review) 08 Oct '22

08 Oct '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68230 ) Change subject: rayer_spi.c: Move param parse logic into own func ...................................................................... rayer_spi.c: Move param parse logic into own func Deconvolve programmer parameter parse logic out of main 'rayer_spi_init()' entry-point function control flow. Change-Id: I287aa2e5d94e872553d08c0750f8dc6d60b9caff Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M rayer_spi.c 1 file changed, 57 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/68230/1 diff --git a/rayer_spi.c b/rayer_spi.c index cd7a066..8632f8c 100644 --- a/rayer_spi.c +++ b/rayer_spi.c @@ -235,20 +235,18 @@ .half_period = 0, }; -static int rayer_spi_init(const struct programmer_cfg *cfg) +static int get_params(const struct programmer_cfg *cfg, uint16_t *lpt_iobase, char **prog_type) { - const struct rayer_programmer *prog = rayer_spi_types; - char *arg = NULL; - struct rayer_pinout *pinout = NULL; - uint16_t lpt_iobase; - uint8_t lpt_outbyte; + /* Pick a default value for the I/O base. */ + *lpt_iobase = 0x378; + /* no programmer type specified. */ + *prog_type = NULL; /* Non-default port requested? */ - arg = extract_programmer_param_str(cfg, "iobase"); + char *arg = extract_programmer_param_str(cfg, "iobase"); if (arg) { char *endptr = NULL; - unsigned long tmp; - tmp = strtoul(arg, &endptr, 0); + unsigned long tmp = strtoul(arg, &endptr, 0); /* Port 0, port >0x10000, unaligned ports and garbage strings * are rejected. */ @@ -262,35 +260,52 @@ "given was invalid.\nIt must be a multiple of " "0x4 and lie between 0x100 and 0xfffc.\n"); free(arg); - return 1; + return -1; } else { - lpt_iobase = (uint16_t)tmp; + *lpt_iobase = (uint16_t)tmp; msg_pinfo("Non-default I/O base requested. This will " "not change the hardware settings.\n"); } - } else { - /* Pick a default value for the I/O base. */ - lpt_iobase = 0x378; + free(arg); } - free(arg); + + arg = extract_programmer_param_str(cfg, "type"); + if (arg) { + *prog_type = strdup(arg); + free(arg); + } + + return 0; +} + +static int rayer_spi_init(const struct programmer_cfg *cfg) +{ + const struct rayer_programmer *prog = rayer_spi_types; + struct rayer_pinout *pinout = NULL; + uint16_t lpt_iobase; + uint8_t lpt_outbyte; + char *prog_type; + + if (get_params(cfg, &lpt_iobase, &prog_type) < 0) + return 1; + + if (prog_type) { + for (; prog->type != NULL; prog++) { + if (strcasecmp(prog_type, prog->type) == 0) { + break; + } + } + free(prog_type); + + if (prog->type == NULL) { + msg_perr("Error: Invalid device type specified.\n"); + return 1; + } + } msg_pdbg("Using address 0x%x as I/O base for parallel port access.\n", lpt_iobase); - arg = extract_programmer_param_str(cfg, "type"); - if (arg) { - for (; prog->type != NULL; prog++) { - if (strcasecmp(arg, prog->type) == 0) { - break; - } - } - if (prog->type == NULL) { - msg_perr("Error: Invalid device type specified.\n"); - free(arg); - return 1; - } - free(arg); - } msg_pinfo("Using %s pinout.\n", prog->description); pinout = (struct rayer_pinout *)prog->dev_data; -- To view, visit https://review.coreboot.org/c/flashrom/+/68230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I287aa2e5d94e872553d08c0750f8dc6d60b9caff Gerrit-Change-Number: 68230 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: tests/meson.build: Turn file list into list of file objects
by Felix Singer (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Anastasia Klimchuk. Hello build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68197 to look at the new patch set (#3). Change subject: tests/meson.build: Turn file list into list of file objects ...................................................................... tests/meson.build: Turn file list into list of file objects When a file object is created, Meson also checks if the file actually exists and an errors points to the specific line of meson.build if not. Thus, use file objects in tests/meson.build as it is done elsewhere. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I0b9144a6b76c1772833817b4e6873818dcf36b05 --- M tests/meson.build 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/68197/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/68197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0b9144a6b76c1772833817b4e6873818dcf36b05 Gerrit-Change-Number: 68197 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: meson.build: Fix indentation of mstarddc_spi definition
by Angel Pons (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68163 ) Change subject: meson.build: Fix indentation of mstarddc_spi definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68163 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I064b50f87760fd7ad40b3629b3fa68552c8ddb46 Gerrit-Change-Number: 68163 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Fri, 07 Oct 2022 20:11:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: tests/meson.build: Rename list of source files to `test_srcs`
by Angel Pons (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68228 ) Change subject: tests/meson.build: Rename list of source files to `test_srcs` ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica0fc3923070bff63323204bd58edb5276dc9493 Gerrit-Change-Number: 68228 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 20:11:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022