October 2022 - flashrom-gerrit

[XL] Change in flashrom[master]: tree/: Convert flashchip read func ptr to enumerate
by Edward O'Callaghan (Code Review) 01 Nov '22

01 Nov '22

Hello Felix Singer, build bot (Jenkins), Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66788 to look at the new patch set (#14). Change subject: tree/: Convert flashchip read func ptr to enumerate ...................................................................... tree/: Convert flashchip read func ptr to enumerate This forges the way for flashchips.c to be pure declarative data and lookup functions for dispatch to be pure. This means that the flashchips data could be extracted out to be agnostic data of the flashrom code and algorithms. Squash in, flashchips.c: convert edi_chip_read() flashchips.c: convert spi_chip_read() flashchips.c: convert read_opaque() flashchips.c: convert read_memmapped() flashchips.c: convert spi_read_at45db_e8() flashchips.c: convert spi_read_at45db() flashchips.c: convert NULL cases Change-Id: I612d46fefedf2b69e7e2064aa857fa0756efb4e7 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashchips.c M flashrom.c M fmap.c M include/flash.h M libflashrom.c M tests/chip.c M tests/chip_wp.c 7 files changed, 678 insertions(+), 606 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/66788/14 -- To view, visit https://review.coreboot.org/c/flashrom/+/66788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I612d46fefedf2b69e7e2064aa857fa0756efb4e7 Gerrit-Change-Number: 66788 Gerrit-PatchSet: 14 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip write func ptr to enumerate
by Edward O'Callaghan (Code Review) 31 Oct '22

31 Oct '22

Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66782 ) Change subject: tree/: Convert flashchip write func ptr to enumerate ...................................................................... Patch Set 13: (1 comment) File tests/chip.c: https://review.coreboot.org/c/flashrom/+/66782/comment/b56c7441_afcf122a PS11, Line 150: static const struct flashchip chip_8MiB = { > If you could add one empty line between 149 and 150? Extern declaration is used by more than one str […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/66782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80149de169464b204fb09f1424a86fc645b740fd Gerrit-Change-Number: 66782 Gerrit-PatchSet: 13 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 31 Oct 2022 22:59:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip write func ptr to enumerate
by Edward O'Callaghan (Code Review) 31 Oct '22

31 Oct '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons. Hello Felix Singer, build bot (Jenkins), Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66782 to look at the new patch set (#13). Change subject: tree/: Convert flashchip write func ptr to enumerate ...................................................................... tree/: Convert flashchip write func ptr to enumerate This forges the way for flashchips.c to be pure declarative data and lookup functions for dispatch to be pure. This means that the flashchips data could be extracted out to be agnostic data of the flashrom code and algorithms. Squash in, flashchips.c: convert spi_chip_write_256() flashchips.c: convert write_jedec_1() flashchips.c: convert write_jedec() flashchips.c: convert write_opaque() flashchips.c: convert spi_chip_write_1() flashchips.c: convert spi_aai_write() flashchips.c: convert edi_chip_write() flashchips.c: convert write_en29lv640b() flashchips.c: convert write_82802ab() flashchips.c: convert spi_write_at45db() flashchips.c: convert write_28sf040() flashchips.c: convert NULL write Change-Id: I80149de169464b204fb09f1424a86fc645b740fd Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashchips.c M flashrom.c M include/flash.h M sfdp.c M tests/chip.c M tests/chip_wp.c M tests/spi25.c 7 files changed, 685 insertions(+), 599 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/82/66782/13 -- To view, visit https://review.coreboot.org/c/flashrom/+/66782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I80149de169464b204fb09f1424a86fc645b740fd Gerrit-Change-Number: 66782 Gerrit-PatchSet: 13 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip read func ptr to enumerate
by Edward O'Callaghan (Code Review) 31 Oct '22

31 Oct '22

Hello Felix Singer, build bot (Jenkins), Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66788 to look at the new patch set (#13). Change subject: tree/: Convert flashchip read func ptr to enumerate ...................................................................... tree/: Convert flashchip read func ptr to enumerate This forges the way for flashchips.c to be pure declarative data and lookup functions for dispatch to be pure. This means that the flashchips data could be extracted out to be agnostic data of the flashrom code and algorithms. Squash in, flashchips.c: convert edi_chip_read() flashchips.c: convert spi_chip_read() flashchips.c: convert read_opaque() flashchips.c: convert read_memmapped() flashchips.c: convert spi_read_at45db_e8() flashchips.c: convert spi_read_at45db() flashchips.c: convert NULL cases Change-Id: I612d46fefedf2b69e7e2064aa857fa0756efb4e7 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashchips.c M flashrom.c M fmap.c M include/flash.h M libflashrom.c M tests/chip.c M tests/chip_wp.c 7 files changed, 678 insertions(+), 607 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/66788/13 -- To view, visit https://review.coreboot.org/c/flashrom/+/66788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I612d46fefedf2b69e7e2064aa857fa0756efb4e7 Gerrit-Change-Number: 66788 Gerrit-PatchSet: 13 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[XL] Change in flashrom[master]: tree/: Convert flashchip erase_block func ptr to enumerate
by Edward O'Callaghan (Code Review) 31 Oct '22

31 Oct '22

Attention is currently required from: Felix Singer, Edward O'Callaghan. Hello Felix Singer, build bot (Jenkins), Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67240 to look at the new patch set (#10). Change subject: tree/: Convert flashchip erase_block func ptr to enumerate ...................................................................... tree/: Convert flashchip erase_block func ptr to enumerate This forges the way for flashchips.c to be pure declarative data and lookup functions for dispatch to be pure. This means that the flashchips data could be extracted out to be agnostic data of the flashrom code and algorithms. Change-Id: I58415a4f2589812b26d284c96876e88f8d9acf52 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M at45db.c M atapromise.c M flashchips.c M flashrom.c M include/chipdrivers.h M include/flash.h M sfdp.c M spi25.c M tests/chip.c M tests/chip_wp.c 10 files changed, 2,103 insertions(+), 1,982 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/67240/10 -- To view, visit https://review.coreboot.org/c/flashrom/+/67240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I58415a4f2589812b26d284c96876e88f8d9acf52 Gerrit-Change-Number: 67240 Gerrit-PatchSet: 10 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: writeprotect: Add some debug logging if wp_verify fails
by Anastasia Klimchuk (Code Review) 31 Oct '22

31 Oct '22

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67720 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: writeprotect: Add some debug logging if wp_verify fails ...................................................................... writeprotect: Add some debug logging if wp_verify fails Change-Id: I5fcaf767570418f90ae44826a1135d9b49653033 Signed-off-by: Evan Benn <evanbenn(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67720 Reviewed-by: Nikolai Artemiev <nartemiev(a)google.com> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M writeprotect.c 1 file changed, 23 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Nikolai Artemiev: Looks good to me, but someone else must approve Sergii Dmytruk: Looks good to me, but someone else must approve diff --git a/writeprotect.c b/writeprotect.c index dcffe03..f72c362 100644 --- a/writeprotect.c +++ b/writeprotect.c @@ -155,6 +155,7 @@ return FLASHROM_WP_ERR_WRITE_FAILED; } + enum flashrom_wp_result ret = FLASHROM_WP_OK; /* Verify each register */ for (enum flash_reg reg = STATUS1; reg < MAX_REGISTERS; reg++) { if (!write_masks[reg]) @@ -164,14 +165,18 @@ if (wp_read_register(flash, reg, &value)) return FLASHROM_WP_ERR_READ_FAILED; + msg_cdbg2("%s: wp_verify reg:%u value:0x%x\n", __func__, reg, value); uint8_t actual = value & write_masks[reg]; uint8_t expected = reg_values[reg] & write_masks[reg]; - if (actual != expected) - return FLASHROM_WP_ERR_VERIFY_FAILED; + if (actual != expected) { + msg_cdbg("%s: wp_verify failed: reg:%u actual:0x%x expected:0x%x\n", + __func__, reg, actual, expected); + ret = FLASHROM_WP_ERR_VERIFY_FAILED; + } } - return FLASHROM_WP_OK; + return ret; } static decode_range_func_t *lookup_decode_range_func_ptr(const struct flashchip *chip) -- To view, visit https://review.coreboot.org/c/flashrom/+/67720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5fcaf767570418f90ae44826a1135d9b49653033 Gerrit-Change-Number: 67720 Gerrit-PatchSet: 4 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: flashrom_tester: Use Path type for test data
by Edward O'Callaghan (Code Review) 31 Oct '22

31 Oct '22

Attention is currently required from: Angel Pons, Anastasia Klimchuk, Evan Benn. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68643 ) Change subject: flashrom_tester: Use Path type for test data ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/68643/comment/c07fafc8_30e0e9ab PS3, Line 9: Update many str types to Path. this commit does more than just re-type data, it refactors too. refactor then re-type. File util/flashrom_tester/src/tester.rs: https://review.coreboot.org/c/flashrom/+/68643/comment/0dcc3081_a5b4f2be PS3, Line 86: layout_file: create_layout_file(rom_sz, Path::new("/tmp/"), print_layout), adding to the TestEnv state is its own commit. File util/flashrom_tester/src/tests.rs: https://review.coreboot.org/c/flashrom/+/68643/comment/67137df0_36cccede PS3, Line 94: info!("Calculate ROM partition sizes & Create the layout file."); : let rom_sz: i64 = cmd.get_size()?; : let layout_sizes = utils::get_layout_sizes(rom_sz)?; : { : let mut f = File::create(LAYOUT_FILE)?; : let mut buf: Vec<u8> = vec![]; : utils::construct_layout_file(&mut buf, &layout_sizes)?; : : f.write_all(&buf)?; : if print_layout { : info!( : "Dumping layout file as requested:\n{}", : String::from_utf8_lossy(&buf) : ); : } : } moving this should be it's own commit. -- To view, visit https://review.coreboot.org/c/flashrom/+/68643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4a0b25c8c70fa6dfd682fba3db7d3bf06b2eb7ac Gerrit-Change-Number: 68643 Gerrit-PatchSet: 3 Gerrit-Owner: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Evan Benn <evanbenn(a)google.com> Gerrit-Comment-Date: Mon, 31 Oct 2022 22:15:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: cli_classic.c: Factor out rom bus limits exceeded validation
by Felix Singer (Code Review) 31 Oct '22

31 Oct '22

Attention is currently required from: Edward O'Callaghan, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68661 ) Change subject: cli_classic.c: Factor out rom bus limits exceeded validation ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/68661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iba1c3c8ab2edc094ede59156ae5e846900fc0777 Gerrit-Change-Number: 68661 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 31 Oct 2022 20:17:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: cli_classic.c: Make count_max_decode_exceedings() pure
by Felix Singer (Code Review) 31 Oct '22

31 Oct '22

Attention is currently required from: Edward O'Callaghan, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68479 ) Change subject: cli_classic.c: Make count_max_decode_exceedings() pure ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/68479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia01f77993deab68e251850008e885828e55b9462 Gerrit-Change-Number: 68479 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 31 Oct 2022 20:17:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable.c: Mark Intel C246 as DEP
by Felix Singer (Code Review) 31 Oct '22

31 Oct '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68594 ) Change subject: chipset_enable.c: Mark Intel C246 as DEP ...................................................................... chipset_enable.c: Mark Intel C246 as DEP Tested reading, writing and erasing the flash chip of a Prodrive Hermes mainboard with an Intel C246 PCH. However, since ME-enabled chipsets are marked as DEP instead of OK, this one shall also be. Change-Id: I07d6c4a60e468c61eba836db91e1335f4a762048 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/68594 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M chipset_enable.c 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/chipset_enable.c b/chipset_enable.c index d6103c1..60b82df 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2145,7 +2145,7 @@ {0x8086, 0xa305, B_S, DEP, "Intel", "Z390", enable_flash_pch300}, {0x8086, 0xa306, B_S, NT, "Intel", "Q370", enable_flash_pch300}, {0x8086, 0xa308, B_S, NT, "Intel", "B360", enable_flash_pch300}, - {0x8086, 0xa309, B_S, NT, "Intel", "C246", enable_flash_pch300}, + {0x8086, 0xa309, B_S, DEP, "Intel", "C246", enable_flash_pch300}, {0x8086, 0xa30a, B_S, NT, "Intel", "C242", enable_flash_pch300}, {0x8086, 0xa30c, B_S, NT, "Intel", "QM370", enable_flash_pch300}, {0x8086, 0xa30d, B_S, NT, "Intel", "HM370", enable_flash_pch300}, -- To view, visit https://review.coreboot.org/c/flashrom/+/68594 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I07d6c4a60e468c61eba836db91e1335f4a762048 Gerrit-Change-Number: 68594 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022